Is it OK to copy Blizzard functions and hooksecure their function with tweaked copy?

[Nikita S. Doroshenko]

I want to change Blizzard's function FriendsFrame_UpdateFriends() to add my buttons in to each frame of long scroll-able list of friends.

So i made hooksecurefunc("FriendsFrame_UpdateFriends", FriendsFrame_UpdateFriendsCopy)

FriendsFrame_UpdateFriendsCopy() is copy of FriendsFrame_UpdateFriends(), but with a few new lines of code.

Is it OK to do so, or is there better way to bulk change each frame of long scroll-able list? because i think hooksecure function is not same for future proof (for future updates).

PS I tried to make for loop for this scroll-able frame to manually attach my buttons in to each frame of scroll-able frame, but this buttons looks hardcoded, and i can't controll them regardless of hidden parent frames parameters that are only available in FriendsFrame_UpdateFriends().

[Nimhfree]

The thing to remember is when you hook a function you are really just adding your function to be called after Blizzard's function is called. So, you typically would not repeat what Blizzard is doing in your function.

If you want to do something before a Blizzard function does its work you can replace the Blizzard function using a technique where you get the pointer to the Blizzard function, then define your function with the same name as the Blizzard function to implement your new code, and have your code then call the original Blizzard function. This technique can be used to do other things like control whether you even want to call the original Blizzard function as well.

I have not looked specifically at what you are trying to do, but sometimes you need not replace or alter any Blizzard function. You might be able to add items to a Blizzard data structure, or some other technique that allows you to get your data into the Blizzard system without touching the actual routines that manipulate that data. You just need to investigate how things are done and the best way to augment that system.

[Phanx]

It sounds like you do want to hook the function, but you don't want your hook function to be a copy of the original function. Your hook function should only do whatever needs to be done in addition to what the original function already does. For example, if you wanted to show a button on each friend that you could click to whisper that friend, but hide the button for offline friends, you could do this:

local function whisperButton_OnClick(self)
    if self:GetParent().buttonType == FRIENDS_BUTTON_TYPE_BNET then
        ChatFrame_SendSmartTell(self.friendName)
    else
        ChatFrame_SendTell(self.friendName)
    end
end
 
local function whisperButton_OnEnter(self)
    GameTooltip:SetOwner(self, "ANCHOR_BOTTOMRIGHT")
    GameTooltip:SetText("Click to whisper " .. self.friendName)
end
 
hooksecurefunc("FriendsFrame_UpdateFriends", function()
    local friends = FriendsFrameFriendsScrollFrame.buttons
    for i = 1, #friends do
        local friend = friends[i]
        if friend:IsShown() then
            -- This friends list row is displayed.
            -- Create a whisper button if this row doesn't have one already.
            if not friend.whisperButton then
                local whisperButton = CreateFrame("Button", nil, friend, "UIPanelButtonTemplate")
                whisperButton:SetScript("OnClick", whisperButton_OnClick)
                whisperButton:SetScript("OnEnter", whisperButton_OnEnter)
                whisperButton:SetScript("OnLeave", GameTooltip_Hide)
                whisperButton:SetSize(26, 26)
                whisperButton:SetText("W")
                friend.whisperButton = whisperButton
            end
            -- Update the whisper button.
            local friendName, isOnline, _
            if friend.buttonType == FRIENDS_BUTTON_TYPE_BNET then
                -- Battle.net friends, move the button left of the game icon.
                _, friendName, _, _, _, _, isOnline = BNGetFriendInfo(friend.id)
                friend.whisperButton:SetPoint("RIGHT", friend.gameIcon, "LEFT")
            else
                -- Regular friend, move the button to the right.
                friendName, _, _, _, isOnline = GetFriendInfo(friend.id)
                friend.whisperButton:SetPoint("RIGHT", friend)
            end
            -- Show or hide the whisper button based on the friend's online status.
            if isOnline then
                friend.whisperButton.friendName = friendName
                friend.whisperButton:Show()
            else
                friend.whisperButton:Hide()
            end
        elseif friend.whisperButton then
            -- This friends list row is not displayed.
            -- Hide its whisper button if it has one.
            friend.whisperButton:Hide()
        end
    end
end)

[Nikita S. Doroshenko]

Originally Posted by Phanx It sounds like you do want to hook the function, but you don't want your hook function to be a copy of the original function. Your hook function should only do whatever needs to be done in addition to what the original function already does. For example, if you wanted to show a button on each friend that you could click to whisper that friend, but hide the button for offline friends, you could do this: local function whisperButton_OnClick(self)     if self:GetParent().buttonType == FRIENDS_BUTTON_TYPE_BNET then         ChatFrame_SendSmartTell(self.friendName)     else         ChatFrame_SendTell(self.friendName)     end end   local function whisperButton_OnEnter(self)     GameTooltip:SetOwner(self, "ANCHOR_BOTTOMRIGHT")     GameTooltip:SetText("Click to whisper " .. self.friendName) end   hooksecurefunc("FriendsFrame_UpdateFriends", function()     local friends = FriendsFrameFriendsScrollFrame.buttons     for i = 1, #friends do         local friend = friends[i]         if friend:IsShown() then             -- This friends list row is displayed.             -- Create a whisper button if this row doesn't have one already.             if not friend.whisperButton then                 local whisperButton = CreateFrame("Button", nil, friend, "UIPanelButtonTemplate")                 whisperButton:SetScript("OnClick", whisperButton_OnClick)                 whisperButton:SetScript("OnEnter", whisperButton_OnEnter)                 whisperButton:SetScript("OnLeave", GameTooltip_Hide)                 whisperButton:SetSize(26, 26)                 whisperButton:SetText("W")                 friend.whisperButton = whisperButton             end             -- Update the whisper button.             local friendName, isOnline, _             if friend.buttonType == FRIENDS_BUTTON_TYPE_BNET then                 -- Battle.net friends, move the button left of the game icon.                 _, friendName, _, _, _, _, isOnline = BNGetFriendInfo(friend.id)                 friend.whisperButton:SetPoint("RIGHT", friend.gameIcon, "LEFT")             else                 -- Regular friend, move the button to the right.                 friendName, _, _, _, isOnline = GetFriendInfo(friend.id)                 friend.whisperButton:SetPoint("RIGHT", friend)             end             -- Show or hide the whisper button based on the friend's online status.             if isOnline then                 friend.whisperButton.friendName = friendName                 friend.whisperButton:Show()             else                 friend.whisperButton:Hide()             end         elseif friend.whisperButton then             -- This friends list row is not displayed.             -- Hide its whisper button if it has one.             friend.whisperButton:Hide()         end     end end)

This is awesome example! Thank you Phanx!

Only thing I can't understand, is how to update this whisperButton on frame scroll. The main problem is that when i scroll down, the buttons are not changes, and they only changes when FriendsFrame_UpdateFriends() function triggers. And this function triggers only when someone login/logout.

I search blizzard code in FriendsFrame.lua for scroll update function, only found this line of code:

function FriendsFrame_OnLoad(self)
-- ...
    local scrollFrame = FriendsFrameFriendsScrollFrame;
    scrollFrame.update = FriendsFrame_UpdateFriends;
    FriendsFrameFriendsScrollFrameScrollBarTrack:Hide();
    FriendsFrameFriendsScrollFrameScrollBar.doNotHide = true;
    HybridScrollFrame_CreateButtons(scrollFrame, "FriendsFrameButtonTemplate");
-- ...
end

Can't figure out by myself, how to apply update for this buttons each time user uses scroll. Will appreciate for your help.

[Phanx]

Try adding:

FriendsFrameFriendsScrollFrame.update = function() return FriendsFrame_Update() end

at the end of your code.

[Nikita S. Doroshenko]

Originally Posted by Phanx Try adding: FriendsFrameFriendsScrollFrame.update = function() return FriendsFrame_Update() end at the end of your code.

Thank you Phanx! I didn't realized that one line of code could fix this! I really should spend more time on learning and understanding how functions works with each other and how to manipulate them.

i just want to add, that I changed FriendsFrame_Update() to FriendsFrame_UpdateFriends() because first one FriendsFrame_Update() only works when user scroll with mouse wheel, but while dragging Scroll Thumb, frame was lagging like hell, so I changed it to FriendsFrame_UpdateFriends().

Everything looks and works perfectly! You saved me many hours! I very appreciate your help Phanx!

PS. Unfortunately after testing this method uses lot's on CPU power, and scrolling up and down friend list, makes my addon worst cpu efficient, not sure if it's normal for such a thing, but i'll try to think how to optimize it, if i'll find something i'll post solution here, maybe it's just not possible.

[Phanx]

Originally Posted by Nikita S. Doroshenko Unfortunately after testing this method uses lot's on CPU power, and scrolling up and down friend list, makes my addon worst cpu efficient, not sure if it's normal for such a thing, but i'll try to think how to optimize it, if i'll find something i'll post solution here, maybe it's just not possible.

It depends entirely on what you're doing inside your function. Make sure you're not re-creating your objects every time the function runs; that seems like the most likely cause for excessive CPU usage here.