Help with COMBAT_LOG_EVENT_UNFILTERED

[Waky]

I'm trying to create an addon that will be able to tell you when you cast Focus Magic on someone.

This is my XML (<Scripts>...</Scripts>):

		<Scripts>
			<OnLoad>
				wFM_OnLoad();
			</OnLoad>
			<OnEvent>
				wFM_OnEvent(event, ...);
			</OnEvent>
			<OnMouseDown>
				wFM_OnMouseDown();
			</OnMouseDown>
			<OnMouseUp>
				wFM_OnMouseUp();
			</OnMouseUp>
		</Scripts>

This is my OnLoad that's referred to in XML, as you can see my wFM_MainFrame is set to Register the combat log event.

function wFM_OnLoad()

	wFM_MainFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");
	
	return;
end --OnLoad

and finally this is my OnEvent:

function wFM_OnEvent(event, ...)
  local timestamp, type, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, spellId, spellName = select(1, ...)
  
   if event == "COMBAT_LOG_EVENT_UNFILTERED" and type == "SPELL_CAST_SUCCESS" then
		if spellId == 54646 then
			DEFAULT_CHAT_FRAME:AddMessage(""..sourceName.." has cast Focus magic");
		end
	end
end --OnEvent

Basically when I cast Focus Magic it should say "Waky has cast Focus Magic" in my chat frame, but it keeps returning sourceName as nil.

Can anyone tell me what's wrong with this code?

Any help would be appreciated, this is my first attempt at an AddOn (besides Hello World! :P)

[Starinnia]

local timestamp, type, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, spellId, spellName = select(1, ...)

Should just be

local timestamp, type, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, spellId, spellName = ...

The call to select(1, ...) only returns the first value from the vararg.

[Waky]

Thanks for responding so quickly!

That sure sounded like it would work, but nothing still . Did you notice anything else that could be wrong?

[Starinnia]

You could try changing your XML file

		<Scripts>
			<OnLoad>
				wFM_OnLoad();
			</OnLoad>
			<OnEvent function="wFM_OnEvent"/>
			<OnMouseDown>
				wFM_OnMouseDown();
			</OnMouseDown>
			<OnMouseUp>
				wFM_OnMouseUp();
			</OnMouseUp>
		</Scripts>

Not 100% sure that will change anything since I've never used XML frame creation, but its worth a try.

[Waky]

No go I don't want to sound ungrateful lol, but any other ideas?

[Soulofsin_007]

local eventframe = CreateFrame("FRAME")
eventframe:SetPoint("CENTER")
eventframe:SetScript("OnEvent", function(self, event, ...)
  local timestamp, type, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags = select(1, ...)
  
    if event == "COMBAT_LOG_EVENT_UNFILTERED" then
    if (type=="SPELL_AURA_APPLIED") then

      local spellId, spellName, spellSchool = select(9, ...)
  
      if (spellName=="Focus Magic") then 
        DEFAULT_CHAT_FRAME:AddMessage(destName.." has focus magic");
     end
   end
 end
end)
eventframe:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")

Edit: The above works, I just tested it out in game.

[Waky]

The only thing about that one Soul is that it doesn't use the XML frames like I am.

[Seerah]

You don't need to use XML.

In any case, you didn't quite set up your event handler correctly. The first return in OnEvent is a reference to the frame that is registered to that event and triggered the function. The second return is the event name itself, then followed by any returns that come with that event (all the info on CLU).

[Waky]

Alrighty, I decided to use Soul's method and it worked perfectly, thanks very much!

[Phanx]

Originally Posted by Starinnia The call to select(1, ...) only returns the first value from the vararg.

That's actually incorrect. select(n, ...) returns the nth value and all subsequent values.

So, if you have:

local a, b, c, d, e, f, g = GetSomeValues()

But you didn't care about a or b, you could do:

local c, d, e, f, g = select(3, GetSomeValues())

Though it would be slightly faster to do:

local _, _, c, d, e, f, g = GetSomeValues()

The real value of select lies in the fact that normally this:

if GetSomeValues() == "x" then

...would compare the first return value (the one assigned to a in the first example) against the string "x", but we can use select to compare against, say, e instead:

if select(5, GetSomeValues()) == "x" then