Memory and FPS with .17 Plus

Fizban · 05-02-10, 05:41 PM

I am not sure if this is just me, but since installing 17 plus, my FPS is now down at 20-25 instead of 60 and the memory usage has gone up to 25-30 MiB just for nUI. I have no error messages at all.

If I can work out a nice way to do it, I shall add a list of other addons installed, though only Auctioneer seems to take up any memory.

I am going to try and go back to an earlier version of nUI plus and see if that "fixes" the problem.

MidgetMage55 · 05-02-10, 05:42 PM

You can take a screen shot of your open addon folder and post it as an attachment to your post or host with something like photobucket or image shack.

Chmee · 05-02-10, 10:04 PM

Your fps is down in which zone(s)?

Fizban · 05-03-10, 02:20 AM

Ok, I have done some work on this over night.

I went back to .12 plus, took off all the nUI "extras" that I was also using and I am straight back to 60 FPS.

I aded back each "extra" one at a time, and the result is that it isnt nUI plus after all (so apologese Scott), but rather nUI_InfoPanel_MagePorts (sorry Xrystal). Having looked at the forum for that "extra" I think I shall wait for the new version to come out.

Thanks all for replying, and keep up the good work.

Oh... anyone else use nUI_InforPanel_Grid and find it breaks nUI plus?

Xrystal · 05-03-10, 04:14 AM

You'll probably find that most of the plugins may break as they may have been using the VARIABLES_LOADED event that nUI used to do its settings. I have changed my addons that had this problem and so did Scott.

Was that the mageports version that I updated the other day ? Well, I guess it must have been if it was visible

I'll play around with my mage and see if I get the same problem. Not played with her in a while so who knows.

Xrystal · 05-03-10, 04:18 AM

Wow, I can confirm .. just unloading my mageports addon the fps goes from 44fps to 60fps without doing anything rofl.

I'll try and see if I can identify what could be doing that but worse case scenario the full rewrite may have to be started tout suite.

okay, the problem seems to be due to the 2 OnUpdate routines I have. One has a timerSetting and is the main reason for the fps loss *sigh* and the other doesn't being simply a cooldown counter so only lasts a few seconds so minimal.

I'm not sure if I will be able to fix this in its current state without a full rewrite anyway so may have to start on the rewrite sooner than I expected if I can't fix it the way it is coded now rofl.

Xrystal · 05-03-10, 05:57 AM

*grumbles* .. cooldown running but no text displayed ... aaaaargh .. make cooldown always visible and text is displayed but low fps .. make cooldown visible when spell is cast ... no text displayed but only short burst of fps ..

methinks I need to rewrite this code rofl... but can't see where it is wrong for this part. Oh well, back to the code .. *crosses fingers*

Edit: Well got the text appearing and got the cooldown appearing .. marvellous how much you learn each time you write an addon. Switched out OnUpdate frame run with individual event watches. CooldownFrame watches for cooldowns. Main Frame watches for everything else such as item counts and slash commands etc. Current problem is getting the alpha settings to apply immediately instead of on a reload... secure button normal functionality ? Couldn't see an attribute I could use to set the alpha value so guess thats not it .. Im sure I will figure it out though.

Seer · 05-03-10, 11:33 AM

Just gotta love it when she talks dirt.. eh.. geek... eh... talks like that..

Xrystal · 05-03-10, 12:51 PM

rofl.. the guys in the guild say that when I start talking about bios updates.

spiel2001 · 05-03-10, 12:52 PM

So... would this be an inappropriate time to discuss floppy disks?

Seer · 05-03-10, 12:53 PM

Wasn't it hard di... eh.. disks offcourse.

Xrystal · 05-03-10, 01:37 PM

*sigh* well looks like the problem wasn't to do with the onupdate routines at all.

Turned off all the OnUpdate scripts and converted them to OnEvent scripts with a few events set up and stepped into a building .. 60fps. Step outside into Dalaran and get between 34 and 44fps.

Okay, disabled MagePorts and getting about 40fps outside of the store, so at least a guide line to see if want I enable back into the addon.

Ah, I see whats happening .. camera zoomed in on my character 58fps in dalaran outside the store. Zoom Out from my character and it drops to 40fps or thereabouts. That would explain the difference with the store and outside the store with the automatic zoom in

Well, switching out the biggest onUpdate routines for onEvent routines may help but some of the items need to be in an onUpdate as there are no onEvent routines to use and direct updating of the frames fonts outside of the frame doesn't seem to work .. rofl

Xrystal · 05-03-10, 01:39 PM

rofl, I see the infamous nUI derailment regime is here rofl

voodoodad · 05-03-10, 01:40 PM

Missed it by <this> much!

Seer · 05-03-10, 01:52 PM

You're loosing your touch Voodoo...

Xrystal · 05-03-10, 04:15 PM

Well, seeing as I have been getting inconsistent fps spikes today its been hard for me to know for sure whats going wrong but I have removed all but one of the update routines and that one only gets activated after an event and deactivated when it doesn't need to be running.

Added 2 new frames to hold the text and use an event watch to update the text. These seem to work as expected. Receive/Lose an item and it updates.
BAG_UPDATE : Changes to Bag Contents
ITEM_PUSH : Receiving an Item
PLAYER_LOGIN : As soon as you log in

Button:OnEvent(UpdateAlpha) - This works with the events with no problems.
BAG_UPDATE : Changes to Bag Contents
ITEM_PUSH : Receiving an Item
PLAYER_LOGIN : As soon as you log in
PARTY_CONVERTED_TO_RAID : In a Raid Test available
PARTY_INVITE_CANCEL : In a Party Test available
PARTY_INVITE_REQUEST : In a Party Test available

Button.Cooldown:OnUpdate(UpdateCooldown) - This works as expected once activated.
Button.Cooldown:OnEvent(ActivateCooldown)
SPELL_UPDATE_COOLDOWN : A spell is on cooldown

MagePorts_UpdateFrame(Force_Update)
This function was designed to update the frame to reflect the slash command changes. However, not using an onUpdate routine now means that each frame would need to be hard coded to reflect the changes. However, they don't seem to want to work that way. However, the requested change triggers when an event tracked by the frame in question occurs. The following events call this function but for all the help it does *shrugs*.
LEARNED_SPELL_IN_TAB : New Spell Available
PLAYER_ENTERING_WORLD : Faction Available at this point
UNIT_SPELLCAST_START : Started a portal spell
UNIT_SPELLCAST_STOP : Finished/Stopped a portal spell
MERCHANT_SHOW : Merchant Window Opened
MERCHANT_CLOSED : Merchant Window Closed

Anyway, Fizban, can you try this updated version and see what improvement it makes. It seems to be the best I can do without a total rewrite which Id rather do when I have the template code ready.

Fizban · 05-07-10, 08:01 AM

I have tried and everything seems to be working as you intend it to.
FPS is back up again, all the icons work and the reagent elements have appeared. Well done and thanks.

Now if only the GRID info_panel would get fixed, but I know that isnt yours ;-)

Xrystal · 05-07-10, 08:31 AM

Okay, thanks for that .. and for something for you to look forward to .. I have been busy working on part of the new mage ports version.

Here's a screen shot of a slightly older version of what I am currently working on for your reagent use

I am currently working on this as a separate addon so I can test it with a non mage character but that would also mean I could plug it into any addon I may make in the future that could use this information as well.

I tried cheating and using WoWs built in frame templates but they keep breaking so I am guessing I will fall back onto my own creations that I know work the way I intend them to rofl. And people say don't reinvent the wheel rofl.

Fizban · 05-07-10, 10:14 AM

Nice, I look forward to it. ;-)