Update Code Running Twice

[Septih]

I'm trying to use the pattern of waiting till x seconds have passed before running the update code, but for some reason once it gets passed the if statement it runs the update twice.

Code is below, should count up 1 every 8 seconds, instead counts up 1 then another 1 instantly every 8 seconds. e.g.

00:00: 1
00:00: 2
00:08: 3
00:08: 4
00:16: 5
00:16: 6
etc

local MyAddon = CreateFrame("Frame","MyAddon",UIParent)
MyAddon.Units = {}
MyAddon_UpdateInterval = 8.0
loaded=false
e=0

function MyAddon:Initialize(self)
	loaded=true
end

function MyAddon:Update()
	e = e + 1
	print(e)
end

local timeElapsed = 0;
MyAddon:SetScript("OnUpdate", function(self,elapsed)
		timeElapsed = timeElapsed + elapsed
		if(timeElapsed > MyAddon_UpdateInterval) then
			timeElapsed = 0.0
			MyAddon:Update()
		end
end)

<Ui xmlns="http://www.blizzard.com/wow/ui/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.blizzard.com/wow/ui/..\FrameXML\UI.xsd">
	<Script File="addon.lua" />
</Ui>

It seems like it's a concurrency issue, but that would break the whole idea of slowing the update method wouldn't it?

I also tried putting in an update counter so that it would only update every 5 calls, but it still behaved the same way.

[Haleth]

Try to make your 'e' variable local instead (and do the same to loaded). Keep everything as local as possible. This fixes all kinds of strange problems, possibly this one as well, and it's general good practice.

Also, lua makes no distinction between integers and float/double, so there is no need to add decimals to your counter variable.

Edit: I tried this and the counter is actually working fine, maybe I misunderstood the problem? You're not loading the code twice (through ToC and XML), are you?

[Septih]

That didn't fix it, but it did point me in the right direction. With that change it started doing:

1
1
2
2
3
3

which looked like the addon was running twice (and because the e variable wasn't local before, it was being incremented by each version). I removed the <Script> tag from the xml file and it's working fine now.

Thank you!

[myrroddin]

You are calling MyAddon:Update() within your OnUpdate script. That translates into something like "While looping until you get to 8 seconds, loop during the initial 8 seconds".

Side note: the variables "loaded" and "MyAddon_UpdateInterval" and "e" should be local.

Final code might look something like the following. I did away with your xml file, since everything can be done in Lua, and xml is nasty to debug, hard to look at, and I don't like it.

local MyAddon, pt = ... -- string reference to your AddOn, private table shared between all files in your AddOn
local MyAddon_frame = CreateFrame("Frame")
local updateInterval = 8
local e -- needs a descriptive name
local addon_loaded
local MyAddon_units = {}
 
function MyAddon:Initialize(self)
    addon_loaded = true
end
 
local timer = 0
MyAddon_frame:SetScript("OnUpdate", function(self, elapsed)
    timer = timer + elapsed
    if timer <= updateInterval then
        -- do something
    end
    timer = 0
end)

[myrroddin]

Here is a WoWPedia link that might help. It uses xml, but gives the general idea. http://www.wowpedia.org/Using_OnUpdate_correctly

[Haleth]

Yeah, it looks like the problem was that you were loading the lua file in the ToC, and in the XML as well, so you just ended up with the same code running twice. Bescause 'e' was global it kept incrementing the same variable twice each time.

Also a tip, make sure you use descriptive names for your variables. Anyone should be able to figure out more or less what a variable is used for just by looking at its name, and especially in larger projects, 'e' just won't cut it.

[myrroddin]

I have a typo in line 8 above.

MyAddon.Initialize(self)
    addon_loaded = true
end

But if you wanted to really know if your AddOn was loaded, register the event ADDON_LOADED. Adding to the above code...

MyAddon_frame:RegisterEvent("ADDON_LOADED")
function MyAddon_frame:ADDON_LOADED(...)
    if ... == MyAddon then
        addon_loaded = true
        MyAddon_frame:UnregisterEvent("ADDON_LOADED") -- we don't check for other AddOns
    end
end

[SDPhantom]

Originally Posted by myrroddin MyAddon_frame:RegisterEvent("ADDON_LOADED") function MyAddon_frame:ADDON_LOADED(...)     if ... == MyAddon then         addon_loaded = true         MyAddon_frame:UnregisterEvent("ADDON_LOADED") -- we don't check for other AddOns     end end

This won't work without the following OnEvent handler.

MyAddon_frame:SetScript("OnEvent",function(self,event,...)
    local func=self[event];
    if func then func(...); end
end);