Reply
Thread Tools Display Modes
Unread 01-23-10, 11:57 AM   #21
xtoq
An Aku'mai Servant
 
xtoq's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2008
Posts: 32
Rares?

Would it be possible to add the ability to take a screenshot when you kill a rare? Paparazzi has this, and I find its about the only thing I can think of that I'd like this to do. Thanks for a great addon and keep up the great work!
__________________
There is absolutely no evidence to support the theory that life is serious.
xtoq is offline   Reply With Quote
Unread 01-24-10, 06:03 PM   #22
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,191
It's definitely possible but there is a bit of deliberation involved.

There's 2 ways of doing this:
- Use a list of rares (by mining wowhead) similarly to how the addon uses a list of bosses (provided by LibBossID)
- Use API to determine if the mob killed was a rare.

There's pros and cons to both methods.
List pretty much ensures you will not miss a rare screenshot (if your list is complete)
but you can end up with screenshots when others (in combatlog distance) kill a rare.

I'm testing a method that doesn't rely in a hardcoded list but it is a bit hard to find rares on demand

Anyway I'll probably post some code tomorrow or the next day for both methods and dlui can decide if and which he'd like to use

Last edited by Dridzt : 01-25-10 at 11:40 PM.
Dridzt is offline   Reply With Quote
Unread 01-25-10, 08:33 PM   #23
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,191
Changed files (against Multishot r39.1) for:

Method A (rares determined by API)
-----------------------------------
Multishot.lua http://www.pastey.net/131911
Config.lua http://www.pastey.net/131912
This will catch any rare or rare elite that you kill provided it was your target at the time of death.
Pros: no need for a hardcoded list and "auto updates" if new rares are added to the game.
Cons: you can lose a screenshot if somehow the mob is not targetted when it dies.

Method B (rares determined by a list of IDs)
------------------------------------------
A new file added to the addon folder...
Rares.lua http://www.pastey.net/131915
and to Multishot.toc http://www.pastey.net/131916
Multishot.lua http://www.pastey.net/131913
Config.lua http://www.pastey.net/131912 (same as above)
Pros: Will catch any rare killed that's included in the list regardless if it was targetted.
Cons: The included list will need updates if new rares are added / discovered.
It will take screenshots when a rare is killed in combatlog range regardless if it was the player's kill.
Dridzt is offline   Reply With Quote
Unread 01-26-10, 06:28 AM   #24
dlui
A Fallenroot Satyr
 
dlui's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 20
Great Work. Thanks.

But which of the two solutions should I add?

Does UnitClassification("target") work? Isn't the target cleared on killing a mob?

Maybe combining these two methods: if UnitClassification isn't a match let's ask our inbuild db?
dlui is offline   Reply With Quote
Unread 01-26-10, 08:29 AM   #25
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,191
UnitClassification works and the target is cleared but after UNIT_DIED fires.
So if you had the mob targetted as it died the screenshot is taken as expected.

I can't think of a way to combine the 2 so that they complement each other.
The list will catch all rare kills included in it.
Trying to qualify it by checking that it was your target as it died (weeding out false positives: other peoples kills in the vicinity)
will effectively be the same as if you didn't use a list at all and only used the classification+target method.
What might make some sense is check classification after checking the list ('or' logic) to catch a rare that isn't included in the list (was recently put in game, or hasn't been encountered/datamined by wowhead or the list of ids included in the addon is incomplete).
I imagine this to be an extremely rare occurrence.

Flipping a coin would be an idea

Edit: Maybe go with the more 'catch all' (safer) approach of the list.
A false positive here and there shouldn't be an issue for the majority of users.

Last edited by Dridzt : 01-26-10 at 08:43 AM.
Dridzt is offline   Reply With Quote
Unread 01-31-10, 02:04 PM   #26
dlui
A Fallenroot Satyr
 
dlui's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 20
Thumbs up

I've uploaded the second solution. Thanks again!
dlui is offline   Reply With Quote
Unread 02-03-10, 10:43 PM   #27
Viper423
Premium Member
Join Date: Oct 2008
Posts: 1
Hello! Love the mod. I'm having a problem with it since I updated it to the latest version that was released on 1/31. Every time I kill a boss it takes a screen shot, and I have it disabled because I don't want a screen shot of every boss I kill. Anyway to fix this? I only want the mod to take a screen shot of achievements I get. Thanks!
Viper423 is offline   Reply With Quote
Unread 02-04-10, 12:08 AM   #28
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,191
I have to take the blame for that one.

It is a side-effect of the code added to support rares.

dlui's previous version was only monitoring the combatlog for deaths when the option to take screenshots in party or raid was selected.

As a temporary workaround you can uncheck the rares option and the addon will revert to the previous behavior.

For a proper fix a minor edit is necessary.
Dridzt is offline   Reply With Quote
Unread 02-07-10, 12:22 AM   #29
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,191
This should fix that glitch and allow both bosskill and rare kill options to work independently.

Multishot.lua (off 39.2)
http://www.pastey.net/132597
Dridzt is offline   Reply With Quote
Unread 03-18-10, 04:17 PM   #30
Zidomo
A Cliff Giant
 
Zidomo's Avatar
Join Date: Apr 2006
Posts: 76
As per my Dec. 17/09 post in the Multishot comments:

Originally posted by Zidomo
Problem with Multishot r34 in WoW 3.3 (using with the latest LibBossIDs-1.0 r36 from Dec. 9/09).

Its consistently taking screenshots of certain trash mob deaths in the new Pit of Saron 5-man instance. Specifically: Ymirjar Flamebearers, Ymirjar Flamebearers and/or Ymirjar Wrathbringers.

No, its not connected to any reputation level gains or anything else. Have yet kill the first mob group up the path after the Krick & Ick boss without it taking an unwanted screenshot.
This problem is still occurring on every run of PoS heroic in WoW 3.3.2 live with Multishot r42. Have also seen it occur in other instances/raids.
Zidomo is offline   Reply With Quote
Unread 03-19-10, 10:01 AM   #31
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,191
User chicknlil25 debugged this.
Answer is in comment section.

Short version:
Addon takes a screenshot when Jaina/Tyranus Roleplay finishes and Ick is killed.
Dridzt is offline   Reply With Quote
Unread 03-19-10, 03:16 PM   #32
dlui
A Fallenroot Satyr
 
dlui's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 20
Thumbs up

This has been fixed in r42a. Thanks for reporting.

dlui is offline   Reply With Quote
Unread 06-14-10, 01:08 PM   #33
dlui
A Fallenroot Satyr
 
dlui's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 20
Unhappy

Multishot r44b is out with tons of new features!

The sad part is I'm almost sure that I messed up something. So if anybody please could have a look at the source code if I made a mistake?

Please report bugs as soon as possible!
dlui is offline   Reply With Quote
Unread 06-14-10, 01:59 PM   #34
robthedude
Don't Panic
 
robthedude's Avatar
Join Date: Oct 2006
Posts: 364
Bug Report!


Multishot-r44b\Locales\Locale-deDE.lua:2: attempt to index local 'L' (a nil value)

but deDE is German, right? I'm not German, and neither is my client... dunno if that's important
__________________

robthedude is offline   Reply With Quote
Unread 06-14-10, 02:21 PM   #35
dlui
A Fallenroot Satyr
 
dlui's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 20
Thank you. Could it be that you did not restart WoW after updating?

Last edited by dlui : 06-14-10 at 02:29 PM. Reason: Desperate. No more.
dlui is offline   Reply With Quote
Unread 06-14-10, 03:08 PM   #36
robthedude
Don't Panic
 
robthedude's Avatar
Join Date: Oct 2006
Posts: 364
nope, I always log out to install addons... that said, I do have rather a lot, so in all likelyhood, it's not yours that is causing the problem.

Even then, it's not really a problem, it doesn't seem to break anything. I deleted Locale-deDE.lua and removed the reference to it from Locales.xml, which has stopped the bug from showing up
__________________

robthedude is offline   Reply With Quote
Unread 06-14-10, 03:42 PM   #37
dlui
A Fallenroot Satyr
 
dlui's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 20
robthedude: fixed, thank you.

Last edited by dlui : 06-16-10 at 06:34 AM. Reason: fixed
dlui is offline   Reply With Quote
Unread 06-15-10, 06:06 AM   #38
xzbbzx
A Kobold Labourer
Join Date: Apr 2010
Posts: 1
Could you add the option to open the character window when taking the screenshot?

I like to take a screenshot of my character at every level, to see how their appearance changes over the levels.

Thx for the addon!
xzbbzx is offline   Reply With Quote
Unread 07-06-10, 04:08 PM   #39
dlui
A Fallenroot Satyr
 
dlui's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 20
Hi xzbbzx. Thanks for the suggestion. I'll think of a way to implement that.
dlui is offline   Reply With Quote
Unread 07-18-10, 07:32 PM   #40
Nitearrow01
A Murloc Raider
AddOn Author - Click to view addons
Join Date: Nov 2008
Posts: 5
Toggling off UI when taking a auto screen shot

would be nice if the addon had a option to toggle off UI when taking a screen shot for clean guild kill screen shots for guild web sites i tend to forget to take screen shot so i love this addon the bad part is you can see all my crap in the screen shots so was wondering if you can add a funtion to toggle off ui when it taks the screen shot
Nitearrow01 is offline   Reply With Quote
Reply

Go BackWoWInterface » AddOns, Compilations, Macros » Released AddOns » Multishot (Screenshot)

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off