Auras sorting

[Nodd]

I'm trying to implement a very custom sorting for my auras.
I want auras casted by me first, with priority on some auras, the others being sorted by decreasing total time. Here's what I've done so far :

local AuraPrio = { 139 }

local function AuraSort(a,b)
	if not a then
		return false
	elseif not b then
		return true
	elseif a.caster=='player' and not(b.caster=='player') then
		return true
	elseif b.caster=='player' and not(a.caster=='player') then
		return false
	elseif a.caster=='player' and b.caster=='player' then
		for i,Id in ipairs(AuraPrio) do
			if a.Id==Id then
				return true
			elseif b.Id==Id then
				return false
			end
		end
	end

	return a.duration >= b.duration
end

local function preAuraSetPosition(self,aura,max)
	for i=1, max do
		if aura[i] then
			local auras = aura[i]:GetParent()
			local frame = auras:GetParent()
			local unit, filter = frame.unit, auras.filter
			_, _, _, _, _, aura[i].duration, _, aura[i].caster, _, _,aura[i].Id = UnitAura(unit, i, filter)
		
			if( aura[i].duration == nil ) then
				aura[i].duration = math.huge
			end
		end
	end

	table.sort(aura,AuraSort)
end

But when an aura expires, I get an error : "attempt to index local value 'b' (a userdata value)" at the second "elseif" in function "AuraSort".

It works fine if I set the sorting function to :

local sort = function(a, b)
	return a.duration > b.duration
end

Any ideas ?

Bonus question :
in preAuraSetPosition, the for loop should go to 'max' ou '#aura' ?

[haste]

Originally Posted by Nodd Bonus question : in preAuraSetPosition, the for loop should go to 'max' ou '#aura' ?

Bonus answer:
Pre-sort: Going to max is in most cases enough.
Post-sort: Going to #auras is the only certain solution.

Commit f91cf5fc should be enough to explain why this is.

[Nodd]

Thanks Haste !

if not a then

became

if (not a) or (not a:IsShown())  then

And everything works like a charm !


I'm a bit afraid of "in most cases enough". Does it means I should go to #auras to be certain ?

The table.sort function enables to limit the range of the table which will be sorted. (http://lua-users.org/wiki/TableLibraryTutorial)
Setting

auras.n = max

would be "in most cases enough" then ?

[haste]

Originally Posted by Nodd Thanks Haste ! I'm a bit afraid of "in most cases enough". Does it means I should go to #auras to be certain ?

You should only have to go to #auras if your artificially injecting auras into the table.

Originally Posted by Nodd The table.sort function enables to limit the range of the table which will be sorted. (http://lua-users.org/wiki/TableLibraryTutorial) Setting auras.n = max would be "in most cases enough" then ?

That's the Lua 5.0 behavior. It won't work in Lua 5.1.

[Nodd]

Oops, I wrote too fast : I still get the "attempt to index local value 'b' (a userdata value)".
It seems logical actually : 'b:IsShown' isn't valid if 'b' is not valid either.

I get it sometimes when a buff fades (but not everytime).

[haste]

it should work fine, no real changes has been made to sorting since around 1.3.20 or so. I'd just suggest debugging it and see if you can figure out why it fails (and how).

[v6o]

Necro Haste!

On a serious matter I just deleted the posts because I figured out what was wrong after.

[haste]

Originally Posted by v6o Necro Haste! On a serious matter I just deleted the posts because I figured out what was wrong after.

I saw you deleted it the first time at least :P

[Caellian]

I figured there was no need for a new topic about this so i'm dropping this here.

I'm not as complicated, i only wanted a simple duration sorting for my buffs/debuffs, and using:

local SortAura = function(a, b)
	return (a.timeLeft) > (b.timeLeft)
end

local PreSetPosition = function(auras)
	sort(auras, SortAura)
end

With the player frame it's just fine, but with the target frame (and some others aswell), the timers seems "jumpy", and i can't figure out why.

[p3lim]

Make sure the .timeLeft attribute is on all the icons, and that they are set before the sort function triggers.

I set the .timeLeft in CustomFilter, you can take a look at how I did it:
http://github.com/p3lim/Scent/blob/master/Auras.lua

[Caellian]

Originally Posted by p3lim Make sure the .timeLeft attribute is on all the icons, and that they are set before the sort function triggers. I set the .timeLeft in CustomFilter, you can take a look at how I did it: http://github.com/p3lim/Scent/blob/master/Auras.lua

Very nice, thanks, it worked.