Beta API discussion

[Iza]

GetSpellBookItemName(index, booktype) will cause an error ("... invalid spell slot ...") instead of returning <nil> values for non-existant spell slots it seems. I solved this by using pcall for the moment, but that's just not very smart. Is there way to tell how many slots there are?

[Xrystal]

I used that in one of my addons earlier but managed to bypass it somehow but can't remember how but now I see that same error for GetSpellInfo as well in nUI. Not double checked my own addons yet. Something for tonight me thinks.

[Iza]

Originally Posted by Xrystal I used that in one of my addons earlier but managed to bypass it somehow but can't remember how but now I see that same error for GetSpellInfo as well in nUI. Not double checked my own addons yet. Something for tonight me thinks.

GetSpellInfo(spellId) is still working fine for me for some reason. I remember some people reporting inconsistent return values for some of the GetSpellxxx functions on official forums these days.

[Xrystal]

I just took a look at my post in the nUI forums about my investigations yesterday and I found that somehow the way Scott has coded it to build the spell database for cool downs wow no longer likes it twice as the first time it goes through fine but the second time it errors out.

For no apparent reason barring it is a different event. Which makes it difficult if SPELLS_CHANGED isn't called when you learn a spell as if you tried to also run through the update routine when LEARNED_SPELL_IN_TAB event is fired it would error out. Or any such other Spell related event required an update to the table the way it currently does it in nUI.

If it isn't a blizzard oversight I may have to recode how it builds the spell database so that it could be dynamically built rather than rebuilt everytime.

[Xrystal]

well I changed scotts way of reading through the spell book with a while an infinite break when we run out of spells loop to a for loop that just reads through the spell tab using the following block of code. No errors since I did that but when I logged in earlier before the change i got the same error.

-- Get Specialization Spell Tab Info
local tabName, tabTexture, tabOffset, tabSlots, tabIsGuild, tabOffSpecID = GetSpellTabInfo(2);
 
-- Cycle through specialization spell tab and extra spells for cooldown usage
for i = tabOffset+1, tabSlots+tabOffset do
     local spellType, spellID = GetSpellBookItemInfo( i, BOOKTYPE_SPELL );
     local spellName,spellRank = GetSpellInfo( i, BOOKTYPE_SPELL );
     ....
end

[Ketho]

For the 16004 build seems they only added GetLootSourceInfo(slot) (unused) wowpedia/wowprog

Edit:
It seems to be used for differentiating between from what GUIDs an item (stack) is while AoE looting

In my case there were [Wool Cloth] x10 in the 4th loot slot

-- guid, lootQuantity = GetLootSourceInfo(slot)
GetLootSourceInfo(4) => "0xF130B4AA00000035", 4, "0xF130B4A900000034", 4, "0xF130B4AC00000067", 2

"Riverpaw Poacher" = 0xB4AA = 46250
"Riverpaw Slayer" = 0xB4A9 = 46249
"Riverpaw Shaman" = 0xB4AC = 46252

[Lombra]

The following code crashes the client:

local f = CreateFrame("Frame")
f:RegisterEvent("ADDON_LOADED")
f:SetScript("OnEvent", function(self, event, addon)
	GetIgnoreName(1)
end)

Dunno if it does on live too.

[Torhal]

Originally Posted by Ketho For the 16004 build seems they only added GetLootSourceInfo(slot) (unused) wowpedia/wowprog Edit: It seems to be used for differentiating between from what GUIDs an item (stack) is while AoE looting In my case there were [Wool Cloth] x10 in the 4th loot slot -- guid, lootQuantity = GetLootSourceInfo(slot) GetLootSourceInfo(4) => "0xF130B4AA00000035", 4, "0xF130B4A900000034", 4, "0xF130B4AC00000067", 2 "Riverpaw Poacher" = 0xB4AA = 46250 "Riverpaw Slayer" = 0xB4A9 = 46249 "Riverpaw Shaman" = 0xB4AC = 46252

This was because with AoE looting, it was impossible to determine which NPC an item came from. The WoWDB and WoWHead AddOns could not record accurate drop rates because of this. The function makes this possible again.

[Ketho]

Originally Posted by Torhal This was because with AoE looting, it was impossible to determine which NPC an item came from. The WoWDB and WoWHead AddOns could not record accurate drop rates because of this. The function makes this possible again.

Thanks for the explanation, and my apologies .. I didn't notice this thread beforehand ><

@Lombra: just tested, it doesn't also crash on live*

[Iza]

Using "MONOCHROME" font modifier instantly crashes game client for me.

@Xrystal: Thanks a lot, will change it this way too.

[Haleth]

I use "OUTLINEMONOCHROME" and I haven't been seeing these problems.

[Iza]

Originally Posted by Haleth I use "OUTLINEMONOCHROME" and I haven't been seeing these problems.

Right, "OUTLINE|MONOCHROME" is working for me too, but not "MONOCHROME" alone.

[Seerah]

Hmm... "MONOCHROME" was fine for me a couple builds ago.

[Shackleford]

Does anyone know the status of SummonRandomCritter()? Currently this only returns an error message of "You do not have a pet". Is this to be removed or is it just bugged?

[Meorawr]

Fontstrings with the MONOCHROME style set (and no outline styles) still crash the client as of 16010.

[Iza]

Originally Posted by Meorawr Fontstrings with the MONOCHROME style set (and no outline styles) still crash the client as of 16010.

Thanks for confirming, I already started thinking it's on my end...

[Kharthus]

Originally Posted by Shackleford Does anyone know the status of SummonRandomCritter()? Currently this only returns an error message of "You do not have a pet". Is this to be removed or is it just bugged?

It looks like they moved almost everything into C_PetJournal functions, but they didn't copy all the old functions over.

[Vlad]

Still not response on the API bug:
http://us.battle.net/wow/en/forum/to...5843?page=1#10 (illustration)
I hope they fix it for release, jeez.

Cladhaire if you are here, any inside info?

[Talyrius]

I hope this gets fixed for release as well:
[Bug] SecureAuraHeader

I've tried to make it as easy as possible for them to implement the necessary code changes.

[Meorawr]

And the MONOCHROME fontstring style crash is still in as of 16016. Might have to remove it as a configurable option for now