Pilgrims bounty broken

[Mechrior]

went to start pilgrims bounty on the current nui release and the action buttons are not appearing for the table quest so you can not eat food or throw it to anyone else.

No error text just not changing, the only one that changes its looks is button = that changes to the arrow graphically but still acts like a spell button its supposed to replace

...:::EDIT:::...
the pet/stance/shapeshift bar is coming up for a split second and then dissapearing when you enter a seat!
...:::EDIT:::...

[Xrystal]

And you are using the latest nUI version ?

Can you post up a screen shot.

[tawaraya]

none of buttons show with nui for pilgrim event. so was wondering if theres a fix to this problem? using latest version

[Mechrior]

Originally Posted by Xrystal And you are using the latest nUI version ? Can you post up a screen shot.

uninstalled then reinstalled NUI before trying to use the chairs this morning, here is a screen of my UI as it stands, I have tried disabling all other addons before trying and have tried with them enabled, nothing changed.



just took a look by disabling NUI and nothing else and got this:

definatly looks like an NUI error, maybe they changed the frame that is used?
/fstack says the bar is the OverrideActionBar

using /click macro's you can FORCE the actions to work using:

/click OverrideActionBarButton1 - will throw the food for your chair
/click OverrideActionBarButton2 - will eat on of the other foods thrown to you depending on your chair
/click OverrideActionBarButton3 - will eat on of the other foods thrown to you depending on your chair
/click OverrideActionBarButton4 - will eat on of the other foods thrown to you depending on your chair
/click OverrideActionBarButton5 - will eat on of the other foods thrown to you depending on your chair
/click OverrideActionBarButton6 - will eat the food from your chair



using this macro will eat each of the foods you have and holding shift and using it will exit the chair.

/click OverrideActionBarButton1
/click OverrideActionBarButton2
/click OverrideActionBarButton3
/click OverrideActionBarButton4
/click OverrideActionBarButton5
/click OverrideActionBarButton6
/click [mod:shift] OverrideActionBarLeaveFrameLeaveButton

[Xrystal]

hmm very strange. The override buttons work for the fair and the panda quests. will have to check it out and see whats happening there.

[zork]

Maybe I can help. Afaik it is the macro condition that gets you in trouble.

Neither [vehicleui] or [overridebar] are firing. But still the OverrideActionBar shows up in the default UI.

Can be checked with this macro from Phanx:

/run local s=SecureCmdOptionParse print(s("[extrabar]extrabar"),s("[overridebar]overridebar"),s("[possessbar]possessbar"),s("[vehicleui]vehicleui"))

How come? It turns out that actually what fired is [possessbar].

Now, to fix the problem and not to destroy normal possessbar behaviour it is possible to create a new condition that checks for the vehicle unit. That is: [possessbar,@vehicle,exists]

Here is my DIFF on rABS:
http://code.google.com/p/rothui/sour...verridebar.lua
http://code.google.com/p/rothui/sour.../core/bar1.lua

Not sure nUI is actually using macro conditions. But that is what worked for me.

If you are not using macro conditions and are using function check instead you can use sth like this:

--function check
        if ((HasVehicleActionBar() and UnitVehicleSkin("player") and UnitVehicleSkin("player") ~= "")
        or (HasOverrideActionBar() and GetOverrideBarSkin() and GetOverrideBarSkin() ~= ""))
        or UnitHasVehicleUI("player") then
          --I am the OverrideActionBar
        else
          --No thank you
        end

The default ActionBarController is using the same check.

[Sandwich62]

only change to action bar is "leave vehicle" button. If I disable nUI, everything works fine.

[Xrystal]

Thanks zork, I'll have a look and see if that works but not sure how it will affect other instances.

[Xrystal]

well zorks idea kinda works.

It flashes up very briefly with the buttons. So quickly I haven't been able to get a screenshot. Then the buttons disappear leaving the leave button there.

For your info nUI uses macro conditonals for visibility.


I changed nUI's line in the possesbar.lua file from:
RegisterStateDriver( frame, "visibility", "[bonusbar:5] show; hide" );
to
RegisterStateDriver(frame,"visibility","[possessbar][possessbar,@vehicle,exists] show; hide")

I then tried to change it to
RegisterStateDriver(frame,"visibility","[possessbar][overridebar,@vehicle,exists] show; hide")

But no visual difference but managed to take a screenshot before it disappeared.

Tried some changes but a line as simple as
RegisterStateDriver(frame,"visibility","[possessbar,@vehicle,exists] show; hide")

Did the exact same thing.

[spiel2001]

The issue is that you're trying to show the bar with his rules, but the bar visibility driver is hiding it again. Add a bar state to the bar visibility rule (something like "nui_override" and then set the bar state to nui_override if/when that if condition is true.

[Xrystal]

how do you do that ? I've only ever seen this stuff in nUI so don't know any other way of using it.

[spiel2001]

I *think* it works this way...

if not InCombatLockdown() 
and (test for the override bar special case)
then
   nUI_ActionBar:SetAttribute( page, "nui_override" );
end

and to set the action bar itself up to show the overlay bar when that happens...

        RegisterStateDriver(nUI_ActionBar, "page", "[vehicleui] 12; [nui_override] 14; [overridebar] 14; [bar:2] 2; [bar:3] 3; [bar:4] 4; [bar:5] 5; [bar:6] 6; [bonusbar:1] 7; [bonusbar:2] 8; [bonusbar:3] 9; [bonusbar:4] 10; [bonusbar:5] 11;1" );

I think that's right. If not, it should be close.

Note that you can't set attributes on secure frames while in combat, so that's why I added that test.

[Xrystal]

gotcha. will try it out next test session.

[Xrystal]

well, I don't know whether I have understood that rightly but it isn't erroring out which is a good sign. unfortunately it hasn't made a difference.

Still using the nUI_PossessBar.lus file as it is the possessbar that is being affected it seems.

at the top I have added the following:
RegisterStateDriver( frame, "page", "[nui_vehicle] 12; [nui_override] 14; [bonusbar:5] 11; 1" );

visibility is still the same:
RegisterStateDriver( frame, "visibility", "[bonusbar:5] show; hide" );

I then have the following OnEvent code - the blocks headed with my name or with my name alongside is what has been added:

anchor:SetScript( "OnEvent", 
 
    function( who, event ) 
 
--      nUI_ProfileStart( ProfileCounter, "OnEvent", event );
    
        if event == "PLAYER_ENTERING_WORLD"
        or event == "UPDATE_POSSESS_BAR"        -- xrystal
        or event == "UPDATE_OVERRIDE_ACTIONBAR" -- xrystal
        or event == "UPDATE_BONUS_ACTIONBAR"
        then
            
            frame.applyScale();
 
            -- xrystal
            if event == "UPDATE_POSSESS_BAR" or event == "UPDATE_OVERRIDE_ACTIONBAR" then
                print("Here - ",event)
                print("HasVehicleActionBar = ", HasVehicleActionBar())
                print("HasOverrideActionBar= ", HasOverrideActionBar())
                print("UnitHasVehicleUI=",UnitHasVehicleUI())
 
                if not InCombatLockdown() then
                    if ((HasVehicleActionBar() and UnitVehicleSkin("player") and UnitVehicleSkin("player") ~= "") or UnitHasVehicleUI()) then
                        print("Here - vehicle")
                        nUI_ActionBar:SetAttribute( "page", "nui_vehicle" );
                    end
                    if ((HasOverrideActionBar() and GetOverrideBarSkin() and GetOverrideBarSkin() ~= "") ) then
                        print("Here - override")
                        nUI_ActionBar:SetAttribute( "page", "nui_override" );
                    end
                else
                end
            end
 
        end
        
        -- update the bar
        
        for i=1, #frame.Buttons do
            frame.updateState( i );             
        end
        
--      nUI_ProfileStop();
        
    end 
);

and of course registered the extra events.

Now whether I have done this stuff wrong I have no idea what else to do at least at the moment.

[zork]

This is how Elvui does actionbar page swapping. The Childupdate is pretty cool. It updates all children to the same state.

AB["barDefaults"] = {
        ["bar1"] = {
            ['visibility'] = "[petbattle] hide; show", --[petbattle][overridebar][vehicleui] hide; show
            ['page'] = 1,
            ['conditions'] = string.format("[vehicleui] %d; [possessbar] %d; [overridebar] %d; [bar:2] 2; [bar:3] 3; [bar:4] 4; [bar:5] 5; [bar:6] 6;", GetVehicleBarIndex(), GetVehicleBarIndex(), GetOverrideBarIndex()),
        },
    }
 
        --GetPage() just concatenates condition and default page
        --basically returns this: [vehicleui] GetVehicleBarIndex(); [possessbar] GetVehicleBarIndex(); [overridebar] GetOverrideBarIndex(); [bar:2] 2; [bar:3] 3; [bar:4] 4; [bar:5] 5; [bar:6] 6; 1"     
        RegisterStateDriver(bar, "page", self:GetPage(barName, self['barDefaults'][barName].page, self['barDefaults'][barName].conditions));
        RegisterStateDriver(bar, "visibility", self['barDefaults'][barName].visibility)
     
        bar:SetAttribute("_onstate-page", [[
            self:SetAttribute("state", newstate)
            control:ChildUpdate("state", newstate)
        ]])

[Xrystal]

Thanks Zork,

I'll probably get another stab at this while I wait for my US buddies to log in after their thanksgiving get togethers.

[Xrystal]

still a no go ..

Im off most of next week though so will have a bit more time to play about with it somewhat.