UnitInParty(name)

[gmarco]

Hi all,
If I want to check if something is happening to me and to a player (name) that is in party or raid or bg with me, can I use only:

if destGUID == UnitGUID("player") or UnitInParty(name) then
 
-- code
 
end

UnitInParty(name) seems to me true (and so enough) if unit is in party or raid (also in different group).

Or I have to check something else like UnitInRaid(name) ?

Thanks for attention.

[Phanx]

If you just want to check if they're in your group, you can use any UnitWhatever function; all of those functions will return nil if called with a name (instead of a unitID) that doesn't belong to someone in your group. eg. this will work the same way:

if destGUID == UnitGUID("player") or UnitClass(name) then
    -- code
end

Also, looking up UnitGUID("player") on every combat log is extremely inefficient. Look it up once when PLAYER_LOGIN fires (you're probably already doing other initialization stuff there) and store it in a file-level local variable, and compare the destGUID against that.

[gmarco]

Hi Phanx,

as usual thanks for your precious inputs.

About the second iussue, the

destGUID == UnitGUID("player")

I wrote it in this way here to let others readers understand what I mean, but in the addon code it was:

if destGUID == playerGUID or UnitInParty(destName) then

where PlayerGUID is initialized as you suggested.


About the other part of the problem, what I'd like to understand was if the function:

UnitInParty(name)

was true also for raids and battleground (even if the units are in differents groups).

This because I was not able to find something like UnitInGroup() (even if there is a function: IsInGroup() for the player) that could be fine for all of them (party/raid/bg) and a I was a little bit confused about this.

Your answer is, as usual, perfect because UnitClass(name) works exactly I need.

Thanks again for all your answers.

P.s.
I am writing a "fatality" like addon, named autopsy. This because the most part of the code is common with the other addon I wrote on gankers and because the "real" fatality addon continues to fire a lot of LUA errors on the blizzard raidframe. I'll post the code here for a "final" review, if someone wants to check, as soon as it is refined a little bit.