Reply
Thread Tools Display Modes
Unread 01-28-13, 04:10 PM   #1
Foxlit
A Warpwood Thunder Caller
 
Foxlit's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2006
Posts: 91
SecureActionButtonTemplate: add LearnTalents/RemoveTalent as actions

Currently, the LearnTalents and RemoveTalent API functions are protected, and only called from Blizzard_TalentUI, which is prone to getting tainted in annoying ways. These API functions should be made available as SecureActionButtonTemplate actions, similar to how CastGlyph is accessible via the "glyph" action type of that template.

In theory, addons can already call these functions by performing a series of /click's on TalentUI buttons via SecureActionButtonTemplate, so adding explicit support for calling these directly from SABT does not permit addons to do anything they already can't do (if it weren't for the TalentUI/FrameXML/Addon interactions that taint TalentUI).

This would make it possible to work around the TalentUI taint issues by implementing a protected mechanism to swap talents in addons.


P.S. Speaking of glyphs, the "glyph" SABT action should also expose RemoveGlyphFromSocket, allowing glyphs to be removed as well as applied via the template.
__________________
... and you do get used to it, after a while.
Foxlit is offline   Reply With Quote
Reply

Go BackWoWInterface » Developer Discussions » Wish List » SecureActionButtonTemplate: add LearnTalents/RemoveTalent as actions

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off