Thread Tools Display Modes
Unread 04-23-13, 11:16 PM   #1
Belechannas
A Warpwood Thunder Caller
Join Date: May 2010
Posts: 86
Bug: All channel casts are displayed as interruptible

This has been driving me nuts for a while. I finally figured out what's going on (and how to fix it).

This is in reference to nUI5, latest version. I have not checked the code for nUI6.

In nUI_UnitCasting.lua, there are calls to the API functions

UnitCastingInfo

and

UnitChannelInfo

Both calls in nUI use 9 return arguments, the last of which is interpreted as the flag indicating whether the cast is (not) interruptible. This is correct for UnitCastingInfo.

The problem is that UnitChannelInfo only returns *8* arguments. The 8th return parameter (castID) of UnitCastingInfo is *not* present for UnitChannelInfo, which means the flag which indicates that a channeled spell is not interruptible is in the 8th (and final) returned value.

Since nUI expects the flag to be in the 9th returned value for both casts and channels, the value it gets for channels is always nil, which makes it think the spell is not "not-interruptible".

Trivial fix: delete the variable this_cast.castID from the list of returned values in the call to UnitChannelInfo (but *not* UnitCastingInfo) in nUI_UnitCasting.lua.

Although the returned value of castID (for casts) is shuffled around various data structures in nUI, it does not appear to be actually used for anything.

Edit: Checked nUI6, and the bug is already fixed there

Last edited by Belechannas : 04-24-13 at 12:50 AM.
Belechannas is offline  
Unread 04-24-13, 01:55 PM   #2
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
I have some bar work to do in nUI5 to deal with the temp shapeshift bar... I'll fix this at the same time.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
spiel2001 is offline  
Unread 09-11-13, 06:10 PM   #3
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
This should be in tonight's 5.07.37 release.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
spiel2001 is offline  
 

Go BackWoWInterface » Featured Projects » nUI, MozzFullWorldMap and PartySpotter » Support » nUI: Bug Reports » Bug: All channel casts are displayed as interruptible

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off