Thread Tools Display Modes
Old 06-30-13, 04:59 AM   #1
Belechannas
A Warpwood Thunder Caller
Join Date: May 2010
Posts: 86
nUI5: flyout spell cooldowns ignored

After being annoyed long enough with nUI not showing the cooldowns of my Shaman's totems (why does nUI hate Shaman?!), I dug into the code and figured out why.

The problem is that now all totems are stored in the spellbook as flyout lists, and nUI essentially ignores spells buried in there when building its spell table (which is in turn used to build the cooldown table). In particular, when scanning the spellbook, it finds the top-level flyout item (which has nil spell name, and hence is ignored), but doesn't "drill down" to the spells contained.

This presumably affects various other flyout abilities (hunter and warlock pets, rogue poisons, mage ports being some I can think of), but none of these have cooldowns (I think).

The solution is slightly messy, since nUI tracks spells using their index in the spellbook, which does not exist for flyout abilities.

The attached hack seems to work, but it is hardly beautiful code; it also contains the fix for passive spell cooldowns (e.g. Reincarnation) discussed in the above-linked thread.

Edit: to be clear, the problem is totems (and any other flyout spells) not appearing on the cooldown bar of the HUD.
Attached Files
File Type: lua nUI_CooldownBar.lua (34.7 KB, 143 views)

Last edited by Belechannas : 06-30-13 at 05:06 AM.
Belechannas is offline  
Old 06-30-13, 12:00 PM   #2
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
Yeah... this is a problem that I've been trying to figure out the best solution to in nUI6. I'm not happy with either solution (or several of the others I have tried) -- it's not a small part of why I still haven't released auras for nUI6. I'm being anal and OCD, but the solution has to be right.

To be sure, it is a problem and I am aware of it.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
spiel2001 is offline  
Old 09-11-13, 06:34 PM   #3
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
This should be in tonight's 5.07.37 release

Originally Posted by Belechannas View Post
After being annoyed long enough with nUI not showing the cooldowns of my Shaman's totems (why does nUI hate Shaman?!), I dug into the code and figured out why.

The problem is that now all totems are stored in the spellbook as flyout lists, and nUI essentially ignores spells buried in there when building its spell table (which is in turn used to build the cooldown table). In particular, when scanning the spellbook, it finds the top-level flyout item (which has nil spell name, and hence is ignored), but doesn't "drill down" to the spells contained.

This presumably affects various other flyout abilities (hunter and warlock pets, rogue poisons, mage ports being some I can think of), but none of these have cooldowns (I think).

The solution is slightly messy, since nUI tracks spells using their index in the spellbook, which does not exist for flyout abilities.

The attached hack seems to work, but it is hardly beautiful code; it also contains the fix for passive spell cooldowns (e.g. Reincarnation) discussed in the above-linked thread.

Edit: to be clear, the problem is totems (and any other flyout spells) not appearing on the cooldown bar of the HUD.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
spiel2001 is offline  
 

Go BackWoWInterface » Featured Projects » nUI, MozzFullWorldMap and PartySpotter » Support » nUI: Bug Reports » nUI5: flyout spell cooldowns ignored

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off