WoWInterface - Comments for PsiVen's AddOn(s)

i don't know if anyone else is inte... (HolyTrinity)

mrkurtz — Sun, 30 Sep 2012 12:30:59 +0000

i don't know if anyone else is interested, but based on my UI, i decided it'd be best to not have spell names, cd countdown, or icons for the cooldowns.

to do this, i just commented out the relevant lines by adding a "--" (without the quotes) to the beginning of each line in the following sections of HolyTrinity.lua (not counting lines beginning with local):

Text Timer
Spell Name Text
Cooldown Texture
Cooldown Icon Border

this makes each section look like:

-- Text Timer
local tdur = frame:CreateFontString(nil, "OVERLAY", "GameFontNormal")
--tdur:SetFont(vfont, 12, "OUTLINE")
--tdur:SetShadowColor(0,0,0,1)
--tdur:SetText("")
--tdur:SetJustifyH("RIGHT")
--tdur:SetPoint("RIGHT", frame, "RIGHT", -102, 0)

-- Spell Name Text
local sname = frame:CreateFontString(nil, "OVERLAY", "GameFontNormal")
--tdur:SetFont(vfont, 12, "OUTLINE")
--sname:SetShadowColor(0,0,0,1)
--sname:SetText(spellname)
--sname:SetJustifyH("LEFT")
--sname:SetPoint("LEFT", frame, "LEFT", 102, -12)

-- Cooldown Texture
local texture = frame:CreateTexture("texture", "BACKGROUND")
--texture:SetPoint("CENTER", bar, "CENTER", -117, 0)
--texture:SetTexture(GetSpellTexture(GetSpellInfo(spell)))
--texture:SetTexCoord(0.08,0.92,0.08,0.92)
--texture:SetHeight(24)
--texture:SetWidth(24)

-- Cooldown Icon Border
local border = frame:CreateTexture("texture", "OVERLAY")
--border:SetPoint("CENTER", texture, "CENTER")
--border:SetTexture(art.."border")
--border:SetHeight(24)
--border:SetWidth(24)

no errors, it at least works for the two items i show cooldown bars for (holy shock and holy prism), and in fact, it's gotten rid of every lua error i had at login.

i'd back up your HolyTrinity.lua file first, your mileage may vary.

Is th... (HolyTrinity)

enegence — Tue, 11 Sep 2012 23:30:49 +0000

Is there an option to make the background for holy power completely transparent, so they don't show up as empty outlines when there isn't a holy power inside them?

On the older version, I had renamed the empty.tga file to something else, and it gave me the result I was looking for, but in the new version, doing that creates a large green rectangle.

Does anyone know of an elegant solution for this?

Thanks!

I looked into this and couldn't find an easy way to do it manually, so I added an option to the config.

Awesome! Thanks a ton!

Is there an option... (HolyTrinity)

PsiVen — Sun, 09 Sep 2012 18:41:54 +0000

Is there an option to make the back... (HolyTrinity)

enegence — Sun, 02 Sep 2012 19:40:41 +0000

I was wondering, wo... (Holy Trinity (MoP Beta))

PsiVen — Mon, 27 Aug 2012 06:07:30 +0000

I was wondering, would it be possible to get a weakend blow debuff timer in this? (applied by HoTR lasts 30seconds).

I may implement this sort of thing eventually but the current implementation is strictly "abilities with cooldowns" which are processed differently. For the time being I plan to use PowerAuras myself.

I was wondering, would it be possib... (Holy Trinity (MoP Beta))

Falleneu — Thu, 02 Aug 2012 19:38:29 +0000

I was wondering, would it be possible to get a weakend blow debuff timer in this? (applied by HoTR lasts 30seconds).

nice work, I adopte it.no bug f... (Holy Trinity (MoP Beta))

Inshade — Sun, 08 Jul 2012 11:21:20 +0000

nice work, I adopte it.

no bug found for the moment

I'm pushing a minor update today, b... (HolyTrinity)

PsiVen — Sat, 03 Dec 2011 20:48:36 +0000

I'm pushing a minor update today, but the previous version still works with 4.3.

Are you still planning to update th... (HolyTrinity)

Falleneu — Sat, 03 Dec 2011 15:49:13 +0000

Are you still planning to update this addon for 4.3?
Just asking so i know if i should look for a replacement.

(It does still work fine tho so no real rush just curious).

Originally posted by Virr... (HolyTrinity)

PsiVen — Thu, 03 Nov 2011 05:27:21 +0000

Originally posted by Virro
Quick question, is it possible to do this:

Make the Holy Power meter appear ONLY when i have 1,2 or 3 Holy Power, and make it fade 100% out when my holy power is empty?

I think that should be possible. I'll put it on the list for 4.3.

Quick question, is it possible to d... (HolyTrinity)

Virro — Sun, 23 Oct 2011 19:34:17 +0000

Quick question, is it possible to do this:

Make the Holy Power meter appear ONLY when i have 1,2 or 3 Holy Power, and make it fade 100% out when my holy power is empty?

Hi there again,so sad i post ag... (HolyTrinity)

Morwo — Thu, 12 May 2011 22:34:56 +0000

Hi there again,

so sad i post again, above my own post above my own post! I would like to see HolyTrinity shows up any yet selectable cooldown to be set to flicker (maybe in some adjustable transparency, with the design HolyTrinity now provides, full bar and symbol) if its ready to use again.

Thx

Holy Power cooling down (HolyTrinity)

Morwo — Sun, 01 May 2011 14:27:17 +0000

Hi there,

i just found on PowerUp http://wowinterface.com/downloads/info18438-PowerUp.html, a similar design to holy trinity. while i won't change to PowerUp because of HolyTrinitys Cooldown bars, i wonder if u can implement the HolyPower cooling down out of fight, like in PowerUp.

Re: Please Add (HolyTrinity)

Morwo — Wed, 09 Feb 2011 21:33:36 +0000

And Rebuke plz, since 4.06 is out :)

Please Add (HolyTrinity)

Roguebullit — Sat, 22 Jan 2011 22:21:53 +0000

Psi love this AddOn and keep up the good work. Just wondering if you could add an Inquisition cool down to the list. Think it would really be helpful. Thanks.

How i can diseable cooldown bar ? (HolyTrinity)

Roiyan — Mon, 06 Dec 2010 17:17:24 +0000

Originally posted by Zidomo
In looking for reliable a Holy Power monitor on a new 80 Paladin, gave this a try. Several large usability issues.

For all four "Holy Power Spacing" and "Holy Power Size" sliders, try to move the sliders to an integer greater than 0 and the sliders will improperly automatically "slide back" to the full minimum.

For example, try to change "Holy Power Size (X)" to a value greater than 0 using the slider, it will automatically slide back to "-512", meaning the monitors will vanish off the screen. You have to manually enter positive values in the number box (for example, 100) for them to take effect. The slider bar still remains improperly on the full left after doing that. Try to move the slider again, it flips back to -512 and you have to start over.

In the Settings top menu, there are four different sliders, 2 of them labeled "X" and 2 of them labeled "Y" with all of them being unmarked...heh. Once you make the Holy Power boxes visible out of combat (via the Alpha bars), you can then see that the first 2 sliders are for it, but the other 2 you have no idea of. Can assess that they are for the cooldown bars, but its less than intuitive.

But the first "X" and "Y" sliders in Settings are not just for the Holy Power monitors, they strangely reposition both them and the cooldown bars together. The second X/Y set move the cooldown bars alone. Meaning in order to reposition the monitors, you have to move everything at once, then reposition the cooldown bars alone.

Very inconvenient, especially so since you can't actually see any of the cooldown bars out of combat unless you hit something like Hammer of Justice and still have its cooldown up OOC. Then you only have 1 minute to change the bars before they vanish...heh. Needs a "test" mode or similar.

And the fact they are resized using the very same "Scale" settings as the Holy Power monitors (that has problems as noted above) as well as "Display Order" for each (moves them only up and down when Enable Collapsing is disabled) means it can be very difficult to get them the size/position you want, if you can at all. Bars that are convenient to use can be resized by length and width and/or have draggable anchors and/or can be moved separately from other different UI elements (none of which apply to the cooldown bars here currently).

Nice idea combining both Holy Power monitors and ability cooldown bars, but needs a lot more usability work.

In looking for reliable a Holy Powe... (HolyTrinity)

Zidomo — Sat, 27 Nov 2010 11:21:23 +0000

In looking for reliable a Holy Power monitor on a new 80 Paladin, gave this a try. Several large usability issues.

For all four "Holy Power Spacing" and "Holy Power Size" sliders, try to move the sliders to an integer greater than 0 and the sliders will improperly automatically "slide back" to the full minimum.

For example, try to change "Holy Power Size (X)" to a value greater than 0 using the slider, it will automatically slide back to "-512", meaning the monitors will vanish off the screen. You have to manually enter positive values in the number box (for example, 100) for them to take effect. The slider bar still remains improperly on the full left after doing that. Try to move the slider again, it flips back to -512 and you have to start over.

In the Settings top menu, there are four different sliders, 2 of them labeled "X" and 2 of them labeled "Y" with all of them being unmarked...heh. Once you make the Holy Power boxes visible out of combat (via the Alpha bars), you can then see that the first 2 sliders are for it, but the other 2 you have no idea of. Can assess that they are for the cooldown bars, but its less than intuitive.

But the first "X" and "Y" sliders in Settings are not just for the Holy Power monitors, they strangely reposition both them and the cooldown bars together. The second X/Y set move the cooldown bars alone. Meaning in order to reposition the monitors, you have to move everything at once, then reposition the cooldown bars alone.

Very inconvenient, especially so since you can't actually see any of the cooldown bars out of combat unless you hit something like Hammer of Justice and still have its cooldown up OOC. Then you only have 1 minute to change the bars before they vanish...heh. Needs a "test" mode or similar.

And the fact they are resized using the very same "Scale" settings as the Holy Power monitors (that has problems as noted above) as well as "Display Order" for each (moves them only up and down when Enable Collapsing is disabled) means it can be very difficult to get them the size/position you want, if you can at all. Bars that are convenient to use can be resized by length and width and/or have draggable anchors and/or can be moved separately from other different UI elements (none of which apply to the cooldown bars here currently).

Nice idea combining both Holy Power monitors and ability cooldown bars, but needs a lot more usability work.

Originally posted by shad... (HolyTrinity)

PsiVen — Tue, 23 Nov 2010 19:04:26 +0000

Originally posted by shadow16990
Hi. Just started using this addon and I love it but I have a bug where divine plea and Avenging Wrath are anchored on top of each other. Dont know if its been reported to you but I dont see it here so :)
Keep up the good work

PS: Can upload a SS if you need

Are you using collapsing cooldowns or the standard fixed-position? If fixed-position you can move the anchor positions for each cooldown in the options menu, though they should not be overlapping in default settings.

Hi. Just started using this addon a... (HolyTrinity)

shadow16990 — Mon, 22 Nov 2010 22:07:08 +0000

Hi. Just started using this addon and I love it but I have a bug where divine plea and Avenging Wrath are anchored on top of each other. Dont know if its been reported to you but I dont see it here so :)
Keep up the good work

PS: Can upload a SS if you need

1x HolyTrinity-1.06\HolyTrinity.lua... (HolyTrinity)

Malqui — Wed, 10 Nov 2010 04:08:23 +0000

1x HolyTrinity-1.06\HolyTrinity.lua:419: attempt to index field 'db' (a nil value)
HolyTrinity-1.06\Options.lua:97: in function
(tail call): ?:
: ?
:"safecall Dispatcher":9: in function <"]:5>
(tail call): ?:
AceConfigDialog-3.0-50:797: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:612>
AceConfigDialog-3.0-50:849: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:837>
(tail call): ?:
: ?
:"safecall Dispatcher":9: in function <"]:5>
(tail call): ?:
AceGUI-3.0-33 (BankStack):314: in function `Fire'
...Stack\lib\AceGUI-3.0\widgets\AceGUIWidget-Slider.lua:76: in function <...Stack\lib\AceGUI-3.0\widgets\AceGUIWidget-Slider.lua:74>:

---