WoWInterface - Comments for Sandron's AddOn(s)

Re: Suggestion: LDB? (BEM-Button)

Sandron — Fri, 15 Oct 2010 19:35:43 +0000

Originally posted by SannaSK
4. I have a suggestion for this addon!

Can you make it where this will go into my LDB Display (personally I use ChocolateBar but I think all LDB is more or less the same)? I really really really hate having things on my minimap.

Now that Blizz's EM saves "do not save this slot" (and that ItemRack hasn't been updated for 401, and since IR did a ton of things I didn't need), I figure it's time to switch and reduce my addon consumption, even by a little bit. So this looks like a nice little "does only what I want and nothing I don't" addon... but prettiful please can it go into my LDB bar? Thanks a ton for considering \o
Use this instead: http://www.wowinterface.com/downloads/info12641-Broker_Equipment.html

Suggestion: LDB? (BEM-Button)

SannaSK — Fri, 15 Oct 2010 17:06:33 +0000

4. I have a suggestion for this addon!

Can you make it where this will go into my LDB Display (personally I use ChocolateBar but I think all LDB is more or less the same)? I really really really hate having things on my minimap.

Now that Blizz's EM saves "do not save this slot" (and that ItemRack hasn't been updated for 401, and since IR did a ton of things I didn't need), I figure it's time to switch and reduce my addon consumption, even by a little bit. So this looks like a nice little "does only what I want and nothing I don't" addon... but prettiful please can it go into my LDB bar? Thanks a ton for considering \o

editing in here because I feel bad making a whole 'nother comment just to say thanks, but: Thanks for the link!

Originally posted by Zido... (Broker TankInfo)

Sandron — Fri, 03 Sep 2010 11:15:09 +0000

Originally posted by Zidomo
Right, but why does it need to check for new data every 5 seconds, in combat or not (or whatever; when I tested, the CPU spiked every 2-3)? Why not just update when someone invokes showing the LDB tooltip/mouses over the LDB display?

As noted before, no other mod tested that provides similar info to TankInfo uses CPU on idle. Likely due to refraining from updating until its actually needed (i.e. a display is shown).
Okay, you may be right, I will change this in a future version, I have not much time at the moment, but it is on top of my to do list.

Originally posted by Sand... (Broker TankInfo)

Zidomo — Thu, 02 Sep 2010 15:25:54 +0000

Originally posted by Sandron
Well, this data isn't really static, it can be changed by buffs, debuffs, and so on. The addon checks for new data every 5 seconds. I think this is, what causes the cpu usage.Right, but why does it need to check for new data every 5 seconds, in combat or not (or whatever; when I tested, the CPU spiked every 2-3)? Why not just update when someone invokes showing the LDB tooltip/mouses over the LDB display?

As noted before, no other mod tested that provides similar info to TankInfo uses CPU on idle. Likely due to refraining from updating until its actually needed (i.e. a display is shown).

Originally posted by Zido... (Broker TankInfo)

Sandron — Sun, 15 Aug 2010 17:37:05 +0000

Originally posted by Zidomo
Testing the new v1.1.7dev from Curse (it hasn't been uploaded here), a couple of new problems.

The most serious: this is now using CPU time every 2 to 3 ticks/seconds.

Ace3 have disembedded, other 4 libraries are embedded (CallBackHandler-1.0, LibStub & LibDataBroker-1.1 use no CPU; don't know about the new "LibCopyStuff.lua" that's in this version). Testing with OptionHouse with CPU profiling enabled, Broker_TankInfo v1.1.7dev uses 0.180 CPU/second every 2-3 ticks/seconds (Ace3 on its own medians 0.775 CPU/second continually).

Not a lot, but a mod like this that provides static data should not be using CPU at all. Similar mods such as the aforementioned lowAvoidance & idhitthat as well as Broker_Unhittable, Broker Hittable & so on use no CPU at any time.

Well, this data isn't really static, it can be changed by buffs, debuffs, and so on. The addon checks for new data every 5 seconds. I think this is, what causes the cpu usage.

Second issue is that the new pop-up box when you log on am not a fan of. That info--if its really necessary--could just as easily be put in chat.

I'll think about this.

Another problem with it: the "This is your first launch, thank you for using Broker TankInfo! For configuration, type /tankinfo config into your chat window!" text, although cool, is incorrect. That command does not open the Blizzard options frame.
True, but it should. This is a bug, I will take a look into it. Thank you for the feedback.

The new v1.1.7dev hasn't been uploaded here, because it's a beta.

Testing the new v1.1.7dev from [URL... (Broker TankInfo)

Zidomo — Thu, 12 Aug 2010 17:31:04 +0000

Testing the new v1.1.7dev from Curse (it hasn't been uploaded here), a couple of new problems.

The most serious: this is now using CPU time every 2 to 3 ticks/seconds.

Ace3 have disembedded, other 4 libraries are embedded (CallBackHandler-1.0, LibStub & LibDataBroker-1.1 use no CPU; don't know about the new "LibCopyStuff.lua" that's in this version). Testing with OptionHouse with CPU profiling enabled, Broker_TankInfo v1.1.7dev uses 0.180 CPU/second every 2-3 ticks/seconds (Ace3 on its own medians 0.775 CPU/second continually).

Not a lot, but a mod like this that provides static data should not be using CPU at all. Similar mods such as the aforementioned lowAvoidance & idhitthat as well as Broker_Unhittable, Broker Hittable & so on use no CPU at any time.

Second issue is that the new pop-up box when you log on am not a fan of. That info--if its really necessary--could just as easily be put in chat.

Another problem with it: the "This is your first launch, thank you for using Broker TankInfo! For configuration, type /tankinfo config into your chat window!" text, although cool, is incorrect. That command does not open the Blizzard options frame.

Originally posted by Zido... (Broker TankInfo)

Sandron — Sat, 07 Aug 2010 23:36:03 +0000

Originally posted by Zidomo
The new v1.1.5 is bugged. Log on and the following errors are thrown. The mod doesn't load either:

1x Broker_TankInfo-v1.1.5\core.lua:12: attempt to call field 'OnClick' (a nil value)
&
1x Broker_TankInfo-v1.1.5\config.lua:60: attempt to call field 'copy' (a nil value)

USEnglish client/server, WoW 3.3.5 live, StatBlockCore LDB display. The prior v1.1.2 produces no errors at logon or any other time.
Fixed in 1.1.6, uploading right now

Second problem that is also present in v1.1.2. The data this provides doesn't align with that provided by other, similar mods.

For example, on a level 65 Paladin tank with 395 defense (& so on), Broker_TankInfo v1.1.2 states that vs. a level 68 mob/boss: "Chance to get critically hit: 13.4%". But with the following mods, the chance to get critically hit stated is much less vs. a level 68:
--lowAvoidance: 2.17%
--idhitthat (a fork of lowAvoidance): same
--Stomped Shear (vs. a level 68 targeted): 5.60%

So not sure what your incoming crit chance formula is, but it sure seems "off" compared with these other mods. Unless there is a mistake where it is actually calculating vs. a level 83 boss target, even though the character is only 65.
Did you check the enemy level in settings?
Edit: confirmed, this is a bug, going to fix this.

The new v1.1.5 is bugged. Log on an... (Broker TankInfo)

Zidomo — Sat, 07 Aug 2010 10:40:56 +0000

The new v1.1.5 is bugged. Log on and the following errors are thrown. The mod doesn't load either:

1x Broker_TankInfo-v1.1.5\core.lua:12: attempt to call field 'OnClick' (a nil value)
&
1x Broker_TankInfo-v1.1.5\config.lua:60: attempt to call field 'copy' (a nil value)

USEnglish client/server, WoW 3.3.5 live, StatBlockCore LDB display. The prior v1.1.2 produces no errors at logon or any other time.

Second problem that is also present in v1.1.2. The data this provides doesn't align with that provided by other, similar mods.

For example, on a level 65 Paladin tank with 395 defense (& so on), Broker_TankInfo v1.1.2 states that vs. a level 68 mob/boss: "Chance to get critically hit: 13.4%". But with the following mods, the chance to get critically hit stated is much less vs. a level 68:
--lowAvoidance: 2.17%
--idhitthat (a fork of lowAvoidance): same
--Stomped Shear (vs. a level 68 targeted): 5.60%

So not sure what your incoming crit chance formula is, but it sure seems "off" compared with these other mods. Unless there is a mistake where it is actually calculating vs. a level 83 boss target, even though the character is only 65.

Originally posted by Tary... (Broker TankInfo)

Sandron — Sun, 28 Feb 2010 03:27:09 +0000

Originally posted by Taryble
Why did you choose a level 85 enemy?

There are no enemies in the game that are level 85 currently - the highest are raid bosses, which are level 83.
The default enemy level is player level plus 3, which should be 83. You can change this to higher levels, i.e. when Cataclysm comes out or if you're doing forbidden things (I hope you won't). If you don't use this feature, where's the problem? ;-)

Why did you choose a level 85 enemy... (Broker TankInfo)

Taryble — Sun, 28 Feb 2010 01:18:58 +0000

Why did you choose a level 85 enemy?

There are no enemies in the game that are level 85 currently - the highest are raid bosses, which are level 83.

Originally posted by Dark... (BEM-Button)

Sandron — Mon, 07 Dec 2009 13:28:06 +0000

Originally posted by DarkStarX
I used now for over 2 years the same itemrack version with never updating and always worked fine till recently with the same itemnames, it started to make trouble, so wanted to write a own minimap button in itemrack style for the blizz one but then found this.

One thing i really missed is the option to put a set to bank or grab it from bank with shift+left click.

I do need in raid my tank and dps set while outside i prefer to have 1 of them in bank for the more bagspace when farming etc...

So i added that myself to the addon, if you are interested in adding something like that i could send you the code for it.
Could be nice.

I used now for over 2 years the sam... (BEM-Button)

DarkStarX — Wed, 25 Nov 2009 14:43:49 +0000

I used now for over 2 years the same itemrack version with never updating and always worked fine till recently with the same itemnames, it started to make trouble, so wanted to write a own minimap button in itemrack style for the blizz one but then found this.

One thing i really missed is the option to put a set to bank or grab it from bank with shift+left click.

I do need in raid my tank and dps set while outside i prefer to have 1 of them in bank for the more bagspace when farming etc...

So i added that myself to the addon, if you are interested in adding something like that i could send you the code for it.

Originally posted by rick... (DuelBlocker)

Sandron — Sun, 18 Oct 2009 14:05:33 +0000

Originally posted by ricks322
I had to switch back to the older version, I keep getting this error:

Date: 2009-10-16 18:57:34
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\DuelBlocker\core.lua line 33:
bad argument #1 to 'gsub' (string expected, got nil)
Debug:
(tail call): ?
: ?
: gsub()
DuelBlocker\core.lua:33:
DuelBlocker\core.lua:26

I'll take a look at this.
Edit: Did you change the output text of DB?

I had to switch back to the older v... (DuelBlocker)

ricks322 — Fri, 16 Oct 2009 22:59:38 +0000

I had to switch back to the older version, I keep getting this error:

Date: 2009-10-16 18:57:34
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\DuelBlocker\core.lua line 33:
bad argument #1 to 'gsub' (string expected, got nil)
Debug:
(tail call): ?
: ?
: gsub()
DuelBlocker\core.lua:33:
DuelBlocker\core.lua:26

Originally posted by bioy... (BEM-Button)

Sandron — Tue, 29 Sep 2009 17:43:42 +0000

Originally posted by bioy
:) can you add the shortcut key support?
There are many other addons for this, but if you want, you can contact me and I might write a plugin for BEMB to do this, but this will not land in the main addon.
Originally posted by Servus
Would it be possible to add options to show/hide the cloak and helmet for each set?
This, I think, can also be done by other addons or a plugin, but I think this is too large to keep BEMB tiny.

Sorry for the late answer, but my c... (DuelBlocker)

Sandron — Tue, 29 Sep 2009 17:34:06 +0000

Sorry for the late answer, but my computer was not doing it's job and since I'm student, I've not much money. So I had to wait to get a new one.
But now I'm back and I've added some basic method to change the output text.
It'll be described in the addon description as soon as the new version is upped.

Well, in fact I'm going to change m... (DuelBlocker)

Abelius — Mon, 14 Sep 2009 13:10:31 +0000

Well, in fact I'm going to change myself that GTFO for something stronger. They fully deserve that... :rolleyes:

"Come on, FIVE duel requests in a row? Are you stupid or what??" :mad:

Originally posted by vikk... (DuelBlocker)

ricks322 — Sat, 22 Aug 2009 10:19:04 +0000

Originally posted by vikkyne
I had this thing fire of the 'gtfo' response today and cause a big problem.

Honestly, that response is uncalled for, and I won't use it or recommend it until I have the option of cancelling *any* type of response or it is taken out. There is no place for that kind of response in a social game.

You can go into the localisation .lua file and change it to say what ever you want. That is what I did.

I had this thing fire of the 'gtfo'... (DuelBlocker)

vikkyne — Mon, 17 Aug 2009 16:51:11 +0000

I had this thing fire of the 'gtfo' response today and cause a big problem.

Honestly, that response is uncalled for, and I won't use it or recommend it until I have the option of cancelling *any* type of response or it is taken out. There is no place for that kind of response in a social game.

Originally posted by rick... (DuelBlocker)

Sandron — Tue, 11 Aug 2009 16:53:40 +0000

Originally posted by ricks322
Great add-on. Now if you could write one to cancel those annoying guild requests that would take care of everthing....
i will take a look at this