WoWInterface - Comments for Legorol's AddOn(s)

Long time user and fan of EquipComp... (EquipCompare)

shinjuru — Sun, 11 Nov 2012 22:06:41 +0000

Long time user and fan of EquipCompare. Since there's been no update, I would highly suggest switching over to http://www.curse.com/addons/wow/moncaicompare as a great alternative. Not much to it, as it works directly with Blizzard's basic comparison tool.

I went through and made the changes... (EquipCompare)

Belial_69699 — Wed, 05 Sep 2012 06:56:39 +0000

I went through and made the changes as you posted, seems to be working fine atm but I checked !swatter (error catching add on that comes with Auctioneer) and this was there:

Date: 2012-09-05 01:33:58
ID: -1
Error occured in: Global
Count: 90
Message: ..\AddOns\EquipCompare\EquipCompare.lua line 1037:
Invalid inventory slot in GetInventorySlotInfo
Debug:
: ?
: GetInventorySlotInfo()
EquipCompare\EquipCompare.lua:1037:
EquipCompare\EquipCompare.lua:1035
EquipCompare\EquipCompare.lua:1188: EquipCompare_ShowCompare()
EquipCompare\EquipCompare.lua:1126: EquipCompare_CheckCompare()
EquipCompare\EquipCompare.lua:768: EquipCompare_OnUpdate()
:1:
:1
Locals:
(*temporary) = "RangedSlot"

AddOns:
Swatter, v5.14.5335 (KowariOnCrutches)
ACP, v3.4
Align, v
Atlas, v1.21.1
AtlasBattlegrounds, v1.21.1
AtlasDungeonLocs, v1.21.0
AtlasOutdoorRaids, v1.21.0
AtlasTransportation, v1.21.1
AtlasLootLoader, vv7.00.01
AtlasQuest, v4.8.0 BETA
AucAdvanced, v5.14.5335 (KowariOnCrutches)
AucFilterBasic, v5.14.5335 (KowariOnCrutches)
AucFilterOutlier, v5.14.5335.5335(5.14/embedded)
AucMatchUndercut, v5.14.5335.5225(5.14/embedded)
AucScanData, v5.14.5335 (KowariOnCrutches)
AucStatHistogram, v5.14.5335 (KowariOnCrutches)
AucStatiLevel, v5.14.5335 (KowariOnCrutches)
AucStatPurchased, v5.14.5335 (KowariOnCrutches)
AucStatSales, v5.14.5335.5335(5.14/embedded)
AucStatSimple, v5.14.5335 (KowariOnCrutches)
AucStatStdDev, v5.14.5335 (KowariOnCrutches)
AucStatWOWEcon, v5.14.5335.5335(5.14/embedded)
AucUtilAHWindowControl, v5.14.5335.5133(5.14/embedded)
AucUtilAppraiser, v5.14.5335.5335(5.14/embedded)
AucUtilAskPrice, v5.14.5335.5160(5.14/embedded)
AucUtilAutoMagic, v5.14.5335.5335(5.14/embedded)
AucUtilCompactUI, v5.14.5335.5335(5.14/embedded)
AucUtilEasyBuyout, v5.14.5335.5238(5.14/embedded)
AucUtilFixAH, v5.14.5335 (KowariOnCrutches)
AucUtilItemSuggest, v5.14.5335.5335(5.14/embedded)
AucUtilPriceLevel, v5.14.5335.5237(5.14/embedded)
AucUtilScanButton, v5.14.5335.5335(5.14/embedded)
AucUtilScanFinish, v5.14.5335.5153(5.14/embedded)
AucUtilScanProgress, v5.14.5335.4979(5.14/embedded)
AucUtilScanStart, v5.14.5335.5153(5.14/embedded)
AucUtilSearchUI, v5.14.5335.5335(5.14/embedded)
AucUtilSimpleAuction, v5.14.5335.5208(5.14/embedded)
AucUtilVendMarkup, v5.14.5335.4828(5.14/embedded)
Babylonian, v5.1.DEV.312(/embedded)
ButtonFacade, v5.0.387
Chatter, v1.0
Configator, v5.1.DEV.330(/embedded)
CTCore, v5.0002
DBMCore, v
DebugLib, v5.1.DEV.312(/embedded)
EquipCompare, v2.18
GFWDisenchantPredictor, v5.0.1
Grid, vr1522
Informant, v5.14.5335 (KowariOnCrutches)
LibExtraTip, v5.12.DEV.324(/embedded)
Linkepedia, v1.1.2
Masque, v5.0.387
MasqueLiteStep, v5.0.63
Omen, v3.1.7
OmniCC, v4.3.0
Quartz, v3.1.0-1-g0d31d19
RatingBuster, v5.0.4.361
Recount, v
SlideBar, v5.14.5335 (KowariOnCrutches)
StellarBars, v5.0.001
Stubby, v5.14.5335 (KowariOnCrutches)
TipHelper, v5.12.DEV.315(/embedded)
Titan, v5.1.3.50001
TitanBag, v5.1.3.50001
TitanClock, v5.1.3.50001
TitanGold, v5.1.3.50001
TitanLocation, v5.1.3.50001
TitanLootType, v5.1.3.50001
TitanPerformance, v5.1.3.50001
TitanRecZone, v5.0.0.3
TitanRepair, v5.1.3.50001
TitanVolume, v5.1.3.50001
TitanXP, v5.1.3.50001
XPerl, v3.5.10
XPerlArcaneBar, v
XPerlParty, v
XPerlPartyPet, v
XPerlPlayer, v
XPerlPlayerBuffs, v
XPerlPlayerPet, v
XPerlRaidAdmin, v
XPerlRaidFrames, v
XPerlRaidHelper, v
XPerlRaidMonitor, v
XPerlRaidPets, v
XPerlTarget, v
XPerlTargetTarget, v
BlizRuntimeLib_enUS v5.0.4.50001
(ck=b68)

Did I miss editing something in the file?

Re: 5.0.4 Fixes (EquipCompare)

defunk — Sun, 02 Sep 2012 19:05:46 +0000

These match the changes I made. Good Job. All works now.

To get rid of all errors introduced by Ranged/Relic slot removal and other 5.0.4 changes, open EquipCompare.lua and edit the following lines:

184-185:
= "MainHandSlot", -- Ranged
-- = "RangedSlot", -- Relic

198:
= "MainHandSlot", -- Wand

201-205:
= "MainHandSlot", -- Gun
-- = "AmmoSlot", -- Projectile
-- = "AmmoSlot", -- Projectile
= "MainHandSlot", -- Crossbow
= "MainHandSlot", -- Thrown

That's it, you're done. EQ 2.18 now works fine with WoW 5.0.4

5.0.4 Fixes (EquipCompare)

SaraFdS — Sun, 02 Sep 2012 04:14:13 +0000

To get rid of all errors introduced by Ranged/Relic slot removal and other 5.0.4 changes, open EquipCompare.lua and edit the following lines:

184-185:
= "MainHandSlot", -- Ranged
-- = "RangedSlot", -- Relic

198:
= "MainHandSlot", -- Wand

201-205:
= "MainHandSlot", -- Gun
-- = "AmmoSlot", -- Projectile
-- = "AmmoSlot", -- Projectile
= "MainHandSlot", -- Crossbow
= "MainHandSlot", -- Thrown

That's it, you're done. EQ 2.18 now works fine with WoW 5.0.4

Lots of errors on thi... (EquipCompare)

khurzog — Fri, 31 Aug 2012 01:43:11 +0000

Lots of errors on this patch. Any update coming?
Or any other addons similar to this?

http://www.curse.com/addons/wow/moncaicompare

Lots of errors on this patch. Any... (EquipCompare)

mondoz — Thu, 30 Aug 2012 08:25:20 +0000

Lots of errors on this patch. Any update coming?
Or any other addons similar to this?

Any update comming? (EquipCompare)

Wall — Sat, 12 May 2012 07:39:16 +0000

Any update comming?

No more working... (EquipCompare)

Zmb — Tue, 28 Feb 2012 20:22:42 +0000

No more working with last patch.

include WoW-like attribute change information (EquipCompare)

Luke1410 — Sun, 10 Jul 2011 20:50:59 +0000

Since some latest patch WoW tooltips contain inforamtion about attribute changes when holding down shift while hovering over an item (i.e. +- x stamina, compared to the item currently equipped).

Equipcompare currently lacks this additional information.

Hence I'd like to suggest to:
a) either add these information to Equipcompare or
b) let the default WoW tooltip being displayed for at least those situations where WoW itself supports equipment comparison

Reasoning:
These additional information are rather useful and help a lot when comparing items and losing these information when having equipcompare installed is a rather heavy argument against using EQCompare at all.

Is it possible to skin this addon?... (EquipCompare)

litesung — Wed, 11 May 2011 06:30:32 +0000

Is it possible to skin this addon? It doesn't match my other skinned mouse-over tooltip. I used this picture in a my Auctioneer post, but it shows my equiped item tool-tip not skinned.

http://imageshack.us/m/204/8616/unledbk.png

pb with new version (EquipCompare)

williamb — Sat, 30 Apr 2011 17:07:20 +0000

I cant use no more the old version.
The new pach seems not working with this old version.
thanks for your help

Tooltip rendered (partially/completely) off screen fix #2 for EquipCompare v2.18 (EquipCompare)

Thrashfinger — Sun, 10 Apr 2011 07:07:02 +0000

Originally posted by Legorol
It is possible for part of a comparison tooltip to be slightly off the screen
when the tooltips are very wide. This is a known bug in EquipCompare.

Howdy, Legorol! I've been AFK for a few years, and one of the first addons
I looked for when I reinstalled WoW was EquipCompare. I am glad to see you
are keeping it going.

Thank you for all your hard work on this addon over the years. :)

I may have figured out a method to resolve some of the issues with wide
comparative tooltip frames being displayed (partially or completely) off
the screen. This attempts to reposition wide comparative tooltip frames
(main hand to the left and off hand to the right of the main tooltip)
when *both* of the comparative tooltip frames do not fit together on the
left or right side of the main game tootlip.

* Works with WoW v4.0.6 and EquipCompare v2.18. * See NOTES below. *

Open the EquipCompare.lua file, found at:
(WindowsXP default location)
C:\Program Files\World of Warcraft\Interface\AddOns\EquipCompare\EquipCompare.lua

Replace code lines starting at 1260 through 1293.

Copy and paste the code between the following two comments:
"-- Try to place the tooltips in sensible places"
and
"-- Record side of alignment"

From:
-------------------------------------------------------------------

-- Try to place the tooltips in sensible places
if ( ComparisonTooltip1:IsVisible() ) then
if ( leftAlign ) then
local left = ComparisonTooltip1:GetLeft();
if ( left < 0 ) then
leftAlign = false;
ComparisonTooltip1:ClearAllPoints();
ComparisonTooltip2:ClearAllPoints();
ComparisonTooltip1:SetPoint("TOPLEFT", tooltip:GetName(), "TOPRIGHT", 0, -10);
ComparisonTooltip2:SetPoint("TOPLEFT", "ComparisonTooltip1", "TOPRIGHT", 0, 0);
end
else
local right;
local twotips = ComparisonTooltip2:IsVisible();
if ( twotips ) then
right = ComparisonTooltip2:GetRight();
else
right = ComparisonTooltip1:GetRight();
end
if ( right and GetScreenWidth() and right > GetScreenWidth() ) then
leftAlign = true;
ComparisonTooltip1:ClearAllPoints();
ComparisonTooltip2:ClearAllPoints();
if ( twotips ) then
ComparisonTooltip2:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
ComparisonTooltip1:SetPoint("TOPRIGHT", "ComparisonTooltip2", "TOPLEFT", 0, 0);
else
ComparisonTooltip1:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
end
end
end
end

-- Record side of alignment

-------------------------------------------------------------------
To:
-------------------------------------------------------------------

-- Try to place the tooltips in sensible places
if ( ComparisonTooltip1:IsVisible() ) then
local left = 0;
local right = 0;
if ( leftAlign ) then
left = ComparisonTooltip1:GetLeft();
if ( left < 0 ) then
leftAlign = false;
ComparisonTooltip1:ClearAllPoints();
ComparisonTooltip1:SetPoint("TOPLEFT", tooltip:GetName(), "TOPRIGHT", 0, -10);
right = ComparisonTooltip1:GetRight();
if ( ComparisonTooltip2:IsVisible() ) then
ComparisonTooltip2:ClearAllPoints();
ComparisonTooltip2:SetPoint("TOPLEFT", "ComparisonTooltip1", "TOPRIGHT", 0, 0);
right = ComparisonTooltip2:GetRight();
end
end
if ( right > GetScreenWidth() ) then
ComparisonTooltip1:ClearAllPoints();
ComparisonTooltip1:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
left = ComparisonTooltip1:GetLeft();
if ( ComparisonTooltip2:IsVisible() ) then
ComparisonTooltip2:ClearAllPoints();
ComparisonTooltip2:SetPoint("TOPLEFT", tooltip:GetName(), "TOPRIGHT", 0, -10);
right = ComparisonTooltip2:GetRight();
end
end
else
right = ComparisonTooltip1:GetRight();
if ( ComparisonTooltip2:IsVisible() ) then
right = ComparisonTooltip2:GetRight();
end
if ( ( right ) and ( GetScreenWidth() ) and ( right > GetScreenWidth() ) ) then
leftAlign = true;
if ( ComparisonTooltip2:IsVisible() ) then
ComparisonTooltip2:ClearAllPoints();
ComparisonTooltip2:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
ComparisonTooltip1:ClearAllPoints();
ComparisonTooltip1:SetPoint("TOPRIGHT", "ComparisonTooltip2", "TOPLEFT", 0, 0);
left = ComparisonTooltip1:GetLeft();
else
ComparisonTooltip1:ClearAllPoints();
ComparisonTooltip1:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
left = ComparisonTooltip1:GetLeft();
end
end
if ( left < 0 ) then
ComparisonTooltip1:ClearAllPoints();
ComparisonTooltip1:SetPoint("TOPRIGHT", tooltip:GetName(), "TOPLEFT", 0, -10);
left = ComparisonTooltip1:GetLeft();
if ( ComparisonTooltip2:IsVisible() ) then
ComparisonTooltip2:ClearAllPoints();
ComparisonTooltip2:SetPoint("TOPLEFT", tooltip:GetName(), "TOPRIGHT", 0, -10);
right = ComparisonTooltip2:GetRight();
end
end
end
--Test new tooltip positions to check if new far left, new far right, ComparisonTooltip1 bottom,
--and/or ComparisonTooltip2 bottom points are rendered off-screen.
--Solution: Reposition the main tooltip and redraw the comparative tooltip(s) to fit on screen.
--(Intentionally left blank, for now.)
end

-- Record side of alignment

-------------------------------------------------------------------
Save the file. Run the game. Your mileage may vary, but probably won't. ;)

NOTES:
1) There may be a few steps that can be optimized in the replacement code,
but I wanted the code to be "easy" to follow.

2) This code modification does not rectify the positioning of long tootips
which display beyond the bottom screen edge (possibly a future fix).

3) EquipCompare's tooltips appear to obscure the tootips displayed when
the player presses the ALT button while hovering over an equippable item.
I suppose if you are using EquipCompare, then you probably don't need the
ALT button's functionality - essentially making this a non-issue.

Re: Atlas Loot tool tips (EquipCompare)

Thrashfinger — Sun, 10 Apr 2011 02:35:31 +0000

Originally posted by noobez
I was wondering if you could implement tool tips that work with Atlas Loot. Simular to what Bonuses did.

Other than

AtlasLoot has a built-in option to show comparison tooltips:

Options // Interface // AtlasLoot

Top box, right column, second option "Comparison TT".

Were you looking for additional functionality beyond this, or was this what you were looking for?

Originally posted by Kola... (EquipCompare)

Malsis — Sat, 19 Mar 2011 13:00:24 +0000

Originally posted by Kolakhan
I see two tooltips to the right of the one I am wearing. The first one is two boxes superimposed over each other with BOTH items mixed together on top of each other and then the next one is the second item in the bag to compare to the one I am wearing?

You probably have Outfitter installed. Use it's option to turn off item comparison.

can you make update for 4.0.6? my c... (EquipCompare)

Katanja — Wed, 23 Feb 2011 22:54:28 +0000

can you make update for 4.0.6? my compare not more works :(
please make update^^:D

I see two tooltips to the right of... (EquipCompare)

Kolakhan — Thu, 03 Feb 2011 15:35:31 +0000

I see two tooltips to the right of the one I am wearing. The first one is two boxes superimposed over each other with BOTH items mixed together on top of each other and then the next one is the second item in the bag to compare to the one I am wearing?

Atlas Loot tool tips (EquipCompare)

noobez — Wed, 02 Feb 2011 21:02:21 +0000

I was wondering if you could implement tool tips that work with Atlas Loot. Simular to what Bonuses did.

Other than

Re: EquipCompare tooltips way off (EquipCompare)

AmeL — Thu, 27 Jan 2011 13:42:08 +0000

Originally posted by Szyarah
TOOLTIP placement is horrible, inconsistent, all over the map.
Suddenly the tips no longer line up. One tip is right at the mouse, the eqc tip is on the other side of the screen opposite wherever the main tip is.

This is a new bug, bad behavior, whatever. I have disabled the mod since it is far too distracting to be useful at this point.

Hopefully it will be updated for 2011. Otherwise, adieu Eqc, it's been fun.

Yeah ive had that same issue every once in a while. What ive been doing is an interface reload and that does the trick. But it does get a little annoying.

EquipCompare tooltips way off (EquipCompare)

Szyarah — Sat, 22 Jan 2011 02:16:29 +0000

TOOLTIP placement is horrible, inconsistent, all over the map.
Suddenly the tips no longer line up. One tip is right at the mouse, the eqc tip is on the other side of the screen opposite wherever the main tip is.

This is a new bug, bad behavior, whatever. I have disabled the mod since it is far too distracting to be useful at this point.

Hopefully it will be updated for 2011. Otherwise, adieu Eqc, it's been fun.

Color implement (EquipCompare)

AmeL — Wed, 29 Dec 2010 15:12:51 +0000

Love the add-on. Just a small request for it. I personally notice that when it does equipment comparisons there have been times that Ive gotten confused. It would be nice if the window(s) that says "CURRENTLY EQUIPPED", those words could say so with red letters or something to distinguish it at a glance. I would do it but not very versed in LUA programming. Dont know if it would be hard to implement without doing a whole lot of re-write of code.