WoWInterface - Comments for Leatrix's AddOn(s)

oh h... (Leatrix Plus)

Leatrix — Fri, 24 May 2013 23:57:37 +0000

oh hell, it was another addon

Tha's ok, Spiralofhope, I always enjoy reading your comments. I'm glad that you got your map addon problem sorted out. :)

Hello, anyway to add an option in M... (Leatrix Plus)

Glauck — Fri, 24 May 2013 13:10:23 +0000

Hello, anyway to add an option in Misc / Frame Features / Class colored target for player too ?

Re: Re: Re: Integrated browser (Leatrix Plus)

Leatrix — Thu, 23 May 2013 19:52:01 +0000

does seem very restricted, which is good. I guess there's not much point in fiddling with the cache.

As an aside - is the browser in lua? I wanted this when I first started playing so I wouldn't have to tab out but now that seems like a security hole to me. =/

It is very restricted and for that reason it's not something that I'm going to be using. I would much rather use a standalone web browser which is faster, easier to use, fills the screen and comes with a bundle of goodies such as the ability to add favorites, change font size, etc. There is some self-explanatory code for the help browser in HelpFrame.lua if you want to check it out, it's all really basic stuff though.

The new loot-role selection is buried in the character portrait menu. Would you consider adding a second row of checkboxes to the dungeon finder window(s), underneath the role selection, for loot-role selection?

Yes, I was thinking that myself. I'll look at it for the next update. :)

Re: Re: Integrated browser (Leatrix Plus)

spiralofhope — Thu, 23 May 2013 19:16:38 +0000

The in-game browser in 5.3 is really just a web interface to Battle.net support. As such, I don't really see any need for the options to delete cache and cookies, do you? If you can explain why those options are useful, please tell me.

It does seem very restricted, which is good. I guess there's not much point in fiddling with the cache.

As an aside - is the browser in lua? I wanted this when I first started playing so I wouldn't have to tab out but now that seems like a security hole to me. =/

---

Second note:

The new loot-role selection is buried in the character portrait menu. Would you consider adding a second row of checkboxes to the dungeon finder window(s), underneath the role selection, for loot-role selection?

Re: Integrated browser (Leatrix Plus)

Leatrix — Thu, 23 May 2013 17:16:56 +0000

With the new 5.3 integrated browser, have you thought about adding an on-login or once-daily Browser:DeleteCookies?

I haven't tinkered with that functionality yet, so I don't know how much it would matter if it's fairly restricted browsing..

(Holy hell, I can't remove that happy face.. bloody munchkin forums..)

Nice to hear from you again, Spiralofhope! :)

The in-game browser in 5.3 is really just a web interface to Battle.net support. As such, I don't really see any need for the options to delete cache and cookies, do you? If you can explain why those options are useful, please tell me.

Integrated browser (Leatrix Plus)

spiralofhope — Thu, 23 May 2013 16:43:43 +0000

I LOVE LOVE this add... (Leatrix Plus)

Leatrix — Wed, 22 May 2013 12:04:19 +0000

I LOV... (Leatrix Plus)

elals29 — Wed, 22 May 2013 04:19:01 +0000

I LOVE LOVE this addon, but it seems for some reason, on only one of my toons, It's making my combat log scroll on the left hand side where I chat to people and I've even checked off the option to hide the combat log. I'm pretty sure it's this addon cuz when I turned it off on my shammy it stopped. :confused::banana::banana::banana::banana::banana:

I'm not entirely sure what you mean and therefore I'm struggling to replicate your issue. So, here's a few pointers.
Please disable all other addons (except Leatrix Plus) and test on the character that you're experiencing the problem with. Do you still get the same result?
The option to hide the combat log only works if the combat log is docked (this is stated in the tooltip for the option). Is the combat log docked? If the combat log is docked when the UI is loaded, and the option to hide the combat log is enabled, the combat log should not be visible.
Be sure that you are using the latest version of Leatrix Plus.
I look forward to your reply.

I didn't think to make a screen shot. I mean the combat log will be readable as the same place where i can read my chats from guild and etc. I'll see if i can replicate thr issue and I ALWAYS updates my addons. ;)

World of Warcraft 5.3.0 and Leatrix Plus 5.3.00 (Leatrix Plus)

Leatrix — Mon, 20 May 2013 17:39:32 +0000

Just in case anyone missed it, the latest Leatrix Plus release (5.3.00) is designed for World of Warcraft patch 5.3 ONLY. If you try to use it with World of Warcraft patch 5.2, you might experience issues so don't do that.

Until World of Warcraft patch 5.3 goes live, you can download the latest version of Leatrix Plus for World of Warcraft patch 5.2 by clicking here.

If you have the latest version installed already, feel free to dance!

I LOVE LOVE this add... (Leatrix Plus)

Leatrix — Thu, 16 May 2013 15:48:07 +0000

I LOVE LOVE this addon, but it seem... (Leatrix Plus)

elals29 — Thu, 16 May 2013 15:37:24 +0000

Public Test Realm update (Leatrix Plus)

Leatrix — Thu, 18 Apr 2013 14:14:41 +0000

Public Test Realm Update

If you are using Leatrix Plus with the PTR (5.3), you need to uncheck world map customisation (interface menu) otherwise Leatrix Plus will not load correctly. This issue only affects the PTR, not the live realms.

Edit: The has been resolved. There is no longer any need to uncheck the map option on the PTR.

Re: Re: Re: auto set role (Leatrix Plus)

Leatrix — Thu, 18 Apr 2013 14:11:59 +0000

yeah i don't buy that. i've used just leatrix and i haven't had to manually select a role in a riad via role check. once i press i select role, save role, its worked every single day for weeks till yesterday.

its cool though i just enabled auto role problem fixed. good type out though 3/10 i'm sure most would read it and think its legit.

The code in Leatrix Plus works by watching two events, ACTIVE_TALENT_GROUP_CHANGED and LFG_ROLE_UPDATE. The first event fires when you change specs and when that happens, it runs a function called SetLFGRoles. This sets the Dungeon Finder role, NOT the character's group role.

The second event fires when a Dungeon Finder role has been changed and that is only watched so that the "Save Roles" button can be locked/unlocked depending on whether your role was changed.

That's basically all the code does. The character group role (for the role check that you are referring to) uses a function called UnitSetRole to set the role. This is the function that role automation addons use to manipulate the role check. The problem is that using this function during combat taints the UI so I won't be using it in Leatrix Plus. Other developers may be happy with the consequences of using functions which taint, I am not.

That's basically all that the code in Leatrix Plus does. It doesn't modify the character's group role at all and never has since it doesn't call UnitSetRole.

I have tried to provide as clear and detailed an answer as I can. If this is not acceptable to you, I can only suggest that you remove the addon.

Re: Re: auto set role (Leatrix Plus)

twopro — Thu, 18 Apr 2013 13:31:53 +0000

Leatrix Plus has never offered an option to automate the role check. The option to save roles with spec (interaction menu) is designed to make switching between specs easier. It's not designed to automate role checks.

yeah i don't buy that. i've used just leatrix and i haven't had to manually select a role in a riad via role check. once i press i select role, save role, its worked every single day for weeks till yesterday.

its cool though i just enabled auto role problem fixed. good type out though 3/10 i'm sure most would read it and think its legit.

Re: auto set role (Leatrix Plus)

Leatrix — Thu, 18 Apr 2013 08:42:36 +0000

hey, since yesterday when raid leaders do role checks the msg is popping up to select role i havent changed any settings ive had it setup up to set my role as damage and ya i think something has changed and it needs to be fixed.

Leatrix Plus has never offered an option to automate the role check. The option to save roles with spec (interaction menu) is designed to make switching between specs easier. It's not designed to automate role checks.

How to use the option to save roles with spec (assuming the option is enabled):
With either of your specs selected, choose a role in the Dungeon Finder window that you want that spec to use.
Click the Save Roles button in the Dungeon Finder window to save that role with your current talent spec. If the button is dimmed and locked, then no change has been made (either because your role was already saved or you have wiped the settings and haven't selected a role yet).
Now change to your other spec in the normal manner.
Choose a role in the Dungeon Finder window that you want that spec to use.
Click the Save Roles button in the Dungeon Finder window to save that role with your current talent spec.
That's it. Switching between specs will now preselect your saved role automatically.
What the option does not do is automate the role check window. The reason is that the role check window is meant to be just that - a check requiring you to confirm your role. People often change roles and they wouldn't be able to do this if the window was automated. Raid leaders should only be issuing a role check if they want everyone in the raid to confirm their role. For that, the raid needs to be required to select a role, otherwise the check itself is pointless. This is the way that the option has always worked.

auto set role (Leatrix Plus)

twopro — Thu, 18 Apr 2013 08:03:12 +0000

Hello, I'm having pro... (Leatrix Plus)

Leatrix — Fri, 12 Apr 2013 07:46:36 +0000

Hello, I'm having problems opening Leatrix Plus. I have no other addons installed and the frame doesn't open via the slash command or minimap. In fact, I can't even input the slash command without it stopping me.

I've also tested Leatrix Plus on the PTR with the same effect. Help!

(Thanks so much for the addon, by the way!!)

The addon works fine so it has to be another addon preventing you from using it or an invalid configuration file.

A few things to try.
Disable all other addons. If that fixes it, enable them again gradually until you find the one which blocks Leatrix Plus. I know you said you did this but it's always the first step to troubleshooting.
Quit Wow and delete the Leatrix Plus configuration files (Wow\WTF\Account\AccountName\SavedVariables\Leatrix_Plus.lua and Leatrix_Plus.lua.bak). Launch Wow again to see if that fixes it.
If both of the above fail, quit Wow and rename your WTF folder. Launch Wow again to see if that fixes it.
Please let me know how you get on.

Hello, I'm having problems opening... (Leatrix Plus)

xetsog — Fri, 12 Apr 2013 04:37:02 +0000

Public Test Realm Update (Leatrix Plus)

Leatrix — Thu, 11 Apr 2013 21:14:47 +0000

Re: Leatrix frames error (Leatrix Plus)

Leatrix — Sat, 06 Apr 2013 20:20:57 +0000

Hi, I have Leatrix frames installed and just got this error, looks like the new arena frames code isnt playing well with it, will I have to update to Leatrix plus? ( although tbh I just need frames moved)

6415x AddOn "Leatrix_Frames" tried to call the protected function "ArenaEnemyFrames:ClearAllPoints()".

Leatrix Frames migrated over to Leatrix Plus around two years ago and is no longer supported.

Leatrix Plus is up to date and it's fully modular so if you only wish to use the frames portion of it, you can do that. Just enable frame customisation (interface menu) and ignore the rest of the addon, that's fine.

If you experience any issues while using the frame customisation feature of Leatrix Plus, and you continue to experience those issues with all other addons disabled, please reply back and I will certainly look at it.

That said, there hasn't been any other reports of frame problems with Leatrix Plus in a long time and the error you pasted seems misleading. It's suggesting that Leatrix Frames tried to move the arena frames and the UI was tainted as a result, but I don't recall that Leatrix Frames ever supported moving the arena frames (unless I'm forgetting something, it was a long time ago).