WoWInterface - Comments for GreatStalin's AddOn(s)

Re: Version and new features (Peddler)

GreatStalin — Tue, 05 Mar 2013 21:52:53 +0000

Hello, is there a way to known what version of Peddler we're using ?

Beside, could it be possible to choose in which corner of the item icon the coin pile appear on selected items ? In the lower right it hides the item count (and it disturbs me). Even thought I changed it in the code (and set it to "texture:SetPoint("TOPRIGHT", -1, -1)") I think it would be nice to be able to choose, as there could be different kind of display for bags and items.

One more question: would it be possible to see the list of items we selected for sale, and to choose weather or not we want to keep or not any item in this list ? Or even, just would it be possible to simply erase the list by clicking a single button in the preferences ?

Your add-on is really nice, I like the way we can do this and the way items are marked: it is simple and clear :)
Many thanks !

Hi old chap!

Unfortunately, there's currently no way to know which version you're running besides comparing the files and checking for a lack of differences, I suppose! I've added it to the options panel now, but perhaps you'll find it too late?

You can now decide which corner of the icon the coins should be displayed in, via the options panel!

There's also a button in the options panel which wipes the current character's auto-sale items list!

Enjoy!

Version and new features (Peddler)

Awak — Thu, 28 Feb 2013 12:15:53 +0000

Hello, is there a way to known what version of Peddler we're using ?

Beside, could it be possible to choose in which corner of the item icon the coin pile appaear on selected items ? In the lower right it hides the item count (and it disturbs me). Even thought I changed it in the code (and set it to "texture:SetPoint("TOPRIGHT", -1, -1)") I think it would be nice to be able to choose, as there could be different kind of display for bags and items.

One more question: would it be possible to see the list of items we selected for sale, and to choose weather or not we want to keep or not any item in this list ? Or even, just would it be possible to simply erase the list by clicking a single button in the preferences ?

Your addon is really nice, I like the way we can do this and the way items are marked: it is simple and clear :)
Many thanks !

Hi old chap! Th... (Peddler)

laukond — Thu, 03 Jan 2013 15:48:01 +0000

Hi old chap! The new version should hopefully comply with your request - let me know how it goes, enjoy!

Thank you :-)

Could you please add... (Peddler)

GreatStalin — Thu, 03 Jan 2013 12:16:14 +0000

Could you please add an option to sell Rare and Epic items as well?
Thanks :-)

Hi old chap! The new version should hopefully comply with your request - let me know how it goes, enjoy!

Could you please add an option to s... (Peddler)

laukond — Wed, 02 Jan 2013 22:30:03 +0000

Could you please add an option to sell Rare and Epic items as well?
Thanks :-)

Not sure if you're aw... (Peddler)

GreatStalin — Mon, 19 Nov 2012 16:28:00 +0000

Not sure if you're aware of this, but any class that doesn't wear cloth gets there cloaks flagged as trash if "Unwanted Items" is checked which is kind of annoying if you have more then one equip set. Thought I'd let you know and aside from that I love Peddler. :)

Hi old chap! Ah, thanks for letting me know - should be fixed in the next version!

Not sure if you're aware of this, b... (Peddler)

Learza — Sun, 18 Nov 2012 21:44:10 +0000

... (Peddler)

GreatStalin — Sun, 11 Nov 2012 13:06:27 +0000

Hi old chaps! Thanks for your interest in my li'l' addon!

Tymesink: Mind if I implement the famBags fix into the code? I didn't want to just take it without asking your permission first!

I'll have a look at ElvUI and see what addon they're using and see if I can't add support.

Sure be my guest.. thats why I posted it here.

Thanks! :)

I see what you mean about famBags completely overriding the modifier keys, bleh. ALT-Leftclick seems to work though, I suppose I'll have to add an option in the options panel for changing between Right- & Left-click, then you'll be able to continue with that setting.

Hi old chaps! T... (Peddler)

Tymesink — Sat, 10 Nov 2012 09:25:32 +0000

Ah, my apologies! v2.9.1 should ho... (Peddler)

GreatStalin — Sat, 10 Nov 2012 06:42:38 +0000

Ah, my apologies! v2.9.1 should hopefully fix the issue, sorry for the inconvenience!

Re: Error (Peddler)

VincentSDSH — Sat, 10 Nov 2012 03:50:46 +0000

Message: Interface\AddOns\Peddler\Peddler.lua:45: attempt to compare nil with number

1x Peddler\Peddler.lua:76: attempt to compare number with nil
Peddler\Peddler.lua:76: in function
Peddler\Peddler.lua:349: in function

Locals:
self = {
0 =
}
event = "MERCHANT_SHOW"
addonName = nil
peddler = {
0 =
}
countLimit = 5
onUpdate = @..\Peddler.lua:304
Baggins = nil
handleBagginsOpened = @..\Peddler.lua:314
markCounter = 0
peddleGoods = @..\Peddler.lua:58

Error (Peddler)

reale411 — Sat, 10 Nov 2012 02:28:36 +0000

Message: Interface\AddOns\Peddler\Peddler.lua:45: attempt to compare nil with number

Hi old chaps! Thanks for your inte... (Peddler)

GreatStalin — Fri, 09 Nov 2012 18:55:29 +0000

Hi old chaps! Thanks for your interest in my li'l' addon!

As per your suggestions, I've added toggles in the Options panel to allow automatic marking of Grey, White & Green items. As was the usual with Grey items before, you can use the modifier key & right-click to un-mark an item, and the addon will never again attempt to sell that item. Let me know what you make of it!

Tymesink: Mind if I implement the famBags fix into the code? I didn't want to just take it without asking your permission first!

I'll have a look at ElvUI and see what addon they're using and see if I can't add support.

dose this also have auto grey selli... (Peddler)

Jynks — Tue, 06 Nov 2012 19:53:24 +0000

dose this also have auto grey selling and an option for auto white selling?

probably has to do with the fact th... (Peddler)

Tymesink — Mon, 05 Nov 2012 07:58:58 +0000

probably has to do with the fact that ElvUI like all the other custom bag addons custom name their frames within bagUI so this addon has to be programmed to be a where of ElvUI frames to hook into it.

Any reason why this doesn't work wi... (Peddler)

kaiden — Mon, 05 Nov 2012 00:53:07 +0000

Any reason why this doesn't work with ElvUI? It sells the items, but it doesn't actually flag the items with icons for the sale.

hey love the addon.. great idea. I... (Peddler)

Tymesink — Wed, 31 Oct 2012 04:45:42 +0000

hey love the addon.. great idea. I really like the idea of flagging items that I want to sell to the vendor. If I can make a request, please allow selling junk/grey items to be optional to allow the user to use this addon but not compete for the same feature that is in other addons such as ElvUI.

I'm also using famBags... I added the following code:
local function markfamBagsBags()
for bagNumber = 0, 4 do
local bagsSlotCount = GetContainerNumSlots(bagNumber)
for slotNumber = 1, bagsSlotCount do
local itemButton = _G
checkItem(bagNumber, slotNumber, itemButton)
end
end
end

It does the job, but I have problem with the fact that all the modifiers for right-click are being used with the famBags addon. I can temporarily use shift+right click but that also triggers a "split" dialog. Any suggestions would be greatly appreciated.

Thanks!

Re: Re: Peddler and CargBags (Peddler)

biznachio — Sat, 20 Oct 2012 22:17:59 +0000

Works wonderfully, thanks so much for the support.

jeruku: Thanks for the advice! I'll see if I can't get this into my code sometime in a future update, when I have the time! :)

I stumbled upon Peddler today and already find it an indispensable tool for my grinding and profession workflow. I have but one question. I use SkaarjUI as I love its functionality and flow. Skaarj uses CargBags (which is listed as an outdated mod here on WoWInterface) and the only thing missing is the coin stack icon on items I set to be sold. Is there currently support in Peddler for CargBags? Thanks for answering back!

The support for cargBags_Nivaya should now be in and working - let me know how it goes!

Re: Peddler and CargBags (Peddler)

GreatStalin — Thu, 18 Oct 2012 04:32:30 +0000

jeruku: Thanks for the advice! I'll see if I can't get this into my code sometime in a future update, when I have the time! :)

I stumbled upon Peddler today and already find it an indispensable tool for my grinding and profession workflow. I have but one question. I use SkaarjUI as I love its functionality and flow. Skaarj uses CargBags (which is listed as an outdated mod here on WoWInterface) and the only thing missing is the coin stack icon on items I set to be sold. Is there currently support in Peddler for CargBags? Thanks for answering back!

The support for cargBags_Nivaya should now be in and working - let me know how it goes!

Peddler and CargBags (Peddler)

biznachio — Tue, 16 Oct 2012 22:55:18 +0000

I stumbled upon Peddler today and already find it an indispensable tool for my grinding and profession workflow. I have but one question. I use SkaarjUI as I love its functionality and flow. Skaarj uses CargBags (which is listed as an outdated mod here on WoWInterface) and the only thing missing is the coin stack icon on items I set to be sold. Is there currently support in Peddler for CargBags? Thanks for answering back!