WoWInterface - Comments for myno's AddOn(s)

lol, i made this cha... (oUF Drk Fanupdate)

myno — Sun, 19 May 2013 16:53:24 +0000

lol, i made this change every update, but forgotten it this time, same thing with group 6,7,8. last update was long ago^^

Edit: Is it possible to add an easyer way to add costombuffs/indicators to the raidframe? Always have to add so much code in two files^^

You could also create your own tags in cfg.lua, then you would only need to edit one file or don't replace the cfg.lua file if there are no changes in it. :p

Just include the following line in cfg.lua:
local tags = oUF.Tags

Then just have the tags in in the cfg.lua file as you would have them in the tags.lua file.

cant see... (oUF Drk Fanupdate)

McBloed — Sun, 19 May 2013 15:22:23 +0000

cant see the Lead, Assist and Masterlooter icons at raidframe

That's how it's supposed to be. Delete Line 361 and 374 in lib.lua to get them.

lol, i made this change every update, but forgotten it this time, same thing with group 6,7,8. last update was long ago^^

Edit: Is it possible to add an easyer way to add costombuffs/indicators to the raidframe? Always have to add so much code in two files^^

cant see the Lead, A... (oUF Drk Fanupdate)

myno — Sun, 19 May 2013 14:50:44 +0000

cant see the Lead, Assist and Masterlooter icons at raidframe

That's how it's supposed to be. Delete Line 361 and 374 in lib.lua to get them.

cant see the Lead, Assist and Maste... (oUF Drk Fanupdate)

McBloed — Sun, 19 May 2013 14:18:27 +0000

cant see the Lead, Assist and Masterlooter icons at raidframe

Re: Re: Re: Re: Mage & castbar lua error (oUF Drk Fanupdate)

Helln_HiHeels — Tue, 02 Apr 2013 02:37:26 +0000

I just commited some small changes to castbar.lua on github. Hope this did the job.

It did indeed !! Thank you ! :)

Re: Re: Re: Mage & castbar lua error (oUF Drk Fanupdate)

myno — Thu, 28 Mar 2013 03:34:57 +0000

I just commited some small changes to castbar.lua on github. Hope this did the job.

Re: Re: Re: Mage & castbar lua error (oUF Drk Fanupdate)

myno — Thu, 28 Mar 2013 02:58:45 +0000

I commited a small change to the castbar.lua on github. However, I don't know if this fixes the bug since I have not seen it in a long time.

Re: Re: Mage & castbar lua error (oUF Drk Fanupdate)

Helln_HiHeels — Thu, 28 Mar 2013 02:09:32 +0000

I have recently been doing some dailies on my rather unforgotten mage and I get this lua error (which I hope has a very easy solution). I also play a shadowpriest but don't see this error message at all. I use the most up-to-date from your Gib site and the only changes I make are from vertical to horizontal for raid/group frames (but that poses no problem on my shadowpriest) and I've use ./omf to move the layout pieces.

Do you remember what you were doing, when the error occured? Did it happen while you were in a vehicle?

I was in Valley of Four Winds (or whatever it's called), plowed my plots and was just starting to plant.. cast to freeze the little vermin guy in place and that's about when the error showed up. Whether I was about to cast a frost bolt or had just completed one I can't be sure but it was pretty much right at that point. So no vehicle but I was in that phased area where our farming plots are.

Re: Mage & castbar lua error (oUF Drk Fanupdate)

myno — Thu, 28 Mar 2013 01:13:49 +0000

Mage & castbar lua error (oUF Drk Fanupdate)

Helln_HiHeels — Tue, 26 Mar 2013 15:37:53 +0000

I have recently been doing some dailies on my rather unforgotten mage and I get this lua error (which I hope has a very easy solution). I also play a shadowpriest but don't see this error message at all. I use the most up-to-date from your Gib site and the only changes I make are from vertical to horizontal for raid/group frames (but that poses no problem on my shadowpriest) and I've use ./omf to move the layout pieces.

Date: 2013-03-26 11:15:00
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\oUF_Drk\castbar.lua line 102:
attempt to index local 'sf' (a nil value)
Debug:
: ?
oUF_Drk\castbar.lua:102: PostCastStart()
oUF\elements\castbar.lua:149: ?()
oUF\events.lua:69:
oUF\events.lua:62
Locals:

**note: there was nothing posted to "Locals" and if needed I can provide a list of addons that are used.
Thank you for keeping this great layout alive !!

Fantastic thanks for the fast respo... (oUF Drk Fanupdate)

Dartrianis — Sun, 10 Mar 2013 04:01:26 +0000

Fantastic thanks for the fast response, i have tested the new code and it is working perfectly. :banana:

I am having 1 sma... (oUF Drk Fanupdate)

myno — Sat, 09 Mar 2013 12:30:27 +0000

I am having 1 small issue with 5.2, Blizz got rid of the glyph of Soul that gave affliction locks a 4th shard and cooked the 4th shard into the spec.

Try the following code (in github) instead of the one you posted :

elseif spec == SPEC_WARLOCK_AFFLICTION then
local maxshards = 4

for i = 1, maxshards do
wsb:Show()
wsb:SetWidth(w / maxshards - spacing)
end

I don't have a warlock myself, so sadly I can't test it.

Hi and thank you for taking this gr... (oUF Drk Fanupdate)

Dartrianis — Sat, 09 Mar 2013 03:44:37 +0000

Hi and thank you for taking this great layout over. i am having 1 small issue with 5.2, Blizz got rid of the glyph of Soul that gave affliction locks a 4th shard and cooked the 4th shard into the spec.

it would seem that the oUF_WarlockSpecBars.lua is still setup to look for the glyph before making the 4th shard show.

elseif spec == SPEC_WARLOCK_AFFLICTION then
local maxshards = 3

for i = 1, GetNumGlyphSockets() do
local glyphID = select(4, GetGlyphSocketInfo(i))
if glyphID == SPEC_WARLOCK_AFFLICTION_GLYPH_SHARDS then maxshards = 4 end
end

for i = 1, maxshards do
if i ~= maxshards then
wsb:Show()
wsb:SetWidth(w / maxshards - spacing)
s = s + (w / maxshards)
else
wsb:SetWidth(w - s)
end
end

if maxshards == 3 then wsb:Hide() else wsb:Show() end

I think i have located the correct place but i have no clue what to change it to so that 4 shards show up for Affliction.

Would you someone know?
Thanks

I really can't say bu... (oUF Drk Fanupdate)

myno — Thu, 20 Dec 2012 00:18:23 +0000

I really can't say but it was the same with a fresh install. COuld you tell me the changes I need to make to the code for the tooltip to work? I don't want to install a fresh copy and have to redo all the changes.

Delete this in core.lua: https://github.com/xmyno/oUF_Drk/commit/64833af69d531dd1a8f2783b1085824d873b032b#L1L275 (Line 275-286)
and add these two in lib.lua: https://github.com/xmyno/oUF_Drk/commit/64833af69d531dd1a8f2783b1085824d873b032b#L2R1436 (Line 1436-1439 and 1447-1449)

1. Toolt... (oUF Drk Fanupdate)

Laorne — Wed, 19 Dec 2012 23:07:52 +0000

1. Tooltip issue seems to be resolved. However when I change cfg.ShowRoleIcons = false to true the tooltips stop working again. Turning them back off tooltips work again so there seems to be a conflict somewhere and likely why I couldn't get them working in the previous setup since I didn't think to turn that option off. I assume it has something to do with this code??

2. Raid orientation is still the same. Vertical = frames grow up, Horizontal = frames grow left.
I dont' use horizontal but I assume they should grow right not left

Update** I think I have fixed this with the following code changes:

The default was TOP. I changed it to BOTTOM

Tooltip issue is fixed in the new github version of core.lua and lib.lua. However I still can't see any reason why raid frame orientation shouldn't be working for you. Changing TOP to BOTTOM is just creating the next frame on top of the previous frame and then you move it down by 80px. TOP in this case means that the next frame is anchored with it's top to the previous frame, not that it's created above the previous one.

I really can't say but it was the same with a fresh install. COuld you tell me the changes I need to make to the code for the tooltip to work? I don't want to install a fresh copy and have to redo all the changes.

1. Tooltip issue see... (oUF Drk Fanupdate)

myno — Wed, 19 Dec 2012 13:59:51 +0000

So i installed a fresh copy of OUF... (oUF Drk Fanupdate)

Laorne — Tue, 18 Dec 2012 20:49:13 +0000

So i installed a fresh copy of OUF and OUF_Drk. I could not find anything in my WTF files for either addon since both seem to be configured directly in the addon. If that is not the case and I missed something else to delete please let me know.

1. Tooltip issue seems to be resolved. However when I change cfg.ShowRoleIcons = false to true the tooltips stop working again. Turning them back off tooltips work again so there seems to be a conflict somewhere and likely why I couldn't get them working in the previous setup since I didn't think to turn that option off. I assume it has something to do with this code??

if cfg.ShowRoleIcons or not cfg.ShowTooltips then
self:SetScript("OnEnter",function()
if not cfg.ShowTooltips then GameTooltip:Hide() end
if cfg.ShowRoleIcons then self.LFDRole:SetAlpha(1) end
end)
end
if cfg.ShowRoleIcons then
self:SetScript("OnLeave",function()
self.LFDRole:SetAlpha(0)
end)
end
2. Raid orientation is still the same. Vertical = frames grow up, Horizontal = frames grow left.
I dont' use horizontal but I assume they should grow right not left

Update** I think I have fixed this with the following code changes:

The default was TOP. I changed it to BOTTOM
if cfg.raidOrientationHorizontal then
point = "LEFT"
else
point = "BOTTOM"
end
I also had to change YOffset from -5 to -80. In addition for the frame height I had to change the self:SetHeight(38) in addition to your suggestion as the power bar would then not show

for i = 1, 5 do
local header = oUF:SpawnHeader(
"drkGroup"..i,
nil,
soloraid,
"showRaid", true,
"point", point,
"startingIndex",1,
"yOffset", -80,
"xoffset", 4,
"columnSpacing", 7,
"groupFilter", tostring(i),
"groupBy", "GROUP",
"groupingOrder", "1,2,3,4,5",
"sortMethod", "NAME",
"columnAnchorPoint", "RIGHT",
"maxColumns", 5,
"unitsPerColumn", 5,
"oUF-initialConfigFunction", self:SetHeight(38)
self:SetWidth(77)
]]
)

Everything else you suggested seems to be working now with the exception of the tooltips when RoleIcons is turned on.

1. I am still unable... (oUF Drk Fanupdate)

myno — Tue, 18 Dec 2012 19:33:54 +0000

1. I am still unable to get tooltips working. I made the change but still no go. I had made no alterations to the code other than changing from false to true so is there possibly something missing elsewhere? **Note** I disabled my tooltip addon to ensure nothing was interferring but it still did not work.
2. The change for the leader/master/assist icons seemed to break the package. I removed the requested. This is not a big deal so if it doesn't work I'm not to worried.
3. Based on the original position of the frames I assumed so as well until I joined a group and they went up rather than down. i compared the following code to the site and it appears the same but perhaps I missed something. If you could peak I would appreciate it.

Also with regards to this same code. I tried to adjust the frame height which it did adjust but the actual health bar did not reflect this and there was just dead space where i increased the height. Ideas??

4. Perhaps I missworded my original request with regards to the frame color. I just wanted the color to be lighter. Perhaps a lighter shade of gray. I adjusted the Alpha but it did not seem to make any difference.

1. Have you tried it with a fresh download? It's working fine for me.

2. Delete the two orange lines, I checked the position and it's fine.
lib.lua Line 391if f.mystyle ~= 'raid' then
--Leader icon
li = h:CreateTexture(nil, "OVERLAY")
li:SetPoint("TOPLEFT", f, 0, 8)
li:SetSize(12,12)
f.Leader = li
--Assist icon
ai = h:CreateTexture(nil, "OVERLAY")
ai:SetPoint("TOPLEFT", f, 0, 8)
ai:SetSize(12,12)
f.Assistant = ai
--ML icon
local ml = h:CreateTexture(nil, 'OVERLAY')
ml:SetSize(10,10)
ml:SetPoint('LEFT', f.Leader, 'RIGHT')
f.MasterLooter = ml
end

3. Same as number 1. I can't see where the problem is. Try if it's still the same with a fresh download.

3a. Height of the health frame is in lib.lua Line 104:

s:SetHeight(retVal(f,f:GetHeight()*.68,f:GetHeight()*.76,29))

The orange value is the height of the health bar for the raid frames.

4. Color of the background is in lib.lua Line 132. I need to clean up the code :p

1. I am still unable to get toolti... (oUF Drk Fanupdate)

Laorne — Mon, 17 Dec 2012 18:23:50 +0000

1. I am still unable to get tooltips working. I made the change but still no go. I had made no alterations to the code other than changing from false to true so is there possibly something missing elsewhere? **Note** I disabled my tooltip addon to ensure nothing was interferring but it still did not work.
2. The change for the leader/master/assist icons seemed to break the package. I removed the requested. This is not a big deal so if it doesn't work I'm not to worried.
3. Based on the original position of the frames I assumed so as well until I joined a group and they went up rather than down. i compared the following code to the site and it appears the same but perhaps I missed something. If you could peak I would appreciate it.

Also with regards to this same code. I tried to adjust the frame height which it did adjust but the actual health bar did not reflect this and there was just dead space where i increased the height. Ideas??

-- Raid Frames
if cfg.ShowRaid then
local soloraid,point
if cfg.RaidShowSolo then
soloraid = "custom show;"
else
soloraid = "party,raid"
end
if cfg.raidOrientationHorizontal then
point = "LEFT"
else
point = "TOP"
end

self:SetActiveStyle('drkGroup')
local raid = {}
for i = 1, 5 do
local header = oUF:SpawnHeader(
"drkGroup"..i,
nil,
soloraid,
"showRaid", true,
"point", point,
"startingIndex",1,
"yOffset", -5,
"xoffset", 4,
"columnSpacing", 7,
"groupFilter", tostring(i),
"groupBy", "GROUP",
"groupingOrder", "1,2,3,4,5",
"sortMethod", "NAME",
"columnAnchorPoint", "RIGHT",
"maxColumns", 5,
"unitsPerColumn", 5,
"oUF-initialConfigFunction", ]
)

if i == 1 then
header:SetAttribute("showSolo", true)
header:SetAttribute("showPlayer", true)
header:SetAttribute("showParty", true)
header:SetPoint("TOPLEFT",UIParent,"BOTTOMRIGHT",cfg.raidX,cfg.raidY)
else
if cfg.raidOrientationHorizontal then
header:SetPoint("TOPLEFT",raid,"BOTTOMLEFT",0,-4)
else
header:SetPoint("TOPLEFT",raid,"TOPRIGHT",4,0)
end
end
header:SetScale(cfg.raidScale)
raid = header
end
end

4. Perhaps I missworded my original request with regards to the frame color. I just wanted the color to be lighter. Perhaps a lighter shade of gray. I adjusted the Alpha but it did not seem to make any difference.

Thanks again.

cfg.ShowToolTips =... (oUF Drk Fanupdate)

myno — Mon, 17 Dec 2012 16:41:27 +0000

cfg.ShowToolTips = true -- Show Tooltips on raid frames

The option has to be called cfg.ShowTooltips with a lower-case t.

There are a few other things i'd like to see just not sure if it's possible on this edit.

1. Show leader/assist/master loot icons on raid frames - I see the options in the config files just not sure how to add to the raid frames.
2. Show AFK timer on target frame. It currently shows AFK but i'd like to see the timer if possible
3. Is there a way to change the direction the raid groups grow. For vertical they grow up and I would prefer if the direction was down. I looked in the settings but just could not seem to find how to do this.
4. Is there a way to change the raid frame background color when health is missing. I tried editing the following but the only option that seems to do anything is the self.range settings. I tried changing self.Health.bg.multiplier = 0.3 but it doesn't seem to have any effect.

1. You can add them by editing the code at Line 391 and below in lib.lua. (https://github.com/xmyno/oUF_Drk/blob/master/lib.lua#L391)
Either remove the if f.mystyle ~= raid and the end in Line 407, but of the top of my head I don't know if the icons would fit for the raid frames so you might have to recreate them in an else-block (after Line 406).
2. This would require extra code to save the time when the player has gone afk. It's possible, but I currently do not have the time to try it out.
3. They should already be growing downwards. Check with the code of core.lua in the github if you have differences.
4. What color do you want? Can't really help you without knowing that.

Hope some if this helps.
Myno