WoWInterface - Comments for SuranthianH3's AddOn(s)

for it to work properly in 4... (Broker_H3DungeonCooldowns)

Bargan — Sun, 04 Dec 2011 09:57:33 +0000

for it to work properly in 4.3, you need to change the Broker_H3DungeonCooldowns.lua file.

Inside you will find GetLFGQueueStats in 4 places. Replace each of those lines with the following

hasData, leaderNeeds, tankNeeds, healerNeeds, dpsNeeds, totalTanks, totalHealers, totalDPS, instanceType, instanceSubType, instanceName, averageWait, tankWait, healerWait, damageWait, myWait, queuedTime = GetLFGQueueStats()

Thanks for that, is working fine now.:D

still no 4.x update?[/q... (Broker_H3DungeonCooldowns)

Shamino — Sun, 04 Dec 2011 02:36:00 +0000

still no 4.x update?

for it to work properly in 4.3, you need to change the Broker_H3DungeonCooldowns.lua file.

Inside you will find GetLFGQueueStats in 4 places. Replace each of those lines with the following

hasData, leaderNeeds, tankNeeds, healerNeeds, dpsNeeds, totalTanks, totalHealers, totalDPS, instanceType, instanceSubType, instanceName, averageWait, tankWait, healerWait, damageWait, myWait, queuedTime = GetLFGQueueStats()

still no 4.x update? (Broker_H3DungeonCooldowns)

Wall — Thu, 18 Nov 2010 15:06:44 +0000

still no 4.x update?

Great Addon, simple and exactly wha... (Broker_H3Nametoggle)

kin — Wed, 11 Aug 2010 16:20:50 +0000

Great Addon, simple and exactly what I need.

After I installed it, it worked fine on the first char I logged in, for hours. After I changed my char I get a lua error and the addon doesn't work on any of my chars anymore. I didn't delete or change anything, but it seems that something is missing (but why had it worked on the beginning?). The lua error even doesn't appear every time, it seems to pop up completely random. Hope you can help to fix it, I have no idea of lua. :eek: (I'm using Docking Station if it's relevant)

Message: ...ns\Broker_H3Nametoggle\Lib\Tablet-2.0\Tablet-2.0.lua:16: Tablet-2.0 requires AceLibrary
Time: 08/11/10 18:15:09
Count: 1
Stack: : in function `error'
...ns\Broker_H3Nametoggle\Lib\Tablet-2.0\Tablet-2.0.lua:16: in main chunk

Locals: (*temporary) = "Tablet-2.0 requires AceLibrary"

sry for my english :o

Disappearing Dropdown Menu (Broker_H3Currency)

loctrinh01 — Wed, 11 Aug 2010 02:12:18 +0000

When I hover my mouse over H3 Currency in Titan Panel, I can see the drop down of all the currency I have. But the menu would disappear after a few seconds.

Yep swapped to Choc and it works s... (Broker_H3DungeonCooldowns)

Balsta — Mon, 09 Aug 2010 00:11:21 +0000

Yep swapped to Choc and it works so there is a ninjapanel issue somewhere.

Originally posted by Bals... (Broker_H3DungeonCooldowns)

ffcloud2000 — Sun, 08 Aug 2010 21:01:49 +0000

Originally posted by Balsta
For some reason I dont get a tooltip at all with this. The tooltip just says "LDBplugin". I use ninjapanel for a display. Any ideas?

I actually had the same issue and had to switch to Chocolate Bar in order for it to show up properly :(

For some reason I dont get a toolti... (Broker_H3DungeonCooldowns)

Balsta — Sun, 08 Aug 2010 20:42:29 +0000

For some reason I dont get a tooltip at all with this. The tooltip just says "LDBplugin". I use ninjapanel for a display. Any ideas?

Originally posted by zaph... (Broker_H3DungeonCooldowns)

SuranthianH3 — Tue, 03 Aug 2010 09:12:37 +0000

Originally posted by zaphon
Well it wasn't working for me right either, but I did fix it. Couple things I did.

1. I got rid of the redundant calls to GetLFGRandomCooldownExpiration() and GetLFGDeserterExpiration()

2. I changed the time display to show the time until it resets, versus the time at which it resets (which didn't work anyway, it showed 23 days).

Here's the diff

***************
*** 1376,1393 ****

hasData, leaderNeeds, tankNeeds, healerNeeds, dpsNeeds, instanceType, instanceName, averageWait, tankWait, healerWait, damageWait, myWait, queuedTime = GetLFGQueueStats()
-- Dungeon Cooldown info (At request of ffcloud2000) --
! if (GetLFGRandomCooldownExpiration()) or (GetLFGDeserterExpiration()) then
tooltip:AddSeparator(db.separatorSize, db.separatorCol, db.separatorCol, db.separatorCol)
-- Time until you can queue for a random again --
! if GetLFGRandomCooldownExpiration() then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Random Queue - " .. SecondsToTime(GetLFGRandomCooldownExpiration()), headerFont, "CENTER", tooltip:GetColumnCount())
end

-- Time until you can queue again after leaving a group prematurely --
! if GetLFGDeserterExpiration() then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Dungeon Deserter - " .. SecondsToTime(GetLFGDeserterExpiration()), headerFont, "CENTER", tooltip:GetColumnCount())
end

if GetLFGProposal() or hasData then return end
--- 1376,1394 ----

hasData, leaderNeeds, tankNeeds, healerNeeds, dpsNeeds, instanceType, instanceName, averageWait, tankWait, healerWait, damageWait, myWait, queuedTime = GetLFGQueueStats()
-- Dungeon Cooldown info (At request of ffcloud2000) --
! local random, deserter, now = GetLFGRandomCooldownExpiration(), GetLFGDeserterExpiration(), GetTime()
! if ((random) or (deserter)) then
tooltip:AddSeparator(db.separatorSize, db.separatorCol, db.separatorCol, db.separatorCol)
-- Time until you can queue for a random again --
! if random then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Random Queue - " .. SecondsToTime(random-now), headerFont, "CENTER", tooltip:GetColumnCount())
end

-- Time until you can queue again after leaving a group prematurely --
! if deserter then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Dungeon Deserter - " .. SecondsToTime(deserter-now), headerFont, "CENTER", tooltip:GetColumnCount())
end

if GetLFGProposal() or hasData then return end

NOTE: You will see the number show up when you zone into a random, if you mouse over it, as you have the random cooldown until either 15 minutes pass or the instance is completed.

Ok, thanks for the help, never worked with that function before.. I'm out of town right now but I'll do a quick upload of that fix right now.

when i select my role and it starts... (Broker_H3DungeonCooldowns)

spAnser — Wed, 28 Jul 2010 07:52:07 +0000

when i select my role and it starts turning some of the letters green to show me what it has found its not showing myself as green

btw i have been choosing tank as my role havent tried it as anything else just yet

Originally posted by Sura... (Broker_H3DungeonCooldowns)

zaphon — Tue, 27 Jul 2010 16:22:51 +0000

Originally posted by SuranthianH3
It SHOULD show up at the top of the tooltip, but only when you are a deserter. The code isn't the problem:
-- Time until you can queue again after leaving a group prematurely --
if GetLFGDeserterExpiration() then
placeHolder = tooltip:AddLine(" ")
tooltip:SetCell(placeHolder, 1, "Dungeon Deserter - " .. SecondsToTime(GetLFGDeserterExpiration()), headerFont, "CENTER", tooltip:GetColumnCount())
end

So if it isn't working, then the bug where it doesn't show in the dungeon browser isn't a UI bug, it's the function itself working improperly.

tl;dr - Nothing I can do about it.

Well it wasn't working for me right either, but I did fix it. Couple things I did.

1. I got rid of the redundant calls to GetLFGRandomCooldownExpiration() and GetLFGDeserterExpiration()

2. I changed the time display to show the time until it resets, versus the time at which it resets (which didn't work anyway, it showed 23 days).

Here's the diff

***************
*** 1376,1393 ****

hasData, leaderNeeds, tankNeeds, healerNeeds, dpsNeeds, instanceType, instanceName, averageWait, tankWait, healerWait, damageWait, myWait, queuedTime = GetLFGQueueStats()
-- Dungeon Cooldown info (At request of ffcloud2000) --
! if (GetLFGRandomCooldownExpiration()) or (GetLFGDeserterExpiration()) then
tooltip:AddSeparator(db.separatorSize, db.separatorCol, db.separatorCol, db.separatorCol)
-- Time until you can queue for a random again --
! if GetLFGRandomCooldownExpiration() then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Random Queue - " .. SecondsToTime(GetLFGRandomCooldownExpiration()), headerFont, "CENTER", tooltip:GetColumnCount())
end

-- Time until you can queue again after leaving a group prematurely --
! if GetLFGDeserterExpiration() then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Dungeon Deserter - " .. SecondsToTime(GetLFGDeserterExpiration()), headerFont, "CENTER", tooltip:GetColumnCount())
end

if GetLFGProposal() or hasData then return end
--- 1376,1394 ----

hasData, leaderNeeds, tankNeeds, healerNeeds, dpsNeeds, instanceType, instanceName, averageWait, tankWait, healerWait, damageWait, myWait, queuedTime = GetLFGQueueStats()
-- Dungeon Cooldown info (At request of ffcloud2000) --
! local random, deserter, now = GetLFGRandomCooldownExpiration(), GetLFGDeserterExpiration(), GetTime()
! if ((random) or (deserter)) then
tooltip:AddSeparator(db.separatorSize, db.separatorCol, db.separatorCol, db.separatorCol)
-- Time until you can queue for a random again --
! if random then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Random Queue - " .. SecondsToTime(random-now), headerFont, "CENTER", tooltip:GetColumnCount())
end

-- Time until you can queue again after leaving a group prematurely --
! if deserter then
placeHolder = tooltip:AddLine(" ")
! tooltip:SetCell(placeHolder, 1, "Dungeon Deserter - " .. SecondsToTime(deserter-now), headerFont, "CENTER", tooltip:GetColumnCount())
end

if GetLFGProposal() or hasData then return end

NOTE: You will see the number show up when you zone into a random, if you mouse over it, as you have the random cooldown until either 15 minutes pass or the instance is completed.

Originally posted by caco... (Broker_H3DungeonCooldowns)

SuranthianH3 — Mon, 19 Jul 2010 09:16:09 +0000

Originally posted by cacomixl8
Two problems I'm having...

1. If you're the last person out of the dungeon, there is no option to teleport out of dungeon. I've had to reenable the minimap icon to be able to get out.

2. Sometimes it does not track the cooldown for the dungeon. I run heroics on 5 characters a day, and just about every day one cooldown is missing in the broker list.

Thanks for the great addon!
1. Not very good with figuring out when you can't teleport in and out of the dungeon, right now it goes off of role, which you can't do if you don't have a role (last one in the instance/everyone else left the group).. Anyone know of a specific variable or function to figure it out? This is why I didn't want to add it, there would be bugs like this :P

2. If you are checking the tooltip RIGHT AFTER the lock, that's probably why, rollover it once to allow it to update the data then rollover again (also, it takes a while for even the official raidlock window to update sometimes). It tries to update every minute or so on a toon, so I don't see why it would be missing. Is anyone else getting this bug of a couple instances flat out not showing? If so maybe a screenshot of the tooltip and one of the raidinfo window? The only reason I could think would be some expansion content being disabled or your client being something other than enUS

Thanks for the feedback. I'll try to update at least once a month, but I haven't been playing much WoW lately.

Two problems I'm having...1. If... (Broker_H3DungeonCooldowns)

cacomixl8 — Mon, 19 Jul 2010 01:58:51 +0000

Two problems I'm having...

1. If you're the last person out of the dungeon, there is no option to teleport out of dungeon. I've had to reenable the minimap icon to be able to get out.

2. Sometimes it does not track the cooldown for the dungeon. I run heroics on 5 characters a day, and just about every day one cooldown is missing in the broker list.

Thanks for the great addon!

Originally posted by Nevy... (Broker_H3DungeonCooldowns)

SuranthianH3 — Wed, 14 Jul 2010 23:25:00 +0000

Originally posted by Nevyr28
Where is the deserter cooldown supposed to show up? I'm using r016 with Bazooka and it's not showing up in the tooltip or the LDB itself.

It SHOULD show up at the top of the tooltip, but only when you are a deserter. The code isn't the problem:
-- Time until you can queue again after leaving a group prematurely --
if GetLFGDeserterExpiration() then
placeHolder = tooltip:AddLine(" ")
tooltip:SetCell(placeHolder, 1, "Dungeon Deserter - " .. SecondsToTime(GetLFGDeserterExpiration()), headerFont, "CENTER", tooltip:GetColumnCount())
end

So if it isn't working, then the bug where it doesn't show in the dungeon browser isn't a UI bug, it's the function itself working improperly.

tl;dr - Nothing I can do about it.

Where is the deserter cooldown supp... (Broker_H3DungeonCooldowns)

Nevyr28 — Wed, 14 Jul 2010 21:57:08 +0000

Where is the deserter cooldown supposed to show up? I'm using r016 with Bazooka and it's not showing up in the tooltip or the LDB itself.

Attempt to compare number with nil: Minor function usage typo (Broker_H3DungeonCooldowns)

SuranthianH3 — Wed, 14 Jul 2010 20:02:13 +0000

Sorry 'bout that. Will fix it right away.

The issue was me thinking GetLFGRandomCooldownExpiration() and GetLFGDeserterExpiration() were returning 0 if they didn't exist for some reason. But they returned nil. Did a real quick fix and uploaded it. Sorry for the inconvenience.

There is no popup when moving over... (Broker_H3DungeonCooldowns)

ts7348 — Wed, 14 Jul 2010 20:00:00 +0000

There is no popup when moving over the LBD button, but also no error in BugSack (I'm using DockingStation)

Confirm new error (Broker_H3DungeonCooldowns)

Xylan Trueheart — Wed, 14 Jul 2010 19:26:53 +0000

Mousing over the LBD icon revelas the error below. As seen by BugGrabber, English American client

3x ...ker_H3DungeonCooldowns\Broker_H3DungeonCooldowns.lua:1379: attempt to compare number with nil:
ChocolateBar-v2.0.2\Chocolate.lua:207: in function

Locals:
self = ChocolateBroker_H3DungeonCooldowns {
0 =
text = {}
Update = @ ChocolateBar\Chocolate.lua:253:
settings = {}
tooltip = {}
obj =

{}
name = "Broker_H3DungeonCooldowns"
icon = {}
bar = ChocolateBar1 {}
}
obj =

{
}
name = "Broker_H3DungeonCooldowns"
db =

{
strata = "DIALOG"
combathidetip = false
scale = 1
iconSize = 0.7
background =

{}
hideonleave = false
fontPath = "Fonts\FRIZQT__.TTF"
objSettings =

{}
gap = 7
barSettings =

{}
moreBar = "none"
combatdisbar = false
moreBarDelay = 4
fontSize = 8
height = 16
moveFrames = true
fontName = "Friz Quadrata TT"
combathidebar = false
}
ChocolateBar =

{
OnEnterWorld = @ ChocolateBar\Core.lua:243:
SetDefaultModuleLibraries = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:381:
TempDisAutohide = @ ChocolateBar\Core.lua:347:
Enable = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:313:
RegisterChatCommand = @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:85:
EnableModule = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:346:
modules =

{}
GetModule = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:230:
IterateEmbeds = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:456:
NewModule = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:255:
defaultModuleLibraries =

{}
OnInitialize = @ ChocolateBar\Core.lua:120:
baseName = "ChocolateBar"
UnregisterChatCommand = @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:111:
UpdateDB = @ ChocolateBar\Core.lua:510:
Disable = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:328:
AnchorBars = @ ChocolateBar\Core.lua:433:
Printf = @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:69:
OnLeaveCombat = @ ChocolateBar\Core.lua:258:
GetName = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:298:
DisableDataObject = @ ChocolateBar\Core.lua:326:
AddBar = @ ChocolateBar\Core.lua:408:
UpdateChoclates = @ ChocolateBar\Core.lua:399:
name = "ChocolateBar"
UpdateBars = @ ChocolateBar\Core.lua:425:
IsEnabled = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:465:
LibDataBroker_DataObjectCreated = @ ChocolateBar\Core.lua:272:
GetBars = @ ChocolateBar\Core.lua:371:
DisableModule = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:364:
GetChocolate = @ ChocolateBar\Core.lua:363:
GetBar = @ ChocolateBar\Core.lua:367:
UnregisterMessage = @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:181:
EnableDataObject = @ ChocolateBar\Core.lua:285:
RegisterMessage = @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:118:
GetArgs = @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:144:
Print = @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:54:
SetBars = @ ChocolateBar\Core.lua:375:
OnEnterCombat = @ ChocolateBar\Core.lua:248:
OnDisable = @ ChocolateBar\Core.lua:232:
OnEnable = @ ChocolateBar\Core.lua:219:
IsModule = @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:482:
d
---

Error in this latest version when m... (Broker_H3DungeonCooldowns)

thelurkerbelow — Wed, 14 Jul 2010 19:16:02 +0000

Error in this latest version when mousing over the LDB object:

...ker_H3DungeonCooldowns\Broker_H3DungeonCooldowns.lua:1379: attempt to compare number with nil
Time: 07/14/10 15:15:03
Count: 5
Stack: ...ker_H3DungeonCooldowns\Broker_H3DungeonCooldowns.lua:1379: in function `OnEnter'
Interface\AddOns\Fortress\Core.lua:239: in function

Re: Re: Re: Re: Re: Feature Request (Broker_H3DungeonCooldowns)

SuranthianH3 — Wed, 14 Jul 2010 17:56:09 +0000

Originally posted by ffcloud2000
It's been bugged since 3.3.3 where it doesn't display it sometimes.... i was thinking only show the cd timer when your not in queue for anything at the least

Been so so soo many times where i goto queue for something click the join button and i get this warning text about not being able to queue because of the cooldown.. sometimes if you reload ui it'll update on the lfg window but it seems to disappear after abit and doesn't always display unfortunately
Ok, did a quick update to fix the brackets on the roles during queue and added the 2 times while I was at it.

EDIT: Hooray! 1000 downloads :D