WoWInterface - Comments for Jelly's AddOn(s)

Jelly patch 5.2 added a... (RiggsBar)

Jelly — Tue, 07 May 2013 13:55:16 +0000

Jelly patch 5.2 added a new function called UnitGetTotalAbsorbs(). Maybe that is useful for what you do.

It gets the total absorb for a specific unit. Not sure if you really care about every single absorb infight.

Been using it since the first iteration. Thanks though.

Jelly patch 5.2 added a new functio... (RiggsBar)

zork — Tue, 07 May 2013 07:20:17 +0000

Jelly patch 5.2 added a new function called UnitGetTotalAbsorbs(). Maybe that is useful for what you do.

http://www.wowpedia.org/API_UnitGetTotalAbsorbs

It gets the total absorb for a specific unit. Not sure if you really care about every single absorb infight.

Too lazy to crop it right now but h... (RiggsBar)

Jelly — Fri, 03 May 2013 15:37:44 +0000

Too lazy to crop it right now but here's what I have so far:

http://i.imgur.com/1IxnDoj.jpg
http://i.imgur.com/QnNfXZE.jpg

Both the fonts and textures pull from SharedMedia and obviously I haven't implemented the check boxes yet.

[highlig... (RiggsBar)

Jelly — Fri, 03 May 2013 00:07:04 +0000

[highlig... (RiggsBar)

Jelly — Fri, 03 May 2013 00:05:41 +0000

if UnitClass("player") ~= "Death Knight" then
This doesn't work because the first return value from UnitClass is localized and Tonyleila is using the german client.

You need to use the second value from UnitClass and compare it to "DEATHKNIGHT".

local _, class = UnitClass('player')
if class == 'DEATHKNIGHT' then
or
if select(2, UnitClass('player')) == 'DEATHKNIGHT' then
The first one is marginally faster.

I guarantee you that's why it's not working. I use spell names . Yeah, I was thinking about the lower levels while I was making it and I'll likely fix that later on. I'll try to do a localization ... at some point but to be honest, I'm not entirely sure how.

I will be pushing an update that should work for you out shortly. Thanks for your patience.

if U... (RiggsBar)

semlar — Thu, 02 May 2013 21:40:41 +0000

Do you plan to add... (RiggsBar)

Jelly — Thu, 02 May 2013 15:03:08 +0000

Do you plan to add Warrior Shield Barrier absorb, too?

It's a definite possibility. Along with AMS.

Do you plan to add Warrior Shield B... (RiggsBar)

Stanzilla — Thu, 02 May 2013 06:51:18 +0000

Do you plan to add Warrior Shield Barrier absorb, too?

~= <-- means not equal... (RiggsBar)

Tonyleila — Wed, 01 May 2013 16:29:46 +0000

~= <-- means not equal to
But it shows the monk icon on my DK and if I change it as shown below it works fine :)

~= <-- means not equal to (RiggsBar)

Jelly — Wed, 01 May 2013 14:47:16 +0000

~= <-- means not equal to

if U... (RiggsBar)

Tonyleila — Wed, 01 May 2013 14:29:37 +0000

if UnitClass("player") ~= "Death Knight" then
RiggsFrame.bloodshield:SetTexture("Interface/Icons/Ability_Monk_Guard")
else
RiggsFrame.bloodshield:SetTexture("Interface/Icons/Spell_DeathKnight_Butcher2")
end

That's exactly how it is in my code and well, how it's been since I put it in.

yes and its still wrong way around :D
It says IF Death Knight then SHOW Monk Guard icon!

uard, it's absolutely possible for people who aren't Monks or Death Knights to get guard- the brewmaster statue puts it out and it's a different spellid than the monk's version.
Than why do you replace the monk icon with deathknight icon? Deathknight want to see the monk absorb too than :o Or can't they have the monk absorb + bloodshild.
So best woud be show bloodshild only for DK show rest for all classes

if UnitClass("pla... (RiggsBar)

Jelly — Wed, 01 May 2013 00:22:12 +0000

YES now it shows up deathstrike AND... (RiggsBar)

Tonyleila — Tue, 30 Apr 2013 22:12:21 +0000

YES now it shows up deathstrike AND overall absorb ;)

But the deathstrike symbol is not showing up its showing the monk icon :S
This was wrong way around :D
if UnitClass("player") ~= "Death Knight" then
RiggsFrame.bloodshield:SetTexture("Interface/Icons/Spell_DeathKnight_Butcher2")
else
RiggsFrame.bloodshield:SetTexture("Interface/Icons/Ability_Monk_Guard")
end

And maybe it shoud hide Monk Guard and Bloodshield if you are not a monk and not a DK - I mean this spells can only be on you if you play this class/spec

And this is on your front page read again :P
/riggs hide-- toggles the main frame shown and hidden: /riggs short

EDIT: Now its bugged even more in combat sometimes looks like this on my DK:
http://i.imgur.com/LdepUlO.jpg

Re: bug (RiggsBar)

Jelly — Tue, 30 Apr 2013 20:30:21 +0000

Once it's approved should be good to go!

Re: bug (RiggsBar)

Jelly — Tue, 30 Apr 2013 19:25:23 +0000

Maybe its something with ther german client that stops me from seeing anything els but overall absorb?
Also let it a friend test he had the same problem

The sortend numbers update was quick! However can you show 420 absorb instead of 0.4k that woud be better for low levels. Also right now it always shows 0k at the overall absorb untill I make more

I guarantee you that's why it's not working. I use spell names . Yeah, I was thinking about the lower levels while I was making it and I'll likely fix that later on. I'll try to do a localization ... at some point but to be honest, I'm not entirely sure how.

I will be pushing an update that should work for you out shortly. Thanks for your patience.

bug (RiggsBar)

Tonyleila — Tue, 30 Apr 2013 19:22:22 +0000

Maybe its something with the german client that stops me from seeing anything els but overall absorb?
Also let it a friend test he had the same problem

The sortend numbers update was quick! However can you show 420 absorb instead of 0.4k that woud be better for low levels. Also right now it always shows 0k at the overall absorb untill I make more

Re: Re: Re: Re: Re: Re: Nice addon! (RiggsBar)

Jelly — Tue, 30 Apr 2013 18:51:56 +0000

Still waiting for Approval :D

Yeah, I'm in IRC with a lot of the WoWI staff but I always feel weird pestering them for approvals, especially when I'm spam uploading. :-\

I have had two friends download and try it and neither of them are having the issues where it's just .. not working. Color me confused.

Re: Re: Re: Re: Re: Nice addon! (RiggsBar)

Tonyleila — Tue, 30 Apr 2013 18:32:03 +0000

Still waiting for Approval :D

Re: Re: Re: Re: Nice addon! (RiggsBar)

Jelly — Tue, 30 Apr 2013 18:09:56 +0000

Just pushed a release however until I narrow down this variable issue, I'm not certain that it will be much use to you. Still awaiting a reply from my pals.

Re: Re: Re: Nice addon! (RiggsBar)

Jelly — Tue, 30 Apr 2013 17:50:32 +0000

No lua errors but its also not showing up others spells at my DK - (I was a HC with a Pala healer and its only showing the overall absorb nothing else) Also the overall absorb overlabs sometimes with the 0. Also tryed disable all addons and /riggs reset

Also tryed my priest and its only shows the overall absorb

To update you, I've reached out to a friend of mine on why this would work fine for me but not you, even after checking the code for random references to my characters specifically. Hopefully he'll get back to me at some point with some insight. Given that the total works but the individuals don't, I'm guessing that it's a variable issue since they're are actually being called different.

I have also added a setting for short numbers so that it'll read 203.5k, for instance.
http://i.imgur.com/zjI5q6z.jpg
Regarding the zeros issue, I can duplicate that but it's as confusing to me as it might be to you. Also something to ask my friend about. Just double checked and it only seems to be happening on my Death Knight. Hmmmmmm