WoWInterface - Comments for evonder's AddOn(s)

Originally posted by Aise... (TradeFilter)

evonder — Sat, 29 Jan 2011 07:50:44 +0000

Originally posted by Aisenfaire
Thank you for the fast update! <3

I saw a message from Ace in chat while in a raid, saying something like "TradeFilter3 has 480 live timers, surely this is not intended?" (I copied it to paste later but forgot and copied something else. :( )
Give this version a try g0f22db4

Reference: Ticket 6

Thank you for the fast update! <3... (TradeFilter)

Aisenfaire — Sat, 29 Jan 2011 07:39:52 +0000

Thank you for the fast update! <3

I saw a message from Ace in chat while in a raid, saying something like "TradeFilter3 has 480 live timers, surely this is not intended?" (I copied it to paste later but forgot and copied something else. :( )

Originally posted by Aise... (TradeFilter)

evonder — Mon, 24 Jan 2011 14:40:23 +0000

Originally posted by Aisenfaire
Getting the following error:

2x TradeFilter3-v3.4.4\TradeFilter3.lua:278: attempt to call method 'ScheduleTimer' (a nil value)
CallbackHandler-1.0-6:145: in function <...ade\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
:"safecall Dispatcher":4: in function <"]:4>
: ?
:"safecall Dispatcher":13: in function `?'
CallbackHandler-1.0-6:92: in function `Fire'
AceEvent-3.0-3 (Casualty):120: in function `OnEvent'
StopAddonMessage-1.6.0beta\core.lua:282: in function
(tail call): ?:

---
Fixed in v3.4.5

Getting the following error:[co... (TradeFilter)

Aisenfaire — Sun, 23 Jan 2011 10:20:30 +0000

Getting the following error:

2x TradeFilter3-v3.4.4\TradeFilter3.lua:278: attempt to call method 'ScheduleTimer' (a nil value)
CallbackHandler-1.0-6:145: in function <...ade\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
:"safecall Dispatcher":4: in function <"]:4>
: ?
:"safecall Dispatcher":13: in function `?'
CallbackHandler-1.0-6:92: in function `Fire'
AceEvent-3.0-3 (Casualty):120: in function `OnEvent'
StopAddonMessage-1.6.0beta\core.lua:282: in function
(tail call): ?:

---

Re: 2 issues i found (TradeFilter)

evonder — Wed, 10 Nov 2010 04:24:13 +0000

Originally posted by DaemonSambe
1. My trade channels got scrambled today (probably for loggin out in BRD). After that, filters were broken, specifically for the Tradeforward channel, which is usually #4, but became #1. Since i don't filter General, i was not checking TFW at all. That took me a few minutes to figure out. I imagine the filters are checking channel #s, which is fine, but you should probably check the active channels and reset the numbers on each init. There may even be an EVENT for join/leave channel, that you may want to catch as well.

2. Sometimes editing expressions can cause one of them to be blank. I'm still not certain how it happened, since i removed the blank line at the end of the list. However, all spam was going thru, and the debug output showed - matched: ; with just a blank expression.

Regards.
1. Channels are filtered by either there zoneid or channel id via the CHAT_MSG_X event. I did however find a flaw that was filtering special channels according the GENERAL list and not the TRADE list.

2. This is odd as a blank line in a table should be nil, but I have been able to reproduce the problem and am working on it.

Edit:: please try 3.3.4-beta
- Fix allowing a blank entry into any list
- Add check in FilterFunc() for special channels
- Move profile management into TradeFilter GUI frame

2 issues i found (TradeFilter)

DaemonSambe — Tue, 09 Nov 2010 21:39:35 +0000

1. My trade channels got scrambled today (probably for loggin out in BRD). After that, filters were broken, specifically for the Tradeforward channel, which is usually #4, but became #1. Since i don't filter General, i was not checking TFW at all. That took me a few minutes to figure out. I imagine the filters are checking channel #s, which is fine, but you should probably check the active channels and reset the numbers on each init. There may even be an EVENT for join/leave channel, that you may want to catch as well.

2. Sometimes editing expressions can cause one of them to be blank. I'm still not certain how it happened, since i removed the blank line at the end of the list. However, all spam was going thru, and the debug output showed - matched: ; with just a blank expression.

Regards.

Re: Error (TradeFilter)

evonder — Tue, 09 Nov 2010 01:19:45 +0000

Originally posted by DaemonSambe
There was a lua error on line 155 (Print) that was causing the problem.

Also, that blacklist for Thunderfury, doesn't work.. maybe because the item: whitelist is in?? I'm pretty bad with expressions anyway, so just guessing.
The string should work fine in the blacklist to block link as any message must pass both the white and black list unless you expressly tell TradeFilter that a match on the whitelist bypass the blacklist.

Originally posted by Tondef
Consistently getting the following error.
I'm checking to see if it is prat or addon loader conflicting with it.

Its an oversight on my part and will be fixed tonight. line 155 should read:
print(L.TOC.Title .. ": " .. TF3.version .. " " .. L)

Error (TradeFilter)

Tondef — Tue, 09 Nov 2010 00:47:59 +0000

Consistently getting the following error.
I'm checking to see if it is prat or addon loader conflicting with it.

1x TradeFilter3-3.3.0-release\TradeFilter3.lua:155: attempt to call global 'Print' (a nil value)
TradeFilter3-3.3.0-release\TradeFilter3.lua:134: in function
(tail call): ?:
: ?
:"safecall Dispatcher":9: in function <"]:5>
(tail call): ?:
AceAddon-3.0-10 (Prat-3.0_Libraries):514: in function `InitializeAddon'
AceAddon-3.0-10 (Prat-3.0_Libraries):628: in function <...Ons\Prat-3.0_Libraries\AceAddon-3.0\AceAddon-3.0.lua:621>
: in function `LoadAddOn'
AddonLoader-2.0\AddonLoader.lua:109: in function `LoadAddOn'
AddonLoader-2.0\Conditions.lua:128: in function
AddonLoader-2.0\Conditions.lua:143: in function

---

There was a lua error on line 155 (... (TradeFilter)

DaemonSambe — Mon, 08 Nov 2010 20:23:32 +0000

There was a lua error on line 155 (Print) that was causing the problem.

Also, that blacklist for Thunderfury, doesn't work.. maybe because the item: whitelist is in?? I'm pretty bad with expressions anyway, so just guessing.

Re: Whitelist Bug (TradeFilter)

evonder — Mon, 08 Nov 2010 05:08:32 +0000

Originally posted by DaemonSambe
Bug /w the default Whitelist:

I tried to delete the item: reference, as a way of blacklisting useless spam, however, every reload the whitelist resets to default.
I am not able to reproduce the whitelist resetting itself to default settings, could you reset your profile or delete the saved variable file and try it again to see if it persists?

As far as removing crap in trade I just added item:%d+ to the blacklist.

Whitelist Bug (TradeFilter)

DaemonSambe — Mon, 08 Nov 2010 04:53:47 +0000

Bug /w the default Whitelist:

I tried to delete the item: reference, as a way of blacklisting useless spam, however, every reload the whitelist resets to default.

NVM seems to be working now :) (TradeFilter)

Niightblade — Fri, 16 Jul 2010 04:45:06 +0000

NVM seems to be working now :)

I think I have finally found the ad... (TradeFilter)

Beta7 — Thu, 17 Jun 2010 12:43:47 +0000

I think I have finally found the add-on that makes Trade chat bearable. I hope you keep this up, this is wonderful.

Thanks! (TradeFilter)

BattleChicken — Sun, 14 Mar 2010 02:10:10 +0000

Fantastic addon :) My server's trade and general channels are so full of trash that I had to run out and find an addon that filtered it.

Thank you so much for your contribution to our game. :D

Here's another suggestion then, cou... (TradeFilter)

thantik — Fri, 25 Dec 2009 00:30:05 +0000

Here's another suggestion then, could you make it so LFG style captures in the trade channel get redirected to LFG and DISPLAYED instead of just hidden in TF?

Re: Suggestions (TradeFilter)

evonder — Sat, 08 Aug 2009 03:27:25 +0000

Originally posted by thantik
Could we have seperate white/black lists per major channel? I'd just like a bit better control over what's let through and what's not.

Also...the 'in bed' filter...currently blacklists anyone who links any gem with "inscribed" listed in the name. Might wanna redo the regex to be a little more specific by default.

Also - if you were to make seperate black/white lists, some little pre-set regex list to be able to add/remove to each black/white list would make setting it up really easy.

The defaults are amazing right now otherwise, just some minor quirks and I'm a control freak.
I have a feeling that having a configurable whitelist per-channel would make the addon far to convoluted and make the average user confused. The blacklist actually wasn't blocking the item links but a bug that I found while adding a new option, which will do what Contiki requested earlier but I failed to understand. I think I understand what you are saying about the pre-sets though I don't think really see the use of it if we only have one list, what type of situation would call for changing pre-sets?

Updates: Alpha r167
- Added option whitelist bypass blacklist
- Added simple duel spam block
- Fix repeat filter and blacklist not actually being off

Suggestions (TradeFilter)

thantik — Thu, 06 Aug 2009 06:46:39 +0000

Could we have seperate white/black lists per major channel? I'd just like a bit better control over what's let through and what's not.

Also...the 'in bed' filter...currently blacklists anyone who links any gem with "inscribed" listed in the name. Might wanna redo the regex to be a little more specific by default.

Also - if you were to make seperate black/white lists, some little pre-set regex list to be able to add/remove to each black/white list would make setting it up really easy.

The defaults are amazing right now otherwise, just some minor quirks and I'm a control freak.

Hi,I've had a chance to test sp... (TradeFilter)

Contiki — Sat, 01 Aug 2009 12:55:47 +0000

Hi,

I've had a chance to test special channel filtering and it seems to work fine. If I've interpreted TradeFilter's bevahior correctly, however, the black list does not (yet) apply to special channels and the hidden guild add-on channel. If the black list is used for special channels, too, I must've set something incorrectly. I couldn't find any suspicios options though. In case this behavior is intended, could you modify TradeFilter so that special channels don't bypass the black list anymore?

While I was testing EverTrade with a guildie I missed the appropriate output in the SPAM and DEBUG chat frames. In case EverTrade messages indeed aren't displayed in those chat frames yet, could you change TradeFilter so that those messages are displayed there?

The bottom line is that special channels support is already working great. Makes the combination of EverTrade (and others) and TradeFilter a lot nicer than with former TradeFilter versions.

As for the sorting mechanism, it's way better than before. Now the sorting is predictable since it's always alphabetically from a to z. If possible, a next step in sorting greatness might be to actually save the player's sorting. That way players who prefer to group their filter and black list entries by context can retain their custom sorting, too. As in "here's everything about dungeons", "here's everything about obscenities" and "here's the valid profession stuff".

Keep it up! ;-)

All the best

Originally posted by Cont... (TradeFilter)

evonder — Thu, 30 Jul 2009 04:35:22 +0000

Originally posted by Contiki
This is an actual issue. I think. When I hit the Accept button underneath each of the filter input fields like Trade filter, Black list and so on, the fields' entries are randomly mixed.Ok give this on a shot =) r160

EDIT:: little fix - r160 should keep list sorting constant

Originally posted by Cont... (TradeFilter)

evonder — Thu, 30 Jul 2009 00:47:27 +0000

Originally posted by Contiki
I've added German translations for the four new strings. Looks like the key RPTBYPASSD has a mistake, namely "Allow strings that match your a pattern in your whitelist to bypass the repeat filter." Nothing else to bitch and moan about though ;-) aghh yes, it is now fixed. I also added "" to keys GAC and GACD ;)