WoWInterface - Comments for p3lim's AddOn(s)

While waiting for p3lim to update h... (HabeebIt)

Cloudyfa — Thu, 23 May 2013 19:49:00 +0000

While waiting for p3lim to update his addon, here's a quick fix for patch 5.3 by editing lua file:

- Line 248:
Replace

if(patch50300) then
...
end

With

local loot = GetLootSpecialization()
if (loot and loot > 0) then
local spec = 0
for index = 1, GetNumSpecializations() do
if (GetSpecializationInfo(index) == loot) then
spec = index
break
end
end
UpdateSpecializations(spec)
else
UpdateSpecializations(GetSpecialization())
end

- Line 267:
Replace

if(patch50300) then
...
end

With

local loot = GetLootSpecialization()
if (loot and loot > 0) then
local spec = 0
for index = 1, GetNumSpecializations() do
if (GetSpecializationInfo(index) == loot) then
spec = index
break
end
end
InitializeList(spec)
else
InitializeList(GetSpecialization())
end

P/S: Thanks for great addon, p3lim

This appears to work fine in 5.3 as... (Broker_Equipment)

GreyWolfSC — Thu, 23 May 2013 17:19:53 +0000

This appears to work fine in 5.3 as well when loaded out-of-date if you're interested.

Re: Re: Alternate Arrow Placement (HabeebIt)

LadySilverwolf — Wed, 22 May 2013 17:49:52 +0000

I was wondering if there were ever plans to possibly of adding support to move the 'arrow' to the Left side of the loot?

It's on my list of things to do.
Exam time right now so it would have to wait.

Sweet. Good luck with the exams! Looking forward to it. :D

Re: update toc (HabeebIt)

p3lim — Wed, 22 May 2013 12:16:27 +0000

thanks for your 5.3 update but the toc file is still at 5.2 (50200)

Intended.
I wanted to get a quick update out that works with 5.3, but it's not a finished product yet.

Re: Alternate Arrow Placement (HabeebIt)

p3lim — Wed, 22 May 2013 12:15:55 +0000

update toc (HabeebIt)

Tonyleila — Wed, 22 May 2013 07:59:10 +0000

thanks for your 5.3 update but the toc file is still at 5.2 (50200)

Alternate Arrow Placement (HabeebIt)

LadySilverwolf — Tue, 21 May 2013 12:04:56 +0000

I was wondering if there were ever plans to possibly of adding support to move the 'arrow' to the Left side of the loot?

[quote=Ae... (Broker_Equipment)

GreyWolfSC — Thu, 16 May 2013 22:21:39 +0000

Aside from this, does the addon work like expected?
If yes, I'll drycode Phanx's fix and push an update.

I added Phanx's edits and bumped the TOC and it seems to work like it always did. :)

Great addon. Sadly, it won't work f... (HabeebIt)

Ruven — Fri, 10 May 2013 09:40:19 +0000

Great addon. Sadly, it won't work for me for some reason. Nothing really happens...Are there known addons that mess with this one's functionality ? :( I'm not getting any lua errors either, so yeah.

Did you move your Bonu... (HabeebIt)

Tonyleila — Thu, 09 May 2013 22:15:47 +0000

Did you move your BonusRollFrame out of the screen?
I moved it around but not out of the screen - with DragEmAll
This was first time this poped up and I have moved it around alot in last weeks so don't think thats the problem

6x HabeebIt\... (HabeebIt)

p3lim — Thu, 09 May 2013 21:47:25 +0000

6x HabeebIt\HabeebIt-50200.5-... (HabeebIt)

Tonyleila — Thu, 09 May 2013 20:39:34 +0000

6x HabeebIt\HabeebIt-50200.5-Beta.lua:97: attempt to compare number with nil
HabeebIt\HabeebIt-50200.5-Beta.lua:97: in function

FrameXML\LootFrame.lua:309: in function "GroupLootContainer_AddFrame"
FrameXML\LootFrame.lua:505: in function "BonusRollFrame_StartBonusRoll"
FrameXML\UIParent.lua:1028: in function

Locals:
(*temporary) = BonusRollFrame {
0 =
PromptFrame = {}
active = true
LootSpinnerBG = {}
remaining = 180
animTime = 0.048000000417233
IconBorder = {}
RollingFrame = {}
Background = {}
SetPoint = =:-1
Hide = =:-1
rewardQuantity = 257846
rewardLink = ""
BlackBackgroundHoist = {}
endTime = 1368113014
rewardType = "money"
StartRollAnim = {}
FinishRollAnim = {}
Show = =:-1
animFrame = 6
scale_mod = 0.9
currencyID = 697
WhiteFade = {}
CurrentCountFrame = {}
state = "prompt"
spellID = 132205
}
(*temporary) = =:-1

Very nice addon :) (HabeebIt)

Wall — Thu, 09 May 2013 11:36:24 +0000

Very nice addon :)

Re: Nalak (HabeebIt)

p3lim — Sat, 04 May 2013 14:45:15 +0000

Well for Nalak it shows the allianz items too if you are horde thats why the list is very long at this boss and also if I move the list down at the bottom of my screen its still to long with 40 items in the list.
But I think best way to fix woud be add a scrool options and a max. number of items that coud be shown at the same time.
Thank you!

It's the next thing on my todo list.

Nalak (HabeebIt)

Tonyleila — Fri, 03 May 2013 15:12:45 +0000

Fantastic idea. :) (HabeebIt)

ckramme — Thu, 02 May 2013 20:14:00 +0000

Fantastic idea. :)

I love this mod btw. :) (HabeebIt)

zork — Thu, 02 May 2013 07:40:24 +0000

I love this mod btw. :)

I found your error at... (HabeebIt)

p3lim — Wed, 01 May 2013 20:28:14 +0000

I found your error at Galleon:
Habeebit: Found an unknown spell . Please report this!

Thanks, apparently I misread "Garalon" for "Galleon" in my data, pushed a new version with this fixed.

I found your error at Galleon:... (HabeebIt)

jasje — Wed, 01 May 2013 18:02:33 +0000

I found your error at Galleon:
Habeebit: Found an unknown spell . Please report this!

Damn there was an... (HabeebIt)

p3lim — Wed, 01 May 2013 16:54:23 +0000

Damn there was an error massage @ Galleon there was some missing spell id but I did not screenshot it :(

Printed in the chat? If so, that's my warning system for missed/unknown boss IDs, and I would need to know exactly what it was.