WoWInterface - Comments for lifetapt's AddOn(s)

broke?? (PetCaught)

rigdig — Fri, 15 Mar 2013 18:21:54 +0000

I can't get this to work. It doesn't pop up saying if i have the pet. I disabled all other addons and it still didn't work

any ideas??

Linking to Others Spells (RollMeter)

SnuggleZombie — Thu, 07 Mar 2013 15:58:52 +0000

I really like the addon, very useful when rolling in a dungeon to the next group of enemies ( when everyone just runs ahead of the tank and you have to RUN to get the agrro off them :mad: )... but heres a thought, what if you allow the addon to link with other spells such as the warlocks "Hand of Gul'dan" i think it would be awesome to link this up with not only roll but with other spells, just a thought though nothing i can't live without... :D

Hi there, I really love this little... (RollMeter)

Cancrizans — Sat, 19 Jan 2013 18:14:40 +0000

Hi there, I really love this little addon, it does it's job perfectly and the customizability is terrific. I do have one problem though...it will not remember my texture choice for the bar and keeps resetting it to the default. How can I get it to remember my texture choice so I do not have to change it every time I load the game?

Roll & Epacity options request (RollMeter)

twopro — Thu, 03 Jan 2013 18:25:27 +0000

hey, could you add sound files so when you Use and Gain a Roll.

Roll Gained = I.E. "Shotgun reload" sound clip
Roll Used = I.E. "Chang, Ching and Chong" sound clip

(other thoughts) Sega "Sonic" video game roll sounds i'm sure there is a few that would suit this addon.
(other thoughts) Nintendo "mario" or "wario" video game sounds.

Raven buff,debuff timers http://www.curse.com/addons/wow/raven
Also, could you Add more to opacity like Raven addon. (was my suggestion)
option you can find under General via "bar groups" tab after you create a bar group

I.E.

Opacity "in Combat" "out of combat" "mouseover" "fade effects"
Slider---========---==========---========--=========

Love this addon. Just wanted to re... (PetCaught)

kittykatmax — Mon, 17 Dec 2012 04:18:41 +0000

Love this addon. Just wanted to report:

37x PetCaught\PetCaught-1.1.lua:23: attempt to compare number with nil
PetCaught\PetCaught-1.1.lua:23: in function "OnEvent"
PetCaught\PetCaught-1.1.lua:6: in function

Blizzard_PetJournal\Blizzard_PetJournal-1.0.lua:846: in function

Thanks.

Oh, please please don't discontinue... (PetCaught)

SomeoneSneaky — Fri, 30 Nov 2012 20:53:34 +0000

Oh, please please don't discontinue this addon! Yes, they added the caught pets number to the tooltip, but PetCaught is awesome for the minimap mouseover telling you what quality you have in your journal. The default WoW tooltip doesn't do that, only gives a number -- and even then, you have to land and find the critter in the first place in order to target it, or stop and search for the pet in your journal to see what you own.

PetCaught has been an invaluable thing to have while hunting new pets and upgrading ones I already own. It would be sad to see it go just because WoW adds a default that is sort of (but not really) the same.

Re: Minimap color (PetCaught)

Phanx — Mon, 15 Oct 2012 06:49:55 +0000

... change the minimap color of the pets. It is always green and I have to stop, mouseover and check ...

Unfortunately, this isn't possible, since addons can't even see minimap tracking blips, let alone find out what each blip is tracking. Mousing over the icon is your only option.

request (RollMeter)

Tymliz — Wed, 10 Oct 2012 05:02:47 +0000

cool addon, simple and works as advertised. Just a simple request, could you maybe make it track the talent Momentum as well as it ties in with Rolls/Chi Torpedo. Add that and i think this mod will be a must have for all monks.

Minimap color (PetCaught)

BronzeMoy — Tue, 02 Oct 2012 10:13:55 +0000

Hi

I love your addon since I like to collect pets. I have a few suggestions though...

Mainly its to change the minimap color of the pets. It is always green and I have to stop, mouseover and check if I have it or not.
My suggestion is to change the icon color depending on for example:

Rarity: Green, Blue, Purple
Caught: Grey
Hard: Red

(hard: say when the pet level is above 5 or 10 levels above my highest pet so i have no chance of catching it anyway)

I realize that changing this icon may or may not be hard to do so I humbly suggest it.

Thanks again for a nice addon!

Really nice mod, but I think its bl... (PetCaught)

Negatron — Sun, 30 Sep 2012 18:12:39 +0000

Really nice mod, but I think its blocking my achievements. Not from getting them, but seeing them.

For example, in the last 30 minutes or so, I have got 2 battle pet achievements, getting a pet to 10 and getting my first rare. both of them never showed, if I checked my achievements it said I never got them, reloading my ui didn't change it, and I had to relog for them to show.

the only other mods I use is Recount and WarcraftpetsExpress.

Any idea if this is your mod doing it, a glitch, or what? anyone else having this issue? no error report displays.

Other than that, I really like this mod. super helpful because I'm stuck in a "Gotta catch'em all" mindset right now. Love this mod, I actually just now registered to WoW Interface because I'm hoping you can fix this, if its your mod doing it.

thanks

I got some errors, when i'm searchi... (PetCaught)

Lemon — Sat, 29 Sep 2012 16:03:35 +0000

I got some errors, when i'm searching pet's.

Message: Interface\AddOns\PetCaught\PetCaught.lua:23: attempt to compare number with nil
Time: 09/29/12 17:59:43
Count: 2
Stack: : ?
Interface\AddOns\PetCaught\PetCaught.lua:23: in function `OnEvent'
Interface\AddOns\PetCaught\PetCaught.lua:6: in function
: in function `SetSearchFilter'
...e\AddOns\Blizzard_PetJournal\Blizzard_PetJournal.lua:837: in function <...e\AddOns\Blizzard_PetJournal\Blizzard_PetJournal.lua:830>

Locals:

Just For Fun (PetCaught)

QuickBASIC37 — Fri, 28 Sep 2012 13:40:58 +0000

Should have named it "CaughtOrNot.com" (parody of Hotornot.com).

Ah, I went through and found out wh... (PetCaught)

Tiberion1701 — Fri, 28 Sep 2012 06:58:10 +0000

Ah, I went through and found out what was causing it; I had just updated Dominos (a bar mod) and it seems to be the culprit, the previous version wasn't doing it.

I did find a genuine issue with your addon though, that was causing the detection to "fail" on the tooltips. if you use the filters in the pet journal (say to show only favorites) then any pet that is "hidden" in the journal will display as "not caught" in the world, even if you have caught it. I turned it on and off several times to confirm :)

It seems that t... (PetCaught)

lifetapt — Fri, 28 Sep 2012 06:08:56 +0000

It seems that the addon is making the menu icons (charsheet, spellbook, questlog, etc..) that appear in the little box on the right side during a Pet Battle disappear.

If you use a menu hotkey (like L to open the questlog, or shift+P for the pet journal) the icons come back. So yeah.

Edit: actually opening/closing the map is what makes the icons show up again.

Edit2: saw another issue; Found a skunk wandering in Duskwood, it said "not caught" - but I do have one caught from the same zone. I used the "click to open in Journal" link to make sure it was the same Pet ID

Liking it so far, can't wait for more features. I would like to see rarity color and caught/not caught show somewhere on the info cards/tooltips that show up during pet battles, as there is no way to tell if you have the 2nd pet in a wild-battle, or its rarity (there is another pet addon that does this currently)

I wasn't able to reproduce the issue with the minibar icons disappearing. Make sure you disable all addons except for PetCaught, then try fighting a pet again. The code for the addon is really simple and it doesn't touch anything UI-related other than tooltips so I'm not sure how that could even be occurring. :S

I'll look into adding rarity inside of pet battles, since that's something I've been wanting also. I don't think I'll be adding a ton of crazy features though... I'm sure very deep and complex "Pokdex" type addons will start to pop up in a few months once other coders have had time to play with the new API, and I have no doubt that they'll do a better job than I ever could. This addon was really meant as just a quick fix for a very minor UI annoyance. :P

VERY useful addon. Thanks for taking the time.

I did notice that when you get multiple creatures in the same tooltip its looks a little strange. i.e.

Frog
Toad
Caught
Uncaught

Other than that I dig it. Seems like it should be standard in the Blizz UI.
Yeah, unfortunately the API is very limiting and clunky when it comes to those minimap tooltips and I wasn't able to devise an elegant solution to that issue at the time (it was 2AM, I was tired, and I kept getting distracted by pet battles...).

It's a little messy, but for now it'll have to do. Once I've gotten over my MoP release leveling binge I'll see what I can do.

It seems that the addon is making t... (PetCaught)

Tiberion1701 — Fri, 28 Sep 2012 03:22:56 +0000

VERY useful addon. Thanks for takin... (PetCaught)

Ratso Steamwheedle — Fri, 28 Sep 2012 00:53:25 +0000

VERY useful addon. Thanks for taking the time.

I did notice that when you get multiple creatures in the same tooltip its looks a little strange. i.e.

Frog
Toad
Caught
Uncaught

Other than that I dig it. Seems like it should be standard in the Blizz UI.

Re: Re: Re: error when trying to search journal (PetCaught)

lifetapt — Thu, 27 Sep 2012 22:34:02 +0000

first off - addon works great as intended to function. problem i have is when i open the journal to search something as soon as i type the first letter, and for each subsequent letter i get this error:

Thanks for catching that. I've uploaded a fix for it just now.

greatly appreciated - tyvm ;)

Looks like the file is still pending approval from a moderator. The fix is tiny, literally a single line, so you can paste it into the code for the current version if you want.

Open up PetCaught.lua and look for the line that says:

local _, _, _, _, rarity = C_PetJournal.GetPetStats(petID)

Create a new line before that one and paste the following:

if (petID == nil) then return end

Then save the file and you're good to go.

Re: Re: error when trying to search journal (PetCaught)

txamethyst — Thu, 27 Sep 2012 22:23:50 +0000

Re: error when trying to search journal (PetCaught)

lifetapt — Thu, 27 Sep 2012 22:22:10 +0000

error when trying to search journal (PetCaught)

txamethyst — Thu, 27 Sep 2012 20:40:54 +0000

first off - addon works great as intended to function. problem i have is when i open the journal to search something as soon as i type the first letter, and for each subsequent letter i get this error:

PetCaught\PetCaught-1.0.lua:15: Usage: GetPetStats(ID)

PetCaught\PetCaught-1.0.lua:15: in function "OnEvent"
PetCaught\PetCaught-1.0.lua:6: in function

Blizzard_PetJournal\Blizzard_PetJournal-1.0.lua:837: in function

Locals:
self = {
LastTooltipText = ""
KnownPets = {}
0 =
AddTooltipLine = @..\PetCaught.lua:29
Print = @..\PetCaught.lua:39
OnEvent = @..\PetCaught.lua:8
}
self = {
LastTooltipText = ""
KnownPets =

{}
0 =
AddTooltipLine = @..\PetCaught.lua:29
Print = @..\PetCaught.lua:39
OnEvent = @..\PetCaught.lua:8
}
numPets = 7
numOwned = 215
(for index) = 8
(for limit) = 215
(for step) = 1
i = 8
petID = nil
speciesID = nil
isOwned = nil
customName = nil
level = nil
favorite = nil
isRevoked = nil
name = nil
icon = nil
petType = nil
creatureID = nil
sourceText = nil
description = nil
isWildPet = nil