Go to Page... |
Updated: | 09-24-12 05:37 AM |
Created: | 12-29-09 11:31 AM |
Downloads: | 18,445 |
Favorites: | 186 |
MD5: | |
Categories: | Data Broker, Auction House & Vendors, Bags, Bank, Inventory |
Have you ever been in a situation where you just can't turn in a quest because your inventory is full? Trying to figure out an item to delete that's cheap and won't make you loose much gold?
This is one of the many situations where Broker_Garbage makes your life easier.
What is it?
Broker_Garbage shows your cheapest item(s) for easily freeing bag space. It uses your auction addon of choice for pricing, including disenchant prices if available. And if you don't want to throw away that [Broken I.W.I.N. Button], put it on your Exclude List and Broker_Garbage will keep it. Forever. Really! And those [Shiny Fish Scales]? Just put them on your Include List.
This addon works as-is but you will only see the text and tooltip if you use an LDB display addon. Some are Bagnon, DockingStation, Bazooka.
Basic Features - all features can be disabled if you don't want to use them
Comment Options |
04-01-10, 08:22 PM | |
|
Gave the GitHub build a36ff3b
of core.lua a try (the one that includes your suggested line change). It doesn't work either. Ran another instance, picked up another unusable rare item (leather helmet). Trying the sell button at vendor, the helmet never sold or showed up in the tooltip. Switched it to auto-sell and it didn't sell either. |
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
04-01-10, 04:32 AM | ||
|
Fixed it on GitHub. Get it there or just change line 682 in Broker_Garbage/core.lua from "isVendor = true" to "isSell = true". I'm currently busy (three more exams next week), so just tell me if it still doesn't work as I've got no time to test it.
__________________
It all starts to make a creepy kind of sense. Avatar
Last edited by ckaotik : 04-01-10 at 05:28 AM.
|
|
|
ckaotik |
View Public Profile |
Send a private message to ckaotik |
Find More Posts by ckaotik |
Add ckaotik to Your Buddy List |
04-01-10, 03:34 AM | |
|
3.3v23, WoW 3.3.3a live, on a 80 Priest character. Problem with the Sell Gear function.
Have Sell Gear checkmarked and the Max. Quality slider set to Epic. Do a heroic instance that has no enchanter in party, win Fist of the Deity (which a Priest cannot use/equip). It has not previously been put on The Whitelist/Exclude list and is not there now. It does not show up in the Broker Garbage tooltip. But also, opening a vendor (having not picked up any gray junk during the run), the Garbage sell button is grayed out. The unusable Rare item cannot be dropped or sold by Broker Garbage. Then go back into options and click Rescan Inventory. Same thing, no change. Finally click Create default lists. Same thing, no change. |
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
03-31-10, 04:44 AM | ||
|
I tried this on my own machine but didn't find any defect. It never once equipped an item for me (well, it's not supposed to do so, anyway).
__________________
It all starts to make a creepy kind of sense. Avatar |
|
|
ckaotik |
View Public Profile |
Send a private message to ckaotik |
Find More Posts by ckaotik |
Add ckaotik to Your Buddy List |
lodewijk |
View Public Profile |
Send a private message to lodewijk |
Find More Posts by lodewijk |
Add lodewijk to Your Buddy List |
03-30-10, 09:58 AM | ||
|
@SkunkWerks: I found the problem you talked about. When you report something again, please provide a little more information The 'Addon blocked' popup was caused by some cheap (and therefore insecure) hooking on my part and would only occur if you tried to loot in combat and afterwards wanted to delete something. You will still get a message in your chatframe when looting in combat for the first time, but it should not break the addon anymore. @Zidomo: I changed the scanning of unusable gear. Therefore now both tresholds will be used - the basic 'Quality Treshold' option to decide if the item will be shown in the tooltip and the 'Max. Quality' (belonging to 'Sell Gear') to decide if the item will be sold. Also, the category test panel might help figuring out why items appear where the appear
__________________
It all starts to make a creepy kind of sense. Avatar |
|
|
ckaotik |
View Public Profile |
Send a private message to ckaotik |
Find More Posts by ckaotik |
Add ckaotik to Your Buddy List |
03-29-10, 11:57 PM | |
A Molten Giant
Forum posts: 960
File comments: 18
Uploads: 0
|
Just found this, and have been trying it out. I like it so far, but I had an interesting problem last night — I would shift-click on something to delete it, but instead of deleting it, it would be swapped with my equipped gear (when it was some piece of gray gear I was trying to delete). I didn't lose anything, but it was a bit scary, until I figured out what was going on. And I still don't know why it was doing it. There were no lua errors, for example.
|
|
Chmee |
View Public Profile |
Send a private message to Chmee |
Find More Posts by Chmee |
Add Chmee to Your Buddy List |
03-28-10, 05:08 PM | |
|
If you'd like to see those promised features, but can't wait for me to upload them here, you can get beta style versions here: BrokerGarbage (w/o LootManager), LootManager plugin. These are updated frequently and may contain bugfixes/improvements which are not "big" enough yet to get a new release here.
To anyone, I highly encourage you to make use of the default list entries. If you didn't already use them (they've been included since 3.3v17), you can get them by using the 'Create default lists' button in the options (currently only available in beta versions). This will give you some suggestions what may be put on which list. Make sure to re-check you lists afterwards and also add any other entries you like. Now, Zidomo. There are various ways to not have an item getting sold by Broker_Garbage. These include:
When you have 'Sell Gear' disabled, that is what it means: Broker_Garbage will not sell your unusable gear. If you have it enabled, though, it will sell only soulbound, unwearable gear (that excludes for example trinkets and stuff you class can wear, like shields for warriors) in case you're not an enchanter. If you still feel something gets on your tooltip that shouldn't, enable 'Show Source' to see where Broker_Garbage gets its value and why it puts the item on there. Explanations on those "codes" can be found in the readme.txt .
__________________
It all starts to make a creepy kind of sense. Avatar
Last edited by ckaotik : 03-28-10 at 05:11 PM.
|
|
ckaotik |
View Public Profile |
Send a private message to ckaotik |
Find More Posts by ckaotik |
Add ckaotik to Your Buddy List |
03-28-10, 01:34 AM | ||
|
As mentioned previously: hopefully the next version will completely exclude on its own any such items from appearing in the tooltip if "Sell Gear" is not turned on. And (better) include a built-in "black list" of soulbound+crafted/faction items that will never be sold unless you specifically add them to the "always sell" list. Another way to go: add a selectable option for "confirmation-before-selling" (a popup box, etc.) that can be enabled for selling things at various quality levels. For example, set it to pop up on "rare" or higher vendor-sells. The popup box would have "yes" and "no" buttons that would need to be pressed before anything happened. Similar to vendor-buy confirmation that exists in some reagent-buying mods like BuyDropper. It wouldn't replace the above options, but would also help make things safer.
Last edited by Zidomo : 03-28-10 at 03:09 AM.
|
|
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
03-27-10, 06:46 AM | ||||
|
And yes, I'll do something about that in the next release.
You can get some basic list settings (including ammo if you're a hunter) by running this on all relevant characters: Code:
/run BrokerGarbage:CreateDefaultLists()
__________________
It all starts to make a creepy kind of sense. Avatar |
|||
|
ckaotik |
View Public Profile |
Send a private message to ckaotik |
Find More Posts by ckaotik |
Add ckaotik to Your Buddy List |
03-26-10, 05:40 PM | |
|
Since v21 whenever I obtained any trash items in my bag the LDB display on my bar would look like below. If I downgraded to v20 the issue didn't occur. I was hoping it might be fixed with this new release, but what ever the issue is, it's still there.
Also, any clue why my Timeless Arrows are coming up as garbage? Thanks |
|
Ookami.kun |
View Public Profile |
Send a private message to Ookami.kun |
Find More Posts by Ookami.kun |
Add Ookami.kun to Your Buddy List |
03-26-10, 12:24 PM | |||||
|
To get a better ideas of what is tainting, use the following command ingame, exit and restart: Code:
/console taintLog 1 Code:
SET taintLog "1" When it happens again, exit WoW, head to \World of Warcraft\Logs and look for a taint.log file. The info contained in it will help to determine what is causing the taint. But unlike regular mod errors, sometimes the mod(s) mentioned in that log have no connection at all to what is causing the taint.
A built-in blacklist for items such as that would remove some of the danger/hassle. Other such items I can think of offhand include enchanting rods (Runed Eternium Rod, etc.) & Jewelcrafting trinkets (Figurine - Monarch Crab, etc.). There may be others. As well as my suggestion to keep all BOP items or items above your regular drop/sell threshold out of the tooltip when Sell gear is disabled. As noted above, the regular drop/sell threshold was set to Poor. |
||||
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
03-26-10, 05:29 AM | ||
|
Are you sure this is because of Broker_Garbage? Maybe test with just BG and an LDB display enabled? Which LDB display do you use?
__________________
It all starts to make a creepy kind of sense. Avatar |
|
|
ckaotik |
View Public Profile |
Send a private message to ckaotik |
Find More Posts by ckaotik |
Add ckaotik to Your Buddy List |
03-26-10, 05:00 AM | ||
|
|
|
|
SkunkWerks |
View Public Profile |
Send a private message to SkunkWerks |
Find More Posts by SkunkWerks |
Add SkunkWerks to Your Buddy List |
03-26-10, 04:35 AM | |||||
|
There currently is a bug though which is connected to items without a value (like conjured water). Other than that it works fine for me ... so I don't quite know how to help you there
Your descriptions are quite detailed, as always It helps with finding the errors, though, so this is a good thing.
__________________
It all starts to make a creepy kind of sense. Avatar |
||||
|
ckaotik |
View Public Profile |
Send a private message to ckaotik |
Find More Posts by ckaotik |
Add ckaotik to Your Buddy List |