Go to Page... |
Updated: | 08-03-10 03:18 AM |
Created: | 04-09-10 08:35 AM |
Downloads: | 4,781 |
Favorites: | 38 |
MD5: |
All users with revision 10 or under, delete it before you install a newer version
***IMPORTANT***
This requires a databroker addon such as Chocolate Bar or TitanPanel.
Broker_H3DungeonCooldown is only available in English and was designed for enUS. If you aren't enUS, the only thing that should break is expansion sorting. Just disable expansion headers.
Broker H3 DungeonCooldowns started out as a quick "Hello World" test to start out coding Lua in WoW and eventually turned into this. It is a somewhat simple DataBroker Display that shows what dungeons you are saved to and how long until they unlock.
Please provide feedback in comments. Also provide suggestions for more features. I will update with a list of features I plan on adding when there are enough.
It is important that if you find a bug that you please a comment here, otherwise the bug will not be fixed.
Features
Self explanatory section title is self explanatory.
The chat report feature inserts the text without enabling text input, so pressing enter opens the edit box (sets it to full opacity), and clears what was in it. |
Comment Options |
06-01-10, 03:49 PM | ||
|
|
|
|
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
Gsusnme |
View Public Profile |
Send a private message to Gsusnme |
Find More Posts by Gsusnme |
Add Gsusnme to Your Buddy List |
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
06-01-10, 02:02 PM | |
|
On deleting
Make sure in addition to deleting the old file version also delete the Saved Variables portion of this addon as well to insure there well be a painless transition. Good work.
|
|
Xylan Trueheart |
View Public Profile |
Send a private message to Xylan Trueheart |
Find More Posts by Xylan Trueheart |
Add Xylan Trueheart to Your Buddy List |
05-31-10, 11:35 PM | |
|
Another simple and very useful addon by you. Thanks
|
|
flaicher |
View Public Profile |
Send a private message to flaicher |
Find More Posts by flaicher |
Add flaicher to Your Buddy List |
05-31-10, 08:57 PM | |
|
Rerelease
Remade the entire addon. Would have taken less time and effort to just remake it instead of trying to fix it. The nil table bug is now completely gone and the addon takes up less memory. Enjoy! :P
EDIT: Make sure to delete the old version.
Last edited by SuranthianH3 : 05-31-10 at 08:57 PM.
|
|
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
05-27-10, 05:14 AM | ||
|
|
|
|
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
05-27-10, 05:03 AM | ||
|
In a mod like this where the user should never need to reset anything in standard usage, there really is no proper time for the mod to be calling collectgarbage(). There is no way for a mod to collect garbage on its own in a "right way". The solution is to not generate so much garbage (or as you put it here, variables) in the first place. Or avoiding generating variables which "cause" the errors. I'm a professional software beta/QA tester for a company in RL, haven't ever bothered to learn LUA thoroughly...heh. Good places to ask on what you can change in the mod to get rid of those nil table errors without resorting to manual garbage collection (or rewriting the mod from scratch): here on WowI in the General Authoring Discussion Forum and/or Lua script help forums. And on WowAce in the Lua Code Discussion forum. Be sure to include the offending code that's generating the error(s). |
|
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
05-26-10, 12:13 PM | ||
|
Maybe a proper usage like when WOULD be a proper time to use the function or a code snippet showing a proper way to do what garbage collect does without "halting" your computer? It just seems the default way isn't deleting the variables fast enough, and this nil table is very frustrating. I've reviewed the code and I see no reason why it's doing this. I REALLY don't want to remake an entire addon just to get rid of one bug and remove 1 line.
Last edited by SuranthianH3 : 05-26-10 at 12:21 PM.
|
|
|
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
05-26-10, 11:41 AM | |
|
Your revision 010 change--BUGFIX - Added garbage collection--is not a good move at all. Addons should never be arbitrarily calling garbage collection on their own (without being prompted by a specific user action in the mod), as is being done in this revision.
For expert discussion on the matter, take a look at this thread: Garbage Collection on UI Load.... Some highlights: From Jerry (author of Talented, Grid2 and others): --"There is no reason for any addon to call this function without user input." --"An addon can not and should not call collectgarbage() because it possibly created a lot of memory that needs collection. There is no addon that is by himself important enough to force the full lua heap to be traversed just to clean up its mess." --"You should understand that garbage memory will be reclaimed by the system even if no addon ever calls collectgarbage() ever. This process is done in small steps, while executing other instructions. It's called the "incremental garbage collection cycle"" --"But the mistake that is made by all the addons (that automatically call collectgarbage() as part of their loading/execution process) is that they assume they know what the user lua heap is and that they are important enough to allow themselves to hang your computer while they do their cleanup." From Xbeeps (author of LibHealComm-3.0 & 4.0, VisualHeal & others): --"Calling collectgarbage deprives the interpreter engine from sensibly collecting the garbage incrementally and slowly in a low priority thread (i.e. it never disturbs the thread that runs the addons), and only forcible running a blocking garbage collect if it really needs to (which does disturb the thread running the addons). The memory released during garbage collection is returned to the pool used by the interpreter only, so you achieve exactly nothing by doing it, except that you always keep more memory idle than you have to, and you expend more high priority cycles collecting garbage than you have to. Addons that collect garbage usually does so because they pretend to think that they know when it is opportune to do so, and they think that if they do it at this oppertune time it will not happen later at a bad time. This way of thought is flawed, because a single addon does not know when it is a good time to spend cycles doing this, and the incremental garbage collection used by Lua is never noticable (as it was in the early days of wow, where the garbage collection was invoked as a blocking call when it ran out of addon memory)." |
|
Zidomo |
View Public Profile |
Send a private message to Zidomo |
Find More Posts by Zidomo |
Add Zidomo to Your Buddy List |
05-03-10, 11:20 AM | ||
|
|
|
|
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
05-03-10, 09:43 AM | ||
A Kobold Labourer
Forum posts: 0
File comments: 8
Uploads: 0
|
|
|
|
darni |
View Public Profile |
Send a private message to darni |
Find More Posts by darni |
Add darni to Your Buddy List |
05-03-10, 09:36 AM | ||
|
|
|
|
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
05-03-10, 07:46 AM | |
A Fallenroot Satyr
Forum posts: 24
File comments: 98
Uploads: 0
|
thanks for the quick update.. um im not sure if im just too early in trying to update but the zip file doesn't seem to be working when i download :S
|
|
ffcloud2000 |
View Public Profile |
Send a private message to ffcloud2000 |
Find More Posts by ffcloud2000 |
Add ffcloud2000 to Your Buddy List |
05-03-10, 07:13 AM | ||
|
Last edited by SuranthianH3 : 05-03-10 at 07:36 AM.
|
|
|
SuranthianH3 |
View Public Profile |
Send a private message to SuranthianH3 |
Find More Posts by SuranthianH3 |
Add SuranthianH3 to Your Buddy List |
https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=satterwc%40gmail%2ecom&lc=US&item_name=Broker%20H3%20DungeonCooldowns¤cy_code=USD&bn=PP%2dDonationsBF%3abtn_donateCC_LG%2egif%3aNonHostedGuest
You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.