Download
(17Kb)
Download
Updated: 01-30-07 04:12 AM
Pictures
File Info
Updated:01-30-07 04:12 AM
Created:unknown
Downloads:8,866
Favorites:29
MD5:

Unit Frame Action Bars  Popular! (More than 5000 hits)

Version: 0.9
by: Jasmeralia [More]

This is a fork of PartyBars by mubari. Both Unit Frame Action Bars and PartyBars are designed as replacements for Discord's popular Group Buttons mod, as GB is not compatible with 2.0 (and Loz is busy working on other things at the moment).

Note:

If you want me to help you with a problem, please help me by telling me what unit frame mod(s) you are using. If you don't, then the amount of help I can give you is virtually nil.

Done:
* Allow support for attaching to unit frames rather than requiring the user to drag each bar over to the frame by hand (not very viable for 40 mans, imho). (Added in v.0.4)
* Allow support for alternative unit frames (such as Perl, aguf, etc) (Added in v.0.4)
* Optimized the XML file considerably using template inheritance
* Added support for XPerl (Added in v.0.5)
* Added initial config window (Added in v.0.6)
* Added a separate hostile target bar (as long as you are not in-combat when changing targets, it will hide the friendly target bar and show the hostile bar). (Added in v.0.6.)
* Fixed the Inner Fire Fade hack (finally-- even tested with my newly leveled priest). No longer requires the spell to be placed on the last button, place it anywhere on the player action bar and it will be faded/unfaded appropriately. (v.0.7)
* Fixed rescaling issues so scale is displayed appropriately. (v.0.7)
* Fixed it so that frames are movable again and added a config option to lock the frames. Note that if you move it and lock the frames it may get moved back by the attachment code-- this is something I need to tweak further. ** No longer accurate. ** (v.0.7)
* Added support for German users of the Inner Fire fading hack. (v.0.8)
* Added /ufab showraid command.(v.0.8)
* Added support (untested) for empty bars to optimize button usage. (v.0.8)
* Added config option to hide party bars in raids. (v.0.8)
* Added code to detect x/y offsets when a frame is dragged and save them. (v.0.9)
* Fixed bug where UFAB would try to autodetect raid frames with main style rather than raid style. (v.0.9)
* Fixed CTUF raid detection and CTUF/XPerl frame name code. (v.0.9)
* Added code to ignore unsupported frame combinations (ToTT and Blizzard UI, etc.) so they will not generate errors/warnings. (v.0.9)
* Added /ufab resetall command. (v.0.9)
* Added /ufab raidreset command. (v.0.9)

Todo:

* Improve support and detection for other unit frames (works best with Perl Classic frames)
* Improve config interface
* Allow support for vertical action bars (so you could have 2-3 bars by each raid frame to keep screen real-estate to a minimum)
* Fix target/empty target frames
* Add config support for controlling number of buttons assigned to bars
* Get rid of the 120 standard button limit
* Add config support for attachment point offsets

Please help me support other unit frames by noting when you get errors about frames being unknown and what frame add-ons you are using. If you can find out the name of the unknown frame, even better.

At this point, unknown frames should default to the standard draggable bar. All known frames should auto-attach themselves correctly. If you get a message about the attachment failing, please note which frame and what add-ons you are using... it's possible either the detection was incorrect, or I got the name of the frame wrong.

AGUF users: I believe that agUF should be properly supported at this time, thanks to DUF's FrameFinder. There does seem to be a timing issue sometimes where UFAB will try to attach to the agUF frame before agUF finishes creating the frame. A simple "/ufab partyreset" should fix this.

XPerl users: I believe that I have the raid frames correct, but please test it out and let me know how it works. (I often code from work and can only do minimal testing.)

Hostile/Friendly target bars: Please let me know how this works out for you all. I can potentially see an issue where you are in-combat and changing from a friendly target to a hostile target and it cannot swap the bar due to the UI Protection Blizzard has implemented. If this is an active issue I am open to suggestions as to how to design a viable workaround (perhaps show both bars and change alpha-colors to make buttons invisible? They would still be clickable but it would be almost like hiding the bar...)

Blank target bar buttons: I'm aware of this issue and am working to resolve it.

Optional Files (0)


Post A Reply Comment Options
Unread 01-06-07, 11:24 AM  
skyflash
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
if (GetNumRaidMembers() > 0) then
for i = 1, 40 do
UFAB_AttachFrame("UFABRaid"..i.."BarFrame", UFAB_FrameName(FRAME_RAID, i, style_main), "raid"..i)
end
else
for i = 1, 40 do
getglobal("UFABRaid"..i.."BarFrame"):Hide()
end
end

copy paste error in your raid code.... should be style_raid, not style_main. Sorry, cant download 0.8 yet.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 10:59 AM  
skyflash
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Error messages

UFAB_AttachFrame: frame2 unknown, displaying UFABRaid11BarFrame

I get the same message for target bars and all other raid bars. I do have CTRA and Discord Unit Frames installed. I don't have time right now, but when I get some I will fix it and tell you how I did it.

Frame Names:

DUF_FocusFrame
DUF_TargetOfTargetFrame
DUF_TargetFrame
DUF_PlayerFrame

CT_RAGroup1UnitButton1
CT_RAGroup1UnitButton2
CT_RAGroup2UnitButton1
...
...
Last edited by skyflash : 01-06-07 at 11:03 AM.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 10:34 AM  
Jasmeralia
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 45
Uploads: 1
Re: How to get Frame Names

Originally posted by skyflash
You write often that you didnt know the name of frames... there is an easy way to get them.

Install Discord Frame Modifier (DFM) and use the frame finder it has included... it will give you the exact frame name with parent and children.... it's great. *g*

There is an updated DFM version that works on 2.0, it's in the Discord general forum...
I will definitely have to give that a whirl, thanks for the heads up!
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 10:30 AM  
skyflash
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Lightbulb How to get Frame Names

You write often that you didnt know the name of frames... there is an easy way to get them.

Install Discord Frame Modifier (DFM) and use the frame finder it has included... it will give you the exact frame name with parent and children.... it's great. *g*

There is an updated DFM version that works on 2.0, it's in the Discord general forum...
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 08:18 AM  
Jasmeralia
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 45
Uploads: 1
Uploaded 0.8. Written at work, so untested. Please report any errors (the exact error message is most helpful) along with what unit frame mods you are using.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 07:51 AM  
Jasmeralia
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 45
Uploads: 1
Originally posted by Deca
Jas,
I'm not sure how to display the raid bar? I tried it in a raid for the first time and cannot get the bar to show up..

Update, I noticed this message when attempting to setup raid:
UFAB_AttachFrame:attaching UFABRaid1BarFrame to Pearl_Raid1 failed:
Perl_Raid1 does not exist.
I don't believe the Perl Raid frames have actually been updated for 2.0 yet.

Originally posted by Deca
I turned off Pearl and went with CT_Raid Assist and got this message:
UFAB_AttachFrame:attaching UFABRaid1BarFrame to CTRAGroup0.21 failed:
CTRAGroup0.21 does not exist.
I'll have to look into this. I got the code for CTRA frames from Raidbars, but didn't test it personally.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 07:47 AM  
Jasmeralia
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 45
Uploads: 1
Re: Little problems I encountered

Originally posted by skyflash
Hi, nice addon...some small things....

1. The translation for "Inner Fire" for german is "Inneres Feuer".. it would be nice, if you could include that one in your two IF clauses in the hacks section, so I don't have to add it myself every update. *g*

Like...

if (name == "Inner Fire" or name == "Inneres Feuer") then
innerfire_found = 1
end

and then the same for the second clause. I think the small amount of text does not require a real localization file, it will be fine this way.
Added in 0.8. I might localize things later, but for now I'll just support translations as they are given to me.

Originally posted by skyflash
2. Your attachment code is not good...

ATTACH_POINT = "TOPLEFT"

if (frame2) then
--DEFAULT_CHAT_FRAME:AddMessage("UFAB_AttachFrame: attaching "..frame1_n.." to "..frame2_n)
frame1:ClearAllPoints()
frame1:SetPoint(ATTACH_POINT, frame2, "BOTTOMLEFT", -10, -10)
frame1:Show()
else

Thats what I did to my version.. basicly, if you do a ''frame1:SetPoint(ATTACH_POINT, frame2)" then whatever you set to ATTACH_POINT will be used on both child and parent for the attach point.... which most of the time, does not work.

Also, we do need an offset, and we do need to change the attach points separately for child and parent, if possible in the config window...
Thanks for the suggestions. I'm not changing the code yet but I fully agree that support for saved offsets needs to be added. I'm also looking to see if I can save the dragged position as a set of offset values.

Originally posted by skyflash
3. There should be an option to autohide the group frames when you are in a raid.
Right now you can do this via "/ufab hideparty", but agreed. The config interface is something I am just now starting to delve into. I can't add too much to it until I can get multiple pages working.

Originally posted by skyflash
If I set the number of buttons to zero, the addon does do unnecessary work, and has error messages coming up. The thing is, I don't need raid buttons right now, and I don't want pets... so I set it to zero. This is not really supported. *g*
Please let me know what errors you get on this, as they will help me improve the mod. I have just added a few tweaks into 0.8 regarding this and will continue to do so as it evolves.

Originally posted by skyflash
5. The method for selecting the button base is really bad... I know, it's from the original, but it really should be changed... everytime someone adds a button to pets or whereever, all the buttons have to be redone, because it does start on a different offset.

One idea would be to start counting backwards from the last button... so if you add a button, it will just extend the number upwards, and all the buttons above it can stay the same... i.e. lets say we only have 10 buttons for the player. So... instead of starting at 120, and having the playerframe at 110, 111, 112... it should set the buttons to 120, 119, 118, 117.. if you know what I mean... :P Then, when we add one button to the players, so that we have 11... it will still be 120, 119, 118, 117 with the new button at 109, instead of changing from 110, 111, 112... to 109, 110, 111, thus invalidating all the buttons that we set up before.

My idea would be: just remove that subtracting thing, and let the player set the base value in the config... so he can sync this addon with his other addons that use buttons... so if he sets 100, your addon uses the buttons 100 to 100 + player*playernum + ... ... and so on.
The right way to do this is to get out of the 120 button limit so I'm not conflicting with other bars. Then I can allocate some 20 buttons per bar and not have it be an issue. That's where I'm focusing my time on right now, not an interim hack that'll just have to be replaced later.

Originally posted by skyflash
6. Feature request... having a few rows per frame would be great! *g* I know it's a lot of work. :P
That's low on the priority list. I definitely want vertical raid bars first.

Originally posted by skyflash
7. I did have lots of errors with the addon not being able to attach to raid frames... there should be more defensive programming, like checking for nil values, not running code that isn't needed and stuff like that. That should at least prevent the addon from dying.

Thats it! Love your mod, now that GB is gone, it brings back some feeling of it. If you need help with coding any of this, let me know.
Please let me know any errors the mod throws. This is my first mod so I'm still getting my feet wet.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 07:21 AM  
Jasmeralia
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 45
Uploads: 1
Re: Re: 0.7 Uploaded

Originally posted by Deca
I can't seem to be able to show my toons bar, even after I type in /ufab showplayer. My chat states "UFAB: Showing player bar", but I cannot see it even when I grab a spell to put in there.

(Edit) - When I turned on Classic Pearl I can now see the player bar...
What unit frame mod were you using before?

Originally posted by Deca
question for you, is there anyway that you know of to see raid bars if your not in a raid?

- Deca
I'll add in a /ufab showraid in 0.8... but it'll show all 40 bars, you realize.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 07:19 AM  
Jasmeralia
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 45
Uploads: 1
Originally posted by Paulbino
I'm having the same problem. I don't use Perl frames. I love this addon, and have gotten quite a few of my friends to use it as well. Can we get a fix for this?
What unit frame are you using?

Originally posted by Paulbino
What is happening is that the drag box for the player bar is hovering on the screen. When I attempt to click and move it it behaves as though I am dragging the screen to look around normally. I also cannot move buttons onto or off of the addon's bar. The "Lock Bars" function is off, and all settings are at their default.
If you are having issues moving action buttons, check that your action bars aren't locked in your interface options-- the option in the UFAB Config window is only to lock/unlock the mobility of the bars, not the buttons on the bars. That's controlled by the Blizzard settings.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 07:16 AM  
Jasmeralia
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 45
Uploads: 1
Originally posted by Deca
I can put spells in the target bar, and they work, just can't see the icons. I see blank boxes.
Also, even though I have the bars locked, they will jump to their start point sometimes.
The target bar is a known issue, see previous posts.

If you read the main post here you will notice the bars jumping is also a known issue.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 06:37 AM  
skyflash
A Kobold Labourer

Forum posts: 0
File comments: 8
Uploads: 0
Little problems I encountered

Hi, nice addon...some small things....

1. The translation for "Inner Fire" for german is "Inneres Feuer".. it would be nice, if you could include that one in your two IF clauses in the hacks section, so I don't have to add it myself every update. *g*

Like...

if (name == "Inner Fire" or name == "Inneres Feuer") then
innerfire_found = 1
end

and then the same for the second clause. I think the small amount of text does not require a real localization file, it will be fine this way.

2. Your attachment code is not good...

ATTACH_POINT = "TOPLEFT"

if (frame2) then
--DEFAULT_CHAT_FRAME:AddMessage("UFAB_AttachFrame: attaching "..frame1_n.." to "..frame2_n)
frame1:ClearAllPoints()
frame1:SetPoint(ATTACH_POINT, frame2, "BOTTOMLEFT", -10, -10)
frame1:Show()
else

Thats what I did to my version.. basicly, if you do a ''frame1:SetPoint(ATTACH_POINT, frame2)" then whatever you set to ATTACH_POINT will be used on both child and parent for the attach point.... which most of the time, does not work.

Also, we do need an offset, and we do need to change the attach points separately for child and parent, if possible in the config window...

3. There should be an option to autohide the group frames when you are in a raid.

4. If I set the number of buttons to zero, the addon does do unnecessary work, and has error messages coming up. The thing is, I don't need raid buttons right now, and I don't want pets... so I set it to zero. This is not really supported. *g*

5. The method for selecting the button base is really bad... I know, it's from the original, but it really should be changed... everytime someone adds a button to pets or whereever, all the buttons have to be redone, because it does start on a different offset.

One idea would be to start counting backwards from the last button... so if you add a button, it will just extend the number upwards, and all the buttons above it can stay the same... i.e. lets say we only have 10 buttons for the player. So... instead of starting at 120, and having the playerframe at 110, 111, 112... it should set the buttons to 120, 119, 118, 117.. if you know what I mean... :P Then, when we add one button to the players, so that we have 11... it will still be 120, 119, 118, 117 with the new button at 109, instead of changing from 110, 111, 112... to 109, 110, 111, thus invalidating all the buttons that we set up before.

My idea would be: just remove that subtracting thing, and let the player set the base value in the config... so he can sync this addon with his other addons that use buttons... so if he sets 100, your addon uses the buttons 100 to 100 + player*playernum + ... ... and so on.

6. Feature request... having a few rows per frame would be great! *g* I know it's a lot of work. :P

7. I did have lots of errors with the addon not being able to attach to raid frames... there should be more defensive programming, like checking for nil values, not running code that isn't needed and stuff like that. That should at least prevent the addon from dying.

Thats it! Love your mod, now that GB is gone, it brings back some feeling of it. If you need help with coding any of this, let me know.
Last edited by skyflash : 01-06-07 at 06:50 AM.
Report comment to moderator  
Reply With Quote
Unread 01-06-07, 12:11 AM  
Deca
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
Jas,
I'm not sure how to display the raid bar? I tried it in a raid for the first time and cannot get the bar to show up..

Update, I noticed this message when attempting to setup raid:
UFAB_AttachFrame:attaching UFABRaid1BarFrame to Pearl_Raid1 failed:
Perl_Raid1 does not exist.


I turned off Pearl and went with CT_Raid Assist and got this message:
UFAB_AttachFrame:attaching UFABRaid1BarFrame to CTRAGroup0.21 failed:
CTRAGroup0.21 does not exist.
Last edited by Deca : 01-06-07 at 12:28 AM.
Report comment to moderator  
Reply With Quote
Unread 01-05-07, 01:17 PM  
Paulbino
A Murloc Raider

Forum posts: 5
File comments: 7
Uploads: 0
I can't seem to be able to show my toons bar, even after I type in /ufab showplayer. My chat states "UFAB: Showing player bar", but I cannot see it even when I grab a spell to put in there.

(Edit) - When I turned on Classic Pearl I can now see the player bar...

question for you, is there anyway that you know of to see raid bars if your not in a raid?


- Deca
I'm having the same problem. I don't use Perl frames. I love this addon, and have gotten quite a few of my friends to use it as well. Can we get a fix for this?

What is happening is that the drag box for the player bar is hovering on the screen. When I attempt to click and move it it behaves as though I am dragging the screen to look around normally. I also cannot move buttons onto or off of the addon's bar. The "Lock Bars" function is off, and all settings are at their default.
Report comment to moderator  
Reply With Quote
Unread 01-05-07, 12:20 PM  
Deca
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
I can put spells in the target bar, and they work, just can't see the icons. I see blank boxes.
Also, even though I have the bars locked, they will jump to their start point sometimes.
Report comment to moderator  
Reply With Quote
Unread 01-05-07, 11:32 AM  
Deca
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
Re: 0.7 Uploaded

Originally posted by Jasmeralia
Ok, tossed up 0.7, which has a lot of fixes. The main thing I need to get working now is the target bar issues and further options in the config window.
I can't seem to be able to show my toons bar, even after I type in /ufab showplayer. My chat states "UFAB: Showing player bar", but I cannot see it even when I grab a spell to put in there.

(Edit) - When I turned on Classic Pearl I can now see the player bar...

question for you, is there anyway that you know of to see raid bars if your not in a raid?


- Deca
Last edited by Deca : 01-05-07 at 11:39 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: