(145Kb)

Updated: 03-15-11 03:47 PM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	03-15-11 03:47 PM
Created:	unknown
Downloads:	65,304
Favorites:	334
MD5:

Scrap (Junk Seller)

Version: 5.5

by: jaliborc [More]

Scrap is no longer maintained on WoWInterface. For the latest release, check Curse.

Description
Scrap sells all your junk when you visit a merchant. What makes it different from other junk selling addons? Mainly, it is:

Intuitive & Easy to use
Mostly Load on Demand
Provides in-game tutorials for quick learning
Supports many plugins which add extra functionality (and the list is always growing)

Plugins

Baggins Scrap - Adds a Scrap filter to Baggins
Combuctor Scrap - Adds a Scrap category to Combuctor
Scrap Cleaner - Deletes your scrap as your bags get full
Scrap Launcher - A DataBroker Launcher for Scrap

Notes

For feedback, support, suggestions and bug reports, feel free to post a comment.
If you wish to translate Scrap to another language, fell free to use this localization tool.
And please consider supporting Scrap with a donation.

Version 5.5

This is the last version of Scrap to be uploaded here at WoWInterface. For now on, Scrap will only be available at Curse.com (http://wow.curse.com/downloads/wow-addons/details/scrap.aspx).

Version 4.2

New attempt to fix nasty bug

Version 4.1

Improved the options menu look
Disabled tutorials for now
Hopefully made a bug fix
Added compatibility to Scrap's new plugin: Scrap Cleaner!

Version 4

Updated for 4.0.1
Scrap will no longer consider soulbound armor which your character will never use junk if you are an enchanter
Tutorials are not working yet

Version 3.1

Scrap will now consider soul-bound equipment items your character can't equip junk by default (careful enchanters!)
Added Chinese and Spanish translations (thanks to thwa and yllelder, respectively)
Other translation updates

Version 3

Tested on 3.3.3 patch
Added German and updated Russian translations (thanks to ckaotik and RustamIrzaev, respectively)

Version 2.2

Added some French translations (thanks to laumacwow)

Version 2.1

Moved the tutorials to a more convenient position on the screen
Added Russian translation (thank you p4tv)

Version 2

Went back to the old options dropdown. Without the junk lists option, the window does not make much sense.
Added new "blizzard-style" tutorials. Stop pressing F3!
Small code changes to allow compatibility with Scrap Launcher

Version 1.2

Fixed a bug breaking SpamSentry
Fixed a bug causing lists to not be saved in some situations
Permanently deleted the old profile data

Version 1.1

Fixed a bug breaking Combuctor_Scrap and Baggins_Scrap

Version 1

New custom icon
Junk lists are now saved per-character (old global profiles will be kept for now, so this change is reversible). If you wish to have profiles, use Reflux.
New option window:
Replaces the old options drop-down
Was built using a new library (Sushi-2.0), so it may be unstable. Feedback is highly welcome
As the junk lists are saved per-character, most of the window's space is empty. Ideas for new options are welcome.
Now items with no sell value can be added to the junk lists
No longer beta

Beta 5.1

Fixed several bugs causing add/remove item functionalities not to work properly

Beta 5

Updated for 3.2
Scrap is going trough a "transitional phase": there are many upcoming changes, which will make Scrap profiles from previous versions incompatible with the new version. An additional addon, Scrap BetaUpdater, has been included, which will make the transition of enUS profiles a smooth process, but users with other clients may find transitioning their junk lists a difficult process. Our apologies, but this will be better for the users on a long term.
Added a new module: Scrap Merchant, which will make the Scrap merchant button load on demand. What does this means? Faster loading and less use of memory and cpu on startup.
Now Scrap does not allows items which can't be sold to the merchant to be added to the junk lists.
Chat messages now behave depending of your chat settings
Removed the profiles chat messages
More changes coming in a close future...

Beta 4.1

Updated TOC for 3.1

Beta 4

Updated for 3.0.2
Scrap now prints how much you profit by selling your junk when you visit the merchant
Fixed a bug causing the buttons to not be correctly placed after using the 'Buypack' tab
Scrap no longer has a 'module API'. Combuctor Scrap and Baggins Scrap now 'hook' Scrap to work properly.
Combuctor Scrap and Baggins Scrap are now separate downloads
Before you start asking, this is still not the version which includes the library I've been working for the last year. That will be a closed beta.

Beta 3

All: Code improvements
Added: Baggins Scrap and Combuctor Scrap

Beta 2

Core: Fixed a bug causing an error message when trying to drag a spell to the Scrap button
Options: Current profile is now checked instead of disabled in the "Set Profile" option

Beta 1

Initial Release

Optional Files (0)

Comment Options

Page 4 of 7

« First

Last »

09-01-09, 09:19 PM
Talyrius An Onyxian Warder Forum posts: 363 File comments: 259 Uploads: 3	Deleted it. Already enabled. ok No errors. ok No errors. ok ok Nothing was printed to the chat window.

09-01-09, 04:13 AM

jaliborc

A Chromatic Dragonspawn

Forum posts: 196

File comments: 329

Uploads: 20

Originally posted by ForeverTheGM
Beta 5.1 is installed. Resetting the Scrap_Settings didn't change anything.

Hum... this is getting hod. Lets try another thing:

Unnistall BetaUpdater if you still have it
Login and make sure you have the option "Show Lua Errors" enabled in the blizzard interface option panel
Type in chat "/run ReloadUI()"
If any message shows up, copy it and post it here. Otherwise, continue to the next step.
Open the merchant window
Repeat step 4
Type in chat "/run Scrap:HookScript('OnReceiveDrag', function() print(GetCursorInfo()) end)"
Drag an item to the Scrap button
Post what appears in the chat window

Last edited by jaliborc : 09-03-09 at 03:32 AM.

08-31-09, 03:27 PM

Talyrius

An Onyxian Warder

Forum posts: 363

File comments: 259

Uploads: 3

Originally posted by jaliborc
Make sure you have Beta 5.1 installed and not Beta 5

Type in chat "/run Scrap_Settings = nil ReloadUI()"

Hope that helps.

Beta 5.1 is installed. Resetting the Scrap_Settings didn't change anything.

08-31-09, 11:44 AM

jaliborc

A Chromatic Dragonspawn

Forum posts: 196

File comments: 329

Uploads: 20

Originally posted by ForeverTheGM
The 'Default' profile is selected.

Dump: Scrap_SV
Scrap_SV=nil,
empty result

Scrap_Settings={
lists={
Default={
}
},
AutoSell=true
}

Make sure you have Beta 5.1 installed and not Beta 5
Type in chat "/run Scrap_Settings = nil ReloadUI()"

Hope that helps.

Last edited by jaliborc : 09-03-09 at 03:32 AM.

08-30-09, 03:59 PM

Talyrius

An Onyxian Warder

Forum posts: 363

File comments: 259

Uploads: 3

Originally posted by jaliborc
Please read the instructions before posting:
Make sure your current character has a junk list selected

Write in the chat "/dump Scrap_SV" and "/dump Scrap_Settings" and report back the results

The 'Default' profile is selected.

Dump: Scrap_SV
Scrap_SV=nil,
empty result

Scrap_Settings={
lists={
Default={
}
},
AutoSell=true
}

08-30-09, 03:36 PM

jaliborc

A Chromatic Dragonspawn

Forum posts: 196

File comments: 329

Uploads: 20

Ok, I'm back, so let's start answering your questions!

Originally posted by antisocialink
Removed 5.1 due to updater issues and attempted reinstalling 4.1 (last version that worked for me)... Now I have a highlighted button that does nothing. Can't press it, can't drag things to it... nothing.

You shouldn't had installed 4.1 version back, you should had followed the instructions I posted right here, on WoWInterface, to help users with the same problem as you:
Write in the chat "/dump Scrap_SV" and "/dump Scrap_Settings" and report back the results.

Try it anyway, but it's more likely that you have simply erased or corrupted your settings when you installed 4.1 back.
Oh, and DO NOT INSTALL VERSION 5 OR ANY OTHER RECENT VERSION!

Originally posted by ForeverTheGM
I'm supposed to pickup an item from my bags and drop it on the Scrap icon at the vendor frame, correct? The icon just stays gray and won't do or say anything no matter how many times I click it with the item on my mouse cursor. It will sell gray items and I can change the options, but I'm definitely not able to add any items to the junk list.

Please read the instructions before posting:

Make sure your current character has a junk list selected
Write in the chat "/dump Scrap_SV" and "/dump Scrap_Settings" and report back the results

Originally posted by Alarisha
Scrap fires a CHAT_MSG_MONEY event when it sells junk at merchants. As this event is a Blizzard event that is only supposed to fire when a unit loots money (i.e. not at a merchant), Auditor doesn't know what to do and gets confused.

I'll put in a check to stop this happening, but in my mind, this is a problem with Scrap firing game events when it shouldn't, and not a problem with Auditor. I am totally open to being shown how I am doing it wrong, though, if I am.

Scrap is not firing an event, it's a library that it uses. And you weren't doing nothing wrong, you were just still using global event variables (arg1, in this case), something that Blizzard now longer uses but still supports in the default event tracking API.
I made the library to fire this events because it was the best way I found to allow Scrap messages to be displayed in any chat frame, even the non-default ones.

08-22-09, 11:59 AM

Alarisha

A Murloc Raider

Forum posts: 4

File comments: 304

Uploads: 1

This is fixed in the just-about-to-be-uploaded Auditor.

08-22-09, 07:56 AM

Alarisha

A Murloc Raider

Forum posts: 4

File comments: 304

Uploads: 1

Originally posted by Jesamyn
OK, I know you won't see this until Sept 1, but thanks for looking at the issue with Auditor. I'll let the author know.

Scrap fires a CHAT_MSG_MONEY event when it sells junk at merchants. As this event is a Blizzard event that is only supposed to fire when a unit loots money (i.e. not at a merchant), Auditor doesn't know what to do and gets confused.

I'll put in a check to stop this happening, but in my mind, this is a problem with Scrap firing game events when it shouldn't, and not a problem with Auditor. I am totally open to being shown how I am doing it wrong, though, if I am.

08-22-09, 04:03 AM
Talyrius An Onyxian Warder Forum posts: 363 File comments: 259 Uploads: 3	I'm supposed to pickup an item from my bags and drop it on the Scrap icon at the vendor frame, correct? The icon just stays gray and won't do or say anything no matter how many times I click it with the item on my mouse cursor. It will sell gray items and I can change the options, but I'm definitely not able to add any items to the junk list.

08-19-09, 09:21 PM
antisocialink A Kobold Labourer Forum posts: 0 File comments: 39 Uploads: 0	Removed 5.1 due to updater issues and attempted reinstalling 4.1 (last version that worked for me)... Now I have a highlighted button that does nothing. Can't press it, can't drag things to it... nothing.

08-14-09, 02:39 PM
Jesamyn <This Space for Rent> Forum posts: 141 File comments: 82 Uploads: 0	OK, I know you won't see this until Sept 1, but thanks for looking at the issue with Auditor. I'll let the author know. __________________ I'm not an idiot. I'm just harmlessly psychotic.

08-14-09, 01:36 PM
jaliborc A Chromatic Dragonspawn Forum posts: 196 File comments: 329 Uploads: 20	Jaliborc is not going to be online for the rest of the month. Any comments posted from the current moment may not be answered until 1 September. This applies to any of Jaliborc's addons.

08-14-09, 12:45 PM

jaliborc

A Chromatic Dragonspawn

Forum posts: 196

File comments: 329

Uploads: 20

Originally posted by Jesamyn
I tried 5.1 today. Adding, removing, and auto-selling works. I do get the below error when I selll items while Auditor is also running. I'm not sure who I should approach about it, so I'm including it in case you are interested. I confirmed the error doesn't happen if Auditor isn't running.

Code:

2009/08/14 09:06:52-3606-x1]: Auditor2-4.0\Core.lua:390: bad argument #1 to 'find' (string expected, got nil) Pretender-1.0\Pretender-1.0.lua:22: in function <...\Scrap_Merchant\Libs\Pretender-1.0\Pretender-1.0.lua:18> <in C code>: ? Pretender-1.0\Pretender-1.0.lua:31: in function `SimulateEvent' Scrap_Merchant\Scrap_Merchant.lua:221: in function `SystemMessage' Scrap_Merchant\Scrap_Merchant.lua:175: in function `SellJunk' Scrap_Merchant\Scrap_Merchant.lua:186: in function `AutoSellJunk' Scrap_Merchant\Scrap_Merchant.lua:62: in function `MERCHANT_SHOW' Scrap_Merchant\Scrap_Merchant.lua:54: in function `CreateButton' Scrap_Merchant\Scrap_Merchant.lua:242: in main chunk <in C code>: in function `LoadAddOn' Scrap-Beta 5\Scrap.lua:25: in function `LoadModule' Scrap-Beta 5\Scrap.lua:60: in function `?' Scrap-Beta 5\Scrap.lua:18: in function <Interface\AddOns\Scrap\Scrap.lua:18>

Thanks for the fix!

Ok, I will look into that. It appears that Pretender-1.0, a new library which I created for our mods, is conflicting with Auditor.

EDIT: I've downloaded Auditor and looked at the code. The problem is that Auditor "is using global variables for the events, system that has been deprecated by blizzard, instead of passing them trough the functions". I can't fix anything. The only solution is to contact Auditor's author and tell him just that.

Last edited by jaliborc : 08-14-09 at 01:23 PM.

08-14-09, 10:20 AM

Jesamyn

Forum posts: 141

File comments: 82

Uploads: 0

I tried 5.1 today. Adding, removing, and auto-selling works. I do get the below error when I selll items while Auditor is also running. I'm not sure who I should approach about it, so I'm including it in case you are interested. I confirmed the error doesn't happen if Auditor isn't running.

Code:

2009/08/14 09:06:52-3606-x1]: Auditor2-4.0\Core.lua:390: bad argument #1 to 'find' (string expected, got nil)
Pretender-1.0\Pretender-1.0.lua:22: in function <...\Scrap_Merchant\Libs\Pretender-1.0\Pretender-1.0.lua:18>
<in C code>: ?
Pretender-1.0\Pretender-1.0.lua:31: in function `SimulateEvent'
Scrap_Merchant\Scrap_Merchant.lua:221: in function `SystemMessage'
Scrap_Merchant\Scrap_Merchant.lua:175: in function `SellJunk'
Scrap_Merchant\Scrap_Merchant.lua:186: in function `AutoSellJunk'
Scrap_Merchant\Scrap_Merchant.lua:62: in function `MERCHANT_SHOW'
Scrap_Merchant\Scrap_Merchant.lua:54: in function `CreateButton'
Scrap_Merchant\Scrap_Merchant.lua:242: in main chunk
<in C code>: in function `LoadAddOn'
Scrap-Beta 5\Scrap.lua:25: in function `LoadModule'
Scrap-Beta 5\Scrap.lua:60: in function `?'
Scrap-Beta 5\Scrap.lua:18: in function <Interface\AddOns\Scrap\Scrap.lua:18>

Thanks for the fix!

__________________
I'm not an idiot. I'm just harmlessly psychotic.

08-13-09, 09:08 PM
Jesamyn <This Space for Rent> Forum posts: 141 File comments: 82 Uploads: 0	I was having the same problem (not seeing my Scrap button), so I just deleted all of my Scrap saved variables (global and char-specific). Now I have a Scrap button, and when I drop something onto it, it tells me that it was added, and the button greys out. I have 'Default' selected as the list. If I drop the same item on the button, it tells me that the item is removed, and the button remains greyed out. If I close the merchant window and re-open it, the button still remains greyed out. Here are my results from the commands below. I had dropped an item on the button and verified that it said it was added, but haven't logged out, so no SV Code: Dump: Scrap_SV Scrap_SV=nil, empty result Dump: Scrap_Settings Scrap_Settings={ lists={ Default={ [40195]=true } }, AutoSell=true } The item id is correct for the one that I dropped onto the button (Pygmy Oil). __________________ I'm not an idiot. I'm just harmlessly psychotic. Last edited by Jesamyn : 08-14-09 at 10:03 AM.

Page 4 of 7

« First

Last »

Due to the significant time which is necessary to develop and keep addons up to date, donations to support this project are welcome. If you wish to help, anything is appreciated. Thank you for your support!

Report this File

Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.

[Disable these notices]