Quantcast
Download
(15 Kb)
Download
Updated: 08-12-18 12:26 PM
Compatibility:
Battle for Azeroth (8.0.1)
Updated:08-12-18 12:26 PM
Created:04-01-17 01:27 PM
Downloads:2,194
Favorites:39
MD5:
8.0.1

Ara Broker Reputations

Version: r32
by: vikingking [More]

I've overhauled the Addon to support the current expansion, this includes BfA

Check change log for list of fixes/changes

Original Addon is here: http://wowinterface.com/downloads/in...putations.html

r32
  • Fixed bug when selecting the option to Sort by Reputation in the tooltip

r31
  • Removed Block Display -> Text -> Faction Text Color as Rep Color option
  • Added Block Display -> Text -> Faction Name Color radio button
  • Faction Name Color is a radio button option that can be No Color, Blizzard Color, ASCII Color

r30
  • Added Block Display -> Text -> Faction Text Color as Rep Color option
  • Unchecking Faction Text Color as Rep Color sets the name of faction in broker to uncolored
  • Restored BlizzColors color palette.
  • Added Color Options options menu.
  • Color Options -> Use Blizzard colors for broker will use Blizzard Color palette for broker
  • Color Options -> Use Blizzard colors for tooltip will use Blizzard Color palette for tooltip rep table
  • Color Options -> Reload Blizzard colors on startup
  • Reload Blizzard colors on startup always pulls Blizzard palette from the system when checked, will overwrite/reset user changes to Blizzard colors
  • When not checked, Reload Blizzard colors on startup pulls Blizzard colors from user settings for addon
  • Changes to Blizzard colors are only saved to user settings
  • Changes to Blizzard colors are not saved back to client due to API restriction that was causing errors during combat.

r27
  • Removed BlizzColors color palette, no need for 2 color palettes if Blizzard is restricting access to the default palette. This was causing errors going into combat in some cases.

r26
  • Bumped TOC for BfA

r25
  • Added reputation from Death of Chromie scenario to Friends so displays ranks properly

r24
  • Updated code to fix database issues if you were using Ara_Broker_Reputations prior to r20. No longer a need to remove your preferences.
  • Corrected reputation reporting when Paragon rep rolls over from level to level.
  • Corrected issue with Paragon session gains going negative when Paragon rep rolls over from level to level.
  • Corrected issue with setting color from the color swatch on the drop down menu that was in the addon prior to r20.

r23
  • Fixed error on startup and when selecting reps if you had a specific reputation ID on your character.

r22
  • Fixed custom tooltip data entry issue in the configuration settings
  • Fixed Paragon reputation session numbers (starting numbers were off)

r21
  • Reputation on bar not being updated for Paragon factions is fixed
  • Changing settings on bar (percentage/rep to go) now works properly for Paragon factions
  • Corrected possible error when going to a Paragon faction if no watched faction was set

r20
  • For reputations that support paragon, it now changes to "Paragon" and tracks the rep as you progress
  • For Exalted reps, removed the numeric display. This echoes how the Blizz rep tracker is doing it
  • Added support in options for setting Paragon color
  • Updated right-click functionality to support added Paragon/Exalted changes
  • Updated bar display functionality to support added Paragon/Exalted changes
  • Fixed a problem when loading it would revert a Paragon rep to an Exalted rep in the display
Archived Files (10)
File Name
Version
Size
Author
Date
r31
15kB
vikingking
08-11-18 06:11 PM
r30
15kB
vikingking
08-06-18 09:49 PM
r27
14kB
vikingking
08-06-18 01:31 PM
r26
15kB
vikingking
08-06-18 11:42 AM
r25
15kB
vikingking
06-22-17 08:03 AM
r24
15kB
vikingking
04-11-17 09:57 AM
r23
15kB
vikingking
04-02-17 06:24 PM
r22
15kB
vikingking
04-02-17 10:29 AM
r21
15kB
vikingking
04-01-17 11:54 PM
r20
15kB
vikingking
04-01-17 01:27 PM


Post A Reply Comment Options
Unread 08-31-18, 06:03 PM  
Jzar
A Chromatic Dragonspawn
 
Jzar's Avatar
AddOn Author - Click to view AddOns

Forum posts: 158
File comments: 281
Uploads: 5
Bless you for this!
Report comment to moderator  
Reply With Quote
Unread 08-19-18, 12:42 PM  
Vedma
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 10
Uploads: 1
The new addon works flawlessly. Thanks a lot.
Report comment to moderator  
Reply With Quote
Unread 08-13-18, 08:47 AM  
vikingking
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 43
Uploads: 5
Originally Posted by VincentSDSH
Originally Posted by vikingking
Hmm, introduce a third color palette?

I'll review it. In the meantime, you could set either the ASCII palette or the Blizzard palette to the desired color and select that.
Sure, they're on sale this week. (I've already coded a custom solution for that but I know I can't be the only one who'd like to select a static color for the names)
Not saying I won't get to it, but on the priority list, it's pretty low. I'm actually revisiting a lot of the older code and trying to fix up some other issues.
Report comment to moderator  
Reply With Quote
Unread 08-12-18, 06:38 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 345
File comments: 256
Uploads: 14
Originally Posted by vikingking
Hmm, introduce a third color palette?

I'll review it. In the meantime, you could set either the ASCII palette or the Blizzard palette to the desired color and select that.
Sure, they're on sale this week. (I've already coded a custom solution for that but I know I can't be the only one who'd like to select a static color for the names)
__________________
AddonsExecutive Assistant User Configurable To-Do ListLegible Mail Choose the Font for Your Mail
Report comment to moderator  
Reply With Quote
Unread 08-12-18, 03:38 PM  
vikingking
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 43
Uploads: 5
Originally Posted by vikingking
Originally Posted by VincentSDSH
re r31: love the color choices for the faction name. One request: could 'no color' be changed to a user-selected color?

Hmm, introduce a third color palette?

I'll review it. In the meantime, you could set either the ASCII palette or the Blizzard palette to the desired color and select that.

I looked this over, I'm not inclined to change this right now unless there are more calls for it. There are a couple ways you could handle this on your own if you like, you can use my suggestion above. Alternatively, if you open the Ara_Broker_Reputations.lua file, you can look at the value of defaultColor. This is the color used for "No Color". You could hand code this RGB value to a value of your choosing and then save the file. Then choose the "No Color" option.


The reason I don't want to undertake it at this time is because when I did some prototypes, it looks like I'd have to completely overhaul the color picker code to make this work for a single value color palette. I'm not sure I want to do that right now for a single option.
Last edited by vikingking : 08-12-18 at 03:39 PM.
Report comment to moderator  
Reply With Quote
Unread 08-12-18, 12:29 PM  
vikingking
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 43
Uploads: 5
Originally Posted by vikingking
Originally Posted by Pseudopath
Anyway, using that issue appears okay but with the latest version, expanding 'classic' (with exodar as exalted, gnomeregan and stormwind too):

Hope that helps.

And as always I appreciate you keeping this up to date!

Regards,

Sudo
Looks like there is a bug in the "Sort by Rep" option. I was able to reproduce the error, now I need to fix it. While I work on it, if you turn off "Sort by Rep" option in the config, it will prevent the error from occurring for now.

Fixed in r32. There was leftover code that was sorting by numeric values in the sort routine. Exalted and Best Friend now return no numeric value. So, when it detects Exalted or Best Friend reps, it sorts them alphabetically together under the same sub heading.
Report comment to moderator  
Reply With Quote
Unread 08-12-18, 09:51 AM  
vikingking
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 43
Uploads: 5
Originally Posted by Pseudopath
Originally Posted by vikingking
Originally Posted by Pseudopath
</snip>
thanks

Sudo
Can you provide your list of reputations? Have you tried this with r25 and as the only addon? I can't reproduce this on any of my alts, but I have found that it's because sometimes I don't have a certain rep that other users have. Providing me a list of you factions might help run this down. I don't think this is the same as the color palette issue, it's in code that is meant to display the factions.
Apologies, I didnt see this reply, I've either disabled it or wowinterface doesnt provide those notifications.

Anyway, using that issue appears okay but with the latest version, expanding 'classic' (with exodar as exalted, gnomeregan and stormwind too):

Hope that helps.

And as always I appreciate you keeping this up to date!

Regards,

Sudo
Looks like there is a bug in the "Sort by Rep" option. I was able to reproduce the error, now I need to fix it. While I work on it, if you turn off "Sort by Rep" option in the config, it will prevent the error from occurring for now.
Last edited by vikingking : 08-12-18 at 09:51 AM.
Report comment to moderator  
Reply With Quote
Unread 08-12-18, 02:44 AM  
Pseudopath
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 80
Uploads: 1
Originally Posted by vikingking
Originally Posted by Pseudopath
</snip>
thanks

Sudo
Can you provide your list of reputations? Have you tried this with r25 and as the only addon? I can't reproduce this on any of my alts, but I have found that it's because sometimes I don't have a certain rep that other users have. Providing me a list of you factions might help run this down. I don't think this is the same as the color palette issue, it's in code that is meant to display the factions.
Apologies, I didnt see this reply, I've either disabled it or wowinterface doesnt provide those notifications.

Anyway, using that issue appears okay but with the latest version, expanding 'classic' (with exodar as exalted, gnomeregan and stormwind too):

Code:
15x ...ns\Ara_Broker_Reputations\Ara_Broker_Reputations-r31.lua:416: attempt to compare two nil values
...ns\Ara_Broker_Reputations\Ara_Broker_Reputations-r31.lua:416: in function <...ns\Ara_Broker_Reputations\Ara_Broker_Reputations.lua:411>
[C]: in function `sort'
...ns\Ara_Broker_Reputations\Ara_Broker_Reputations-r31.lua:428: in function <...ns\Ara_Broker_Reputations\Ara_Broker_Reputations.lua:252>
...ns\Ara_Broker_Reputations\Ara_Broker_Reputations-r31.lua:529: in function `OnEnter'
ChocolateBar\Chocolate.lua:216: in function <ChocolateBar\Chocolate.lua:186>

Locals:
a = <unnamed> {
 0 = <userdata>
 values = <unnamed> {
 }
 fs = <unnamed> {
 }
 rep = <table> {
 }
 togo = <unnamed> {
 }
 faction = <unnamed> {
 }
 session = <unnamed> {
 }
 bg = <unnamed> {
 }
 icon = <unnamed> {
 }
 bar = <unnamed> {
 }
}
b = <unnamed> {
 0 = <userdata>
 values = <unnamed> {
 }
 fs = <unnamed> {
 }
 rep = <table> {
 }
 togo = <unnamed> {
 }
 faction = <unnamed> {
 }
 session = <unnamed> {
 }
 bg = <unnamed> {
 }
 icon = <unnamed> {
 }
 bar = <unnamed> {
 }
}
aRep = "Exalted"
bRep = "Exalted"
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Exalted"
(*temporary) = "attempt to compare two nil values"
Hope that helps.

And as always I appreciate you keeping this up to date!

Regards,

Sudo
Report comment to moderator  
Reply With Quote
Unread 08-12-18, 12:37 AM  
Ookami.kun
A Cliff Giant
 
Ookami.kun's Avatar

Forum posts: 76
File comments: 234
Uploads: 0
Thanks for keeping this up to date. I'm unsure if it's possible, but any chance of updating all the other Ara Broker addons? Guild/Friends and Tradeskills don't seem to function correctly with 8.0.1, and Reputations Alt does seem to work, but it might be time to update it to the current expansion since it hasn't been updated in about 7 years. Thanks.
__________________
Report comment to moderator  
Reply With Quote
Unread 08-11-18, 11:14 PM  
vikingking
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 43
Uploads: 5
Originally Posted by VincentSDSH
re r31: love the color choices for the faction name. One request: could 'no color' be changed to a user-selected color?

Hmm, introduce a third color palette?

I'll review it. In the meantime, you could set either the ASCII palette or the Blizzard palette to the desired color and select that.
Report comment to moderator  
Reply With Quote
Unread 08-11-18, 11:11 PM  
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view AddOns

Forum posts: 345
File comments: 256
Uploads: 14
re r31: love the color choices for the faction name. One request: could 'no color' be changed to a user-selected color?
__________________
AddonsExecutive Assistant User Configurable To-Do ListLegible Mail Choose the Font for Your Mail
Report comment to moderator  
Reply With Quote
Unread 08-07-18, 11:42 AM  
LadySilverwolf
Premium Member
 
LadySilverwolf's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 38
File comments: 67
Uploads: 2
Thanks for maintaining this. Been using this addon for years and its just easy on the eyes and yet full of info. Thank you again
__________________
~ Strength of Character withstands the Test of Time. ~
Report comment to moderator  
Reply With Quote
Unread 08-06-18, 10:04 PM  
vikingking
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 43
Uploads: 5
r30 Color Palette Changes

Due to several PM requests, I have restored the BlizzardColors palette, but I had to make some changes to how the color system works.

The following options have been added in r30:
Block Display -> Text -> Faction Text Color as Rep Color option
Blizzard Colors
Color Options
Use Blizzard colors for broker
Use Blizzard colors for tooltip
Reload Blizzard colors on startup
So, on initial startup and in the default config, the Blizzard colors are pulled from the server/client.
When "Reload Blizzard colors on startup" is checked, the Blizzard colors are pulled from the system whenever the addon is loaded. Any changes made to the Blizzard color palette will not be saved back to the server/client due to a new API restriction to FACTION_BAR_COLORS that was causing errors when saving. Having this option on will also overwrite any changes made to the Blizzard color palette that was saved in the DB.
When "Reload Blizzard colors on startup" is not checked, then the initial set of Blizzard colors is pulled from the system/client, but the user can make changes. The changes are saved in the Ara_Broker_Reputations db, and will be reloaded from the db on startup.

With the other color options, you can now choose between the ASCII colors and Blizzard colors for either the tooltip or broker display.

When the Faction Text Color as Rep Color option when setting the broker to Text, you can choose to have the name of the faction (i.e. Orgrimmar) colored or not. The actual rep standing will still use the color option palette you have selected for the broker.

This has been working for me and hasn't caused any errors in combat. Please report any issues with this release.
Report comment to moderator  
Reply With Quote
Unread 08-06-18, 01:33 PM  
vikingking
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 43
Uploads: 5
Originally Posted by bazelle
Error I get...

This doesn't change any thing in the mod and everything else works fine. Still a great mod! Many thanks.

Hope this helps.
I've uploaded r27, which removes the Blizzard Colors palette entirely. No need for it. Your fix just disables it, but still allows the user to play with it in the options. If we can't update the default colors due to restrictions anymore, then there is no need for a second color palette at all.
Report comment to moderator  
Reply With Quote
Unread 08-06-18, 01:22 PM  
bazelle
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 20
Uploads: 1
Error I get...

5x [ADDON_ACTION_BLOCKED] AddOn 'Ara_Broker_Reputations' tried to call the protected function 'MainMenuBar:SetPoint()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]: in function `SetPoint'
FrameXML\UIParent.lua:2943: in function `UIParentManageFramePositions'
FrameXML\UIParent.lua:2326: in function <FrameXML\UIParent.lua:2313>
[C]: in function `SetAttribute'
FrameXML\UIParent.lua:3115: in function <FrameXML\UIParent.lua:3113>
[C]: in function `UIParent_ManageFramePositions'
FrameXML\MainMenuBar.lua:172: in function <FrameXML\MainMenuBar.lua:149>
[C]: in function `MainMenuBarVehicleLeaveButton_Update'
FrameXML\MainMenuBar.lua:146: in function <FrameXML\MainMenuBar.lua:145>

Locals:
InCombatSkipped


All I did was to replace your code at line '20 blizzardColors = FACTION_BAR_COLORS,'
with blizzards own colours! then, edit out line 893 -- FACTION_BAR_COLORS = blizzColors.
The only two reference to 'FACTION_BAR_COLORS'.
With my altertions, no more errors.

Here my eddited lines

20 blizzardColors = FACTION_BAR_COLORS

to

20 blizzardColors = {
[1] = {r = 0.80, g = 0.13, b = 0.13}, -- Hated
[2] = {r = 1.00, g = 0.00, b = 0.00}, -- Hostile
[3] = {r = 0.93, g = 0.40, b = 0.13}, -- Unfriendly
[4] = {r = 1.00, g = 1.00, b = 0.00}, -- Neutral
[5] = {r = 0.00, g = 1.00, b = 0.00}, -- Friendly
[6] = {r = 0.00, g = 1.00, b = 0.53}, -- Honored
[7] = {r = 0.00, g = 1.00, b = 0.80}, -- Revered
[8] = {r = 0.00, g = 1.00, b = 1.00}, -- Exalted
[9] = {r = 0.25, g = 0.41, b = 0.88}, -- Paragon
},

(may have moved to aboout line 903)
893 FACTION_BAR_COLORS = blizzColors

to

893-- FACTION_BAR_COLORS = blizzColors
or delete it.

This doesn't change any thing in the mod and everything else works fine. Still a great mod! Many thanks.

Hope this helps.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: