(2Kb)

Updated: 12-23-22 05:49 AM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Compatibility:	Dragonflight (10.0.2)
Updated:	12-23-22 05:49 AM
Created:	07-30-19 06:41 PM
Downloads:	1,410
Favorites:	10
MD5:

Compact Vendor Filter (This module is obsolete since Dragonflight)

Version: v10.0.2.221223

by: Vlad [More]

Official repository can be found at GitHub.

Compact Vendor converts your vendor frame into a compact scrollable list with a search box.

Inspiration drawn from Yssaril's GoblinVendorFilter.

Note that this addon module has been merged into the main addon CompactVendor since Dragonflight.

CompactVendorFilter is now part of CompactVendor (It's safe to delete me!)
v10.0.2.221223 (2022-12-23)
Full Changelog Previous Releases

Merge pull request #2 from Vladinator/feature/df
Dragonflight and v2 rewrite
We have moved the addon module into the main addon. This module now contains nothing except information on the fact it is safe to be deleted.
TOC bump
Avoid overlapping refreshes.
TOC bump
Added accumulative dropdown option to better support the stats style of checkboxes.
Adjusted the filters. Stats needs more scaffolding work to function.
Fixed a nil issue/check.
Filters seem fine, except the stats one.
Reimplemented the filters. Consider making affordable/usable the same way as we did appearance. Make a wrapper for that style of option.
Fixed filter logic issues.
Fixed issue with internal merchant items table state. Relying on the data provider to give us the full items available.
Implemented some basic templates and functionality filters.
Adjusted some logical errors.
The filter is added to the merchant datra provider on load.
Revamping the filter module to function with the new core addon.
Revamped the filters to utilize the new itemData table of information.

Optional Files (0)

Archived Files (2)

File Name	Version	Size	Author	Date
Compact Vendor Filter	v10.0.0.221026	14kB	Vlad	10-26-22 02:17 PM
Compact Vendor Filter	v9.2.7.220917	14kB	Vlad	09-17-22 09:14 AM

Comment Options

10-15-20, 02:55 PM

Vlad

A Molten Giant

Forum posts: 793

File comments: 337

Uploads: 31

Re: Issues with tooltip hooks

Originally Posted by brykrys

Please could you look again at how you set hooks on GameTooltip-type objects?

I see you have hooked SetMerchantItem and SetMerchantCostItem (to set a flag called EnableHooks), and these hooks are applied to every GameTooltip-type object.

However the hooks are not calling back the correct old function in every case, they all call back the old function from GameTooltip itself.

This is a problem if any other AddOn has hooked these functions before you:

For example if an AddOn has hooked SetMerchantItem only on the GameTooltip, and expects the function to be called only from GameTooltip itself, it may cause unexpected errors when called from other tooltip objects.

Alternatively if an AddOn has applied a special version of SetMerchantItem to a particular tooltip other than GameTooltip itself, your hook will simply remove this special version.

Thanks for the heads up, you are right that this isn't good enough. I will have to create new functions per widget and store their original function whatever they might be in order to avoid hooking issues the way its done right now.

I believe this commit fixes this particular issue: https://github.com/Vladinator89/wow-...1dc9fcbdc04afd

__________________
Profile: Curse | Wowhead

Last edited by Vlad : 10-15-20 at 03:02 PM.

07-27-20, 07:37 AM
brykrys A Deviate Faerie Dragon Forum posts: 13 File comments: 85 Uploads: 3	Issues with tooltip hooks Please could you look again at how you set hooks on GameTooltip-type objects? I see you have hooked SetMerchantItem and SetMerchantCostItem (to set a flag called EnableHooks), and these hooks are applied to every GameTooltip-type object. However the hooks are not calling back the correct old function in every case, they all call back the old function from GameTooltip itself. This is a problem if any other AddOn has hooked these functions before you: For example if an AddOn has hooked SetMerchantItem only on the GameTooltip, and expects the function to be called only from GameTooltip itself, it may cause unexpected errors when called from other tooltip objects. Alternatively if an AddOn has applied a special version of SetMerchantItem to a particular tooltip other than GameTooltip itself, your hook will simply remove this special version.

09-10-19, 11:03 AM
AnrDaemon A Chromatic Dragonspawn Forum posts: 156 File comments: 2231 Uploads: 5	Would you mind fixing the link on the front page? https://www.wowinterface.com/downloa...dorFilter.html

Report this File

Category Jump: