Download
(125Kb)
Download
Updated: 09-06-19 09:09 AM
Pictures
File Info
Compatibility:
Classic (1.13.2)
Updated:09-06-19 09:09 AM
Created:09-04-19 12:00 PM
Downloads:16,267
Favorites:69
MD5:

Easy Fishing Classic  Popular! (More than 5000 hits)

Version: 1.2
by: Firedancer [More]

This AddOn enables double-right-click to cast for Fishing when a fishing pole is equipped. Additionally, it will disable Click To Move while a fishing pole is equipped, and re-enable it when the fishing pole is unequipped. There are options to turn off Ambience and Music while a fishing pole is equipped (and turn them back on when you unequip the fishing pole) as well as enabling Auto Loot while fishing (if you normally keep it turned off). All options are ENABLED by default.

You're currently on your own for applying fishing lures - if I can figure out a good way to do it, I'll add it in the future.

Disclaimer: My testing character is a level 10 Gnome with a fishing skill of 50 using a vendor bought Fishing Pole. I have tested this to the best of that character's abilities, but something might be wonky. Please let me know if you encounter any trouble!

Credits: Ammo for FishermansFriend, which this is based on.

v1.2
Rewritten using FishermansFriend as the base; now has in-game options!

v1.1a
Disable sound changes by default (forgot to reset it before I zipped)

v1.1
Disable click to move when a fishing pole is equipped - thanks MoopMoom!
Fix fishing pole lookup

v1.0
Initial release
Optional Files (0)


Post A Reply Comment Options
Unread 09-04-19, 02:29 PM  
Whyspir
A Defias Bandit

Forum posts: 2
File comments: 6
Uploads: 0
Thank You

Just want to be the First to say THANK YOU!
I do not see the settings in my _classic_\WTF\Config.wtf to change.
(local sound = false)
do I need to add it?
Report comment to moderator  
Reply With Quote
Unread 09-04-19, 02:57 PM  
Whyspir
A Defias Bandit

Forum posts: 2
File comments: 6
Uploads: 0
Actually it is not working at all.
shows up ok in addOns.
Double right click does nothing
Report comment to moderator  
Reply With Quote
Unread 09-04-19, 06:18 PM  
spamplz
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Does nothing.
Report comment to moderator  
Reply With Quote
Unread 09-04-19, 09:22 PM  
Jasmer
A Flamescale Wyrmkin
 
Jasmer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 122
File comments: 155
Uploads: 4
Working so far. Thanks.
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 12:21 AM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 59
Uploads: 2
Re: Thank You

Originally Posted by Whyspir
Just want to be the First to say THANK YOU!
I do not see the settings in my _classic_\WTF\Config.wtf to change.
(local sound = false)
do I need to add it?
Just to be clear, you don't change the WTF. You can find the numbers for your volume settings there, and then plug them into the Restore Sound part so that your settings go back to your usual default for things.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 12:23 AM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 59
Uploads: 2
Originally Posted by spamplz
Does nothing.
Do you know Fishing and have a fishing pole equipped when you attempt to cast? If so, could you tell me the spellID for your fishing skill and the itemID for your fishing pole (or just their names and rank if you don't have the IDs in your tooltip) so I can see if I missed something? I only tested it with a regular Fishing Pole on a level 10 Gnome with 50 fishing skill.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 12:25 AM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 59
Uploads: 2
Originally Posted by Jasmer
Working so far. Thanks.
You're welcome! Please let me know if you run into any snags. I'm still in the 'I can't decide who to play' stage of things, so I have a bunch of level 10s, which only grants me a basic pole and Journeyman Fishing.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 05:16 AM  
Mark the betrayer
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
I can confirm it works with expert fishing and normal fishing rod but not with strong fishing pole (ItemID:6365)
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 06:43 AM  
djm1609
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Only Working with the normal Fishing Pole (ID 6256). I couldn't get it to work with the Blump Family Fishing Pole (ID 12225).

Changing this line in fish.lua:

Code:
local function IsFishPole()
	local itemId = GetInventoryItemID("player", 16)
>>	if itemId == (6256 or 12225 or 6365 or 6367 or 19022 or 19970) then
		return true
	else
		return false
	end
end
to

Code:
if itemId == 6256 or itemId == 12225 or itemId == 6365 or itemId == 6367 or itemId == 19022 or itemId == 19970 then
fixes it. Not tested with the others because I don't own yet
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 08:28 AM  
MoopMoom
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
If you have "Right click to move" turned on by default, this addon won't work. I made a fix - and also fixed some fishing poles not working.

Code:
--[[ based on the sFishing addon by Coolkid; fixed to work in Classic by Firedancer ]]--
local knowFish = false
local spell = GetSpellInfo(7620) or GetSpellInfo(7731) or GetSpellInfo(7732) or GetSpellInfo(18248)
local isPole = false
local holder = CreateFrame("Frame", nil, UIParent)

local sound = false -- set to false if you don't want to override your sound settings
local clicktomove = true -- set to false if you don't want to change the settings for click to move depending if you have a fishing pole equipped or not
--[[ turn on master/sfx (bobber sound) and turn off music/ambience ]]--
local function EnhanceSound()
	SetCVar("Sound_MasterVolume", 1)
	SetCVar("Sound_SFXVolume", 1.0)
	SetCVar("Sound_MusicVolume", 0.0)
	SetCVar("Sound_AmbienceVolume", 0.0)
end
--[[ reset all values to default // find your values in _classic_\WTF\Config.wtf ]]--
local function RestoreSound()
	SetCVar("Sound_MasterVolume", 1)
	SetCVar("Sound_SFXVolume", 1)
	SetCVar("Sound_MusicVolume", 1)
	SetCVar("Sound_AmbienceVolume", 1)
end
local function ClickToMoveDisable()
	SetCVar("AutoInteract", 0)
end
local function ClickToMoveEnable()
	SetCVar("AutoInteract", 1)
end

local function ResetOverride()
	btn.holder:Hide()
	ClearOverrideBindings(btn)
end

local function ClickHandled(self)
	ResetOverride()
end
local function OverrideClick()
	SetOverrideBindingClick(btn, true, "BUTTON2", "FishHolder")
	btn.holder:Show()
end
btn = CreateFrame("Button", "FishHolder", holder, "SecureActionButtonTemplate")
btn.holder = holder
btn:EnableMouse(true)
btn:RegisterForClicks("RightButtonUp")
btn:Show()

holder:SetPoint("LEFT", UIParent, "RIGHT", 10000, 0)
holder:SetFrameStrata("LOW")
holder:Hide()
btn:SetScript("PostClick", ClickHandled)

local function IsFishPole()
	local itemId = GetInventoryItemID("player", 16)
if itemId == 6256 or itemId == 12225 or itemId == 6365 or itemId == 6367 or itemId == 19022 or itemId == 19970 then

		return true
	else
		return false
	end
end
local lastClickTime = nil
local function CheckForDoubleClick()
	if lastClickTime then
		local pressTime = GetTime()
		local doubleTime = pressTime - lastClickTime
		if ( (doubleTime < 0.4) and (doubleTime > 0.05) ) then
			lastClickTime = nil
			return true
		end
	end
	lastClickTime = GetTime()
	return false
end
local function OnMouseDown(...)
	local button = select(2, ...)
	if button == "RightButton" and not InCombatLockdown() and CheckForDoubleClick() and knowFish and isPole then
		btn:SetAttribute("type", "spell")
		btn:SetAttribute('spell', spell)
		OverrideClick()
	end
end
btn:RegisterEvent("PLAYER_ENTERING_WORLD")
btn:RegisterEvent("PLAYER_EQUIPMENT_CHANGED")
btn:SetScript("OnEvent", function(self, event)
	if event == "PLAYER_ENTERING_WORLD" then
		self:UnregisterEvent("PLAYER_ENTERING_WORLD")
		if (IsSpellKnown(7620)) or (IsSpellKnown(7731)) or (IsSpellKnown(7732)) or (IsSpellKnown(18248)) then
			knowFish = true
			WorldFrame:HookScript("OnMouseDown", OnMouseDown)
		end
		isPole = IsFishPole()
		if isPole and (sound == true) then EnhanceSound() else RestoreSound() end
		if isPole and (clicktomove == true) then ClickToMoveDisable() else ClickToMoveEnable() end
	end
	if event == "PLAYER_EQUIPMENT_CHANGED" then
		isPole = IsFishPole()
		if isPole and (sound == true) then EnhanceSound() else RestoreSound() end
		if isPole and (clicktomove == true) then ClickToMoveDisable() else ClickToMoveEnable() end
	end
end)
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 09:19 AM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 59
Uploads: 2
Thank you for the comments about the poles and about click to move. I don't use click to move, so I was unaware about that issue. I used a different solution to resolve it (which doesn't require a file edit by the user), but I really do appreciate the help!! A new file should be available shortly.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Last edited by Firedancer : 09-05-19 at 10:54 AM.
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 11:27 AM  
spamplz
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Originally Posted by Firedancer
Do you know Fishing and have a fishing pole equipped when you attempt to cast? If so, could you tell me the spellID for your fishing skill and the itemID for your fishing pole (or just their names and rank if you don't have the IDs in your tooltip) so I can see if I missed something? I only tested it with a regular Fishing Pole on a level 10 Gnome with 50 fishing skill.
It was spell 7731 and item 12225. It is fixed with the update, thank you so much!
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 12:20 PM  
bravejohn
A Deviate Faerie Dragon

Forum posts: 17
File comments: 154
Uploads: 0
thanks a lot for this!! I was waiting for an addon for like this :P
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 12:53 PM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 59
Uploads: 2
Originally Posted by spamplz
Originally Posted by Firedancer
Do you know Fishing and have a fishing pole equipped when you attempt to cast? If so, could you tell me the spellID for your fishing skill and the itemID for your fishing pole (or just their names and rank if you don't have the IDs in your tooltip) so I can see if I missed something? I only tested it with a regular Fishing Pole on a level 10 Gnome with 50 fishing skill.
It was spell 7731 and item 12225. It is fixed with the update, thank you so much!
I'm glad it works now! It was probably due to the fishing poles not being properly identified.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 08:00 PM  
Whyspir
A Defias Bandit

Forum posts: 2
File comments: 6
Uploads: 0
Fast as Fast can Be!

Thank you again, Did not expect such a fast response, also got the sound, thank you for setting me strait.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: