(301Kb)

Updated: 12-31-06 01:47 AM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	12-31-06 01:47 AM
Created:	unknown
Downloads:	6,345
Favorites:	69
MD5:

FilterTradeSkill

Version: 2.3.0 beta2

by: tardmrr [More]

Patch 2.1:
Just a little under 2 years after FilterTradeSkill was written, Blizzard has finally included a tradeskill filter to the base UI. As a result, this addon is more or less redundant and will most likely not receive further updates.

FilterTradeSkill allows you to filter your trade skills (including rogue poisons) with an intutive filter that allows filtering by name, description, and the item's reagents. Check out the sreanshots to see more...

Sadly this will not work with enchanting since enchanting uses the CraftFrame and this modifies the TradeSkillFrame. I have been planning to add Enchanting support for a long time, but since I don't have an enchanter, there is little motivation. However, when TBC goes live, I plan on rerolling and my new character just might have enchanting.

Version History:
v 2.3.0 beta2 (December 31, 2006)

A few minor optimization tweaks

v 2.3.0 beta1 (November 19, 2006)

Updated to work with the expansion

v 2.2.4 (April 30, 2006)

Fixed a bug that hid the Title Text
Change a bit to make FTS more compatible with other TradeSkill Addons (look for an FTS-compatible version of KC_ET soon!)

v 2.2.3 (April 20, 2006)

Fixed a bug that would cause a lua error on line 302.

v2.2.2 (March 28, 2006)

Updated for patch 1.10
More scroll frame fixes as suggested by Tageshi

v2.2.1 (March 27, 2006)

A few slight changes to correct small scroll frame issues
Fixed display issues when switching tradeskills without closing the frame
Should be completely Compatible with AutoCraft

v2.2 (March 22, 2006)

Full rewrite to make it compatible with recent patch changes
Now LoadOnDemand
Fixed filter and display bugs
Fixed Vertical offset feature
Drastically reduced codebase
Now using the embeded AceHook library

v2.11 (August 10, 2005)

Now Compatible with ArmorCraft!

v2.1 (August 9, 2005)

New Features:
- GUI to configure new options
- The TradeSkillFrame can now be resized to show up to 20 trade skills at once.
- It can now also be moved to anywhere you like
Improved the Filter Function to get information about skills that it would have previously overlooked
Reversed the Skill difficulty order to make more sence

v2.01c (August 1, 2005)

Fixed a few bugs that caused item reagents not to update properly
Cleaned up the item creation code. No more OnUpdate hack anymore. /joy

v2.01b (July 31, 2005)

So I did my last update at 4 in the morning and had some retarded logic... All fixed now

v2.01 (July 31, 2005)

Added Filter by Diffuculty

v2.0 (July 30, 2005)

First Public Release
Complete rewrite again... screw other mods.
Finally added GUI features

v1.1 (July 3, 2005)

Complete Rewrite to add compatibility with other mods

v1.01 (June 8, 2005)

Fixed a bug caused by changes to the FauxScrollFrame_Update function

v1.0 (May 29, 2005)

Initial private release
Really just a proof of concept
Um... Yeah.

Optional Files (0)

Comment Options

Page 1 of 2

08-01-05, 10:14 AM
Spiritfire A Kobold Labourer Forum posts: 1 File comments: 16 Uploads: 2	Interferes with Autocraft With this mod activated, the modified buttons "Queue All","Queue", and "Queue Everything" do not show up and the default buttons are there instead. I'd love to use this mod, but I need the functionality of AutoCraft more right now. If you can fix this issue I'd love this mod. --Spiritfire Honor and Glory, Lightbringer, Horde ~~~Live in Honor, Die in Glory~~~

08-16-05, 04:40 PM
Cloe A Kobold Labourer Forum posts: 1 File comments: 1 Uploads: 0	I DL'd this and added it into my "Addons" folder. This does not seem to work for my Enchanting but works fine with my cooking??? If ya can tell me what to do to fix it... this would be a must-have for all tradesmen in WoW... Thanks. Nevermind... just read comments from other link. "This does not work with Enchanting" Last edited by Cloe : 08-19-05 at 07:19 AM.

09-18-05, 07:12 AM

NatalieFord

A Kobold Labourer

Forum posts: 0

File comments: 3

Uploads: 0

Re: Interferes with Autocraft

(paraphrased): With AutoCraft and this mod activated, the AutoCraft modified buttons "Queue All","Queue", and "Queue Everything" do not show up and the default buttons are there instead. I'd love to use this mod, but I need the functionality of AutoCraft more right now. If you can fix this issue I'd love this mod. --Spiritfire

I don't want either/or. I would like to run both or have one that does both. I have always wished that Blizzard would let me only list recipes (or whatever) that were yellow or greater (or even green or greater) - i.e. those that might give me a gain - in the crafting windows.

Would it be possible to make it work with Enchanting as well?

11-09-05, 05:03 AM
Andesite A Murloc Raider Forum posts: 6 File comments: 2 Uploads: 0	Re: Interferes with Autocraft 1.8 update needed

02-28-06, 05:28 PM
kaphi A Kobold Labourer Forum posts: 0 File comments: 1 Uploads: 0	Update Really looking forward to the new update. When do you expect having it completed? Last edited by kaphi : 03-04-06 at 06:57 AM.

03-23-06, 06:11 AM
Baad007 A Kobold Labourer Forum posts: 0 File comments: 1 Uploads: 0	Fizzwidget's AutoCraft Remember me from a while back on the curse site? I still want a Fizzwidget Compatible version! =P It's great to see you are updating this mod again though! "@Punk2021 What you are describing is a bug that was in the first release and has since been fixed. I just made about 50 light armor kits on my alt to check that this works. Make sure you are using the most current version. @Baad007 AutoCraft support is coming soon. The only real hurdle at this point is the artwork... I hate editing textures and I will need to add a place for the "Queue Everything" button because I am not letting it hang out in space like it does in the original mod. Edited by tardmrr - 08/12/2005 - 04:08:20 AM"

03-23-06, 12:29 PM
tardmrr Lua Ninja Forum posts: 133 File comments: 134 Uploads: 12	I actually have an AutoCraft compatible version right now. I'm just waiting on someone to post a screen shot of the visual bug they were seeing to make sure I had actually corrected it. But if they haven't responded soon I'm just going to post the minor update I have ready. Last edited by tardmrr : 03-23-06 at 12:37 PM.

03-25-06, 10:08 PM

Tageshi

A Murloc Raider

Forum posts: 7

File comments: 249

Uploads: 4

The scroll bar of this addon is somewhat broken, and sometimes cannot scroll down to the last line.
Please try this code!

Code:

	local skillIndex = 0
	local count = 0

	for i=1, self.db.ShownSkills do

		local showthis = false
		local skillName, skillType, numAvailable, isExpanded
		
		while((showthis == false) and (skillIndex <= numTradeSkills)) do
		
			skillIndex = skillIndex + 1
			skillName, skillType, numAvailable, isExpanded = GetTradeSkillInfo(skillIndex)
			if (self.showState or SHOWSTATE_ALLTRUE)[skillName] then
				count = count + 1
				if count > skillOffset then
					showthis = 1
				else
					showthis = false
				end
			end
		end
--[[		
	for i=1, self.db.ShownSkills do

		local showthis = false
		local skillIndex = 0
		local skillName, skillType, numAvailable, isExpanded
		
		while((showthis == false) and (skillIndex <= numTradeSkills)) do
		
			skillIndex = i + skillOffset
			skillOffset = skillOffset + 1
			skillName, skillType, numAvailable, isExpanded = GetTradeSkillInfo(skillIndex)
			showthis = (self.showState or SHOWSTATE_ALLTRUE)[skillName]
			
			--[[if(KC_EnhancedTrades) then
				showthis = showthis and KC_EnhancedTrades:_getShowState(skillIndex,"trade")
				if(showthis ~= KC_EnhancedTrades:_getShowState(skillIndex, "trade")) then
					FTS_Debug(skillName)
				end
			end]]
			
		end

		skillOffset = skillOffset - 1
]]

03-26-06, 12:57 AM
Tageshi A Murloc Raider Forum posts: 7 File comments: 249 Uploads: 4	Additional fix FauxScrollFrame_Update should be called just before calling FauxScrollFrame_GetOffset . Filter Trade Skill is calling FauxScrollFrame_Update after FauxScrollFrame_GetOffset, so sometimes using wrong skillOffset value.

03-27-06, 02:57 AM
tardmrr Lua Ninja Forum posts: 133 File comments: 134 Uploads: 12	Tageshi: I'm fairly certain I've already fixed whatever scrollframe issues you were seeing in verion 2.2.1 which I'll be uploading in a few minutes. As far as calling FauxScrollFrame_GetOffset before Update, I checked the Update function and it does not change the offset at all so that is moot. Additionally, if the issue you are seeing persists in version 2.2.1, could you provide detailed instructions on how to reproduce it? Last edited by tardmrr : 03-27-06 at 02:58 AM.

03-27-06, 09:04 AM
Tageshi A Murloc Raider Forum posts: 7 File comments: 249 Uploads: 4	Detail of the scrollbar problem. Hi, tardmrr. First of all, thank you for your great add-on, and thank you for your reply. I am using FilterTradeSkill for very long and I love this add-on. About the problem, the version 2.2.1 didn't fix these problem. I will explain how to reproduce the problem below. I am an alchemist, so I use alchemy as an example. 1) First, I assume you have 97 recipes of alchemy in 3 different sub-classes, and "tradeskills to show" is 8. There are no problem about scroll bar when you didn't type any search keyword. The FauxScrollFrame_GetOffset function returns a value from 0 to 92. Offset=0 means top line, Offset=92 means bottom line (because 8 lines from 93 to 100 are displayed). 2) Second, you type a search keyword "ESS". Many recipes are having "ESS" in their names, for example: - Consumable greater dreamlESS sleep potion dreamlESS sleep potion lESSer stoneshield potion elixir of detect lESSer invisibility lESSer invisibility potion elixir of lESSer agility swiftnESS potion lESSer healing potion - Reagent Transmute: Air to Fire (ESSence) Transmute: Earth to Water (ESSence) Transmute: Fire to Earth (ESSence) Transmute: Undeath to Water (ESSence) Transmute: Water to Air (ESSence) Number of lines in this list is 16, including subclass titles. And I assume the first line of this serched list "greater dreamlESS sleep potion" was skillindex=12 (it's IMPORTANT to reproduce the problem). In this case, the scrollbar DON'T do his job at all; when I drag the scrollbar to the bottom, the list of recipes won't scroll down more than 1 line, and displays only upto Swiftness Potion. You cannot see any of Transmute recipes. But you can see these transmute recipes when you close Consumable subclass tab; in this case, number of lines in the list is 7. The scrollbar is hidden, and all 5 transmute recipes are displayed. (So, this is not the problem of searching code, but the problem of scrollbar.) WHY the scroll bar is broken? I will explain it below; In the second case above, the FauxScrollFrame_GetOffset function will return a value from 0 to 8. Offset=0 means top line, offset=8 is expected to mean bottom line (it SHOULD display lines from 9 to 16) But your code don't do the job. When the scrollbar is at the bottom, the variable skillOffset will begin with 8, and your code skips skillindex=1 to skillindex=8, and begin to search from skillindex=9 for a recipe having "showthis=true". The recipe with skillindex=12 (greater dreamlESS sleep potion) is the first line having "showthis=true", and always displayed. The problem is the way how you are skipping first 8 recipes; you must skip the first 8 recipes with "showthis=true". About the second report of me, FauxScrollFrame_Update MUST change the offset in certain situations. I will explain an example; I assume you have these recipes: -Consumable (skillindex=1) Flask of Chromatic Resistance (skillindex=2) Flask of Petrification (skillindex=3) Flask of Supreme Power (skillindex=4) Flask of the Titans (skillindex=5) and also have 100 more recipes. 1) You drag scrollbar to the bottom. (Now Offset is 92) 2) Next, you type "F" as a search keyword. Now there are 95 recipes in the list, for example. FauxScrollFrame_GetOffset is called first, which returns 92. FauxScrollFrame_Update is called second, which will change internall offset of scrollbar object to 84, because there are only 92 recipes in the list now. FilterTradeSkill displays 3 lines from 93 to 95. There are no problem for now. 3) Next, you type "L", and the search keyword is now "FL". Now there are 4 recipes with "FL" in its name. FauxScrollFrame_GetOffset is called first, which returns 84, because Update is not yet called. FauxScrollFrame_Update is called second, which will change internall offset of scrollbar object to 0, because there are only 4 recipes in the list now. The variable skillOffset is still 84. So FilterTradeSkill skips first 84 skills, and display NOTHING. And scrollbar is hidden, because there are only 4 recipes. List is completely blank now (it is the problem) The 4 recipes will re-appear when you type "A" as a next letter.

04-08-06, 12:04 AM
Rathe A Kobold Labourer Forum posts: 0 File comments: 14 Uploads: 0	Error since 1.10 on Version 2.2.2 filtertradeskill.lua:302:table index is nil Seems to be on first opening tradeskill window. Great mod btw, hate to be without it! Last edited by Rathe : 04-08-06 at 12:04 AM.

04-10-06, 09:02 AM
Maischter A Defias Bandit Forum posts: 2 File comments: 94 Uploads: 0	error fehler:...terface\AddOns\FilterTradeSkill\FilterTradeSkill.lua:302: table index is nil (german cooking window)

04-20-06, 01:50 PM
Zidomo A Cliff Giant Forum posts: 76 File comments: 1046 Uploads: 0	This doesn't play well with KC_EnhancedTrades (KCET). With this enabled (2.2.2), the "+" button in the upper right of the trade skill frame put there by KCET to adjust its options disappears. Also, when you use this to adjust the "trade skills to show" larger than the default 8, the KCET numbers beside the trade skills sometimes disappear never to reappear. Resolved by putting the slider back to "8", but the option becomes useless. Last edited by Zidomo : 04-20-06 at 02:52 PM.

04-20-06, 05:27 PM

tardmrr

Lua Ninja

Forum posts: 133

File comments: 134

Uploads: 12

Originally posted by Zidomo
This doesn't play well with KC_EnhancedTrades (KCET).

With this enabled (2.2.2), the "+" button in the upper right of the trade skill frame put there by KCET to adjust its options disappears.

Also, when you use this to adjust the "trade skills to show" larger than the default 8, the KCET numbers beside the trade skills sometimes disappear never to reappear. Resolved by putting the slider back to "8", but the option becomes useless.

Yeah, um... KCET hooks the same functions I do. So... they just won't work together until I can get time to work with Kael on a solution.

Page 1 of 2

Report this File

Category Jump: