(23 Kb)

Updated: 11-26-20 07:23 PM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Compatibility:	Shadowlands patch (9.0.2)
Updated:	11-26-20 07:23 PM
Created:	unknown
Downloads:	6,895
Favorites:	69
MD5:

9.0.2

SkillUp

Version: 3.9a

by: Nephaliana [More]

About SkillUp:
SkillUp replaces the default message recieved when a skill increases. The Blizzard UI uses the format "Your skill in [skill] has increased to [value]." SkillUp creates a new line in the format "Your skill in [skill] has increased to [value] out of [maxvalue]."

SkillUp options can be edited using the provided GUI. Type /skillup to access it.

SkillUp Extensions:
SkillUp now supports extension addons. Three examples are included with this release: SkillUp+Ding, SkillUp+MaxLineColor, and SkillUp+UCase (all three are disabled by default -- you must go enable them if you want to use them).

SkillUp+Ding plays a sound when you max out one of your skills.

SkillUp+MaxLineColor colors an entire skill message when the skill is maxed (rather than just the normal skill name and current skill value).

SkillUp+UCase makes the skill name display in all upper case.

See the bottom of the SkillUp\SkillUp.lua file as well as the example extensions for more information on how to implement your own addons to extend SkillUp.

Current Issues (updated November 26, 2020):
- No known issues at this time. Please let me know if you discover any problems.

3.9a
- Fixed bug introduced in 3.9 when earning non-Shadowlands skill points

3.9
- Fixed skill caps for Shadowlands
- Added check for the existance of an expansion tier before trying to reference its value (future expansions should now default to "??" for maximum value rather than cause an error)
- Added missing error message which could have resulted in a Lua error

3.8
- Added the skill cap for Shadowlands (fixes bug with it missing)

3.7
- Fixed bug when cooking in Pandaria
- Updated TOC for 9.0

3.6
- Updated maximum skill level for BFA professions (150 -> 175)
- Fixes display bug when current skill is above defined maximum
- Added racial bonus for Kul Tirans (assuming Jack of All Trades works correctly, but unable to test due to not having unlocked the race yet)
- Tweaks to supporting addons
- Updated TOC for 8.2

3.5
- Racial bonuses now affect the maximum skill reported

3.4
- Updated method of determining maximum skill
- Minor tweaks to supporting addons
- Updated TOC for 8.0

3.3
- Fixed issue when severly below skill cap (such as when low level fishers learn Draenor fishing)
- Updated TOC for 6.0

3.2a
- Updated TOC for 5.4

3.2
- Adjusted coloring gradient formula - now does percent of 100 points from the maximum instead percent of all points
- "Way of the ___" now uses Cooking's maximum skill (instead of "??")
- Updated TOC for 5.0

3.1
- Added Delete Profile button
- Added button to reset settings to defaults
- Fixed bugs caused by 4.0 patch
- Updated TOC for 4.0

3.0
- Added profile settings, along with its own GUI
- Saved variables switched to account rather than per character (any existing settings were reset)
- Changed the way the command line is parsed (should be no difference to the player)
- Added two hookable functions: one before SkillUp generates its output message and one after it generates the message but before it is displayed
- Added confirmation prompt before settings are reset to default (/skillup default)
- Updated TOC for 3.3

2.2
- Added a few more localization variables that should have been used before
- Added alternate "gradient" coloring mode
- Updated the options GUI
- Updated TOC for 3.1

2.1
- Reworked how SkillUp skill messages are displayed. SkillUp now modifies the original message, rather than preventing the original and displaying its own.
- Updated TOC for 3.0

2.0
- Finished options GUI (accessible via /skillup)
- Added additional color options
- Default colors changed to have red as low and green as high
- SkillUpColor.lua removed
- Updated TOC for 2.4

1.3
- Fixed bug regarding "this" introduced in one of the WoW 2.1.x patches (enable/disable works again now)
- Updated TOC for 2.2

1.2
- Additional ChatFrame support (not always the default chat frame)
- Code redone to allow for future localization
- Updated TOC for 2.1

1.1
- "Coloring" for current skill value available
- Enable/disable the addon from the command line
- /skillup slash command added w/ help list
- Settings saved per character

1.0
- Auto-unchecks "Skill" from the default chat window's options upon loading
- Messages use "Skill" color instead of always blue

0.1
- Initial Release

Archived Files (5)

File Name	Version	Size	Author	Date
SkillUp	3.8	22kB	Nephaliana	11-23-20 06:33 PM
SkillUp	3.7	22kB	Nephaliana	10-14-20 05:51 PM
SkillUp	3.6	22kB	Nephaliana	07-07-19 10:35 PM
SkillUp	3.6	28kB	Nephaliana	09-22-18 04:52 PM
SkillUp	3.4	28kB	Nephaliana	08-12-18 03:49 PM

Comment Options

Page 1 of 2

11-24-20, 06:29 PM
Nephaliana A Kobold Labourer Forum posts: 1 File comments: 36 Uploads: 17	Why, Blizzard? :confused: So seems I need to update again.... Shadowlands profession cap showed 75 so that is what I set it to in the code, but it appears it does go up to at least 150 now. I guess it was a way to prevent lower level players from getting all the way to the real max? What is worse, mining and herbalism show 150, cooking is still 75, and fishing is 200... so I need to spend some time to research how this is supposed to work and then update a few things to make sure I account for all cases. The current version (3.8) shouldn't cause errors above 75, but it will give a "??" in the message for the max skill. Edit: Version 3.9 was released earlier today which takes into account the variety of maximum skill points for professions. Version 3.9a was also released just now which fixed a bug introduced in 3.9. Last edited by Nephaliana : 11-26-20 at 07:28 PM.

09-06-12, 11:54 AM

Cyn325

A Theradrim Guardian

Forum posts: 65

File comments: 31

Uploads: 0

Re: Re: MoP update?

Originally Posted by Nephaliana

Originally Posted by Cyn325

Will this addon be getting updated for Mists of Pandaria?

Is there something broken that I have not yet encountered, or do you just not like using the "load out of date addons" checkbox?

I generally avoid uploading a new version with simply a new ToC (version) number for a new patch (I think the version that is up now is still using 4.0's rather than 4.3's). I can do it if needed, or if there is a new feature you would like to see, but as far as I know, the addon still works with the latest patch without any changes.

I was more just wondering since I wasn't sure if any of the changes they've been making regarding MoP were going to affect it since some of the new coding has totally wrecked so many others. Its actually probably one of the few that hasn't been throwing errors at me since the last patch.

09-05-12, 04:54 PM

Nephaliana

A Kobold Labourer

Forum posts: 1

File comments: 36

Uploads: 17

Re: MoP update?

Originally Posted by Cyn325

Will this addon be getting updated for Mists of Pandaria?

09-05-12, 12:03 PM
Cyn325 A Theradrim Guardian Forum posts: 65 File comments: 31 Uploads: 0	MoP update? Will this addon be getting updated for Mists of Pandaria?

10-15-10, 07:36 PM

Nephaliana

A Kobold Labourer

Forum posts: 1

File comments: 36

Uploads: 17

Incoming SkillUp 3.1 fix!

Originally posted by Decabah
Receiving this error upon logging in:

Code:

1x SkillUp-2.0\SkillUp.lua:220: attempt to index field 'suFrame' (a nil value) <string>:"*:OnLoad":1: in function <[string "*:OnLoad"]:1> Locals: self = SkillUpCore { 0 = <userdata> } ---

Typing /skillup does nothing either.

It looks like you are running 2.0, which saved an explicit reference to "this" (which was removed in Patch 4.0). As such, the reference would be nil (an invalid value) and cause that error. While SkillUp 3.0 doesn't save that reference, there still was another "this" reference in another spot that I didn't catch with the 3.0 update (don't think it gave the error at login, but you'd still have issues using the addon after Patch 4.0), and I've already corrected that on my local copy.

I haven't actually managed to gain a skill point in any profession yet (made a bunch of food for one of my alt's cooking, but gained nothing from it *sad*) so I need to verify that part of the addon skill works prior to me posting an updated copy. I'll try again and see if I can get it out tonight (with 1-2 other features I've already added since 3.0).

Thanks for the report.

Update: There is an error when you get skill increases too. So the release was delayed while I fix that. 3.1 should still be out soon.

Update: SkillUp 3.1 uploaded.

Last edited by Nephaliana : 10-16-10 at 04:50 PM.

10-15-10, 12:00 PM
Moxie A Cobalt Mageweaver Forum posts: 206 File comments: 126 Uploads: 2	Receiving this error upon logging in: Code: 1x SkillUp-2.0\SkillUp.lua:220: attempt to index field 'suFrame' (a nil value) <string>:":OnLoad":1: in function <[string ":OnLoad"]:1> Locals: self = SkillUpCore { 0 = <userdata> } --- Typing /skillup does nothing either. __________________ "Someday we'll look back on this, laugh nervously and quickly change the subject." "The truth is like sunlight: people used to think it was good for you."

09-20-10, 12:11 PM

Nephaliana

A Kobold Labourer

Forum posts: 1

File comments: 36

Uploads: 17

Originally posted by Ookami.kun
Started leveling up an alt again that's been sitting around for a while, and I ran into this error. As soon as the error is give, no text displays of "x out of x" is posted to the chat frame.

Thanks. I started working on this addon again (after a year or two of when it really should have been done), and would have missed this issue if you didn't report it.

I had changed the variable naming with 3.0, but I had already written the little expansion addons prior to doing that, so this one slipped by when I posted the 3.0 beta. It's fixed for the actual 3.0 release.

Little bit more testing to be done, but I should have the new version out today.

04-03-10, 07:35 PM

Ookami.kun

A Cliff Giant

Forum posts: 78

File comments: 232

Uploads: 0

Started leveling up an alt again that's been sitting around for a while, and I ran into this error. As soon as the error is give, no text displays of "x out of x" is posted to the chat frame.

Code:

Date: 2010-04-03 20:52:53
ID: 2
Error occured in: Stubby
Count: 1
Message: Error: Original call failed after running hooks for:  ChatFrame_OnEvent 
 ...AddOns\SkillUp+MaxLineColor\SkillUp+MaxLineColor.lua line 25:
   attempt to index global 'SkillUp_Settings' (a nil value)
Debug:
   (tail call): ?
   WinterTime\WinterTime.lua:1417: ChatFrame_OnEvent()
   [string "*:OnEvent"]:1:
      [string "*:OnEvent"]:1
AddOns:

Thanks

__________________

12-02-09, 11:40 PM

Nephaliana

A Kobold Labourer

Forum posts: 1

File comments: 36

Uploads: 17

Re: 3 beta

Originally posted by Jaim Sandar
I'm happy with version 2.2, also, but I am going to try 3 beta. One question: will 3 have an option to change the skillup message? I have always edited SkillUp.lua to change it because I don't like it saying "x out of x". I'd rather just have "x of x". Piddly, I know, but that's what I want

Thank you.

There is not currently an option to do it in game, but the method to change it in the file hasn't change. Edit line 68 (in 3.0 beta) to remove "out" from the string.

Alternatively, you could write an extension addon to remove "out" from the final message (some sample code below). It may be overkill in this case, but it would let you not have to worry about editing any future versions you may install.

Code:

local originalSkillUpPostHookFunc = SkillUp.PostHook
function SkillUp.PostHook(self, suppress, msg)
	suppress, msg = originalSkillUpPostHookFunc(self, suppress, msg)
	msg = string.gsub(msg, " out ", " ")
	return suppress, msg
end

12-02-09, 05:52 PM
Jaim Sandar A Deviate Faerie Dragon Forum posts: 13 File comments: 357 Uploads: 1	3 beta I'm happy with version 2.2, also, but I am going to try 3 beta. One question: will 3 have an option to change the skillup message? I have always edited SkillUp.lua to change it because I don't like it saying "x out of x". I'd rather just have "x of x". Piddly, I know, but that's what I want Thank you.

12-01-09, 11:19 AM

Nephaliana

A Kobold Labourer

Forum posts: 1

File comments: 36

Uploads: 17

Re: Re: Re: Seeking max-skill notification

Originally posted by Jaim Sandar
I'm happy with Skillup 2.2, but just curious if 3.0 will ever happen. It sounds interesting.

Thank you.

I've been slacking so much.

Right now I believe everything is done except the GUI for a feature added.. and it's been that way basically since I made my last post here. I'm not really fond of doing GUI layouts for addons (earlier versions of this addon were delayed or released without the GUI because I really didn't want to do it).

I really should go finish it though... maybe tonight I'll work on it, or at the very least toss up a "beta" release.

--

Edit: Version 3.0 is uploaded in a beta state. It's basically missing the GUI for its profile settings. You can use /skillup profile use ProfileName to change which profile your character is using** and /skillup profile copy ProfileName to copy another profile's settings to your current profile. Since I haven't finished it 100%, I haven't done complete testing and therefore cannot guarantee it is bug free.

** Bug discovered here. Some of the code for that is loaded in the GUI, which isn't loaded till you try to show the options ( /skillup ), which means if you attempt to change your profile before showing the options, you will likely generate an error. Furthermore, the prompt that shows when you attempt to switch to a profile that doesn't exist does not go away when you click yes, but it does function. After clicking Yes, click No to hide the dialog.

Last edited by Nephaliana : 12-02-09 at 04:23 AM.

11-27-09, 09:51 PM

Jaim Sandar

A Deviate Faerie Dragon

Forum posts: 13

File comments: 357

Uploads: 1

Re: Re: Seeking max-skill notification

Originally posted by Nephaliana
SkillUp 3.0 will include a few minor addon extras. One of which is my own version of "SkillUp+Ding" that will then work for all future versions of SkillUp.

I'm happy with Skillup 2.2, but just curious if 3.0 will ever happen. It sounds interesting.

Thank you.

04-17-09, 01:06 PM

Nephaliana

A Kobold Labourer

Forum posts: 1

File comments: 36

Uploads: 17

Re: Seeking max-skill notification

Originally posted by Jaim Sandar
Could you please share your modification with us?
Thank you!

Archippus' change should be available under the "optional files" for SkillUp (think he called it "SkillUp + Ding").

Note, however, that it's based off older code, so you won't get the latest features/fixes.

---

Edit: SkillUp 3.0 will include a few minor addon extras. One of which is my own version of "SkillUp+Ding" that will then work for all future versions of SkillUp.

Last edited by Nephaliana : 06-21-09 at 03:05 AM.

04-17-09, 11:48 AM

Jaim Sandar

A Deviate Faerie Dragon

Forum posts: 13

File comments: 357

Uploads: 1

Re: Seeking max-skill notification

Originally posted by Archippus
This mod is very close to what I'm looking for with one shortcoming... I'm hoping for some stand-out notification when I max out on a skill for my current level. ie: If I'm level 39 and my Mace skill hits 195/195, if I could get some kind of audible or (unobtrusive) on-screen alert, that would be perfect. That means it's time to switch to rotate to a new weapon.

[edit] Never mind. I played around with it and figured out how to add a "ding" noise when current == max. That's all I wanted, and it works just fine :-) [/edit]

Could you please share your modification with us?
Thank you!

12-29-08, 07:51 AM
fred A Cobalt Mageweaver Forum posts: 208 File comments: 354 Uploads: 0	looking good! Last edited by fred : 12-29-08 at 08:00 AM.

Page 1 of 2

Report this File

Category Jump: