beSch

Great addon, I love it!

In addition to the issue you mentioned below with events being out of order, I've noticed that it doesn't reset charges to zero when the person the shield is on dies, whether it's Water Shield on me or Earth Shield on whoever.

Edit: Also just noticed that when zoning in/out of an instance, Earth Shield is removed, but there doesn't seem to be a combat log message indicating this.

great addon indeed, had to tinker a bit myself with fonts and such to get it to my liking but the basecode was awesome dude, great job indeed.
as you yourself mentioned there are some problems with the counter resetting itself right after casting.

Well, I've modified my local copy to fix the extremely annoying bug where the addon thinks Water Shield is cancelled when I recast it before it expires. I tend to refresh my Water Shield before entering combat, regardless of how much time or how many charges are left, and the combat log likes to screw up the message order.

The solution I'm using is to record the time on the "gained" message, and when the "lost" message is seen, I check the time; if it's been less than 0.25 seconds since I gained Water Shield, I assume that the combat log is wrong, and don't cancel the tracked Water Shield.

PvPers who use Water Shield in arenas may occasionally see it dispelled off within 0.25 seconds of casting it, but for PvE this number is fine and gives a safety margin to account for latency or plain old combat log bugginess.

You're welcome to adapt this solution for the official version.

Edit: UNIT_DIED is (according to Slouken) fixed in 2.4.2. I'll try to verify this tonight.

if its not fixed, feel like sharing your solution ?

Great addon Infineon! Something I would like to see, but can live without, is writing the settings to a saved variables file. Would help keep settings from getting overwritten every time I update via an updater.

And I know you are trying to keep this addon simple, but if you ever do make a small gui for it, hooking into SharedMedia would work really well for fonts, sounds, etc.

Also, why not make the frame draggable by ctrl-left dragging or something similar?

Thanks again!

the whole idea is to make it lightweight and not include unnecessary code.
changing font is easy enoughl by simply editing core.lua and same goes for moving the text.

Yeah, I like how simple this is too. I was not requesting a gui, just saying SharedMedia would work well if there ever was one. Output to combat texts with SinkLib would also be a possibility. Just some ideas, if author decides to keep it as simple as possible, fine with me.

I am happy with the addon as is. Though I would like to be able to drag the frame rather than having to edit lua, reload, edit lua, reload...I don't think making the frame draggable would cause unnecessary bloat. Really, a draggable frame and saving settings to SV is all I would like to see added right now.

I'm just happy to have found a much simpler addon than ShamanFriend (did way more than I needed) that tracks both shields.

tbh i cant see the need myself to add an output to combat text. in my current setup i cant really miss if my ws drops or my ES target runs out of charges

I wouldn't care either if I simply had to recast it a second time to get the counter correct. The problem is that 99% of the time the combat events are fired in the wrong order, so unless I click off Water Shield or wait for it to expire before I recast it, I will never ever see anything but a big red zero for the Water Shield counter. This is a huge problem, as Water Shield is critical for sustaining my mana in the healing-intensive fights in Sunwell, and I need to be able to tell when it's up and when I need to recast it.

It's also far less efficient to scan through 24 buffs every time an aura is updated. In raid combat, auras are constantly changing; UNIT_AURA is fired every time a buff OR debuff is gained or lost, including stacking debuffs and short duration buffs like hunters' Ferocious Inspiration. As well, if you use UNIT_AURA, you have to do an additional UnitName API call every time the event is fired. This event can fire many many times per second, leading to a tremendous waste of CPU.

It's much cleaner and faster to simply add an additional local variable to store the timestamp that's already passed as the first argument to the COMBAT_LOG_EVENT_UNFILTERED event. As the timestamps are only compared when you see the specific "aura removed" message you're already looking for, there's very little CPU overhead.