Download
(20Kb)
Download
Updated: 08-10-19 03:35 PM
Pictures
File Info
Compatibility:
Classic (1.13.2)
Updated:08-10-19 03:35 PM
Created:08-10-19 09:28 AM
Downloads:39,300
Favorites:72
MD5:
Categories:Classic - General, Graphic UI Mods

oGlow (Classic)  Popular! (More than 5000 hits)

Version: 2.2.8
by: AG007 [More]

This is a quick-fix made for Classic. All credits to the original author Haste. The original addon can be found here.

oGlow will light up your items, by adding a quality border to them. By default, it will display this border for common quality items and above.

It will currently only display the quality borders on the following places:
* Inventory
* Inspect
* Bank
* Bags
* Mail
* Merchant
* Trade
* Professions
* Character
* Loot

2.2.8:
- Added glow for ranged weapon in character/inspect window

2.2.7:
- Added highlight for quest items
- Deleted some unnecessary things
Optional Files (0)


Post A Reply Comment Options
Unread 08-10-19, 07:30 PM  
Leilu
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Hi,
It's what I expected.
Can I change the quest item glow to yellow ?
Report comment to moderator  
Reply With Quote
Unread 08-11-19, 02:21 AM  
schnitzer
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Hi,

i have trouble in combination with OneBag3. The wrong places glow. Is there a possiblility to fix it. Or have you an other suggestion to use oglow with an other onebag addon.

Thank you
Last edited by schnitzer : 08-11-19 at 02:21 AM.
Report comment to moderator  
Reply With Quote
Unread 08-11-19, 04:53 AM  
AG007
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 5
File comments: 10
Uploads: 1
Originally Posted by Leilu
Can I change the quest item glow to yellow ?
Unfortunately this isn't possible atm. I could probably add an option to do so later at some point. However I likely wont be adding/updating anything untill after the release of Classic unless there is some crucial error.

EDIT: However there is a slight workaround that you can do untill then. Since most quest items are Common quality, you can just set your filter to Uncommon and then change the color of Common quality to yellow.

Originally Posted by schnitzer
i have trouble in combination with OneBag3. The wrong places glow. Is there a possiblility to fix it. Or have you an other suggestion to use oglow with an other onebag addon.
I could be wrong, but doesn't OneBag have its own item highlight feature? The addons are probably colliding because of that, causing them not to work properly. Alternative you could try this addon here. It should be pretty similar to OneBag and also have its own item highlight feature.
Last edited by AG007 : 08-11-19 at 08:59 AM.
Report comment to moderator  
Reply With Quote
Unread 08-16-19, 12:31 AM  
Moosetrax
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 124
Uploads: 1
Is it possible to adjust the alpha? I didn't try the addon in the stress test but I am curious?
Report comment to moderator  
Reply With Quote
Unread 08-29-19, 05:05 AM  
InterfaceMinion
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Exclamation Crash

Hello, using and loving the addon. But there is one problem, which is reliably reproduced: If you open your crafting menu and use the little "-" button to fold something in, the game will crash.
Report comment to moderator  
Reply With Quote
Unread 08-29-19, 09:58 AM  
Chaotix
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Re: Crash

Originally Posted by InterfaceMinion
Hello, using and loving the addon. But there is one problem, which is reliably reproduced: If you open your crafting menu and use the little "-" button to fold something in, the game will crash.
I can confirm this. Repeatable.
Report comment to moderator  
Reply With Quote
Unread 08-29-19, 07:50 PM  
rbpaiett
A Murloc Raider

Forum posts: 4
File comments: 49
Uploads: 0
Re: Re: Crash

Originally Posted by Chaotix
Originally Posted by InterfaceMinion
Hello, using and loving the addon. But there is one problem, which is reliably reproduced: If you open your crafting menu and use the little "-" button to fold something in, the game will crash.
I can confirm this. Repeatable.
I 2nd that.
Report comment to moderator  
Reply With Quote
Unread 08-30-19, 03:21 PM  
AG007
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 5
File comments: 10
Uploads: 1
Re: Crash

Originally Posted by InterfaceMinion
Hello, using and loving the addon. But there is one problem, which is reliably reproduced: If you open your crafting menu and use the little "-" button to fold something in, the game will crash.
Thanks, I'll look into it asap!
Report comment to moderator  
Reply With Quote
Unread 09-01-19, 03:35 AM  
toshamaru
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
hi. i would like to ask if it would be possible to change the intensity of the glow?
__________________
Report comment to moderator  
Reply With Quote
Unread 09-10-19, 04:47 PM  
Kanegasi
A Molten Giant
 
Kanegasi's Avatar
AddOn Author - Click to view AddOns

Forum posts: 666
File comments: 14
Uploads: 5
Fix for tradeskill header crash:

In oGlow\pipes\tradeskill.lua, find the following piece of code:

Lua Code:
  1. local pipe = function(id)
  2.     local itemLink = GetTradeSkillItemLink(id)

Add the following code to it:

Lua Code:
  1. local pipe = function(id)
  2.  
  3.     local _,skillType=GetTradeSkillInfo(id)
  4.     if skillType=="header" then return end
  5.  
  6.     local itemLink = GetTradeSkillItemLink(id)

Explanation:

Blizzard has a thing with mashing what should be simple indexing of ids with headers and other objects unrelated to the data. In this case, an id that's supposed to be a header gets caught by oGlow's hook and an infinite loop occurs where oGlow tries to add color to a header that has no trade skill data. What's supposed to happen is a C stack overflow error pops out, but instead the client crashes.

Another fun place Blizzard does this is the reputation frame. I have an addon on retail that enhances paragon reps and it was "fun" working that frame out.

For the curious, here's the beginning of Blizzard's function that oGlow hooks:

Lua Code:
  1. function TradeSkillFrame_SetSelection(id)
  2.     local skillName, skillType, numAvailable, isExpanded = GetTradeSkillInfo(id);
  3.     TradeSkillHighlightFrame:Show();
  4.     if ( skillType == "header" ) then
  5.         TradeSkillHighlightFrame:Hide();
  6.         if ( isExpanded ) then
  7.             CollapseTradeSkillSubClass(id);
  8.         else
  9.             ExpandTradeSkillSubClass(id);
  10.         end
  11.         return;
  12.     end
Last edited by Kanegasi : 09-10-19 at 04:50 PM.
Report comment to moderator  
Reply With Quote
Unread 10-16-19, 04:50 AM  
fgsfdss
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Hello, there is no glow for the ranged slot. Any chance for a fix, or some info on how I can fix it myself?
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: