Quantcast
Download
(132Kb)
Download
Updated: 06-20-21 04:07 PM
Pictures
File Info
Compatibility:
The Burning Crusade Classic (2.5.1)
Updated:06-20-21 04:07 PM
Created:06-24-19 05:05 PM
Downloads:13,569
Favorites:38
MD5:
Categories:Classic - General, Mage

MageButtons (Classic)  Popular! (More than 5000 hits)

Version: 1.04
by: Moxey [More]

MageButtons
- Purpose: Adds "menu" buttons for mage spell categories: water, food, teleports, portals, mana gems, polymorph

Features
- Consolidates spells into collapsible buttons to save bar space (like modern teleports/portals buttons)
- Horizontal or Vertical layouts
- Menu direction left/right/up/down
- Customizable button size, padding, background color, border
- Can specify button order
- Buttons can be keybound via standard bindings page (under Addons)

Other
- First time loading it will default to a set button order, need to go into Options and actually set them for them to save (will say "not set")

Known issues / TODO:
- Keybindings are wonky, probably because I'm doing something wrong, but they mostly work?
- Need to reload UI when new spells are learned from trainer so the addon will pick them up
- Not sure if the Polymorph button is worth it, was thinking it would be nice to easily switch from Sheep to Turtle to Pig
- Could add AI for easy access to lower ranks for lower level players
- Lock/unlock from options panel is out of sync with minimap click
- New spells learned from trainers are not automatically added, need to /reload

1.04 - Hopefully fixed startup error
1.03 - Increased startup delay
1.02 - Updated with TBC spells
1.01 - Set menu button strata to HIGH, updated usage
1.00 - Added mouseover option, minimap icon will now default to on
0.99 - Fix to minimap button, slash commands
0.99 - Largely rewritten, most settings changes should now occur without needing to reload
0.90 - Added check to config file to not load if character isn't a mage
Archived Files (8)
File Name
Version
Size
Author
Date
1.03
132kB
Moxey
05-18-21 05:25 PM
1.02
132kB
Moxey
05-13-21 03:00 PM
1.01
131kB
Moxey
09-04-19 04:03 PM
1.00
131kB
Moxey
08-15-19 08:13 PM
0.99
131kB
Moxey
08-11-19 02:59 PM
0.99
131kB
Moxey
08-09-19 06:17 PM
0.99
159kB
Moxey
08-08-19 09:29 PM
0.90
130kB
Moxey
06-24-19 07:59 PM


Post A Reply Comment Options
Unread 10-08-21, 10:37 PM  
WoWEyE
A Defias Bandit

Forum posts: 2
File comments: 34
Uploads: 0
Re: Re: Re: Re: Re: Re: Re: Lua Error

Originally Posted by endymon
Originally Posted by Himitsu1990
I tried lasted version from github and it still has same error, unfortunately.
All I can say is... DANG. That was my best idea and it seemed to resolve the issue on my end

Since the issues other mods have been having seem to be related to drop down menus, maybe could try deleting the entire options panel (including the dropdowns) and see if that resolves the problem?
Yeah, its like using a machete, but at least maybe we could use that to narrow down what part of the code is causing the taint errors?
Ohhh Yes, @endymon, Please take this over. it would be a WoW life saver!
Report comment to moderator  
Reply With Quote
Unread 10-05-21, 06:52 PM  
bterrik
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Same issue

I've been having the same issue. Grabbed a gif of what's happening, both with all addons enabled and with all disabled except MageButtons.

First time, error happens on hitting "g" for the guild pane. Second time, the error happens after I sort the guild list by name.

https://imgur.com/a/9z8WFK9
Report comment to moderator  
Reply With Quote
Unread 10-01-21, 07:10 AM  
Himitsu1990
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Re: Re: Re: Re: Re: Lua Error

Originally Posted by endymon
Originally Posted by Himitsu1990
I tried lasted version from github and it still has same error, unfortunately.
All I can say is... DANG. That was my best idea and it seemed to resolve the issue on my end

Since the issues other mods have been having seem to be related to drop down menus, maybe could try deleting the entire options panel (including the dropdowns) and see if that resolves the problem?
Yeah, its like using a machete, but at least maybe we could use that to narrow down what part of the code is causing the taint errors?
What do you mean? What part of code or files should i delete to try that?
Report comment to moderator  
Reply With Quote
Unread 09-30-21, 07:30 AM  
Moxey
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 14
Uploads: 3
Re: Re: Re: Re: Re: Lua Error

Originally Posted by endymon
I created a new repo to host this addon.
https://github.com/matthewhively/MageButtons
I'm not going to worry about license issues.

I have backfilled the full version history of this addon starting from version 0.9 all the way up through 1.04 and my own personal changes that seem to have fixed bugs.
Anyone who has additional fixes or improvements to the way this addon loads or behaves, feel free to submit issues or make forks and pull requests to add fixes.
I have not tagged any of my changes as an actual version in this repo.

And @Moxey if you would like to take over this repo, by all means I'll transfer it to you.
You can even grant other persons commit access if you want to take a quasi-hands-off approach to maintenance.
You have my blessing to run with it! Thank you for doing this, as I'm not really playing anymore it's great to see that people want to keep this alive, since it's something I really just made for myself and wanted to share.
Report comment to moderator  
Reply With Quote
Unread 09-30-21, 01:55 AM  
endymon
A Kobold Labourer

Forum posts: 0
File comments: 10
Uploads: 0
Re: Re: Re: Re: Re: Re: Lua Error

Originally Posted by Himitsu1990
I tried lasted version from github and it still has same error, unfortunately.
All I can say is... DANG. That was my best idea and it seemed to resolve the issue on my end

Since the issues other mods have been having seem to be related to drop down menus, maybe could try deleting the entire options panel (including the dropdowns) and see if that resolves the problem?
Yeah, its like using a machete, but at least maybe we could use that to narrow down what part of the code is causing the taint errors?
Report comment to moderator  
Reply With Quote
Unread 09-29-21, 11:31 AM  
Himitsu1990
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Re: Re: Re: Lua Error

Originally Posted by endymon
I created a new repo to host this addon.
https://github.com/matthewhively/MageButtons
I'm not going to worry about license issues.

I have backfilled the full version history of this addon starting from version 0.9 all the way up through 1.04 and my own personal changes that seem to have fixed bugs.
Anyone who has additional fixes or improvements to the way this addon loads or behaves, feel free to submit issues or make forks and pull requests to add fixes.
I have not tagged any of my changes as an actual version in this repo.

And @Moxey if you would like to take over this repo, by all means I'll transfer it to you.
You can even grant other persons commit access if you want to take a quasi-hands-off approach to maintenance.
I tried lasted version from github and it still has same error, unfortunately.
Report comment to moderator  
Reply With Quote
Unread 09-25-21, 10:03 PM  
endymon
A Kobold Labourer

Forum posts: 0
File comments: 10
Uploads: 0
Re: Re: Re: Re: Lua Error

I created a new repo to host this addon.
https://github.com/matthewhively/MageButtons
I'm not going to worry about license issues.

I have backfilled the full version history of this addon starting from version 0.9 all the way up through 1.04 and my own personal changes that seem to have fixed bugs.
Anyone who has additional fixes or improvements to the way this addon loads or behaves, feel free to submit issues or make forks and pull requests to add fixes.
I have not tagged any of my changes as an actual version in this repo.

And @Moxey if you would like to take over this repo, by all means I'll transfer it to you.
You can even grant other persons commit access if you want to take a quasi-hands-off approach to maintenance.
Last edited by endymon : 09-25-21 at 10:05 PM.
Report comment to moderator  
Reply With Quote
Unread 09-25-21, 09:56 AM  
Moxey
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 14
Uploads: 3
Re: Re: Re: Lua Error

Originally Posted by Himitsu1990
Originally Posted by Moxey
Originally Posted by Himitsu1990
Whatever I open guild menu and try to click on it, or scrolldown, this error came out:
Message: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
Time: Thu Sep 16 07:12:48 2021
Count: 1
Stack: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2508: in function `GuildControlPopupFrame_Initialize'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:966: in function `FriendsFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>
[string "=[C]"]: in function `SetGuildRosterShowOffline'
[string "*:OnClick"]:7: in function <[string "*:OnClick"]:1>
Locals: <none>

Same error was after 2.5.2 in Leatrix Maps, but they fix it on 2.5.55 version.
Tried searh for it and can't find where is any string that call for FriendsFrame.lua
I've been away from the game for a while, but I popped on to check this out and wasn't able to reproduce it. It could be another addon tainting it, but it's hard to say - MageButtons definitely shouldn't be messing with the guild/friends frames. I'd say try disabling other addons and see if it still happens, and if you can give me steps to reproduce I'll see what I can do.
Yes, it does happens if magebuttons is the only one enabled addon aswell.
Step to reproduce: Open guild menu (you should be in guild and not the only one person in it > click on some player or check "show offline players". If it not enough - click on several players to see their notes or pretend you wanna invite them to a raid. And error will pop up. Maybe on something other to do with players in guild. Aswell it cause garantee error if you are a guild master and trying to manage guild ranks or rank privileges.
Sometimes error does not pop up immediately and you can click several times on players but error will happen soon.
I've still been unsuccessful in reproducing the issue, but I sent you a message with an update version to see if it works. If so I will publish it.
Report comment to moderator  
Reply With Quote
Unread 09-23-21, 06:09 PM  
Himitsu1990
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Originally Posted by endymon
I believe I have a fix for the taint issue.
Maybe you can share your files with fix applied with us? At least, send me private message with your files, please.
Report comment to moderator  
Reply With Quote
Unread 09-21-21, 12:11 AM  
Himitsu1990
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Lua Error

Originally Posted by Moxey
Originally Posted by Himitsu1990
Whatever I open guild menu and try to click on it, or scrolldown, this error came out:
Message: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
Time: Thu Sep 16 07:12:48 2021
Count: 1
Stack: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2508: in function `GuildControlPopupFrame_Initialize'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:966: in function `FriendsFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>
[string "=[C]"]: in function `SetGuildRosterShowOffline'
[string "*:OnClick"]:7: in function <[string "*:OnClick"]:1>
Locals: <none>

Same error was after 2.5.2 in Leatrix Maps, but they fix it on 2.5.55 version.
Tried searh for it and can't find where is any string that call for FriendsFrame.lua
I've been away from the game for a while, but I popped on to check this out and wasn't able to reproduce it. It could be another addon tainting it, but it's hard to say - MageButtons definitely shouldn't be messing with the guild/friends frames. I'd say try disabling other addons and see if it still happens, and if you can give me steps to reproduce I'll see what I can do.
Yes, it does happens if magebuttons is the only one enabled addon aswell.
Step to reproduce: Open guild menu (you should be in guild and not the only one person in it > click on some player or check "show offline players". If it not enough - click on several players to see their notes or pretend you wanna invite them to a raid. And error will pop up. Maybe on something other to do with players in guild. Aswell it cause garantee error if you are a guild master and trying to manage guild ranks or rank privileges.
Sometimes error does not pop up immediately and you can click several times on players but error will happen soon.
Last edited by Himitsu1990 : 09-21-21 at 12:13 AM.
Report comment to moderator  
Reply With Quote
Unread 09-20-21, 02:03 AM  
endymon
A Kobold Labourer

Forum posts: 0
File comments: 10
Uploads: 0
I believe I have a fix for the taint issue.

As best as I understand it, looks like there is some bug in the wow core lua that is throwing taint errors. I saw several other mods were disabling something or other (map... dropdowns or something) because of similar issues.
While I wasn't able to copy whatever they were doing (since it seemed to already be disabled in those mods), what I did end up doing was converting a bunch of global variables to local variables in a ton of places throughout Magebuttons.
Because my changes are spread out over a bunch of lines, it would be fairly difficult to indicate all of them here in replys. And since there is no git-repo available, I cannot easily share my fixes. But I can confirm... at least from the steps of opening the guild frame, that after my changes these taint errors no longer appeared.
I cannot guarantee there isn't some other UI that when opened will cause random taint issues with this mod though.



However I was digging into some discussions around WoW addons and it looks like there is a strong indication that phrasing within the EULA essentially grants blizzard sole ownership of any addons created, other licenses thus being voided/ignored.
https://www.blizzard.com/en-us/legal...ense-agreement
Specifically:
1. D. i. 4. User Created or Uploaded Content.
and
2. A. v. Computer code, including but not limited to “Applets” and source code

I'm not sure there is any legal case settling that particular matter, but as it has never come up in the 17years of wow's existence, it probably isn't likely any time soon.
But in my opinion @lfxgroove you should just re-host the repo. As long as we aren't trying to repurpose the work and claim it as anything other than fixes/enhancements to the work of the original author... and so long as the original author doesn't try to raise a stink about it (99.999% likely he won't), I think we're just making trouble for ourselves worrying about purely hypothetical copyright claims, rather than doing what we should be doing... FIXING and improving the damn mod.
Last edited by endymon : 09-20-21 at 02:15 AM.
Report comment to moderator  
Reply With Quote
Unread 09-18-21, 06:10 PM  
Moxey
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 14
Uploads: 3
Re: Lua Error

Originally Posted by Himitsu1990
Whatever I open guild menu and try to click on it, or scrolldown, this error came out:
Message: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
Time: Thu Sep 16 07:12:48 2021
Count: 1
Stack: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2508: in function `GuildControlPopupFrame_Initialize'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:966: in function `FriendsFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>
[string "=[C]"]: in function `SetGuildRosterShowOffline'
[string "*:OnClick"]:7: in function <[string "*:OnClick"]:1>
Locals: <none>

Same error was after 2.5.2 in Leatrix Maps, but they fix it on 2.5.55 version.
Tried searh for it and can't find where is any string that call for FriendsFrame.lua
I've been away from the game for a while, but I popped on to check this out and wasn't able to reproduce it. It could be another addon tainting it, but it's hard to say - MageButtons definitely shouldn't be messing with the guild/friends frames. I'd say try disabling other addons and see if it still happens, and if you can give me steps to reproduce I'll see what I can do.
Report comment to moderator  
Reply With Quote
Unread 09-15-21, 11:03 PM  
Himitsu1990
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
Lua Error

Whatever I open guild menu and try to click on it, or scrolldown, this error came out:
Message: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
Time: Thu Sep 16 07:12:48 2021
Count: 1
Stack: [ADDON_ACTION_FORBIDDEN] AddOn 'MageButtons' tried to call the protected function 'GuildControlSetRank()'.
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2508: in function `GuildControlPopupFrame_Initialize'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:966: in function `FriendsFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>
[string "=[C]"]: in function `SetGuildRosterShowOffline'
[string "*:OnClick"]:7: in function <[string "*:OnClick"]:1>
Locals: <none>

Same error was after 2.5.2 in Leatrix Maps, but they fix it on 2.5.55 version.
Tried searh for it and can't find where is any string that call for FriendsFrame.lua
Last edited by Himitsu1990 : 09-15-21 at 11:21 PM.
Report comment to moderator  
Reply With Quote
Unread 08-05-21, 10:06 AM  
Oonade
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Not sure if this was posted before, but;
it should not be the hardest work to transform this into 'warlockbuttons'? For curses, demons, stones...?
I found magebuttons addon most useful in classic, now switched to warlock in TBC and I miss this kind of addon.
Report comment to moderator  
Reply With Quote
Unread 07-19-21, 02:29 AM  
lfxgroove
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
Originally Posted by WoWEyE
I clicked the link to try and download it but couldnt see anywhere to do that. Is it downloadable?
There's no release/zip downloadable as that is already available here, you can however download it via git or by pressing "Code" at the top right and choozing "download zip".

Edit: I've removed the repo for now as I realized there's no license for the original code.
Last edited by lfxgroove : 07-22-21 at 02:12 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: