Quantcast
Download
(138 Kb)
Download
Updated: 10-03-18 06:45 PM
Pictures
File Info
Compatibility:
Battle for Azeroth (8.0.1)
Updated:10-03-18 06:45 PM
Created:08-04-10 07:07 PM
Downloads:13,396
Favorites:41
MD5:
Categories:Action Bar Mods, Combat Mods, Unit Mods

ImpliedTarget  Popular! (More than 5000 hits)

Version: 1.3.12
by: Vrul [More]

This addon only works with action buttons provided by the default UI. Support for other action bar addons may be found in the Other Files tab.

Macros allow you to change the ability that you use based on whether your target is friend or foe. This addon allows you to do the opposite, change the target of an ability based on whether that ability is harmful or helpful. Support for custom paging of the main action bar is also provided (may be disabled by another addon).


Anyone with several macros similar to:

/cast [harm, nodead] [@targettarget, harm, nodead] [@mouseover, harm, nodead] [@pettarget, nodead] HarmfulSpell

or

/cast [@mouseover, help, nodead] [help, nodead] [@targettarget, help, nodead] [@player] HelpfulSpell

can instead set up a targeting priority and apply it to all of your action buttons without wasting a single macro.


To further enhance your mouseover targeting, two additional options are provided. @unitframe can be used in place of @mouseover to target a unit only if it is a unit frame. Similarly, @unitmodel can be used to target only units that are in the 3D world.


Note: Target behavior is only changed for spells and items placed directly into an action button.

Translators: To submit a translation please just edit an existing file (ImpliedTarget\Locales.lua or ImpliedTarget_Config\Locales\deDE.lua) and send it to me.

Developers: If you would like to make ImpliedTarget work with your addon then see the API below and look at how it was done for other addons in the Other Files tab.


API (these functions may be called in combat, but their effects won't happen until combat has ended)

ImpliedTarget.DisableKeyBinding()

Forces ImpliedTarget to disable it's key binding code and allow it to be garbage collected. Only call this if your addon will be providing this functionality.


ImpliedTarget.DisablePaging()

Forces ImpliedTarget to disable it's paging code for the primary action bar and allow it to be garbage collected. Only call this if your addon will be providing this functionality.


ImpliedTarget.AddButton(button [, bind])

Allow ImpliedTarget to alter the behavior of an action button.

Arguments:

button - (table or string) An action button or name of an action button.

bind - (string) The name of the key bind for the action button.
Returns:
button - (table or nil) If successful the action button is returned, otherwise nil.

ImpliedTarget.RemoveButton(button)

Prevent ImpliedTarget from altering the behavior of an action button.

Arguments:
button - (table or string) An action button or name of an action button.
Returns:
button - (table or nil) The action button if it was removed, nil if the action button had not been previously added.

Version 1.3.12 (10/03/2018)
- Changed Discipline Priest's Mindbender from 'help' to 'harm'
- Defaulting to UseAction for non-GTAoE abilities and CastSpellByID for GTAoE abilities

Version 1.3.11 (10/02/2018)
- Added Void Bolt to the Shadow Priest list of spells

Version 1.3.10 (09/30/2018)
- Fix to make actions more closely follow default behavior with regards to starting auto-attack

Version 1.3.9 (09/29/2018)
- Change for weird inconsistent behavior between CastSpellByID and CastSpellByName

Version 1.3.8 (09/29/2018)
- Included missing library file and toc info for LibDataBroker-1.1
- Added Locales.lua to help with anyone wanting to translate

Version 1.3.7 (09/28/2018)
- The modules for Bartender4 and Dominos are now their own addons and available separately
- Removed the Monk ability Chi Wave from the list of targeted actions
- Fixed the option for manual targeting preventing the use of auto-targeting and non-targeted actions
- Merged the Help options Auto and Manual into the drop-down Default
- Corrected an issue with item/spell names not being available until after a UI reload
- Added a LDB plugin
- Library update

Version 1.3.6 (08/27/2018)
- Fixed an error with converting GTAoE settings

Version 1.3.5 (08/26/2018)
- Changed the scope of some variables in ImpliedTarget_Config that were being leaked globally
- Corrected an issue with applying queued commands after combat
- Fixed an issue with detecting specialization changes for applying Harm Priority
- Added a "Manual" option to Harm, Help, Rez, and GTAoE to allow explicit cursor targeting
- Reworded some stuff in the options

Version 1.3.4 (07/24/2018)
- Updated for 8.0
- Reworked how some things are processed behind the scenes
- Added support for ground targeted area of effect (gtaoe) abilities (manually added only)

Version 1.3.3 (02/08/2018)
- Fixed error when assigning custom parameters

Version 1.3.2 (01/21/2018)
- Corrected the classification of the Warlock ability "Phantom Singularity" from 'help' to 'harm'
- Fixed errors with harm priority and roles

Version 1.3.1 (09/02/2017)
- Updated for 7.3

Version 1.3 (07/18/2016)
- Updated for 7.0
- Significant reworking of how things are done behind-the-scenes
- Added a feature to prioritize harm/help for dual-role abilities based on role

Version 1.2.2 (10/19/2014)
- Fix for key binds not working after a reload

Version 1.2.1 (10/14/2014)
- Updated for 6.0

Version 1.2 (10/31/2013)
- Resurrection abilities are now completely separate from helpful abilities in the options
- Improved the way secure unwrapping was done to avoid conflicts with other addons
- Changing the active key bind set now updates key binds so they will still work
- Fix to allow key binds to work with the pet battle UI
- Fix for key binds containing "[" or "]"
- The Grid integration option was replaced with a more universal solution: @unitframe, @unitmodel
- Moved Bartender4 and Dominos support into separate addons as examples for any addon author looking to incorporate ImpliedTarget support
- Added some auto-correction for minor errors in parameters that are manually entered

Version 1.1.7 (09/18/2013)
- Fixed key bind issues with ExtraActionButton and PetBattleUI
- Corrected an issue with changing Paging settings

Version 1.1.6 (06/23/2013)
- Added an option to disable resurrection abilities from working with implied targeting
- Corrected the spellID for the warlock spell Soul Stone
- Improved behavior with Grid integration
- Option based code optimization

Version 1.1.5 (06/14/2013)
- Fixed an error and a bug with Grid integration

Version 1.1.4 (06/13/2013)
- Resurrection abilities will now also work with implied targeting
- Added an option for Grid users

Version 1.1.3 (09/02/2012)
- Added options for excluding entire action bars from implied targeting

Version 1.1.2 (07/28/2012)
- Updated for MoP

Version 1.1.1 (12/10/2011)
- Added compatibility for Dominos

Version 1.1 (11/26/2011)
- Added compatibility for Bartender4
- Changed options to be easier for novice users (borrowed Bartender4's style)

Version 1.0.5 (01/11/2011)
- Correct an issue with some empty vehicle buttons

Version 1.0.4 (01/04/2011)
- Fix for key binds that contain characters that have special meaning for Lua's format function

Version 1.0.3 (12/24/2010)
- Ignore spells that can't be identified as harmful or helpful (fixes errors with vehicle abilities)

Version 1.0.2 (10/13/2010)
- Updated for 4.0

Version 1.0.1 (08/06/2010)
- Fixed a bug when changing key binds for the main action bar

Version 1.0 (08/04/2010)
- Initial release
Optional Files (3)
File Name
Version
Size
Author
Date
Type
1.0
841B
09-27-18 04:43 PM
Addon
1.0
1kB
09-27-18 04:42 PM
Addon
2.0
2kB
08-06-18 12:36 PM
Addon


Archived Files (20)
File Name
Version
Size
Author
Date
1.3.11
138kB
Vrul
10-02-18 06:42 PM
1.3.10
138kB
Vrul
09-30-18 11:09 AM
1.3.9
138kB
Vrul
09-29-18 05:03 PM
1.3.8
138kB
Vrul
09-29-18 08:08 AM
1.3.7
137kB
Vrul
09-28-18 08:12 PM
1.3.6
138kB
Vrul
08-27-18 06:20 AM
1.3.5
138kB
Vrul
08-26-18 06:13 PM
1.3.4
137kB
Vrul
07-24-18 06:04 PM
1.3.3
131kB
Vrul
02-08-18 07:12 AM
1.3.2
131kB
Vrul
01-21-18 12:58 PM
1.3.1
131kB
Vrul
09-02-17 12:29 PM
1.3
130kB
Vrul
07-18-16 10:05 PM
1.2.2
115kB
Vrul
10-19-14 10:12 AM
1.2.1
115kB
Vrul
10-13-14 11:43 PM
1.2
114kB
Vrul
10-31-13 03:40 PM
1.1.7
106kB
Vrul
09-18-13 05:34 PM
1.1.6
105kB
Vrul
06-23-13 02:01 PM
1.1.4
104kB
Vrul
06-13-13 05:13 PM
1.1.3
102kB
Vrul
09-02-12 11:26 AM
1.1.2
102kB
Vrul
07-28-12 02:40 PM


Post A Reply Comment Options
Unread 04-18-20, 02:24 AM  
Amplus
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Re: Re: [help], [harm] macro's

Originally Posted by Vrul
Originally Posted by Amplus
Because I was playing around with it, and by the looks of it, this AddOn only works with plain spells on my actions bars.
It only works for actions directly on your bars and does not work with macros as that would defeat the point of the addon.
Thanks for the swift response.

I already had a feeling it would, and I agree that it would defeat the point if used for only 1 spell.

But I was secretly hoping with would work for simple macros as well, as that would make them a lot simpler and the mouseover priority would be a nice future too.

I wished @unitframe and @unitmodel were build-in macro conditionals. Those are some killer features.
I have not found any other AddOn that could do that, great job on that!
Report comment to moderator  
Reply With Quote
Unread 04-17-20, 05:32 PM  
Vrul
An Onyxian Warder
 
Vrul's Avatar
AddOn Author - Click to view AddOns

Forum posts: 353
File comments: 301
Uploads: 33
Re: [help], [harm] macro's

Originally Posted by Amplus
Because I was playing around with it, and by the looks of it, this AddOn only works with plain spells on my actions bars.
It only works for actions directly on your bars and does not work with macros as that would defeat the point of the addon.
Report comment to moderator  
Reply With Quote
Unread 04-17-20, 12:51 PM  
Amplus
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
[help], [harm] macro's

I just ran into this AddOn, since I am looking for a AddOn that let only mouseover unitframes.
And I was wondering if it also works with [help], [harm] macro's like:
#showtooltip
/cast [help] Shadow Mend, [harm] Smite

Or that this AddOn is only to be used with spells that can be used with for help and harm? Like Penance.

Or does anyone know a work around to make it work?

Because I was playing around with it, and by the looks of it, this AddOn only works with plain spells on my actions bars.
Report comment to moderator  
Reply With Quote
Unread 11-06-19, 04:02 AM  
acsboy
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Updated version for Classic WoW

I am very looking forward to a updated version for the Classsic as ImpliedTarget is quite useful for a healer in the raid.
Many thanks.
Report comment to moderator  
Reply With Quote
Unread 10-13-19, 07:27 AM  
Vrul
An Onyxian Warder
 
Vrul's Avatar
AddOn Author - Click to view AddOns

Forum posts: 353
File comments: 301
Uploads: 33
Re: GTAoE only working on self or cursor, but not others.

Originally Posted by iceypoi
I have what I believe to be a very simple string, but it only seems to work on myself or ground. It won't cast at any mouseover target. Here's the string:

Code:
[@mouseover, help, nodead] [@cursor]
I'm a disc priest and am observing the problem with feather, mass dispel and bubble. Any ideas?
@mouseover only works for spells that can target a unit just like @cursor only works for GTAoE spells. Basically, if you can't do it with a macro you can't do it with ImpliedTarget either.
Report comment to moderator  
Reply With Quote
Unread 10-12-19, 04:27 PM  
iceypoi
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
GTAoE only working on self or cursor, but not others.

I have what I believe to be a very simple string, but it only seems to work on myself or ground. It won't cast at any mouseover target. Here's the string:

Code:
[@mouseover, help, nodead] [@cursor]
I'm a disc priest and am observing the problem with feather, mass dispel and bubble. Any ideas?
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 07:54 AM  
bonitao
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Re: For WoW Classic

Originally Posted by RollbackSegment
Little hack/fix to use this excellent addon in WoW Classic :

Lua Code:
  1. diff --git a/ActionName.lua b/ActionName.lua
  2. index 8d998df..8c6ab5d 100644
  3. --- a/ActionName.lua
  4. +++ b/ActionName.lua
  5. @@ -150,10 +150,10 @@ addon:RegisterEvent('PLAYER_LOGIN', function(self, event)
  6.                                 local skillType, spellID = GetSpellBookItemInfo(bookID, BOOKTYPE_SPELL)
  7.                                 if skillType == 'SPELL' or skillType == 'FUTURESPELL' then
  8.                                         Process(spellID)
  9. -                                       if IsTalentSpell(bookID, BOOKTYPE_SPELL) then
  10. -                                               _, _, spellID = GetSpellBookItemName(bookID, BOOKTYPE_SPELL)
  11. -                                               actionTag.talent[Process(spellID)] = "talent"
  12. -                                       end
  13. +                                       --if IsTalentSpell(bookID, BOOKTYPE_SPELL) then
  14. +                                       --      _, _, spellID = GetSpellBookItemName(bookID, BOOKTYPE_SPELL)
  15. +                                       --      actionTag.talent[Process(spellID)] = "talent"
  16. +                                       --end
  17.                                 end
  18.                         end
  19.                 end
  20. diff --git a/Core.lua b/Core.lua
  21. index 01037f5..8730ced 100644
  22. --- a/Core.lua
  23. +++ b/Core.lua
  24. @@ -172,10 +172,12 @@ do
  25.         local activeHarmPriority
  26.  
  27.         function addon.ProcessSpecChange()
  28. +               --[[
  29.                 local spec, newRole, _ = GetSpecialization(), nil
  30.                 if spec then
  31.                         _, _, _, _, newRole = GetSpecializationInfo(spec)
  32.                 end
  33. +               ]]
  34.                 if not newRole then
  35.                         newRole = 'DAMAGER'
  36.                 end
  37. diff --git a/ImpliedTarget.toc b/ImpliedTarget.toc
  38. index 7e3d2e3..a0b4719 100644
  39. --- a/ImpliedTarget.toc
  40. +++ b/ImpliedTarget.toc
  41. @@ -1,8 +1,8 @@
  42. -## Interface: 80000
  43. +## Interface: 11302
  44.  ## Author: Vrul
  45. -## Version: 1.3.12
  46. +## Version: 1.3.12-classic
  47.  ## Title: ImpliedTarget
  48. -## Notes: Modifies action buttons so that they may change the target of an action based on whether that action is harmful or helpful.
  49. +## Notes: Modifies action buttons so that they may change the target of an action based on whether that action is harmful or helpful. Shameless fix for Classic. ## OptionalDeps: Ace3, CallbackHandler-1.0, LibDataBroker-1.1, LibOptionsAssist-1.1, LibSecureCmdOption-Beta, LibStub
  50.  ## SavedVariables: ImpliedTargetSettings
  51.  ## X-WoWI-ID: 17648
  52. diff --git a/KeyBinds.lua b/KeyBinds.lua
  53. index a4967cd..4dcc943 100644
  54. --- a/KeyBinds.lua
  55. +++ b/KeyBinds.lua
  56. @@ -113,7 +113,7 @@ addon:RegisterEvent('PLAYER_ENTERING_WORLD', function(self, event)
  57.         addon.RemoveKeyBinds = RemoveKeyBinds
  58.         addon.UpdateKeyBinds = ApplyKeyBinds
  59.         hooksecurefunc('LoadBindings', SafeApplyKeyBinds)
  60. -       hooksecurefunc('SaveBindings', SafeApplyKeyBinds)
  61. +       --hooksecurefunc('SaveBindings', SafeApplyKeyBinds)
  62.         SafeApplyKeyBinds()
  63.  end)
  64.  
  65. diff --git a/Settings.lua b/Settings.lua
  66. index ad53369..f9aa80e 100644
  67. --- a/Settings.lua
  68. +++ b/Settings.lua
  69. @@ -99,9 +99,9 @@ addon.defaultSettings = {
  70.  
  71.  do
  72.         local paging = {
  73. -               ("[vehicleui] %d"):format(GetVehicleBarIndex()),
  74. -               ("[overridebar] %s"):format(GetOverrideBarIndex()),
  75. -               ("[possessbar] [@vehicle, exists] %s"):format(GetVehicleBarIndex()),
  76. +               --("[vehicleui] %d"):format(GetVehicleBarIndex()),
  77. +               --("[overridebar] %s"):format(GetOverrideBarIndex()),
  78. +               --("[possessbar] [@vehicle, exists] %s"):format(GetVehicleBarIndex()),
  79.                 ("[shapeshift] %d"):format(GetTempShapeshiftBarIndex())
  80.         }
  81.         for index = 2, NUM_ACTIONBAR_PAGES do
  82. @@ -129,7 +129,7 @@ addon:RegisterEvent('ADDON_LOADED', function(self, event, name)
  83.         RegisterCallback(self, 'OnProfileCopied', "ApplySettings")
  84.         RegisterCallback(self, 'OnProfileReset', "ApplySettings")
  85.  
  86. -       self:RegisterUnitEvent('PLAYER_SPECIALIZATION_CHANGED', self.ProcessSpecChange, 'player')
  87. +       --self:RegisterUnitEvent('PLAYER_SPECIALIZATION_CHANGED', self.ProcessSpecChange, 'player')
  88.         local preHook = addon.header.PLAYER_LOGIN
  89.         self:RegisterEvent('PLAYER_LOGIN', function(self, event)                                        -- ActionName.lua
  90.                 if preHook then
Hi, which .lua do i change with this?

thanks!
Report comment to moderator  
Reply With Quote
Unread 09-01-19, 09:31 AM  
RollbackSegment
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Re: Re: For WoW Classic

Hello,

Could you be more specific ? Did you download the last version of the addon ? Did you comment the lines as shown in the diff command ? What does not work exactly ?

Originally Posted by Nicolya
Don't work

Last edited by RollbackSegment : 09-01-19 at 09:33 AM.
Report comment to moderator  
Reply With Quote
Unread 08-28-19, 08:15 AM  
Nicolya
A Fallenroot Satyr

Forum posts: 29
File comments: 16
Uploads: 0
Re: For WoW Classic

Don't work


Originally Posted by RollbackSegment
Little hack/fix to use this excellent addon in WoW Classic :

Lua Code:
  1. diff --git a/ActionName.lua b/ActionName.lua
  2. index 8d998df..8c6ab5d 100644
  3. --- a/ActionName.lua
  4. +++ b/ActionName.lua
  5. @@ -150,10 +150,10 @@ addon:RegisterEvent('PLAYER_LOGIN', function(self, event)
  6.                                 local skillType, spellID = GetSpellBookItemInfo(bookID, BOOKTYPE_SPELL)
  7.                                 if skillType == 'SPELL' or skillType == 'FUTURESPELL' then
  8.                                         Process(spellID)
  9. -                                       if IsTalentSpell(bookID, BOOKTYPE_SPELL) then
  10. -                                               _, _, spellID = GetSpellBookItemName(bookID, BOOKTYPE_SPELL)
  11. -                                               actionTag.talent[Process(spellID)] = "talent"
  12. -                                       end
  13. +                                       --if IsTalentSpell(bookID, BOOKTYPE_SPELL) then
  14. +                                       --      _, _, spellID = GetSpellBookItemName(bookID, BOOKTYPE_SPELL)
  15. +                                       --      actionTag.talent[Process(spellID)] = "talent"
  16. +                                       --end
  17.                                 end
  18.                         end
  19.                 end
  20. diff --git a/Core.lua b/Core.lua
  21. index 01037f5..8730ced 100644
  22. --- a/Core.lua
  23. +++ b/Core.lua
  24. @@ -172,10 +172,12 @@ do
  25.         local activeHarmPriority
  26.  
  27.         function addon.ProcessSpecChange()
  28. +               --[[
  29.                 local spec, newRole, _ = GetSpecialization(), nil
  30.                 if spec then
  31.                         _, _, _, _, newRole = GetSpecializationInfo(spec)
  32.                 end
  33. +               ]]
  34.                 if not newRole then
  35.                         newRole = 'DAMAGER'
  36.                 end
  37. diff --git a/ImpliedTarget.toc b/ImpliedTarget.toc
  38. index 7e3d2e3..a0b4719 100644
  39. --- a/ImpliedTarget.toc
  40. +++ b/ImpliedTarget.toc
  41. @@ -1,8 +1,8 @@
  42. -## Interface: 80000
  43. +## Interface: 11302
  44.  ## Author: Vrul
  45. -## Version: 1.3.12
  46. +## Version: 1.3.12-classic
  47.  ## Title: ImpliedTarget
  48. -## Notes: Modifies action buttons so that they may change the target of an action based on whether that action is harmful or helpful.
  49. +## Notes: Modifies action buttons so that they may change the target of an action based on whether that action is harmful or helpful. Shameless fix for Classic. ## OptionalDeps: Ace3, CallbackHandler-1.0, LibDataBroker-1.1, LibOptionsAssist-1.1, LibSecureCmdOption-Beta, LibStub
  50.  ## SavedVariables: ImpliedTargetSettings
  51.  ## X-WoWI-ID: 17648
  52. diff --git a/KeyBinds.lua b/KeyBinds.lua
  53. index a4967cd..4dcc943 100644
  54. --- a/KeyBinds.lua
  55. +++ b/KeyBinds.lua
  56. @@ -113,7 +113,7 @@ addon:RegisterEvent('PLAYER_ENTERING_WORLD', function(self, event)
  57.         addon.RemoveKeyBinds = RemoveKeyBinds
  58.         addon.UpdateKeyBinds = ApplyKeyBinds
  59.         hooksecurefunc('LoadBindings', SafeApplyKeyBinds)
  60. -       hooksecurefunc('SaveBindings', SafeApplyKeyBinds)
  61. +       --hooksecurefunc('SaveBindings', SafeApplyKeyBinds)
  62.         SafeApplyKeyBinds()
  63.  end)
  64.  
  65. diff --git a/Settings.lua b/Settings.lua
  66. index ad53369..f9aa80e 100644
  67. --- a/Settings.lua
  68. +++ b/Settings.lua
  69. @@ -99,9 +99,9 @@ addon.defaultSettings = {
  70.  
  71.  do
  72.         local paging = {
  73. -               ("[vehicleui] %d"):format(GetVehicleBarIndex()),
  74. -               ("[overridebar] %s"):format(GetOverrideBarIndex()),
  75. -               ("[possessbar] [@vehicle, exists] %s"):format(GetVehicleBarIndex()),
  76. +               --("[vehicleui] %d"):format(GetVehicleBarIndex()),
  77. +               --("[overridebar] %s"):format(GetOverrideBarIndex()),
  78. +               --("[possessbar] [@vehicle, exists] %s"):format(GetVehicleBarIndex()),
  79.                 ("[shapeshift] %d"):format(GetTempShapeshiftBarIndex())
  80.         }
  81.         for index = 2, NUM_ACTIONBAR_PAGES do
  82. @@ -129,7 +129,7 @@ addon:RegisterEvent('ADDON_LOADED', function(self, event, name)
  83.         RegisterCallback(self, 'OnProfileCopied', "ApplySettings")
  84.         RegisterCallback(self, 'OnProfileReset', "ApplySettings")
  85.  
  86. -       self:RegisterUnitEvent('PLAYER_SPECIALIZATION_CHANGED', self.ProcessSpecChange, 'player')
  87. +       --self:RegisterUnitEvent('PLAYER_SPECIALIZATION_CHANGED', self.ProcessSpecChange, 'player')
  88.         local preHook = addon.header.PLAYER_LOGIN
  89.         self:RegisterEvent('PLAYER_LOGIN', function(self, event)                                        -- ActionName.lua
  90.                 if preHook then
Report comment to moderator  
Reply With Quote
Unread 08-19-19, 08:31 AM  
RollbackSegment
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
For WoW Classic

Little hack/fix to use this excellent addon in WoW Classic :

Lua Code:
  1. diff --git a/ActionName.lua b/ActionName.lua
  2. index 8d998df..8c6ab5d 100644
  3. --- a/ActionName.lua
  4. +++ b/ActionName.lua
  5. @@ -150,10 +150,10 @@ addon:RegisterEvent('PLAYER_LOGIN', function(self, event)
  6.                                 local skillType, spellID = GetSpellBookItemInfo(bookID, BOOKTYPE_SPELL)
  7.                                 if skillType == 'SPELL' or skillType == 'FUTURESPELL' then
  8.                                         Process(spellID)
  9. -                                       if IsTalentSpell(bookID, BOOKTYPE_SPELL) then
  10. -                                               _, _, spellID = GetSpellBookItemName(bookID, BOOKTYPE_SPELL)
  11. -                                               actionTag.talent[Process(spellID)] = "talent"
  12. -                                       end
  13. +                                       --if IsTalentSpell(bookID, BOOKTYPE_SPELL) then
  14. +                                       --      _, _, spellID = GetSpellBookItemName(bookID, BOOKTYPE_SPELL)
  15. +                                       --      actionTag.talent[Process(spellID)] = "talent"
  16. +                                       --end
  17.                                 end
  18.                         end
  19.                 end
  20. diff --git a/Core.lua b/Core.lua
  21. index 01037f5..8730ced 100644
  22. --- a/Core.lua
  23. +++ b/Core.lua
  24. @@ -172,10 +172,12 @@ do
  25.         local activeHarmPriority
  26.  
  27.         function addon.ProcessSpecChange()
  28. +               --[[
  29.                 local spec, newRole, _ = GetSpecialization(), nil
  30.                 if spec then
  31.                         _, _, _, _, newRole = GetSpecializationInfo(spec)
  32.                 end
  33. +               ]]
  34.                 if not newRole then
  35.                         newRole = 'DAMAGER'
  36.                 end
  37. diff --git a/ImpliedTarget.toc b/ImpliedTarget.toc
  38. index 7e3d2e3..a0b4719 100644
  39. --- a/ImpliedTarget.toc
  40. +++ b/ImpliedTarget.toc
  41. @@ -1,8 +1,8 @@
  42. -## Interface: 80000
  43. +## Interface: 11302
  44.  ## Author: Vrul
  45. -## Version: 1.3.12
  46. +## Version: 1.3.12-classic
  47.  ## Title: ImpliedTarget
  48. -## Notes: Modifies action buttons so that they may change the target of an action based on whether that action is harmful or helpful.
  49. +## Notes: Modifies action buttons so that they may change the target of an action based on whether that action is harmful or helpful. Shameless fix for Classic. ## OptionalDeps: Ace3, CallbackHandler-1.0, LibDataBroker-1.1, LibOptionsAssist-1.1, LibSecureCmdOption-Beta, LibStub
  50.  ## SavedVariables: ImpliedTargetSettings
  51.  ## X-WoWI-ID: 17648
  52. diff --git a/KeyBinds.lua b/KeyBinds.lua
  53. index a4967cd..4dcc943 100644
  54. --- a/KeyBinds.lua
  55. +++ b/KeyBinds.lua
  56. @@ -113,7 +113,7 @@ addon:RegisterEvent('PLAYER_ENTERING_WORLD', function(self, event)
  57.         addon.RemoveKeyBinds = RemoveKeyBinds
  58.         addon.UpdateKeyBinds = ApplyKeyBinds
  59.         hooksecurefunc('LoadBindings', SafeApplyKeyBinds)
  60. -       hooksecurefunc('SaveBindings', SafeApplyKeyBinds)
  61. +       --hooksecurefunc('SaveBindings', SafeApplyKeyBinds)
  62.         SafeApplyKeyBinds()
  63.  end)
  64.  
  65. diff --git a/Settings.lua b/Settings.lua
  66. index ad53369..f9aa80e 100644
  67. --- a/Settings.lua
  68. +++ b/Settings.lua
  69. @@ -99,9 +99,9 @@ addon.defaultSettings = {
  70.  
  71.  do
  72.         local paging = {
  73. -               ("[vehicleui] %d"):format(GetVehicleBarIndex()),
  74. -               ("[overridebar] %s"):format(GetOverrideBarIndex()),
  75. -               ("[possessbar] [@vehicle, exists] %s"):format(GetVehicleBarIndex()),
  76. +               --("[vehicleui] %d"):format(GetVehicleBarIndex()),
  77. +               --("[overridebar] %s"):format(GetOverrideBarIndex()),
  78. +               --("[possessbar] [@vehicle, exists] %s"):format(GetVehicleBarIndex()),
  79.                 ("[shapeshift] %d"):format(GetTempShapeshiftBarIndex())
  80.         }
  81.         for index = 2, NUM_ACTIONBAR_PAGES do
  82. @@ -129,7 +129,7 @@ addon:RegisterEvent('ADDON_LOADED', function(self, event, name)
  83.         RegisterCallback(self, 'OnProfileCopied', "ApplySettings")
  84.         RegisterCallback(self, 'OnProfileReset', "ApplySettings")
  85.  
  86. -       self:RegisterUnitEvent('PLAYER_SPECIALIZATION_CHANGED', self.ProcessSpecChange, 'player')
  87. +       --self:RegisterUnitEvent('PLAYER_SPECIALIZATION_CHANGED', self.ProcessSpecChange, 'player')
  88.         local preHook = addon.header.PLAYER_LOGIN
  89.         self:RegisterEvent('PLAYER_LOGIN', function(self, event)                                        -- ActionName.lua
  90.                 if preHook then
Report comment to moderator  
Reply With Quote
Unread 10-05-18, 07:44 AM  
Darchrys
A Kobold Labourer

Forum posts: 0
File comments: 5
Uploads: 0
Originally Posted by Vrul
Originally Posted by Darchrys
Just a thought on this - the spell ID changes (from 34433 to 254224) when you have the glyph applied, could this be the reason?
Yes, but does it still not work in version 1.3.12? I switched from using CastSpellByID to UseAction as the default for non-GTAoE actions and was hoping that would fix that as well.
Just checked with the voidling Glyph and yes it does work now (sorry had removed the Glyph when I noticed it wasn't working so hadn't checked before I posted.) Great thanks.
Report comment to moderator  
Reply With Quote
Unread 10-04-18, 06:02 AM  
Vrul
An Onyxian Warder
 
Vrul's Avatar
AddOn Author - Click to view AddOns

Forum posts: 353
File comments: 301
Uploads: 33
Originally Posted by Darchrys
Just a thought on this - the spell ID changes (from 34433 to 254224) when you have the glyph applied, could this be the reason?
Yes, but does it still not work in version 1.3.12? I switched from using CastSpellByID to UseAction as the default for non-GTAoE actions and was hoping that would fix that as well.
Report comment to moderator  
Reply With Quote
Unread 10-04-18, 03:52 AM  
Darchrys
A Kobold Labourer

Forum posts: 0
File comments: 5
Uploads: 0
Originally Posted by Vrul
Void Bolt should be fixed in the version (1.3.11) that I just put up. I still need to look into the glyphed Shadow Fiend issue.
Just a thought on this - the spell ID changes (from 34433 to 254224) when you have the glyph applied, could this be the reason?
Report comment to moderator  
Reply With Quote
Unread 10-03-18, 10:09 PM  
Vrul
An Onyxian Warder
 
Vrul's Avatar
AddOn Author - Click to view AddOns

Forum posts: 353
File comments: 301
Uploads: 33
Re: Priest Penance

Originally Posted by bonitao
Hi, me again!

Remembered something that bugged me for some time (got used to it).

Since i play discipline, i choose both damage and healer on the first menu hehe. But Penance doesn't respect the mouseover for heals just for harm, even with mouseover priority selected.

I don't know if there is a limitation here, but i think is worth mentioning.
Harm Priority does what it says, prioritizes harm targets over heal targets. If you selected Healer as a Discipline Priest then Penance will always try to harm before heal. Basically it just picks which options to look at first (Harm or Heal) and if no valid target is found then it goes to the other set.
Report comment to moderator  
Reply With Quote
Unread 10-03-18, 09:45 PM  
bonitao
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Priest Penance

Hi, me again!

Remembered something that bugged me for some time (got used to it).

Since i play discipline, i choose both damage and healer on the first menu hehe. But Penance doesn't respect the mouseover for heals just for harm, even with mouseover priority selected.

I don't know if there is a limitation here, but i think is worth mentioning.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: