Frenemy 

1. On line 146, replace `BNet_GetClientEmbeddedTexture` with `BNet_GetClientEmbeddedAtlas`. The arguments are the same; the function was just renamed.
2. On line 167 and line 173, replace `RAID_CLASS_COLORS[classToken]` with `C_ClassColor.GetClassColor(classToken)`. I believe this code is sometimes running before the RAID_CLASS_COLORS table is loaded, so this change will help fix that.
3. After doing those changes, delete lines 76 through 82 and then delete lines 72 through 74. This is needed because most of these values were removed from WoW's interface files - except for WoW itself, App, Client, and Heroes.

local BNET_CLIENT_MOBILE = "BSAp"
local BNET_CLIENT_SC2 = "S2";
local BNET_CLIENT_D3 = "D3";
local BNET_CLIENT_WTCG = "WTCG";
local BNET_CLIENT_OVERWATCH = "Pro";
local BNET_CLIENT_SC = "S1";
local BNET_CLIENT_DESTINY2 = "DST2";
local BNET_CLIENT_COD = "VIPR";
local BNET_CLIENT_COD_MW = "ODIN";
local BNET_CLIENT_COD_MW2 = "LAZR";
local BNET_CLIENT_COD_BOCW = "ZEUS";
local BNET_CLIENT_WC3 = "W3";
local BNET_CLIENT_ARCADE = "RTRO";
local BNET_CLIENT_CRASH4 = "WLBY";
local BNET_CLIENT_D2 = "OSI";
local BNET_CLIENT_COD_VANGUARD = "FORE";
local BNET_CLIENT_DI = "ANBS";
local BNET_CLIENT_ARCLIGHT = "GRY";
 
local CLIENT_SORT_ORDERS = {
    [_G.BNET_CLIENT_WOW] = 1,
    [BNET_CLIENT_SC2] = 2,
    [BNET_CLIENT_D3] = 3,
    [BNET_CLIENT_WTCG] = 4,
    [_G.BNET_CLIENT_HEROES] = 5,
    [BNET_CLIENT_OVERWATCH] = 6,
    [BNET_CLIENT_SC] = 7,
    [BNET_CLIENT_WC3] = 8,
    [BNET_CLIENT_DESTINY2] = 9,
    [BNET_CLIENT_COD] = 10,
    [BNET_CLIENT_COD_MW] = 11,
    [BNET_CLIENT_COD_MW2] = 12,
    [BNET_CLIENT_COD_BOCW] = 13,
    [BNET_CLIENT_ARCADE] = 14,
    [BNET_CLIENT_CRASH4] = 15,
    [BNET_CLIENT_D2] = 16,
    [BNET_CLIENT_COD_VANGUARD] = 17,
    [BNET_CLIENT_DI] = 18,
    [BNET_CLIENT_ARCLIGHT] = 19,
    [_G.BNET_CLIENT_CLNT] = 20,
    [_G.BNET_CLIENT_APP] = 21,
    [BNET_CLIENT_MOBILE] = 22
}

• Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances.
• Alt+click to invite.
• Shift+click to send a Who request.
• Ctrl+click to set a note (check CanEditPublicNote() for guild members).
• Ctrl+right-click to set an officer note if CanEditOfficerNote().
• Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?
• Allow the guild message of the day to be edited when clicked if CanEditMOTD().
• Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD.
• Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range.
• Color realm names with faction color.
• Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..
• Color guild ranks with a gradient based on their index.
• Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.
• Add a class column populated by class icons for another method of sorting.
• Add an option to reformat the string used for the broker's text. RealID Toons does something similar. I'd prefer to add the friends and Real ID counts together, as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows:

Lua Code:

function DataObject:UpdateDisplay()
    local output = ("%d |cFF3E819B%s|r"):format(OnlineFriendsCount + OnlineBattleNetCount, _G.FRIENDS)
 
    if _G.IsInGuild() then
        output = ("%s %d |cFF3E819B%s|r"):format(output, OnlineGuildMembersCount, _G.GUILD)
    end
 
    self.text = output
end

• I can't click on guild members when I first login or reload the UI. However, if I open the guild frame it will begin to work.
• I can't click character names for Real ID/BattleTag friends. Is this intentional? I haven't checked the code.
• If you have a character added to your friends list that belongs to a Real ID/BattleTag friend, they appear twice. Why do this? Well, adding characters to your friends list changes the color of the name displayed above their head—making it easier to pick them out in a crowd.
• There is a colon used in the realm column header, but nowhere else.