Quantcast
Download
(125 Kb)
Download
Updated: 09-06-19 09:09 AM
Pictures
File Info
Compatibility:
Classic (1.13.2)
Updated:09-06-19 09:09 AM
Created:09-04-19 12:00 PM
Downloads:13,343
Favorites:73
MD5:

Easy Fishing Classic  Popular! (More than 5000 hits)

Version: 1.2
by: Firedancer [More]

This AddOn enables double-right-click to cast for Fishing when a fishing pole is equipped. Additionally, it will disable Click To Move while a fishing pole is equipped, and re-enable it when the fishing pole is unequipped. There are options to turn off Ambience and Music while a fishing pole is equipped (and turn them back on when you unequip the fishing pole) as well as enabling Auto Loot while fishing (if you normally keep it turned off). All options are ENABLED by default.

You're currently on your own for applying fishing lures - if I can figure out a good way to do it, I'll add it in the future.

Disclaimer: My testing character is a level 10 Gnome with a fishing skill of 50 using a vendor bought Fishing Pole. I have tested this to the best of that character's abilities, but something might be wonky. Please let me know if you encounter any trouble!

Credits: Ammo for FishermansFriend, which this is based on.

v1.2
Rewritten using FishermansFriend as the base; now has in-game options!

v1.1a
Disable sound changes by default (forgot to reset it before I zipped)

v1.1
Disable click to move when a fishing pole is equipped - thanks MoopMoom!
Fix fishing pole lookup

v1.0
Initial release
Optional Files (0)


Archived Files (2)
File Name
Version
Size
Author
Date
1.1a
2kB
Firedancer
09-05-19 10:57 AM
1.0
2kB
Firedancer
09-04-19 12:00 PM


Post A Reply Comment Options
Unread 10-28-19, 02:07 PM  
SpareSimian
A Murloc Raider

Forum posts: 8
File comments: 4
Uploads: 0
Fishing Buddy is finally available for Classic:

https://www.curseforge.com/wow/addon...-buddy-classic

Firedancer, I do appreciate your stepping in while FB was still being ported. I really used the double-click feature a lot and hacked in the sound save/restore to deal with Classic's much quieter bobber sound. So your work was not wasted!
Report comment to moderator  
Reply With Quote
Unread 10-28-19, 12:37 PM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 54
Uploads: 2
Originally Posted by SpareSimian
I worked to add save/restore of sounds but the restore part isn't reliable and is sometimes leaving me without sound. Can someone spot my bug?
Looks like you're using an old version of the addon, as I used a different base addon for the current release (which has sound saved variables).

Just a note for everyone: I'm not playing Classic anymore. I'm sure someone else has a fishing addon that is similar by now; you won't hurt my feelings if you decide to switch. I just tend to forget that I should check my messages/comments to see if anything has broken.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 10-16-19, 10:41 PM  
SpareSimian
A Murloc Raider

Forum posts: 8
File comments: 4
Uploads: 0
I worked to add save/restore of sounds but the restore part isn't reliable and is sometimes leaving me without sound. Can someone spot my bug?

Code:
--[[ based on the sFishing addon by Coolkid; fixed to work in Classic by Firedancer ]]--
local knowFish = false
local spell = GetSpellInfo(7620) or GetSpellInfo(7731) or GetSpellInfo(7732) or GetSpellInfo(18248)
local isPole = false
local holder = CreateFrame("Frame", nil, UIParent)

local sound = true -- set to false if you don't want to override your sound settings

local soundSaved = false
local old_Sound_MasterVolume = GetCVar("Sound_MasterVolume") -- default is 1.0
local old_Sound_SFXVolume = GetCVar("Sound_SFXVolume") -- default is 0.8
local old_Sound_MusicVolume = GetCVar("Sound_MusicVolume") -- default is 0.4
local old_Sound_AmbienceVolume = GetCVar("Sound_AmbienceVolume") -- default is 0.6

local function SaveSound()
	old_Sound_MasterVolume = GetCVar("Sound_MasterVolume")
	old_Sound_SFXVolume = GetCVar("Sound_SFXVolume")
	old_Sound_MusicVolume = GetCVar("Sound_MusicVolume")
	old_Sound_AmbienceVolume = GetCVar("Sound_AmbienceVolume")
	soundSaved = true
	--[[
	DEFAULT_CHAT_FRAME:AddMessage ("EasyFishingClassic: old sound settings saved: "
		.. old_Sound_MasterVolume .. " "
		.. old_Sound_SFXVolume .. " "
		.. old_Sound_MusicVolume .. " "
		.. old_Sound_AmbienceVolume)
	]]--
end
--[[ turn on master/sfx (bobber sound) and turn off music/ambience ]]--
local function EnhanceSound()
	SaveSound()
	SetCVar("Sound_MasterVolume", 1.0)
	SetCVar("Sound_SFXVolume", 1.0)
	SetCVar("Sound_MusicVolume", 0.0)
	SetCVar("Sound_AmbienceVolume", 0.0)
	-- DEFAULT_CHAT_FRAME:AddMessage ("EasyFishingClassic: fishing sound enhanced")
end
--[[ reset all values to default // find your values in _classic_\WTF\Config.wtf ]]--
local function RestoreSound()
	if soundSaved then
		SetCVar("Sound_MasterVolume", old_Sound_MasterVolume)
		SetCVar("Sound_SFXVolume", old_Sound_SFXVolume)
		SetCVar("Sound_MusicVolume", old_Sound_MusicVolume)
		SetCVar("Sound_AmbienceVolume", old_Sound_AmbienceVolume)
		soundSaved = false
		-- DEFAULT_CHAT_FRAME:AddMessage ("EasyFishingClassic: old sound settings restored")
	else
		-- DEFAULT_CHAT_FRAME:AddMessage ("EasyFishingClassic: no old sound settings to restore")
	end
end
local function SaveRestoreSound()
	if sound == true then
		if isPole then EnhanceSound() else RestoreSound() end
	end
end

local function ResetOverride()
	btn.holder:Hide()
	ClearOverrideBindings(btn)
end
local function ClickHandled(self)
	ResetOverride()
end
local function OverrideClick()
	SetOverrideBindingClick(btn, true, "BUTTON2", "FishHolder")
	btn.holder:Show()
end
btn = CreateFrame("Button", "FishHolder", holder, "SecureActionButtonTemplate")
btn.holder = holder
btn:EnableMouse(true)
btn:RegisterForClicks("RightButtonUp")
btn:Show()

holder:SetPoint("LEFT", UIParent, "RIGHT", 10000, 0)
holder:SetFrameStrata("LOW")
holder:Hide()
btn:SetScript("PostClick", ClickHandled)

local function IsFishPole()
	local itemId = GetInventoryItemID("player", 16)
	-- DEFAULT_CHAT_FRAME:AddMessage ("isFishPole: " .. itemId)
	if itemId == 6256 or itemId == 12225 or itemId == 6365 or itemId == 6367 or itemId == 19022 or itemId == 19970 then
		return true
	else
		return false
	end
end
local lastClickTime = nil
local function CheckForDoubleClick()
	if lastClickTime then
		local pressTime = GetTime()
		local doubleTime = pressTime - lastClickTime
		if ( (doubleTime < 0.4) and (doubleTime > 0.05) ) then
			lastClickTime = nil
			return true
		end
	end
	lastClickTime = GetTime()
	return false
end
local function OnMouseDown(...)
	local button = select(2, ...)
	if button == "RightButton" and not InCombatLockdown() and CheckForDoubleClick() and knowFish and isPole then
		btn:SetAttribute("type", "spell")
		btn:SetAttribute('spell', spell)
		OverrideClick()
	end
end

local resetClickToMove = nil
local function ctmOff()
	if GetCVar("autointeract") == "1" then
		resetClickToMove = true
		SetCVar("autointeract", "0")
	end
end
local function ctmOn()
	if resetClickToMove then
		SetCVar("autointeract", "1")
		resetClickToMove = nil
	end
end

btn:RegisterEvent("PLAYER_ENTERING_WORLD")
btn:RegisterEvent("PLAYER_EQUIPMENT_CHANGED")
btn:SetScript("OnEvent", function(self, event)
	if event == "PLAYER_ENTERING_WORLD" then
		self:UnregisterEvent("PLAYER_ENTERING_WORLD")
		if (IsSpellKnown(7620)) or (IsSpellKnown(7731)) or (IsSpellKnown(7732)) or (IsSpellKnown(18248)) then
			knowFish = true
			WorldFrame:HookScript("OnMouseDown", OnMouseDown)
		end
		isPole = IsFishPole()
		SaveRestoreSound()
		if not resetClickToMove then ctmOff() elseif resetClickToMove then ctmOn() end 
	end
	if event == "PLAYER_EQUIPMENT_CHANGED" then
		isPole = IsFishPole()
		SaveRestoreSound()
		if not resetClickToMove then ctmOff() elseif resetClickToMove then ctmOn() end 
	end
end)
Report comment to moderator  
Reply With Quote
Unread 10-14-19, 12:44 PM  
asemco
A Kobold Labourer
 
asemco's Avatar

Forum posts: 0
File comments: 1
Uploads: 0
Hello! I've added a toggle-able double click option to this addon.
You can get it from here if you'd like.

I'll contact Firedancer and see if they'll upload it here.
Enjoy!

Edit: Added double click wait time slider as well!
Last edited by asemco : 10-14-19 at 12:58 PM.
Report comment to moderator  
Reply With Quote
Unread 09-09-19, 01:56 AM  
Ravenadd
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Re: Re: Zone requirements

Originally Posted by Firedancer
Originally Posted by Ravenadd
Would it be possible to add to the map, which requirement each zone requires, to be able to fish in them? :-)
I'm afraid that's a bit outside the scope of both this addon and my lua knowledge. My intent was just to make the actual act of fishing easier. You can find the fishing info for zones at El's Anglin' Reborn; I used that info to make a simple text WeakAura that attaches to the worldmap. Additionally, there is an addon on another site that says it can do this for you.
Thank you for the quick and in-depth reply, its exactly what i was looking for - and yet again thanks for the addon, its been a good fishing session this night now that right-click to cast is back ;-)
Report comment to moderator  
Reply With Quote
Unread 09-08-19, 11:25 PM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 54
Uploads: 2
Re: Zone requirements

Originally Posted by Ravenadd
Would it be possible to add to the map, which requirement each zone requires, to be able to fish in them? :-)
I'm afraid that's a bit outside the scope of both this addon and my lua knowledge. My intent was just to make the actual act of fishing easier. You can find the fishing info for zones at El's Anglin' Reborn; I used that info to make a simple text WeakAura that attaches to the worldmap. Additionally, there is an addon on another site that says it can do this for you.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-08-19, 09:03 PM  
Ravenadd
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Zone requirements

Hello,

First of all, thank you for the addon.

Would it be possible to add to the map, which requirement each zone requires, to be able to fish in them? :-)
Report comment to moderator  
Reply With Quote
Unread 09-06-19, 10:09 AM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 54
Uploads: 2
Originally Posted by Valimonde
I mean this. When I fish its working fine. But when I have a session that I never touch my fishing poll it's puting my master volume to 100%. Is there a way to store the variable for our volume settings before fishing and return to that instead of 100%?
It should now respect your sound settings. I just tested this by logging in, setting my master volume to 25%, then equipping my fishing pole. With the pole, the master volume went to 100% as expected (as that's what it is set to in the addon's options). When I swapped my pole for my dagger, the master volume went back to 25%.

If you find this isn't the case, please let me know!
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-06-19, 09:57 AM  
Valimonde
Will It Classic's Dad
 
Valimonde's Avatar
Premium Member

Forum posts: 1
File comments: 8
Uploads: 0
Originally Posted by Firedancer
Originally Posted by SpareSimian
Can you put this on GitHub? Then I can mess with the sound code and share it back to you easily.
It's not on GitHub right now, though I might put it there for localization help. I just uploaded v1.2, which adds in-game options for sounds and for enabling auto-loot while fishing (if one normally keeps that turned off).
Thanks for the great addon! I have not checked the new version with the menu, but I wanted to make sure that there is somehow a way for the app to not turn audio to 100% across the board?

I mean this. When I fish its working fine. But when I have a session that I never touch my fishing poll it's puting my master volume to 100%. Is there a way to store the variable for our volume settings before fishing and return to that instead of 100%?

Thanks
Report comment to moderator  
Reply With Quote
Unread 09-06-19, 09:11 AM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 54
Uploads: 2
Originally Posted by SpareSimian
Can you put this on GitHub? Then I can mess with the sound code and share it back to you easily.
It's not on GitHub right now, though I might put it there for localization help. I just uploaded v1.2, which adds in-game options for sounds and for enabling auto-loot while fishing (if one normally keeps that turned off).
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-06-19, 12:15 AM  
SpareSimian
A Murloc Raider

Forum posts: 8
File comments: 4
Uploads: 0
Can you put this on GitHub? Then I can mess with the sound code and share it back to you easily.
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 08:00 PM  
Whyspir
A Defias Bandit

Forum posts: 2
File comments: 6
Uploads: 0
Fast as Fast can Be!

Thank you again, Did not expect such a fast response, also got the sound, thank you for setting me strait.
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 12:53 PM  
Firedancer
An Aku'mai Servant
 
Firedancer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 35
File comments: 54
Uploads: 2
Originally Posted by spamplz
Originally Posted by Firedancer
Do you know Fishing and have a fishing pole equipped when you attempt to cast? If so, could you tell me the spellID for your fishing skill and the itemID for your fishing pole (or just their names and rank if you don't have the IDs in your tooltip) so I can see if I missed something? I only tested it with a regular Fishing Pole on a level 10 Gnome with 50 fishing skill.
It was spell 7731 and item 12225. It is fixed with the update, thank you so much!
I'm glad it works now! It was probably due to the fishing poles not being properly identified.
__________________
(\ /)
( . .) <( if you say 'plz' because it's shorter than 'please' then I'll say 'no' because it's shorter than 'yes' )
c('')('')
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 12:20 PM  
bravejohn
A Deviate Faerie Dragon

Forum posts: 17
File comments: 154
Uploads: 0
thanks a lot for this!! I was waiting for an addon for like this :P
Report comment to moderator  
Reply With Quote
Unread 09-05-19, 11:27 AM  
spamplz
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Originally Posted by Firedancer
Do you know Fishing and have a fishing pole equipped when you attempt to cast? If so, could you tell me the spellID for your fishing skill and the itemID for your fishing pole (or just their names and rank if you don't have the IDs in your tooltip) so I can see if I missed something? I only tested it with a regular Fishing Pole on a level 10 Gnome with 50 fishing skill.
It was spell 7731 and item 12225. It is fixed with the update, thank you so much!
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: