WoWInterface - Itemsort stack overflow.

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Itemsort stack overflow. (https://www.wowinterface.com/forums/showthread.php?t=34594)

Both c1 and c2 returns 'nil'.

Quote:

Originally Posted by sacrife (Post 203774)

I can't see the difference between this code and the one above from SDPhantom. What did you change?

I replaced the "<=" with "<" in line 8.

Quote:

Originally Posted by sacrife (Post 203774)

And also, how would I go about reversing the quality sort? Now its green > blue > epic. I want to see how it looks the other way.

Oh that has already been answered. ^^

Quote:

Originally Posted by sacrife (Post 203788)

Both c1 and c2 returns 'nil'.

Oops, I think that would happen if it tried to sort empty bag slots. This version should just put them at the end instead of comparing the quality/IDs of empty slots.

lua Code:

local QuickSort;
do
    local func = function(v1, v2)
        if v1[1] == 0 or v2[1] == 0 then -- Empty bag slot
            return v1[1] > v2[1]; -- Put empty slots last
        elseif v1[2] ~= v2[2] then
            return v1[2] > v2[2]; -- Higher quality first
        elseif v1[1] ~= v2[1] then
            return v1[1] < v2[1];
        else -- Compare stack counts
            local _, c1 = GetContainerItemInfo(v1[3].bagID, v1[3].slotID);
            local _, c2 = GetContainerItemInfo(v2[3].bagID, v2[3].slotID);
            return c1 < c2;
        end
    end;
    QuickSort = function(tbl) table.sort(tbl, func); end
end

Quote:

Originally Posted by Luzzifus (Post 203771)

I wrote that recursive sorting function because I didn't find a way to use table.sort with my data structure. I was also aware of the stack overflow errors it produced but I didn't find a way around it. So I hope it's ok if I use your code as a replacement in cargbags_Nivaya too?

Go ahead, I had written my own sorting function before that worked perfectly for the only exception that it was a Lua function instead of native C code, so it had the constraints of running through the script engine instead of directly in code.

It took a comparison function like table.sort() does without restriction, if a check returned true, the values remained, otherwise, it swapped them.

The switch back to table.sort() was ultimately to save CPU time. To handle the glitch with equal values, I would usually add a check against a unique number in each value. For items, this would be their location.

Quote:

Originally Posted by Saiket (Post 203795)

lua Code:

local QuickSort;
do
    local func = function(v1, v2)
        if v1[1] == 0 or v2[1] == 0 then -- Empty bag slot
            return v1[1] > v2[1]; -- Put empty slots last
        elseif v1[2] ~= v2[2] then
            return v1[2] > v2[2]; -- Higher quality first
        elseif v1[1] ~= v2[1] then
            return v1[1] < v2[1];
        else -- Compare stack counts
            local _, c1 = GetContainerItemInfo(v1[3].bagID, v1[3].slotID);
            local _, c2 = GetContainerItemInfo(v2[3].bagID, v2[3].slotID);
            return c1 < c2;
        end
    end;
    QuickSort = function(tbl) table.sort(tbl, func); end
end

It really makes me cringe seeing data function calls in a sort comparison function. I would rather have the info directly in the data structure. Then again, to have it make any sense would require an update in the whole codebase to accept the new structure. It barely makes sense now.

Quote:

Originally Posted by SDPhantom (Post 203806)

Adapting the data structure is pretty easy:

lua Code:

local buttonIDs = {}
for i, button in self:IterateButtons() do
    local item = cargBags:GetItemInfo(button.bagID, button.slotID)
    if item.link then
        local _,_,tQ = GetItemInfo(item.link)
        local _,cnt = GetContainerItemInfo(button.bagID, button.slotID)
        buttonIDs[i] = { item.id, tQ, button, cnt }
    else
        buttonIDs[i] = { 0, -2, button, -1 }
    end
end
QuickSort(buttonIDs) -- sorting call

And the corresponding sort function would be this:

lua Code:

local QuickSort;
do
    local func = function(v1, v2)
        if not v1 or not v2 then return (v1 and true or false) end
        if v1[1] == 0 or v2[1] == 0 then
            return v1[1] > v2[1] -- empty slots last
        elseif v1[2] ~= v2[2] then
            return v1[2] > v2[2] -- higher quality first
        elseif v1[1] ~= v2[1] then
            return v1[1] > v2[1] -- group identical item ids
        else
            return v1[4] > v2[4] -- full/larger stacks first
        end
    end;
    QuickSort = function(tbl) table.sort(tbl, func) end
end

Thanks a lot to all of you, really appreciate this, solved so many problems for me.

Quote:

Originally Posted by Luzzifus (Post 203885)

Adapting the data structure is pretty easy:

Again, having it make sense, then again, my style is more for readability than being nit-picky on resources.

Quote:

Originally Posted by SDPhantom (Post 203984)

Again, having it make sense, then again, my style is more for readability than being nit-picky on resources.

When it comes to compare functions which are being called about n times for each data entity in a sorting call (worst case scenario) it definititly is the better way to be nit-picky on ressources, especially cpu time. Readability is overrated. :p

I had to update it a bit to not do anything if it returned nil as opening clams, etc returned errors.

Code:

      local QuickSort;

      do

          local func = function(v1, v2)

                  if (v1 or v2 ~= nil) then

              if v1[1] == 0 or v2[1] == 0 then -- Empty bag slot

                  return v1[1] > v2[1]; -- Put empty slots last

              elseif v1[2] ~= v2[2] then

                  return v1[2] > v2[2]; -- Higher quality first

              elseif v1[1] ~= v2[1] then

                  return v1[1] < v2[1];

              else -- Compare stack counts

                  local _, c1 = GetContainerItemInfo(v1[3].bagID, v1[3].slotID);

                  local _, c2 = GetContainerItemInfo(v2[3].bagID, v2[3].slotID);

                  return c1 < c2;

              end

                  end

          end;

          QuickSort = function(tbl) table.sort(tbl, func); end

      end