WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   Carbonite: Dev Talk (https://www.wowinterface.com/forums/forumdisplay.php?f=167)
-   -   Quests database (https://www.wowinterface.com/forums/showthread.php?t=50841)

ircdirk 12-30-14 11:08 AM

Quote:

Originally Posted by nelegalno2 (Post 303939)
Any chance this could go to a different file - Carbonite.Quests.lua for example?

BTW You should probably remove the Carbonite.Quests/NxQuest.lua.bak file from the pull request.

Yes, i think i can do that. It was a function for Gathering data, just made it work.

Just remove pull this request for now.

nelegalno2 12-30-14 11:26 AM

Quote:

Originally Posted by ircdirk (Post 303941)
Yes, i think i can do that. It was a function for Gathering data, just made it work.

Just remove pull this request for now.

You should probably coordinate this with Rythal because if I remember he was working on the profile system and it'll be nice if each module kept it's data in a different file instead of Carbonite.lua

atl77 12-30-14 03:04 PM

He just told me he was already looking into it...

Rythal 12-30-14 04:12 PM

A lot of things are still stored in Carbonite.lua that should be in it's own file, across all the modules.

If it was just profiles, it wouldn't be so bad and up and running. The problem is if you delete a profile, to also make the modules delete the same profile. If you change profiles, make the modules change to the same profile.

The easy solution would be to not do this, and keep everything separate. Profile options for every module.

nelegalno2 12-30-14 05:11 PM

Quote:

Originally Posted by Rythal (Post 303972)
A lot of things are still stored in Carbonite.lua that should be in it's own file, across all the modules.

If it was just profiles, it wouldn't be so bad and up and running. The problem is if you delete a profile, to also make the modules delete the same profile. If you change profiles, make the modules change to the same profile.

The easy solution would be to not do this, and keep everything separate. Profile options for every module.

I think the logical solution now that Carbonite is modular is that each module should have a file with the profile and module data that is independent of the rest. Maybe also an option to reset settings to default values for emergences. An option to have the same profile assigned to multiple characters where it won't be a problem is also a good idea since I like to have an uniform UI for all my characters but some people prefer to customize the UI per character or class.

That way if someone for example decided not to use the wherehouse anymore the collected inventory data won't be loaded and take space, also having a ~1MB Carbonite.lua file is a bit to much for me when the rest are 1-2KB.

P.S. At some time in the future you might consider renaming the directories to Carbonite_ModuleName for grouping in addon control addons. I don't know if spiting the configuration by modues would help or not - might get too confusing for some users but if it helps the development process...

ircdirk 12-31-14 04:45 AM

Quote:

Originally Posted by nelegalno2 (Post 303977)
I think the logical solution now that Carbonite is modular is that each module should have a file with the profile and module data that is independent of the rest. Maybe also an option to reset settings to default values for emergences. An option to have the same profile assigned to multiple characters where it won't be a problem is also a good idea since I like to have an uniform UI for all my characters but some people prefer to customize the UI per character or class.

That way if someone for example decided not to use the wherehouse anymore the collected inventory data won't be loaded and take space, also having a ~1MB Carbonite.lua file is a bit to much for me when the rest are 1-2KB.

P.S. At some time in the future you might consider renaming the directories to Carbonite_ModuleName for grouping in addon control addons. I don't know if spiting the configuration by modues would help or not - might get too confusing for some users but if it helps the development process...

Ok, changed to save to Carbonite.Quests.lua ;) Pull is waiting on git.

ircdirk 12-31-14 11:40 AM

One thing: please all developers turn on Quest Data Gathering.


All times are GMT -6. The time now is 09:15 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI