WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   Carbonite: Quests Module (https://www.wowinterface.com/forums/forumdisplay.php?f=160)
-   -   Progress Bar Beautification (https://www.wowinterface.com/forums/showthread.php?t=54550)

Svegan 09-26-16 10:45 PM

Progress Bar Beautification
 
I would ask, if the devs that are actively maintaining the addon, would be willing to make the following changes to the progress bar code. It has been tested on my system, and works very nicely. It does not depend on screen resolution, or a specific scale setting for the UI.

Lua Code:
  1. if Nx.qdb.profile.QuestWatch.BonusBar then
  2. --[[    if (math.floor(percent) == 0) then
  3.     list:ItemSet(2, format(" |TInterface\\Addons\\Carbonite\\Gfx\\Skin\\InfoBarB:12:100|t %.2f%%", percent))
  4.     else
  5.     ]]  list:ItemSet(2, format(" |TInterface\\Addons\\Carbonite\\Gfx\\Skin\\InfoBarB:12:%d:|t %.2f%%", math.floor(percent), percent))
  6.      --end

In the version I have, the first section starts at line 9048 and the second chunk of code at line 9090.
Message me here, or battletag me at SDEagleOne#1109 in game. I would love to see how this works on other resolutions. I run at 1680x1050 on my monitor. Thanks to all the ones who do work on this wonderful addon as well.

Thrumbar 09-26-16 11:11 PM

You could submit the changes yourself.

1. Create an Github account https://github.com/join?source=header-home

2. After you creat the Git account you go to the Carbonite Git and Fork it.. https://github.com/mikepauer/Carbonite
The Fork button is on the top right of the page.

3. Make changes on your Git account for the selected files and the save and do a pull request from you git account to the carbonite git. The pull request button is there on screen....

Thrumbar

Quote:

Originally Posted by Svegan (Post 319406)
I would ask, if the devs that are actively maintaining the addon, would be willing to make the following changes to the progress bar code. It has been tested on my system, and works very nicely. It does not depend on screen resolution, or a specific scale setting for the UI.

Lua Code:
  1. if Nx.qdb.profile.QuestWatch.BonusBar then
  2. --[[    if (math.floor(percent) == 0) then
  3.     list:ItemSet(2, format(" |TInterface\\Addons\\Carbonite\\Gfx\\Skin\\InfoBarB:12:100|t %.2f%%", percent))
  4.     else
  5.     ]]  list:ItemSet(2, format(" |TInterface\\Addons\\Carbonite\\Gfx\\Skin\\InfoBarB:12:%d:|t %.2f%%", math.floor(percent), percent))
  6.      --end

In the version I have, the first section starts at line 9048 and the second chunk of code at line 9090.
Message me here, or battletag me at SDEagleOne#1109 in game. I would love to see how this works on other resolutions. I run at 1680x1050 on my monitor. Thanks to all the ones who do work on this wonderful addon as well.


Svegan 09-27-16 10:26 AM

I have had a git account for a while, if I fork carbonite, will it automatically update, when others make changes to carbonite? I do not want to interfere with the main fork, and I would like to make sure that what I do has no negative impact on the wonderful work you guys are doing.

Thrumbar 09-27-16 10:44 AM

Quote:

Originally Posted by Svegan (Post 319415)
I have had a git account for a while, if I fork carbonite, will it automatically update, when others make changes to carbonite? I do not want to interfere with the main fork, and I would like to make sure that what I do has no negative impact on the wonderful work you guys are doing.

The fork will create a copy of the current version on Carbonites git page..

You will need to update the fork on changes they make to the Carbonite git yourself as any changes made there are not transfer to the forks people make.
http://www.hpique.com/2013/09/updati...y-from-github/

When you do a pull request you are sending the changes to Carbonites git but the changes have to be approved by the people with commit authority to become a part of the carbonite release.. So you will not have a negative effect more than I have :rolleyes:..

Thrumbar

ircdirk 09-27-16 11:08 AM

Quote:

Originally Posted by Svegan (Post 319415)
I have had a git account for a while, if I fork carbonite, will it automatically update, when others make changes to carbonite? I do not want to interfere with the main fork, and I would like to make sure that what I do has no negative impact on the wonderful work you guys are doing.

U can aslo click EDIT file, after changes click SAVE this will create Pull Request.


Svegan 09-27-16 11:14 AM

Thanks for your help. I think I am setup properly, made the edit on my fork and submitted a pull request. Let me know if I did anything wrong.

ircdirk 09-27-16 11:19 AM

Quote:

Originally Posted by Svegan (Post 319418)
Thanks for your help. I think I am setup properly, made the edit on my fork and submitted a pull request. Let me know if I did anything wrong.

Pull request already accepted :)

Svegan 09-27-16 11:22 AM

Thank you. I hope to add to the wonderful work you guys do.


All times are GMT -6. The time now is 06:10 AM.

vBulletin © 2020, Jelsoft Enterprises Ltd
© 2004 - 2020 MMOUI