WoWInterface - SecureHandler template object fails visibility check

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - SecureHandler template object fails visibility check (https://www.wowinterface.com/forums/showthread.php?t=56024)

SecureHandler template object fails visibility check

So, I'm currently trying to make a button that cancels aura on right mouse button and here's what I've got atm

Lua Code:

local button = CreateFrame("Button", nil, UIParent, "SecureHandlerClickTemplate");
button:RegisterEvent("PLAYER_ENTERING_WORLD");
button:RegisterUnitEvent("UNIT_AURA", "player");
button:RegisterForClicks("RightButtonUp");
button:SetSize(50, 50);
button:SetPoint("TOP", 0, -150);
button:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_ENTERING_WORLD" or event == "UNIT_AURA" then
        if event == "PLAYER_ENTERING_WORLD" then
            self:UnregisterEvent("PLAYER_ENTERING_WORLD");
        end
 
        local spellName = GetSpellInfo(self.spellID);
 
        local _, _, _, count, _, duration, expires = UnitBuff("player", spellName);
 
        local cd = self.cd;
        if duration and duration > 0 then
            cd:SetCooldown(expires - duration, duration);
            cd:Show();
 
            self.icon:SetDesaturated(false);
 
            self.duration = duration;
        else
            cd:Hide();
 
            self.icon:SetDesaturated(true);
 
            self.duration = nil;
        end
 
        self.count:SetText((count and count > 1) and count or "");
    end
end);
button:SetAttribute("_onclick", [=[
    if button == "RightButton" and not down then
        local name = self:GetAttribute("spellName");
 
        local cd = self:GetFrameRef("cd");
        
        if cd:IsShown() then
            CancelUnitBuff("player", name);
        end
    end
]=]);
 
button.spellID = 241846;
button:SetAttribute("spellName", GetSpellInfo(button.spellID));
 
local cd = CreateFrame("Cooldown", nil, button, "CooldownFrameTemplate");
cd:SetAllPoints(button);
cd:SetReverse(true);
cd:SetDrawEdge(true);
cd:SetHideCountdownNumbers(false);
 
button:SetFrameRef("cd", cd);

It currently fails at L#42 where I check cd's visibility.

Would that be because cd itself is not a SecureHandler template object?

You may check the RestrictedEnvironment.lua#L18-L94, the CancelUnitBuff can't be used in the secure snippets. Also none secure frames like the cooldown can't be used in the secure snippets.

You should use SecureActionButtonTemplate instead of the SecureHandlerClickTemplate

Lua Code:

local button = CreateFrame("Button", nil, UIParent, "SecureActionButtonTemplate")
button:SetAttribute("*type2", "cancelaura")
button:SetAttribute("spell", "the spell name")

See SecureTemplates.lua#L443-L459 for details.

To clarify, you can get frame references to unprotected frames in a secure scope, but you can't see them in a secure scope when you're in combat. :GetFrameRef will not return your frame if it's not protected.

https://github.com/Gethe/wow-ui-sour...es.lua#L76-L97

Many thanks to Kurapica and MunkDev.

Using SecureActionButtonTemplate did the trick :)

It seems like you would need a unit attribute set as well to use cancelaura, btw ;)

Just being curious with

Lua Code:

button:SetAttribute("*type2", "cancelaura")

Can you hook the script when it actually calls cancelaura function(?) either by hooksecurefunc() or :HookScript()?

Quote:

Originally Posted by Engavi (Post 326763)

Just being curious with

Lua Code:

button:SetAttribute("*type2", "cancelaura")

Can you hook the script when it actually calls cancelaura function(?) either by hooksecurefunc() or :HookScript()?

You can hooksecurefunc the CancelUnitBuff or use button:HookScript("OnClick", ...)

Quote:

Originally Posted by kurapica.igas (Post 326764)

You can hooksecurefunc the CancelUnitBuff or use button:HookScript("OnClick", ...)

So, I just need to hook CancelUnitBuff method?

That's easier than I thought :D