Crash On Looting - Global String Edits
I crash when receiving quest rewards (items only, not money) or when looting a boss due to various global string edits that I've collected from threads here and there. I've looked through the latest list of strings and can't see anything that's amiss in mine, aside from removing the brackets around [Loot] -- which wouldn't affect quest rewards, and I crash with or without brackets.
Any ideas on where I'm going wrong? Am I missing something basic after staring at this for hours? Here's the code in question: Code:
LOOT_ROLL_ALL_PASSED = "|HlootHistory:%d|hLoot|h: Everyone passed on %s" |
I had an similar issue, where my custom stats on items strings made it crash, I used $ that was Cata, but later they changed it to % and that made it crash, hehe. Make sure you look at the new strings and translate those, keeping the number of variables intact. Perhaps some changed, some were added, removed, e.g. That's enough to start a crash. "ExportInterfaceFiles code" and start fresh. ;)
|
I'm not sure what the question is. Are you trying to edit global strings, or use them? You shouldn't be editing strings, as that creates all kinds of problems. To use them, do something like
Lua Code:
|
Editing globals depends on several factors, the global and what addosn you run. So far I've edited some globals too, and no other addons use them so they don't crash either. It's important to not local variable global strings in case of situations like this where the string changed. Other than that, the crash is due to conflict of interests I suspect. Does it happen when you only load your string overrides?
|
Quote:
https://github.com/phanx/wow-globalstrings |
Quote:
If the tokens are missing, or in the wrong order, then the values being passed to Lua functions like string.format -- or their C equivalents -- are incorrect. If the values are being handled in Lua (eg. the game's FrameXML code, or another addon) then you should get a Lua error. If the values are being handled in C (eg. populating the tooltip with unit data) then you may well crash the client, though you should report such crashes to Blizzard so they can fix them. If you want to get rid of some part of the string that includes a substitution token, you'll need to find another way to do it. For example, if the final, formatted string is shown in the chat frame, you should use the chat filtering API to remove the unwanted parts. Same goes if you want to change the order in which tokens appear. Check your strings against Blizzard's current global strings for your game client's locale, and make sure your tokens are all correct. |
Yup, it happens only with the string edits loaded. Any time I loot a boss or receive a quest item, boop - disconnected. It, of course, doesn't happen with them disabled (or the ones listed removed from the file).
I've been comparing the strings in the file you listed, Phanx, over the last few days and I honestly can't see what's causing me to crash. That's why I'm so confused. At most, I remove a few words and no tokens. As far as I can see, all tokens are in the same order but I'm obviously missing something. @ Myroddin I've been replacing strings like this with no problem for ages. :) |
Undo all your edits. Load the game and make it sure it all works.
Restore half your edits. Load the game and see what happens. If it crashes, undo half of the restored half. If it works, restore the other half of the original instead. Load the game and see what happens. Repeat as needed, continuing to narrow down which edit(s) are responsible. This kind of search chops down the search space very quickly. |
This is getting to be incredibly confusing. I had no problems running Vortex Pinnacle last night, but crashed again in Grim Batol without changing anything. The search continues. :confused:
|
I think I figured it out. I did, in fact, have the tokens reversed in one string that was actually not listed in my original post: faction_standing_increased. The crash was happening on characters that aren't fully exalted with my guild, which is why it happened sporadically last night.
.. At least I hope that's what's happening. I'll go test it. |
I had a very similar issue when I logged in after patch. Game crashing when doing various stuff, removed my globals and disconnects stopped. I actually followed a few threads here and grabbed the code that people were posting. I do not really understand any of this coding stuff =p but love having these nifty little changes to my ui!
I have a massive long list of globals and instead of me just throwing it away, is there any chance you would post your list again with the fixed version? If it is far too cheeky for me to ask I apologise and I will try to someday get round to figuring it all out ;) |
Sure, here's what I have so far with no crashes in the last couple days.
-- Loot nubbins, inc. currency loot. CREATED_ITEM = "%s |cffffffff+ %s|r" CREATED_ITEM_MULTIPLE = "%s |cffffffff+ %sx%d|r" LOOT_ITEM_CREATED_SELF = "|cffffffff+ %s|r" LOOT_ITEM_CREATED_SELF_MULTIPLE = "|cffffffff+ %sx%d|r" YOU_LOOT_MONEY = "|cffffffff+ %s|r" YOU_LOOT_MONEY_GUILD = "|cffffffff+ %s|r" LOOT_MONEY = "|cffffffff%s + %s|r" LOOT_MONEY_SPLIT = "|cffffffff+ %s|r" LOOT_MONEY_SPLIT_GUILD = "|cffffffff+ %s|r" LOOT_ITEM = "%s + %s" LOOT_ITEM_MULTIPLE = "%s + %s x%d" LOOT_ITEM_SELF = "+ %s" LOOT_ITEM_SELF_MULTIPLE = "+ %s x%d" LOOT_ITEM_PUSHED_SELF = "+ %s" LOOT_ITEM_PUSHED_SELF_MULTIPLE = "+ %s x%d" LOOT_ROLL_ALL_PASSED = "|HlootHistory:%d|hLoot|h: Everyone passed on %s" LOOT_ROLL_PASSED_AUTO = "%s passed on %s" LOOT_ROLL_PASSED_AUTO_FEMALE = "%s passed %s (auto)" LOOT_ROLL_PASSED_SELF = "|HlootHistory:%d|hLoot|h: passed on %s" LOOT_ROLL_PASSED_SELF_AUTO = "|HlootHistory:%d|hLoot|h: passed on %s." CURRENCY_GAINED = "+ %s" CURRENCY_GAINED_MULTIPLE = "+ %s x%d" -- Quest nubbins. NORMAL_QUEST_DISPLAY = "|cffffffff%s|r" TRIVIAL_QUEST_DISPLAY = "|cffffffff%s (low level)|r" ERR_QUEST_ACCEPTED_S = "%s accepted." ERR_QUEST_REWARD_EXP_I = "+ %dxp" ERR_QUEST_REWARD_ITEM_MULT_IS = "+ %d %ss" ERR_QUEST_REWARD_ITEM_S = "+ %s" ERR_QUEST_REWARD_MONEY_S = "|cffffffff+ %s|r" -- Random nubbins. ERR_AUCTION_SOLD_S = "%s sold." CHAT_FLAG_AFK = "afk. " CHAT_FLAG_DND = "dnd! " -- Rep nubbins. FACTION_STANDING_DECREASED = "- %s %d rep" FACTION_STANDING_INCREASED = "+ %s %d rep" The rep nubbins were crashing me, because the tokens were back to front. I'd like to find a way to have them that way again, but I'm just happy to not be crashing over and over anymore. Hope you find that useful. |
This is fantastic! Thank you sooo much! The loot ones were the ones I missed the most, hate seeing all that useless text ;)
Such a quick response aswell, can't thank you enough =) |
Quote:
Code:
ChatFrame_AddMessageEventFilter("CHAT_MSG_SYSTEM", function(frame, event, message, ...) |
Thanks for that, Phanx. I'll have a tinker with it this weekend.
|
All times are GMT -6. The time now is 04:28 PM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI