WoWInterface - Lua Errors from Bosstalk

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Lua Errors from Bosstalk (https://www.wowinterface.com/forums/showthread.php?t=56802)

Lua Errors from Bosstalk

Anyone can help me define on how to fix these select problems?

Attachment 9151

Attachment 9152

Attachment 9153

Attachment 9154

Attachment 9155

Attachment 9156

Error 4 simply looks like that file doesn't exist, so I'd check that path and see.

I believe the locale errors are caused by BossTalk referencing locale IDs that haven't been defined, so they would need to be added in the locale file(s).

Quote:

Originally Posted by MuffinManKen (Post 330581)

I found the problem. For some reason the problem is connected to another addon. I disable it, Bosstalk goes with it. Thoughts on how to make it so it is not part of another addon?

What addon is causing a conflict?

They all appear to be missing Locale entries for an addon using AceLocale.

Search your addons for "Enter an Id." or "Ironaya in Uldamin".

Quote:

Originally Posted by MuffinManKen (Post 330600)

What addon is causing a conflict?

It is called AudioX II.

Quote:

Originally Posted by Fizzlemizz (Post 330601)

They all appear to be missing Locale entries for an addon using AceLocale.

Search your addons for "Enter an Id." or "Ironaya in Uldamin".

Took care of those earlier this morning. It's now the issue on how and why another addon is conflicted onto Bosstalk.

Quote:

Originally Posted by Brellison94 (Post 330604)

Took care of those earlier this morning. It's now the issue on how and why another addon is conflicted onto Bosstalk.

So the LibDataBroker error is being caused by another addon? Or is it a different error?

If it is LibDataBroker then you probably have an addon using an old (pre BfA) version. These days you will get an error if there is an entry in the .toc or an include .xml that lists a file that does not exist.

These used to be ignored.

Quote:

Originally Posted by MuffinManKen (Post 330605)

So the LibDataBroker error is being caused by another addon? Or is it a different error?

Different Error.

We aren't mind readers. What error is it?

When I open Bosstalk, I get this Lua Error message.

Lua Code:

Message: Interface\AddOns\BossTalk\Core.lua:532: table index is nil
Time: Fri Oct 26 10:26:03 2018
Count: 1
Stack: Interface\AddOns\BossTalk\Core.lua:532: table index is nil
Interface\AddOns\BossTalk\Core.lua:532: in function `GenerateMenu'
Interface\AddOns\BossTalk\Options.lua:227: in function `func'
...ace\AddOns\BossTalk\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:741: in function <...ace\AddOns\BossTalk\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:680>
 
Locals: self = <table> {
 SetDefaultModuleLibraries = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:398
 DUEL_REQUESTED = <function> defined @Interface\AddOns\BossTalk\Core.lua:1243
 AddEvent = <function> defined @Interface\AddOns\BossTalk\Core.lua:694
 EnableModule = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:363
 modules = <table> {
 }
 baseName = "BossTalk"
 IterateEmbeds = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:473
 UnregisterComm = <function> defined @Interface\AddOns\BossTalk\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:179
 MakeFunk = <function> defined @Interface\AddOns\BossTalk\Core.lua:797
 SetItemRef_Original = <function> defined @Interface\AddOns\AudioX\AudioX.lua:813
 UNIT_MANA = <function> defined @Interface\AddOns\BossTalk\Core.lua:1300
 Printf = <function> defined @Interface\AddOns\BossTalk\Libs\AceConsole-3.0\AceConsole-3.0.lua:69
 SetDefaultModulePrototype = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:440
 OnCommReceived = <function> defined @Interface\AddOns\BossTalk\Core.lua:1086
 Search = <function> defined @Interface\AddOns\BossTalk\Core.lua:665
 IsEnabled = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:482
 OnCmd = <function> defined @Interface\AddOns\BossTalk\Core.lua:74
 DisableModule = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:381
 GenerateMenu = <function> defined @Interface\AddOns\BossTalk\Core.lua:113
 RegisterMessage = <function> defined @Interface\AddOns\BossTalk\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:116
 GetArgs = <function> defined @Interface\AddOns\BossTalk\Libs\AceConsole-3.0\AceConsole-3.0.lua:144
 data = <table> {
 }
 SendCommMessage = <function> defined @Interface\AddOns\BossTalk\Libs\AceComm-3.0\AceComm-3.0.lua:87
 tcount = <function> defined @Interface\AddOns\BossTalk\Core.lua:583
 UnregisterAllComm = <function> defined @Interface\AddOns\BossTalk\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:200
 SetEnabledState = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:455
 enabledState = true
 COMBAT_LOG_EVENT_UNFILTERED = <function> defined @Interface\AddOns\BossTalk\Core.lua:1222
 RegisterEvent = <function> defined @Interface\AddOns\BossTalk\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:116
 cmdtable = <table> {
 }
 OnEnable = <function> defined @Interface\AddOns\BossTalk\Core.lua:108
 PET_ATTACK_START = <function> defined @Interface\AddOns\BossTalk\Core.lua:1267
 GenerateSync = <function> defined @Interface\AddOns\BossTalk\Core.lua:1167
 CHAT_MSG_MONSTER_YELL = <function> defined @Interface\AddOns\BossTalk\Core.lua:1325
 Enable = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:325
 UnregisterAllEvents = <function> defined @Interface\AddOns\BossTalk\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:200
 MountCheck = <function> defined @Interface\AddOns\BossTalk\Core.lua:1252
 MakeEvent = <function> defined @Interface\AddOns\BossTalk\Core.lua:700
 GetModule = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:241
 defaultModuleLibraries = <table> {
 }
 credits = <table> {
 }
 UnregisterChatCommand = <function> defined @Interface\AddOns\BossTalk\Libs\AceConsole-3.0\AceConsole-3.0.lua:111
 GetName = <function> defined @Interface\AddOns\BossTalk\Libs\AceAddon-3.0\AceAddon-3.0.lua:310
 UNIT_HEALTH = <function> defined @Interface\Ad

Can you attach your BossTalk\Core.lua and BossTalk\Options.lua?

Quote:

Originally Posted by MuffinManKen (Post 330620)

Can you attach your BossTalk\Core.lua and BossTalk\Options.lua?

Sure.

Attachment 9162

Attachment 9163

The the problem is in this line:
tempZone.User.args[worldcheck(dbd.useryell[i].w)].args[dbd.useryell[i].zone] = {

Which table index is nil? It's hard to know since there are roughly 10 different indexing operations in that 1 line. I would recommend cleaning that up so that it's more readable, easier to find issues, and also more efficient:

Lua Code:

if(dbd.useryell[i]) then
            if (not dbd.useryell[i].w) then dbd.useryell[i].w = "1" end
            local wc = worldcheck(dbd.useryell[i].w)
            local zone = dbd.useryell[i].zone
            local world_args = tempZone.User.args[wc]
            if(not world_args.args[zone]) then
                world_args.args[zone] = {
                    type = 'group',
                    name = zone,
                    desc = zone,
                    args = {},
                }
            end

Without knowing the data, it's hard to pinpoint the problem but splitting that stuff up should help zero in on where the issue is. For example, if dbd.useryell[i].w is a value other than nil, "1", "2" then worldcheck() will return nil.

Efficiency-wise there is no need to call worldcheck over and over, so we assign the result to a variable and that can be re-used everywhere else in that loop.

Some of the variable names I used may not be ideal, so adjust as needed.

There is also another bug that I saw. I don't know if it's related, but the bug is also in AudioX. Both addons override SetItemRef and do it incorrectly.

BossTalk.SetItemRef(link, text, button) take 3 parameters and if it isn't a BossTalk link, passes them on to Blizzard's: BossTalk.SetItemRef_Original(link, text, button);

But that isn't actually Blizzard's, because AudioX is overwriting it too, and if the link isn't one it's interested in, it passes it on to (probably) Blizzard's:
SetItemRef_orig(link,text,button)

Unfortunately, Blizzard's function looks like this:
function SetItemRef(link, text, button, chatFrame)

The chatFrame parameter is being thrown away. And overwriting the function like that is dangerous and can mess up other addons or even the entire system. You should change:
BossTalk.SetItemRef_Original = SetItemRef
SetItemRef = BossTalk.SetItemRef
to:
hooksecurefunc("SetItemRef", BossTalk.SetItemRef)

and then you can remove BossTalk.SetItemRef_Original completely. It's no longer needed since the original code will be automatically called first and then yours will be. AudioX has the same issue and should be fixed in the same way.

Quote:

Originally Posted by MuffinManKen (Post 330627)

I applied the fix and I am still at the same spot. However, it will now not show me the problem through the Lua Error.

Quote:

Originally Posted by Fizzlemizz (Post 330609)

Maybe this perhaps? I've been eyeballing on this file for a while.

Attachment 9164

Quote:

Originally Posted by Brellison94 (Post 330628)

I applied the fix and I am still at the same spot. However, it will now not show me the problem through the Lua Error.

Can you attach your fixed lua file?

Quote:

Originally Posted by Brellison94 (Post 330629)

Maybe this perhaps? I've been eyeballing on this file for a while.

That does list Libs\libDataBroker-1-1\libDataBroker-1-1.lua so if that file doesn't exist you will get an error.