WoWInterface - Any performance wise differences between Header and Single spawning for a group?

WoWInterface (https://www.wowinterface.com/forums/index.php)

- oUF (Otravi Unit Frames) (https://www.wowinterface.com/forums/forumdisplay.php?f=87)

- - Any performance wise differences between Header and Single spawning for a group? (https://www.wowinterface.com/forums/showthread.php?t=39009)

Any performance wise differences between Header and Single spawning for a group?

Just wandering, Bliz's "CompactUnitFrame" is a single secure-unit-button and they build party/raid frames with it.
And we can build party/raid frame with a header spawning or some single spawnings but which is the better way?

(Sorry for my bad English. Please let me know if my question is not clear one)

You don't really need to wonder about this. Spawning party/raid frames through headers is the most valid solution for us. Consider the following:

- Using headers: We create one header which then creates up to N unit buttons depending on our header settings and number of existing units.
- Using single spawn: We create N unit buttons depending on our setup, regardless of unit existence.

Generally both oUF and CompactFrames have the same solution, but we're required to go through the secure API provided to actually create frames while in combat.

(sent from my phone)

Thanks for your reply, haste. I'll try to spawn them as a header with no worry. =)

Btw, I was going to spawn them as singles because I was failed to spawn party-target header.

Code:

oUF:Factory(function (self)

        self:SetActiveStyle('MyPartyTargetStyle')



        local partytarget = self:SpawnHeader(

                nil, nil, nil,

                'showParty', true, 'showPlayer', true,

                'point', 'TOP', 'yOffset', -36,

                'oUF-initialConfigFunction', [[

                        self:SetAttribute('unitsuffix', 'target')

                        self:SetWidth(84)

                        self:SetHeight(24)

                ]]

        )



        partytarget:SetPoint('LEFT', 30, 0)

        partytarget:Show()

end)

I think it was because of my fault but:
- These party-targets have not 'partytarget' as 'oUF-guessUnit' attribute.
- It seems 'enableTargetUpdate' function not works correctly. Though 'OnShow' update works.
(I mean when I have no target and then target someone, it's updated correctly. But when I chenge the target to the another one, it's not updated correctly)

Anyway, I'm sure I need farther testing. I'll post again when I find something useful to share.

You have to do this with xml. This is what I use for partypets and partytargets:

xml Code:

<Ui xmlns="http://www.blizzard.com/wow/ui/">
    <Button name="oUF_Party" inherits="SecureUnitButtonTemplate" hidden="true" virtual="true">
        <Frames>
            <Button name="$parentPet" inherits="SecureUnitButtonTemplate">
                <Anchors>
                    <Anchor point="TOPLEFT" relativePoint="BOTTOMLEFT" relativeTo="$parent">
                        <Offset>
                            <AbsDimension x="0" y="-7.5"/>
                        </Offset>
                    </Anchor>
                </Anchors>
                <Attributes>
                    <Attribute name="unitsuffix" type="string" value="pet"/>
                    <Attribute name="useparent-unit" type="boolean" value="true"/>
                    <Attribute name="type1" type="string" value="target"/>
                    <Attribute name="initial-unitWatch" type="boolean" value="true"/>
                </Attributes>
            </Button>
            <Button name="$parentTarget" inherits="SecureUnitButtonTemplate">
                <Anchors>
                    <Anchor point="TOPLEFT" relativePoint="BOTTOMLEFT" relativeTo="$parent">
                        <Offset>
                            <AbsDimension x="0" y="-27.5"/>
                        </Offset>
                    </Anchor>
                </Anchors>
                <Attributes>
                    <Attribute name="unitsuffix" type="string" value="target"/>
                    <Attribute name="useparent-unit" type="boolean" value="true"/>
                    <Attribute name="type1" type="string" value="target"/>
                    <Attribute name="initial-unitWatch" type="boolean" value="true"/>
                </Attributes>
            </Button>
        </Frames>
    </Button>
</Ui>

then just declare "template", "oUF_Party" within SpawnHeader for your party frames

Thanks for your help, Rainrider. =)

I know, many layout uses xml and works fine.
But for me, spawning by lua is easier way to control these frames after spawning.

When I looked a thread, I thought it can be done by lua only ... but maybe I'm wrong.

It doesn't really matter how you spawn them in terms of adressing them. You don't have to spawn them via xml - self:SetAttribute('unitsuffix', 'target')
- is another way, indeed.

I think your "nil, nil, nil," is the problem, try "nil, nil, party,".

Please let me know if this works for you. I tried to spawn partytargets, partypets and mttargets with lua and they get spawned but are never visible. Doing it with xml templates works just fine.

Btw nice catch Dawn but shouldn't the visibility option be a string (nil, nil, "party" instead of "nil, nil, party")? The first nil is supposed to be the frame name. What is the second for? Type of template to be used?

I was just looking at it quickly and giving a hint, no "case-sensitiv-copy&paste ready" code. ;)

I personally spawn MT targets without xml, just fine.

Code:

        local MainTankTarget = self:SpawnHeader("oUF_MainTankTarget", nil, 'raid, party', 

                'showRaid', true, 

                "groupFilter", "MAINTANK", 

                'yOffset', -16, 

                'oUF-initialConfigFunction', ([[

                        self:SetWidth(%d)

                        self:SetHeight(%d)

                        self:SetAttribute('unitsuffix', 'target')

                ]]):format(140, 18))                

        MainTankTarget:SetPoint("TOPRIGHT", oUF_MainTank, "TOPLEFT", -20, 0)

https://github.com/haste/oUF/issues/74

I probably won't be able to take a proper look until Saturday or Friday.

Also, health will update as long as you use frequentUpdates in the current version.

Hm, I managed to spawn MTT and party pets through headers. When I try to spawn party target though, I get this:

Quote:

1x oUF-1.5.8\ouf.lua:468: CreateFrame(): Couldn't find inherited node "party"
oUF-1.5.8\ouf.lua:468: in function `SpawnHeader'
oUF_Rain-pre alpha\oUF_Rain.lua:264: in function `func'
oUF-1.5.8\factory.lua:17: in function <oUF\factory.lua:13>
(tail call): ?:

Locals:
self = "oUF_Rain_PartyTargets"
overrideName = nil
template = "party,raid"
visibility = "showParty"
isPetHeader = nil
name = "oUF_Rain"
style = "Rain"
error = <function> @ oUF\private.lua:20:
generateName = <function> @ oUF\ouf.lua:345:
select = <function> defined =[C]:-1
styleProxy = <function> @ oUF\ouf.lua:404:
initialConfigFunction = " local header = self:GetParent()
local frames = table.new()
table.insert(frames, self)
self:GetChildList(frames)
for i=1, #frames do
local frame = frames[i]
local unit
-- There's no need to do anything on frames with onlyProcessChildren
if(not frame:GetAttribute'oUF-onlyProcessChildren') then
RegisterUnitWatch(frame)

-- Attempt to guess what the header is set to spawn.
if(header:GetAttribute'showRaid') then
unit = 'raid'
elseif(header:GetAttribute'showParty') then
unit = 'party'
end

local headerType = header:GetAttribute'oUF-headerType'
local suffix = frame:GetAttribute'unitsuffix'
if(unit and suffix) then
if(headerType == 'pet' and suffix == 'target') then
unit = unit .. headerType .. suffix
else
unit = unit .. suffix
end
elseif(unit and headerType == 'pet') then
unit = unit .. headerType
end

frame:SetAttribute('*type1', 'target')
frame:SetAttribute('*type2', 'menu')
getCondition = <function> @ oUF\ouf.lua:329:

---

Here the code I use to spawn the headers:

lua Code:

if (cfg.showParty) then
        local party = self:SpawnHeader("oUF_Rain_Party", nil, "party,raid",
            "showParty", true,
            "showRaid", true,
            "showPlayer", true,
            "showSolo", true,
            "maxColumns", 5,
            "unitsPerColumn", 1,
            "columnAnchorPoint", "LEFT",
            "columnSpacing", 7.5,
            "oUF-initialConfigFunction", [[
                self:SetWidth(110)
                self:SetHeight(22)
            ]]
        )
        party:SetPoint("LEFT", UIParent, "CENTER", -231.25, -250)
        party:Show()
    end
 
    if (cfg.showParty and cfg.showPartyTargets) then
        local partyTargets = self.SpawnHeader(
            "oUF_Rain_PartyTargets", nil, "party,raid",
            "showParty", true,
            "showRaid", true,
            "showPlayer", true,
            "showSolo", true,
            "maxColumns", 5,
            "unitsPerColumn", 1,
            "columnAnchorPoint", "LEFT",
            "columnSpacing", 7.5,
            "oUF-initialConfigFunction", [[
                self:SetWidth(110)
                self:SetHeight(22)
                self:SetAttribute("unitsuffix", "target")
            ]]
        )
        partyTargets:SetPoint("TOPLEFT", "oUF_Rain_Party", "BOTTOMLEFT", 0, -27.5)
        partyTarget:Show()
    end
 
    if (cfg.showParty and cfg.showPartyPets) then
        local partyPets = self:SpawnHeader(
            "oUF_Rain_PartyPets", nil, "party,raid",
            "showParty", true,
            "showRaid", true,
            "showPlayer", true,
            "showSolo", true,
            "maxColumns", 5,
            "unitsPerColumn", 1,
            "columnAnchorPoint", "LEFT",
            "columnSpacing", 7.5,
            "oUF-initialConfigFunction", [[
                self:SetWidth(110)
                self:SetHeight(11)
                self:SetAttribute("unitsuffix", "pet")
            ]]
        )
        partyPets:SetPoint("TOPLEFT", "oUF_Rain_Party", "BOTTOMLEFT", 0, -7.5)
        partyPets:Show()
    end
    
    if (cfg.showMT) then
        local mainTanks = self:SpawnHeader(
            "oUF_Rain_MT", nil, "raid",
            "showRaid", true,
            "groupFilter", "MAINTANK",
            "yOffset", -7.5,
            "oUF-initialConfigFunction", [[
                self:SetWidth(110)
                self:SetHeight(22)
            ]]
        )
        mainTanks:SetPoint("TOPLEFT", UIParent, "LEFT", 50, -50)
        mainTanks:Show()
    end
    
    if (cfg.showMT and cfg.showMTT) then
        local mainTankTargets = self:SpawnHeader(
            "oUF_Rain_MTT", nil, "raid",
            "showRaid", true,
            "groupFilter", "MAINTANK",
            "yOffset", -7.5,
            "oUF-initialConfigFunction", [[
                self:SetWidth(110)
                self:SetHeight(22)
                self:SetAttribute("unitsuffix", "target")
            ]]
        )
        mainTankTargets:SetPoint("TOPLEFT", "oUF_Rain_MT", "TOPRIGHT", 7.5, 0)
        mainTankTargets:Show()
    end

So it's not me, it's just bugged?

self.SpawnHeader( is not equal to self:SpawnHeader(

Ooooh maaaan. I definitely need an optician :( Everything works now, thank you very much for looking into it

Thanks haste, with latest git it works. :)

Now, I'm worry about having the units like 'playerpet' or 'playertarget' though.

Should be solved on git.

Sorry about my useless report that was sent while you are still coding.
I'll test it as soon as I can. :)

Edit: I overlooked the thread about git testing. :(
Yes, the title of this thread makes no sense anymore.

I pushed the fix due to you reporting it.

It's also better to report errors, even if you are uncertain why they are happening. I'd rather have too many error reports, than too few.