WoWInterface - Group frames don't respond to OnShow/OnHide?

WoWInterface (https://www.wowinterface.com/forums/index.php)

- oUF (Otravi Unit Frames) (https://www.wowinterface.com/forums/forumdisplay.php?f=87)

- - Group frames don't respond to OnShow/OnHide? (https://www.wowinterface.com/forums/showthread.php?t=55546)

Group frames don't respond to OnShow/OnHide?

Hi all,

It's been a while since I posted my last oUF related thread here :)

So, I'm currently spawning my raid group frames like the following:

Lua Code:

local koverwatch = LSM:Fetch("font", "koverwatch");
 
for i = 1, NUM_RAID_GROUPS do
    local overrideName = "Raid" .. i;
 
    width = db.raid.width;
    height = db.raid.height;
    point, relativeFrame, relativePoint, ofsx, ofsy = unpack(db.raid.position);
    
    if i >= 2 then
        ofsx = ofsx + ((width + 3) * ((i - 1) % 4));
    end
 
    if i >= 5 then
        ofsy = ofsy + (height + 3) * 5 + 28;
    end
 
    local group = self:SpawnHeader(
        overrideName,
        nil,
        "custom [group:raid] show; hide",
        -- attributes
        "oUF-initialConfigFunction", ("self:SetWidth(%d); self:SetHeight(%d);"):format(width, height),
        "showRaid", true,
        "showParty", false,
        "showPlayer", true,
        "showSolo", false,
        "groupFilter", tostring(i),
        "point", "LEFT",
        -- "xOffset", ,
        -- "yOffset", ,
        "maxColumns", 5,
        "unitsPerColumn", 1,
        "columnSpacing", 8,
        "columnAnchorPoint", "TOP"
    );
    group:SetPoint(point, relativeFrame, relativePoint, ofsx, ofsy);
    group:SetScript("OnShow", function(self)
        self.headText:Show();
    end);
    group:SetScript("OnHide", function(self)
        self.headText:Hide();
    end);
 
    local headText = group:CreateFontString("$parentHeadText", "OVERLAY");
    headText:SetFont(koverwatch, 14, "OUTLINE");
    headText:SetPoint("BOTTOM", group, "TOP");
    headText:SetText("Group " .. i);
    headText:Hide();
 
    group.headText = headText;
end

I'm currently trying to display a text, "Group N", on top of each group's frame, but it seems like those frames don't call OnShow/OnHide scripts :confused:

So, I've tested it without headText being hidden on creation and here's what it looks like at the moment.

From "Group 1" to "Group 7" are properly positioned while "Group 8" is off...

So, my conclusion here is that each of groups are created and already visible since I'm in raid group (and that's why it's not calling OnShow/OnHide scripts), but are not yet sized correctly until that particular group gets a member in it and that's why it's causing this.

However, I'm still unsure of how I could fix this :(

Any helps, please?!

Thank you!!

First off, it's good practice to use HookScript instead of SetScript when adding script handlers to a foreign object, to avoid overriding the original script handler.

As for the issue, try HookScript "OnAttributeChanged" and check for the amount of players in the given group.
The visibility that you're trying to check for is always going to be true while you're in a raid, according to your visibility conditions "custom [group:raid] show; hide".

Hi p3lim,

Quote:

Originally Posted by p3lim (Post 324107)

First off, it's good practice to use HookScript instead of SetScript when adding script handlers to a foreign object, to avoid overriding the original script handler.

Thank you for correcting me :)

I definitely didn't consider such cases..

Quote:

Originally Posted by p3lim (Post 324107)

As for the issue, try HookScript "OnAttributeChanged" and check for the amount of players in the given group.
The visibility that you're trying to check for is always going to be true while you're in a raid, according to your visibility conditions "custom [group:raid] show; hide".

You are right, again.

I forgot that I assigned "custom [group:raid] show; hide" for visibility which will always show each header frame while I'm in raid group as you said :(

Had a go with "OnAttributeChanged" script, but eeh... doesn't seem like it.

There were some attributes like "statehidden", "childN", "_ignore" and "frameref-childN" where I thought "childN" attribute would be the one that I should be dealing with, but it wasn't..

Thus, I'm guessing that the best option would be changing visibility condition, although I'm still unsure tho...

(Maybe I should have a look at macro conditionals :p)

You could try parenting the header text to the top member of each group, voids the check completely.

Quote:

Originally Posted by p3lim (Post 324126)

You could try parenting the header text to the top member of each group, voids the check completely.

It worked :banana:!!

Thanks a lot!!

One more question!

What would be the best way to get access (or get reference) to first member frame of the group?

I'm currently doing it this way.

Lua Code:

-- string comparison to see if the current frame is the first member frame of the group 
-- e.g. MyUI_Raid1UnitButton1
if E:StringEndsWith(frame:GetName(), "1") then
    -- get parent
    local group = frame:GetParent();
end

This would work fine, but I am curious if there is any better solution to achieve this.