WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   Carbonite: Dev Talk (https://www.wowinterface.com/forums/forumdisplay.php?f=167)
-   -   Using LibBabble for Translations (https://www.wowinterface.com/forums/showthread.php?t=51290)

gOOvER 12-31-14 02:02 AM

Using LibBabble for Translations
 
There are some Libs for Translations. I think it's better to Use this one, insteed of adding translations:


See:

http://www.wowace.com/search/?scope=...rch=LibBabble-

gOOvER 12-31-14 04:53 AM

Added Support in last Commint for LibBabble-Boss

atl77 12-31-14 01:02 PM

Quote:

Originally Posted by gOOvER (Post 304084)
Added Support in last Commint for LibBabble-Boss

Pull Request denied, reasons here: https://github.com/Rythal/Carbonite/pull/202

gOOvER 01-01-15 12:38 AM

And why you close it? i can revert the 3 lines.

Please reopen, i don't want to loose the other work.

Rythal 01-01-15 12:50 AM

Re-opened it.

Still new to git but I believe you should of still had your groover/Master which could of been used to push a new commit after the library was removed.

gOOvER 01-01-15 01:42 AM

Yes, your right. But so i would open a new PR :)

Lib Remove and Translations Carbonite.Weekly up2date for all languages

atl77 01-01-15 03:16 AM

I would advise against translating debug messages, since you would have to look them up when someone mentions them, which would be a waste of time. Otherwise, I have no objection against merging this.

gOOvER 01-01-15 04:34 AM

I did not translate all Strings. Some, i mean, are also usefull for Users for Info, when something is not working


All times are GMT -6. The time now is 09:50 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI