WoWInterface - Pixel Perfect 1px borders

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Pixel Perfect 1px borders (https://www.wowinterface.com/forums/showthread.php?t=58487)

Pixel Perfect 1px borders

I'm trying to create a pixel perfect border that is 1px. My method was working perfectly in Legion, but seems broken now in Shadowlands.

Here you can see an example of what works and what doesn't. The buffs and Unitframes are a custom oUF Layout.
And in the screenshot you can see they have 2px of Border on the bottom.

The Panel in the middle (behind the actionbars) uses the same function to create borders and is doing just fine with borders, no 2px thickness anywhere.

Lua Code:

function F.createBorder(self, anchor, extend)
    spacing = 0
    if extend then
        spacing = 1
    end
 
    if not anchor then
        anchor = parent
    end
 
    if self:GetObjectType() == "StatusBar" then
        self = CreateFrame("Frame", nil, self)
        self:SetPoint("TOPLEFT", anchor, "TOPLEFT", 0, 0)
        self:SetPoint("BOTTOMRIGHT", anchor, "BOTTOMRIGHT", 0, 0)
    end
 
    if not self.borders then
        self.borders = {}
        for i=1, 4 do
            self.borders[i] = self:CreateLine(nil, "LOW", nil, 0)   
            local l = self.borders[i]
            l:SetThickness(1)
            l:SetColorTexture(unpack(G.colors.border))
            if i==1 then
                l:SetStartPoint("TOPLEFT", -spacing, spacing)
                l:SetEndPoint("TOPRIGHT", spacing, spacing)
            elseif i==2 then
                l:SetStartPoint("TOPRIGHT", spacing, spacing)
                l:SetEndPoint("BOTTOMRIGHT", spacing, -spacing)
            elseif i==3 then
                l:SetStartPoint("BOTTOMRIGHT", spacing, -spacing)
                l:SetEndPoint("BOTTOMLEFT", -spacing, -spacing)
            else
                l:SetStartPoint("BOTTOMLEFT", -spacing, -spacing)
                l:SetEndPoint("TOPLEFT", -spacing, spacing)
            end
        end
    end
 
    return self
end

This is the function to create borders for my frames. When hardcoding spacing to like 5 or so to play around with the position, I noticed the border of 2px sometimes being on top. Other UI Elements like my Tooltip have it on 2 sides.
(Although I don't use the same border function for that on the tooltip)

Here is the code for the tooltip (and rest of my code) if it helps giving any context. https://github.com/gempir/gempUI/blo...es/tooltip.lua

I have read several older threads about this on here, but can't find one that helps me with my problem.
I have played around with UI scaling with stuff like this

Lua Code:

SetCVar('useuiscale', 1)
SetCVar('uiscale', 1)
local _, height = GetPhysicalScreenSize()
UIParent:SetScale(768 / height)

This seems to work but generally just makes everything too big on my 1440p screen. Preffered Solution would be with the UI Scaling option off, that looks best to me.

Setting the UI scale to the minimum possible via the UI seems to make it a bit better, but there are still some vertical borders that are too big.

https://github.com/Gethe/wow-ui-sour...elUtil.lua#L30

Getting length of 1px for 100% scale region would be PixelUtil.GetNearestPixelSize(1, UIParent:GetEffectiveScale(), 1)

That's helpful, never seen that before!

Now it looks even better, but some vertical borders are just non existant now. Is there something I'm missing?

(Right side of Castbar)

Edit: Hmm. Changing the width of the castbar, will fix that on some widths. I'm confused why this doesn't work for every width though.

Well it's not a perfect solution, at the end of the day units will still be rounded up to pixels, you can only try to make so that it happens at the same time from both ends. Try sizing your bar in whole pixels too

I fiddled with this a lot and still haven't found a good solution to this.

Positioning Elements with calculated Pixels didn't really help.

I read an old thread about a technique of having a frame that you parent everything to instead of UIParent. And then scale that frame correctly so everything is 1px.

Lua Code:

G.frame = CreateFrame("Frame", nil, self)
local _, height = GetPhysicalScreenSize()
G.frame:SetAllPoints(UIParent)
G.frame:SetScale(768 / height)

Sadly it doesn't seem to fix many of my issues.

I tried out ElvUI and actually noticed they have the same issue on some UI scales. When I click like on Medium or whatever the names of their scales were they actually had some 2px Borders.

Is there maybe just no good fix to this?

I have the same issue with my bag addon. I spent a lot of time trying to figure out how to resolve it and eventually gave up. Notice the grid between icons sometimes has 2 pixels rather than a single pixel. Even though the math checks out and it should be a single pixel. :/

Are you also on 2560x1440 ? I feel like that resolution has the most problems.

Yep, if down to 1080p the issue goes away.

Quote:

Originally Posted by gempir (Post 338147)

Are you also on 2560x1440p ? I feel like that resolution has the most problems.

Same for my addons.

on 2560 x 1440 I get weird borders sometimes. On 1080p everything is fine.