WoWInterface - [SOLVED] Help with AceDb: Deleting items from table won't stay deleted.

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - [SOLVED] Help with AceDb: Deleting items from table won't stay deleted. (https://www.wowinterface.com/forums/showthread.php?t=56514)

[SOLVED] Help with AceDb: Deleting items from table won't stay deleted.

I'm currently at a loss with this and have tried many different things to no avail, including searching google :(

To quickly explain what's going on, I'm trying to delete an item from a specific table in my addon's db - that uses AceDb - and it works, but the deletion is reverted when the game/ui is reloaded.

The table below is the table I've been working with to test. In my addon's config, I've coded the ability to remove spells from the group. In my case, I've been trying to remove item #3, "LavaBurst".

Lua Code:

groups = {
    [1] = {
        [1] = "FlameShock",
        [2] = "EarthShock",
        [3] = "LavaBurst",
        [4] = "Earthquake",
        [5] = "ElementalBlast",
    },
    ...
},

The following methods were tried to delete the table item

Lua Code:

-- Tried the simplest way to remove a table item
tremove(db.auras[spec].groups[grp],j)

Lua Code:

-- Tried an advance means of removing a table item
local function RemoveItemFromTable(db,index)
    local numItems = #db
    
    db[index] = nil
    
    if (index < numItems) then
        for i=index,numItems do
            if (db[i + 1]) then
                db[i] = db[i + 1]
                db[i + 1] = nil
            else
                db[numItems] = nil
            end
        end
    end 
end

Lua Code:

-- I even tried clearing that table completely and rebuilding it
local function RebuildAuraGroupTable(db,grp)
    local tempTable = {}
    
    for i=1,#db[grp] do
        tinsert(tempTable,db[grp][i])
    end
    
    db[grp] = nil
    
    db[grp] = {}
    
    for i=1,#tempTable do
        db[grp][i] = tempTable[i]
    end
end

Using LuaBrowser, I can verify that "LavaBurst" is correctly removed from the table.

BEFORE DELETION

AFTER DELETION (Before game/UI reload)

AFTER DELETION (After game/UI reload)

It's clear that AceDb didn't recognize the deletion and is just loading slot #5 from the "defaults" table on reload. Is there any way to stop this from happening?

Without your real code it's not really possible to help.
It looks like you don't use the db but a local copy of it.

Ah, good call.

This is my initialization code

Lua Code:

function Auras:OnInitialize()
 
    local defaults = SSA.defaults;
    local about_panel = LibStub:GetLibrary("LibAboutPanel", true)
 
    if about_panel then
        self.optionsFrame = about_panel.new(nil, "ShamanAuras")
    end
    
    self.db = LibStub("AceDB-3.0"):New("SSA_db",defaults)
    self:SetupOptions()
    
    
end

The function that handles removing an item from the table is located in a different file

Lua Code:

local SSA, Auras, L, LSM = unpack(select(2,...))
 
local function ConstructAuraList()
    ...
    --- this is the button that runs the deletion
    removeAura = {
        order = 4,
        type = "execute",
        name = "Remove",
        func = function()
            tremove(Auras.db.char.auras[spec].groups[grp],j)
        end,
        width = "half",
    }
    ...
end

It's strange, though. Any changes go through no problem, but deleting part of a table doesn't.

I'm not sure but iirc tremove does not trigger the metatable of the db-object.
Edit: Perhaps this thread can help you? https://authors.curseforge.com/forum...s-why-immortal
The part with default entries that cant be deleted.
Edit2: Or this http://lua-users.org/lists/lua-l/2008-07/msg00100.html

I also tried these methods in place of tremove(), but still no luck :/

Edit: I just saw your edits and will check them out
Edit2: Hmm, great find! I might have to add the values to the table on load, or something.

-- Method #1

Lua Code:

local function RemoveItemFromTable(spec,grp,index)
    Auras.db.char.auras[spec].groups[grp][index] = nil
    
    if (index < #Auras.db.char.auras[spec].groups[grp]) then
        for i=index,#Auras.db.char.auras[spec].groups[grp] do
            if (Auras.db.char.auras[spec].groups[grp][i + 1]) then
                Auras.db.char.auras[spec].groups[grp][i] = db[i + 1]
                Auras.db.char.auras[spec].groups[grp][i + 1] = nil
            else
                Auras.db.char.auras[spec].groups[grp][numItems] = nil
            end
        end
    end
end
 
local function RebuildAuraGroupTable(spec,grp)
    local tempTable = {}
    
    for i=1,#Auras.db.char.auras[spec].groups[grp] do
        tinsert(tempTable,Auras.db.char.auras[spec].groups[grp][i])
    end
    
    -- Clear the group then remake it
    Auras.db.char.auras[spec].groups[grp] = nil
    Auras.db.char.auras[spec].groups[grp] = {}
    
    for i=1,#tempTable do
        Auras.db.char.auras[spec].groups[grp][i] = tempTable[i]
    end
end
 
local function ConstructAuraList()
    ...
    --- this is the button that runs the deletion
    removeAura = {
        order = 4,
        type = "execute",
        name = "Remove",
        func = function()
            --tremove(Auras.db.char.auras[spec].groups[grp],j)
 
            -- I did this first by itself
            RemoveItemFromTable(spec,grp,index)
 
            -- When the above didn't work, I added this, but still no dice :(
            RebuildAuraGroupTable(spec,grp)
        end,
        width = "half",
    }
    ...
end

You can't use an array like that. You want to use a dictionary:

Code:

groups = {

    [1] = {

        ["FlameShock"] = true,

        ["EarthShock"] = true,

        ["LavaBurst"] = true,

        ["Earthquake"] = true,

        ["ElementalBlast"] = true,

    },

    ...

},

Then to remove it you would do:

Code:

groups[1]["LavaBurst"] = false

Don't set it to nil or the default will kick in.

I would suggest posting all of your code because it looks like you could make your options more efficient.

Not to worry, the rest of my tables in my defaults are dictonaries. The reason I used an indexed table was that I needed the spells in a specific order, which you can't do with dictionaries. However, the solution I used was making a small addition to my "spells" table.

Original configuration

Lua Code:

["Adaptation"] = {
    condition = function() return select(10,GetPvpTalentInfoByID(3597)) and IsPvPZone() end,
    spellID = 214027,
    isInUse = true,
},
["AncestralGuidance"] = {
    condition = function() return select(4,GetTalentInfo(5,2,1)) end,
    spellID = 108281,
    isInUse = true,
},
["Ascendance"] = {
    condition = function() return select(4,GetTalentInfo(7,3,1)) end,
    spellID = 114050,
    isInUse = true,
},
...

New configuration

Lua Code:

["Adaptation"] = {
    condition = function() return select(10,GetPvpTalentInfoByID(3597)) and IsPvPZone() end,
    spellID = 214027,
    group = 4,
    order = 1,
    isInUse = true,
},
["AncestralGuidance"] = {
    condition = function() return select(4,GetTalentInfo(5,2,1)) end,
    spellID = 108281,
    group = 2,
    order = 3,
    isInUse = true,
},
["Ascendance"] = {
    condition = function() return select(4,GetTalentInfo(7,3,1)) end,
    spellID = 114050,
    group = 2,
    order = 2,
    isInUse = true,
},

Thanks for the help/insights, everyone :)

If the array was necessary then all you needed to do with your original code was add a false at the end after removing the value. You were taking a table of length 5 and making it length 4 but the defaults were still length 5 so it added the default at the nil location. If AceDB sees a nil in your table when there is a value in that same spot in the defaults it puts the default value in, hence fill with false.

That wouldn't have worked with how my addon works because I've designed it so users can move spells between groups. The new method I coded works perfectly.