WoWInterface - UseQuestLogSpecialItem vs. the world

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Wish List (https://www.wowinterface.com/forums/forumdisplay.php?f=15)

- - UseQuestLogSpecialItem vs. the world (https://www.wowinterface.com/forums/showthread.php?t=50733)

UseQuestLogSpecialItem vs. the world

Dear Blizzard,

Your new objective tracker is the most delicate of flowers in a winter storm. Even looking sideways at seemingly unrelated things, like the world map, poisons it, rendering its quest item buttons unusable. It's even worse than the infamous and still-overly-sensitive-after-all-these-years UIDropDownMenu system.

You could solve the quest button problem very easily by making the UseQuestLogSpecialItem only require a hardware event, rather than it being a completely protected function. I understand you don't want addons automatically using quest items without the player making decisions, but I really don't see any serious potential for abuse if it requires a click/keypress. It's a quest that probably takes 5 minutes and zero thought beyond looking for the dot on the map -- side note: WTB epic quest chains back from vanilla! -- not raid progression or tournament PvP.

*sign with 10 letters*

I've never used that API, but coincidentally I was thinking about it yesterday. Is it possible to securely hook UseQuestLogSpecialItem()? I'd imagine that would solve most of the problems.

Quote:

Originally Posted by myrroddin (Post 302469)

Is it possible to securely hook UseQuestLogSpecialItem()? I'd imagine that would solve most of the problems.

It's possible to securely hook anything:

Code:

hooksecurefunc("CastSpellByName", function(spell, target)

    print("You are casting", spell, "on the", target or "target", "unit.")

end)

But that doesn't solve any problems, since a secure hook just tells you that the function was called, and what arguments (if any) were passed to it; it doesn't magically let you call functions you're not allowed to call from addon code, and it doesn't let you affect the behavior of the original function.

Signed here too ... I was quite surprised that literally reparenting the main frame broke the buttons security.

What makes it worse is that some of the items aren't physically in the bags to use manually that way, so I sure hope those ones work by clicking on the mobs in question.

...Signed...

I do use the addon http://www.curse.com/addons/wow/questitembuttonfix, but Blizzard has broken all quest addons.

Yes please! This keeps breaking for me and I've absolutely no idea why.

Hmm Interesting ..
Managed to get it not error out in my addon with the following minimal code:

Lua Code:

ObjectiveTrackerFrame:SetAllPoints(frame)
ObjectiveTrackerFrame:SetWidth(frame:GetWidth())
ObjectiveTrackerBlocksFrame:SetWidth(frame:GetWidth())
ObjectiveTrackerBlocksFrame:SetHeight(XObjectivesDB.ScrollHeight)
ObjectiveTrackerBlocksFrame:SetPoint("LEFT",30,0)   
frame:SetScrollChild(ObjectiveTrackerBlocksFrame)

frame being a ScrollFrame parented to UIParent or with nUI Infopanel as necessary.

However, this offsets the tracker lines too far to the left and and makes the POI Icons and check marks not appear properly or at all.

The line that fixes that is :
DEFAULT_OBJECTIVE_TRACKER_MODULE.blockOffsetX = 30
But the moment you use that or any of the specific modules versions it kicks out the error.

Also, the use of these two lines after that code (although not sure if I need it now I'm not re-parenting as such) also produces the error.
ObjectiveTracker_Update()
QuestObjectiveTracker_UpdatePOIs()

The moment I remove those 3 lines from the equation it allows you to click the button.

Edit:
I wonder if creating your own module stops the error. Might have to be something to look into at some point.

After reading Resike's post elsewhere regarding this problem and I have rigged up the following mini addon.

Lua Code:

local addonName,addonData = ...
 
local myScrollFrame
 
addonData.Options = {
    FrameWidth = 500, 
    FrameHeight = 150,
    IsMovable = true,
    HasBorder = true,
}
 
addonData.SetMovable = function(self,frame)
    if not frame then return end
    frame:EnableMouse(true)
    frame:SetMovable(true)
    frame:RegisterForDrag("LeftButton")
    frame:SetScript("OnDragStart",function(self)
        self:StartMoving()
    end)
 
    frame:SetScript("OnDragStop",function(self)
        self:StopMovingOrSizing()
        self:SetUserPlaced(true)
        self:SetClampedToScreen(true)
    end)
 
    frame:SetScript("OnHide",function(self)
        self:StopMovingOrSizing()
        self:SetUserPlaced(true)
        self:SetClampedToScreen(true)
    end)
end
 
addonData.AddBorder = function(self,frame)
    local border = CreateFrame("Frame",_G[frame:GetName().."Border"],frame)
    border:SetFrameLevel(frame:GetFrameLevel()-1)
    border:SetFrameStrata(frame:GetFrameStrata())
    border:ClearAllPoints()
    border:SetPoint("TOPLEFT",-10,10)
    border:SetPoint("BOTTOMRIGHT",35,-10)
 
    local backDrop = {       
        bgFile = "Interface/Tooltips/UI-Tooltip-Background", 
        edgeFile = "Interface/Tooltips/UI-Tooltip-Border", 
        tile = true, 
        tileSize = 16, 
        edgeSize = 16, 
        insets = 
        {
            left = 4, 
            right = 4, 
            top = 4, 
            bottom = 4 
        },
    }                       
    border:SetBackdrop(backDrop)
    border:SetBackdropBorderColor( 1, 1, 0, 1 )
    border:SetBackdropColor( 0, 0, 0, 1 )
 
    frame.border = border
end
 
addonData.BuildScrollFrame = function(self,name,parent,options)
    parent = parent or UIParent
    local frame = CreateFrame("ScrollFrame",name,parent,"UIPanelScrollFrameTemplate")
    frame.ScrollBar = _G[frame:GetName() .. "ScrollBar"];
    frame.ScrollBar:SetPoint("LEFT",frame,"RIGHT",5,0)
    frame:SetWidth(options.FrameWidth - 55)
    frame:SetHeight(options.FrameHeight - 20)
    if options.HasBorder then
        self:AddBorder(frame)
    end
    if options.IsMovable then
        self:SetMovable(frame)
        if not frame:SetUserPlaced() then
            frame:SetPoint("CENTER",parent,"CENTER",10,-10)
        end
    else
        frame:SetPoint("CENTER",parent,"CENTER",10,-10)
    end
    ScrollFrame_OnLoad(frame)
    frame:UpdateScrollChildRect()
 
    frame:SetScript("OnScrollRangeChanged",function(self,xrange,yrange)
        ScrollFrame_OnScrollRangeChanged(self, xrange, yrange)
        self:UpdateScrollChildRect()
    end)
 
    frame:SetScript("OnVerticalScroll",function(self,offset)
        addonData:OnVerticalScroll(frame,offset)
        self:UpdateScrollChildRect()
    end)
 
    frame:SetScript("OnMouseWheel",function(self,delta)
        ScrollFrameTemplate_OnMouseWheel(self, delta)
        self:UpdateScrollChildRect()
    end)
 
    return frame
end
 
addonData.OnVerticalScroll = function(self,frame,offset)
    if offset == 0 then return end
    local scrollbar = _G[frame:GetName().."ScrollBar"];
    scrollbar:SetValue(offset);
    local min;
    local max;
    min, max = scrollbar:GetMinMaxValues();
    if ( offset == 0 ) then
        _G[scrollbar:GetName().."ScrollUpButton"]:Disable();
    else
        _G[scrollbar:GetName().."ScrollUpButton"]:Enable();
    end
    if ((scrollbar:GetValue() - max) == 0) then
        _G[scrollbar:GetName().."ScrollDownButton"]:Disable();
    else
        _G[scrollbar:GetName().."ScrollDownButton"]:Enable();
    end
end
 
local function CreateScrollFrame()
    myScrollFrame = addonData:BuildScrollFrame("XrystalScrollFrame_ObjectivesTracker",UIParent,addonData.Options)
end
 
local OTFMoving
hooksecurefunc(ObjectiveTrackerFrame, "SetPoint", function(self)
    if not myScrollFrame then return end
    if OTFMoving then return end
    OTFMoving = true
    self:SetMovable(true)
    self:SetUserPlaced(true)
    self:ClearAllPoints()
    self:SetPoint("TOPLEFT", myScrollFrame, "TOPLEFT", 30, 0)
    self:SetScale(1.1)
    self:SetWidth(addonData.Options.FrameWidth - 30)
    self:SetHeight(1000)
    myScrollFrame:SetScrollChild(self)
    self:SetMovable(false)
    OTFMoving = nil
end)
 
--DEFAULT_OBJECTIVE_TRACKER_MODULE.blockOffsetX = 30
CreateScrollFrame()

Feel free to try it out .. the questitems don't taint as long as I don't use that blockoffset value, if I don't use the blockoffset value it misaligns as it uses that every update to set the alignment of each block.